tun_linux.go 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677
  1. //go:build !android && !e2e_testing
  2. // +build !android,!e2e_testing
  3. package overlay
  4. import (
  5. "fmt"
  6. "io"
  7. "net"
  8. "net/netip"
  9. "os"
  10. "strings"
  11. "sync/atomic"
  12. "time"
  13. "unsafe"
  14. "github.com/gaissmai/bart"
  15. "github.com/sirupsen/logrus"
  16. "github.com/slackhq/nebula/config"
  17. "github.com/slackhq/nebula/routing"
  18. "github.com/slackhq/nebula/util"
  19. "github.com/vishvananda/netlink"
  20. "golang.org/x/sys/unix"
  21. )
  22. type tun struct {
  23. io.ReadWriteCloser
  24. fd int
  25. Device string
  26. vpnNetworks []netip.Prefix
  27. MaxMTU int
  28. DefaultMTU int
  29. TXQueueLen int
  30. deviceIndex int
  31. ioctlFd uintptr
  32. Routes atomic.Pointer[[]Route]
  33. routeTree atomic.Pointer[bart.Table[routing.Gateways]]
  34. routeChan chan struct{}
  35. useSystemRoutes bool
  36. useSystemRoutesBufferSize int
  37. l *logrus.Logger
  38. }
  39. func (t *tun) Networks() []netip.Prefix {
  40. return t.vpnNetworks
  41. }
  42. type ifReq struct {
  43. Name [16]byte
  44. Flags uint16
  45. pad [8]byte
  46. }
  47. type ifreqMTU struct {
  48. Name [16]byte
  49. MTU int32
  50. pad [8]byte
  51. }
  52. type ifreqQLEN struct {
  53. Name [16]byte
  54. Value int32
  55. pad [8]byte
  56. }
  57. func newTunFromFd(c *config.C, l *logrus.Logger, deviceFd int, vpnNetworks []netip.Prefix) (*tun, error) {
  58. file := os.NewFile(uintptr(deviceFd), "/dev/net/tun")
  59. t, err := newTunGeneric(c, l, file, vpnNetworks)
  60. if err != nil {
  61. return nil, err
  62. }
  63. t.Device = "tun0"
  64. return t, nil
  65. }
  66. func newTun(c *config.C, l *logrus.Logger, vpnNetworks []netip.Prefix, multiqueue bool) (*tun, error) {
  67. fd, err := unix.Open("/dev/net/tun", os.O_RDWR, 0)
  68. if err != nil {
  69. // If /dev/net/tun doesn't exist, try to create it (will happen in docker)
  70. if os.IsNotExist(err) {
  71. err = os.MkdirAll("/dev/net", 0755)
  72. if err != nil {
  73. return nil, fmt.Errorf("/dev/net/tun doesn't exist, failed to mkdir -p /dev/net: %w", err)
  74. }
  75. err = unix.Mknod("/dev/net/tun", unix.S_IFCHR|0600, int(unix.Mkdev(10, 200)))
  76. if err != nil {
  77. return nil, fmt.Errorf("failed to create /dev/net/tun: %w", err)
  78. }
  79. fd, err = unix.Open("/dev/net/tun", os.O_RDWR, 0)
  80. if err != nil {
  81. return nil, fmt.Errorf("created /dev/net/tun, but still failed: %w", err)
  82. }
  83. } else {
  84. return nil, err
  85. }
  86. }
  87. var req ifReq
  88. req.Flags = uint16(unix.IFF_TUN | unix.IFF_NO_PI)
  89. if multiqueue {
  90. req.Flags |= unix.IFF_MULTI_QUEUE
  91. }
  92. copy(req.Name[:], c.GetString("tun.dev", ""))
  93. if err = ioctl(uintptr(fd), uintptr(unix.TUNSETIFF), uintptr(unsafe.Pointer(&req))); err != nil {
  94. return nil, err
  95. }
  96. name := strings.Trim(string(req.Name[:]), "\x00")
  97. file := os.NewFile(uintptr(fd), "/dev/net/tun")
  98. t, err := newTunGeneric(c, l, file, vpnNetworks)
  99. if err != nil {
  100. return nil, err
  101. }
  102. t.Device = name
  103. return t, nil
  104. }
  105. func newTunGeneric(c *config.C, l *logrus.Logger, file *os.File, vpnNetworks []netip.Prefix) (*tun, error) {
  106. t := &tun{
  107. ReadWriteCloser: file,
  108. fd: int(file.Fd()),
  109. vpnNetworks: vpnNetworks,
  110. TXQueueLen: c.GetInt("tun.tx_queue", 500),
  111. useSystemRoutes: c.GetBool("tun.use_system_route_table", false),
  112. useSystemRoutesBufferSize: c.GetInt("tun.use_system_route_table_buffer_size", 0),
  113. l: l,
  114. }
  115. err := t.reload(c, true)
  116. if err != nil {
  117. return nil, err
  118. }
  119. c.RegisterReloadCallback(func(c *config.C) {
  120. err := t.reload(c, false)
  121. if err != nil {
  122. util.LogWithContextIfNeeded("failed to reload tun device", err, t.l)
  123. }
  124. })
  125. return t, nil
  126. }
  127. func (t *tun) reload(c *config.C, initial bool) error {
  128. routeChange, routes, err := getAllRoutesFromConfig(c, t.vpnNetworks, initial)
  129. if err != nil {
  130. return err
  131. }
  132. if !initial && !routeChange && !c.HasChanged("tun.mtu") {
  133. return nil
  134. }
  135. routeTree, err := makeRouteTree(t.l, routes, true)
  136. if err != nil {
  137. return err
  138. }
  139. oldDefaultMTU := t.DefaultMTU
  140. oldMaxMTU := t.MaxMTU
  141. newDefaultMTU := c.GetInt("tun.mtu", DefaultMTU)
  142. newMaxMTU := newDefaultMTU
  143. for i, r := range routes {
  144. if r.MTU == 0 {
  145. routes[i].MTU = newDefaultMTU
  146. }
  147. if r.MTU > t.MaxMTU {
  148. newMaxMTU = r.MTU
  149. }
  150. }
  151. t.MaxMTU = newMaxMTU
  152. t.DefaultMTU = newDefaultMTU
  153. // Teach nebula how to handle the routes before establishing them in the system table
  154. oldRoutes := t.Routes.Swap(&routes)
  155. t.routeTree.Store(routeTree)
  156. if !initial {
  157. if oldMaxMTU != newMaxMTU {
  158. t.setMTU()
  159. t.l.Infof("Set max MTU to %v was %v", t.MaxMTU, oldMaxMTU)
  160. }
  161. if oldDefaultMTU != newDefaultMTU {
  162. for i := range t.vpnNetworks {
  163. err := t.setDefaultRoute(t.vpnNetworks[i])
  164. if err != nil {
  165. t.l.Warn(err)
  166. } else {
  167. t.l.Infof("Set default MTU to %v was %v", t.DefaultMTU, oldDefaultMTU)
  168. }
  169. }
  170. }
  171. // Remove first, if the system removes a wanted route hopefully it will be re-added next
  172. t.removeRoutes(findRemovedRoutes(routes, *oldRoutes))
  173. // Ensure any routes we actually want are installed
  174. err = t.addRoutes(true)
  175. if err != nil {
  176. // This should never be called since addRoutes should log its own errors in a reload condition
  177. util.LogWithContextIfNeeded("Failed to refresh routes", err, t.l)
  178. }
  179. }
  180. return nil
  181. }
  182. func (t *tun) NewMultiQueueReader() (io.ReadWriteCloser, error) {
  183. fd, err := unix.Open("/dev/net/tun", os.O_RDWR, 0)
  184. if err != nil {
  185. return nil, err
  186. }
  187. var req ifReq
  188. req.Flags = uint16(unix.IFF_TUN | unix.IFF_NO_PI | unix.IFF_MULTI_QUEUE)
  189. copy(req.Name[:], t.Device)
  190. if err = ioctl(uintptr(fd), uintptr(unix.TUNSETIFF), uintptr(unsafe.Pointer(&req))); err != nil {
  191. return nil, err
  192. }
  193. file := os.NewFile(uintptr(fd), "/dev/net/tun")
  194. return file, nil
  195. }
  196. func (t *tun) RoutesFor(ip netip.Addr) routing.Gateways {
  197. r, _ := t.routeTree.Load().Lookup(ip)
  198. return r
  199. }
  200. func (t *tun) Write(b []byte) (int, error) {
  201. var nn int
  202. maximum := len(b)
  203. for {
  204. n, err := unix.Write(t.fd, b[nn:maximum])
  205. if n > 0 {
  206. nn += n
  207. }
  208. if nn == len(b) {
  209. return nn, err
  210. }
  211. if err != nil {
  212. return nn, err
  213. }
  214. if n == 0 {
  215. return nn, io.ErrUnexpectedEOF
  216. }
  217. }
  218. }
  219. func (t *tun) deviceBytes() (o [16]byte) {
  220. for i, c := range t.Device {
  221. o[i] = byte(c)
  222. }
  223. return
  224. }
  225. func hasNetlinkAddr(al []*netlink.Addr, x netlink.Addr) bool {
  226. for i := range al {
  227. if al[i].Equal(x) {
  228. return true
  229. }
  230. }
  231. return false
  232. }
  233. // addIPs uses netlink to add all addresses that don't exist, then it removes ones that should not be there
  234. func (t *tun) addIPs(link netlink.Link) error {
  235. newAddrs := make([]*netlink.Addr, len(t.vpnNetworks))
  236. for i := range t.vpnNetworks {
  237. newAddrs[i] = &netlink.Addr{
  238. IPNet: &net.IPNet{
  239. IP: t.vpnNetworks[i].Addr().AsSlice(),
  240. Mask: net.CIDRMask(t.vpnNetworks[i].Bits(), t.vpnNetworks[i].Addr().BitLen()),
  241. },
  242. Label: t.vpnNetworks[i].Addr().Zone(),
  243. }
  244. }
  245. //add all new addresses
  246. for i := range newAddrs {
  247. //TODO: CERT-V2 do we want to stack errors and try as many ops as possible?
  248. //AddrReplace still adds new IPs, but if their properties change it will change them as well
  249. if err := netlink.AddrReplace(link, newAddrs[i]); err != nil {
  250. return err
  251. }
  252. }
  253. //iterate over remainder, remove whoever shouldn't be there
  254. al, err := netlink.AddrList(link, netlink.FAMILY_ALL)
  255. if err != nil {
  256. return fmt.Errorf("failed to get tun address list: %s", err)
  257. }
  258. for i := range al {
  259. if hasNetlinkAddr(newAddrs, al[i]) {
  260. continue
  261. }
  262. err = netlink.AddrDel(link, &al[i])
  263. if err != nil {
  264. t.l.WithError(err).Error("failed to remove address from tun address list")
  265. } else {
  266. t.l.WithField("removed", al[i].String()).Info("removed address not listed in cert(s)")
  267. }
  268. }
  269. return nil
  270. }
  271. func (t *tun) Activate() error {
  272. devName := t.deviceBytes()
  273. if t.useSystemRoutes {
  274. t.watchRoutes()
  275. }
  276. s, err := unix.Socket(
  277. unix.AF_INET, //because everything we use t.ioctlFd for is address family independent, this is fine
  278. unix.SOCK_DGRAM,
  279. unix.IPPROTO_IP,
  280. )
  281. if err != nil {
  282. return err
  283. }
  284. t.ioctlFd = uintptr(s)
  285. // Set the device name
  286. ifrf := ifReq{Name: devName}
  287. if err = ioctl(t.ioctlFd, unix.SIOCGIFFLAGS, uintptr(unsafe.Pointer(&ifrf))); err != nil {
  288. return fmt.Errorf("failed to set tun device name: %s", err)
  289. }
  290. link, err := netlink.LinkByName(t.Device)
  291. if err != nil {
  292. return fmt.Errorf("failed to get tun device link: %s", err)
  293. }
  294. t.deviceIndex = link.Attrs().Index
  295. // Setup our default MTU
  296. t.setMTU()
  297. // Set the transmit queue length
  298. ifrq := ifreqQLEN{Name: devName, Value: int32(t.TXQueueLen)}
  299. if err = ioctl(t.ioctlFd, unix.SIOCSIFTXQLEN, uintptr(unsafe.Pointer(&ifrq))); err != nil {
  300. // If we can't set the queue length nebula will still work but it may lead to packet loss
  301. t.l.WithError(err).Error("Failed to set tun tx queue length")
  302. }
  303. if err = t.addIPs(link); err != nil {
  304. return err
  305. }
  306. // Bring up the interface
  307. ifrf.Flags = ifrf.Flags | unix.IFF_UP
  308. if err = ioctl(t.ioctlFd, unix.SIOCSIFFLAGS, uintptr(unsafe.Pointer(&ifrf))); err != nil {
  309. return fmt.Errorf("failed to bring the tun device up: %s", err)
  310. }
  311. //set route MTU
  312. for i := range t.vpnNetworks {
  313. if err = t.setDefaultRoute(t.vpnNetworks[i]); err != nil {
  314. return fmt.Errorf("failed to set default route MTU: %w", err)
  315. }
  316. }
  317. // Set the routes
  318. if err = t.addRoutes(false); err != nil {
  319. return err
  320. }
  321. // Run the interface
  322. ifrf.Flags = ifrf.Flags | unix.IFF_UP | unix.IFF_RUNNING
  323. if err = ioctl(t.ioctlFd, unix.SIOCSIFFLAGS, uintptr(unsafe.Pointer(&ifrf))); err != nil {
  324. return fmt.Errorf("failed to run tun device: %s", err)
  325. }
  326. return nil
  327. }
  328. func (t *tun) setMTU() {
  329. // Set the MTU on the device
  330. ifm := ifreqMTU{Name: t.deviceBytes(), MTU: int32(t.MaxMTU)}
  331. if err := ioctl(t.ioctlFd, unix.SIOCSIFMTU, uintptr(unsafe.Pointer(&ifm))); err != nil {
  332. // This is currently a non fatal condition because the route table must have the MTU set appropriately as well
  333. t.l.WithError(err).Error("Failed to set tun mtu")
  334. }
  335. }
  336. func (t *tun) setDefaultRoute(cidr netip.Prefix) error {
  337. dr := &net.IPNet{
  338. IP: cidr.Masked().Addr().AsSlice(),
  339. Mask: net.CIDRMask(cidr.Bits(), cidr.Addr().BitLen()),
  340. }
  341. nr := netlink.Route{
  342. LinkIndex: t.deviceIndex,
  343. Dst: dr,
  344. MTU: t.DefaultMTU,
  345. AdvMSS: t.advMSS(Route{}),
  346. Scope: unix.RT_SCOPE_LINK,
  347. Src: net.IP(cidr.Addr().AsSlice()),
  348. Protocol: unix.RTPROT_KERNEL,
  349. Table: unix.RT_TABLE_MAIN,
  350. Type: unix.RTN_UNICAST,
  351. }
  352. err := netlink.RouteReplace(&nr)
  353. if err != nil {
  354. t.l.WithError(err).WithField("cidr", cidr).Warn("Failed to set default route MTU, retrying")
  355. //retry twice more -- on some systems there appears to be a race condition where if we set routes too soon, netlink says `invalid argument`
  356. for i := 0; i < 2; i++ {
  357. time.Sleep(100 * time.Millisecond)
  358. err = netlink.RouteReplace(&nr)
  359. if err == nil {
  360. break
  361. } else {
  362. t.l.WithError(err).WithField("cidr", cidr).WithField("mtu", t.DefaultMTU).Warn("Failed to set default route MTU, retrying")
  363. }
  364. }
  365. if err != nil {
  366. return fmt.Errorf("failed to set mtu %v on the default route %v; %v", t.DefaultMTU, dr, err)
  367. }
  368. }
  369. return nil
  370. }
  371. func (t *tun) addRoutes(logErrors bool) error {
  372. // Path routes
  373. routes := *t.Routes.Load()
  374. for _, r := range routes {
  375. if !r.Install {
  376. continue
  377. }
  378. dr := &net.IPNet{
  379. IP: r.Cidr.Masked().Addr().AsSlice(),
  380. Mask: net.CIDRMask(r.Cidr.Bits(), r.Cidr.Addr().BitLen()),
  381. }
  382. nr := netlink.Route{
  383. LinkIndex: t.deviceIndex,
  384. Dst: dr,
  385. MTU: r.MTU,
  386. AdvMSS: t.advMSS(r),
  387. Scope: unix.RT_SCOPE_LINK,
  388. }
  389. if r.Metric > 0 {
  390. nr.Priority = r.Metric
  391. }
  392. err := netlink.RouteReplace(&nr)
  393. if err != nil {
  394. retErr := util.NewContextualError("Failed to add route", map[string]any{"route": r}, err)
  395. if logErrors {
  396. retErr.Log(t.l)
  397. } else {
  398. return retErr
  399. }
  400. } else {
  401. t.l.WithField("route", r).Info("Added route")
  402. }
  403. }
  404. return nil
  405. }
  406. func (t *tun) removeRoutes(routes []Route) {
  407. for _, r := range routes {
  408. if !r.Install {
  409. continue
  410. }
  411. dr := &net.IPNet{
  412. IP: r.Cidr.Masked().Addr().AsSlice(),
  413. Mask: net.CIDRMask(r.Cidr.Bits(), r.Cidr.Addr().BitLen()),
  414. }
  415. nr := netlink.Route{
  416. LinkIndex: t.deviceIndex,
  417. Dst: dr,
  418. MTU: r.MTU,
  419. AdvMSS: t.advMSS(r),
  420. Scope: unix.RT_SCOPE_LINK,
  421. }
  422. if r.Metric > 0 {
  423. nr.Priority = r.Metric
  424. }
  425. err := netlink.RouteDel(&nr)
  426. if err != nil {
  427. t.l.WithError(err).WithField("route", r).Error("Failed to remove route")
  428. } else {
  429. t.l.WithField("route", r).Info("Removed route")
  430. }
  431. }
  432. }
  433. func (t *tun) Name() string {
  434. return t.Device
  435. }
  436. func (t *tun) advMSS(r Route) int {
  437. mtu := r.MTU
  438. if r.MTU == 0 {
  439. mtu = t.DefaultMTU
  440. }
  441. // We only need to set advmss if the route MTU does not match the device MTU
  442. if mtu != t.MaxMTU {
  443. return mtu - 40
  444. }
  445. return 0
  446. }
  447. func (t *tun) watchRoutes() {
  448. rch := make(chan netlink.RouteUpdate)
  449. doneChan := make(chan struct{})
  450. netlinkOptions := netlink.RouteSubscribeOptions{
  451. ReceiveBufferSize: t.useSystemRoutesBufferSize,
  452. ReceiveBufferForceSize: t.useSystemRoutesBufferSize != 0,
  453. ErrorCallback: func(e error) { t.l.WithError(e).Errorf("netlink error") },
  454. }
  455. if err := netlink.RouteSubscribeWithOptions(rch, doneChan, netlinkOptions); err != nil {
  456. t.l.WithError(err).Errorf("failed to subscribe to system route changes")
  457. return
  458. }
  459. t.routeChan = doneChan
  460. go func() {
  461. for {
  462. select {
  463. case r, ok := <-rch:
  464. if ok {
  465. t.updateRoutes(r)
  466. } else {
  467. // may be should do something here as
  468. // netlink stops sending updates
  469. return
  470. }
  471. case <-doneChan:
  472. // netlink.RouteSubscriber will close the rch for us
  473. return
  474. }
  475. }
  476. }()
  477. }
  478. func (t *tun) isGatewayInVpnNetworks(gwAddr netip.Addr) bool {
  479. withinNetworks := false
  480. for i := range t.vpnNetworks {
  481. if t.vpnNetworks[i].Contains(gwAddr) {
  482. withinNetworks = true
  483. break
  484. }
  485. }
  486. return withinNetworks
  487. }
  488. func (t *tun) getGatewaysFromRoute(r *netlink.Route) routing.Gateways {
  489. var gateways routing.Gateways
  490. link, err := netlink.LinkByName(t.Device)
  491. if err != nil {
  492. t.l.WithField("Devicename", t.Device).Error("Ignoring route update: failed to get link by name")
  493. return gateways
  494. }
  495. // If this route is relevant to our interface and there is a gateway then add it
  496. if r.LinkIndex == link.Attrs().Index && len(r.Gw) > 0 {
  497. gwAddr, ok := netip.AddrFromSlice(r.Gw)
  498. if !ok {
  499. t.l.WithField("route", r).Debug("Ignoring route update, invalid gateway address")
  500. } else {
  501. gwAddr = gwAddr.Unmap()
  502. if !t.isGatewayInVpnNetworks(gwAddr) {
  503. // Gateway isn't in our overlay network, ignore
  504. t.l.WithField("route", r).Debug("Ignoring route update, not in our network")
  505. } else {
  506. gateways = append(gateways, routing.NewGateway(gwAddr, 1))
  507. }
  508. }
  509. }
  510. for _, p := range r.MultiPath {
  511. // If this route is relevant to our interface and there is a gateway then add it
  512. if p.LinkIndex == link.Attrs().Index && len(p.Gw) > 0 {
  513. gwAddr, ok := netip.AddrFromSlice(p.Gw)
  514. if !ok {
  515. t.l.WithField("route", r).Debug("Ignoring multipath route update, invalid gateway address")
  516. } else {
  517. gwAddr = gwAddr.Unmap()
  518. if !t.isGatewayInVpnNetworks(gwAddr) {
  519. // Gateway isn't in our overlay network, ignore
  520. t.l.WithField("route", r).Debug("Ignoring route update, not in our network")
  521. } else {
  522. // p.Hops+1 = weight of the route
  523. gateways = append(gateways, routing.NewGateway(gwAddr, p.Hops+1))
  524. }
  525. }
  526. }
  527. }
  528. routing.CalculateBucketsForGateways(gateways)
  529. return gateways
  530. }
  531. func (t *tun) updateRoutes(r netlink.RouteUpdate) {
  532. gateways := t.getGatewaysFromRoute(&r.Route)
  533. if len(gateways) == 0 {
  534. // No gateways relevant to our network, no routing changes required.
  535. t.l.WithField("route", r).Debug("Ignoring route update, no gateways")
  536. return
  537. }
  538. dstAddr, ok := netip.AddrFromSlice(r.Dst.IP)
  539. if !ok {
  540. t.l.WithField("route", r).Debug("Ignoring route update, invalid destination address")
  541. return
  542. }
  543. ones, _ := r.Dst.Mask.Size()
  544. dst := netip.PrefixFrom(dstAddr, ones)
  545. newTree := t.routeTree.Load().Clone()
  546. if r.Type == unix.RTM_NEWROUTE {
  547. t.l.WithField("destination", dst).WithField("via", gateways).Info("Adding route")
  548. newTree.Insert(dst, gateways)
  549. } else {
  550. t.l.WithField("destination", dst).WithField("via", gateways).Info("Removing route")
  551. newTree.Delete(dst)
  552. }
  553. t.routeTree.Store(newTree)
  554. }
  555. func (t *tun) Close() error {
  556. if t.routeChan != nil {
  557. close(t.routeChan)
  558. }
  559. if t.ReadWriteCloser != nil {
  560. _ = t.ReadWriteCloser.Close()
  561. }
  562. if t.ioctlFd > 0 {
  563. _ = os.NewFile(t.ioctlFd, "ioctlFd").Close()
  564. }
  565. return nil
  566. }