Bläddra i källkod

[MSVC] Add NOMINMAX flag to scons and cmake.

Ensures user inclusion of windows.h do not define "min" and "max"
macros.
Fabio Alessandrelli 2 år sedan
förälder
incheckning
081d425277
3 ändrade filer med 3 tillägg och 5 borttagningar
  1. 1 2
      CMakeLists.txt
  2. 1 2
      test/CMakeLists.txt
  3. 1 1
      tools/windows.py

+ 1 - 2
CMakeLists.txt

@@ -95,8 +95,7 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
 	# Disable conversion warning, truncation, unreferenced var, signed mismatch, different type
 	set(GODOT_COMPILE_FLAGS "${GODOT_COMPILE_FLAGS} /wd4244 /wd4305 /wd4101 /wd4018 /wd4267 /wd4099")
 
-	# Todo: Check if needed.
-	add_definitions(-DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_WARNINGS)
+	add_definitions(-DNOMINMAX)
 
 	# Unkomment for warning level 4
 	#if(CMAKE_CXX_FLAGS MATCHES "/W[0-4]")

+ 1 - 2
test/CMakeLists.txt

@@ -50,8 +50,7 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
 	# Disable conversion warning, truncation, unreferenced var, signed mismatch
 	set(GODOT_COMPILE_FLAGS "${GODOT_COMPILE_FLAGS} /wd4244 /wd4305 /wd4101 /wd4018 /wd4267")
 
-	# Todo: Check if needed.
-	add_definitions(-DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_WARNINGS)
+	add_definitions(-DNOMINMAX)
 
 	# Unkomment for warning level 4
 	#if(CMAKE_CXX_FLAGS MATCHES "/W[0-4]")

+ 1 - 1
tools/windows.py

@@ -24,7 +24,7 @@ def generate(env):
             env["TARGET_ARCH"] = "x86"
         env["is_msvc"] = True
         msvc.generate(env)
-        env.Append(CPPDEFINES=["TYPED_METHOD_BIND"])
+        env.Append(CPPDEFINES=["TYPED_METHOD_BIND", "NOMINMAX"])
         env.Append(LINKFLAGS=["/WX"])
         if env["target"] == "debug":
             env.Append(CCFLAGS=["/Z7", "/Od", "/EHsc", "/D_DEBUG", "/MDd"])