Browse Source

Merge pull request #333 from sheepandshepherd/string-plus-leak

Fix String::operator+ memory leak
Rémi Verschelde 5 years ago
parent
commit
81783c6045
1 changed files with 2 additions and 2 deletions
  1. 2 2
      src/core/String.cpp

+ 2 - 2
src/core/String.cpp

@@ -124,8 +124,8 @@ bool String::operator!=(const String &s) const {
 }
 
 String String::operator+(const String &s) const {
-	String new_string = *this;
-	new_string._godot_string = godot::api->godot_string_operator_plus(&new_string._godot_string, &s._godot_string);
+	String new_string;
+	new_string._godot_string = godot::api->godot_string_operator_plus(&_godot_string, &s._godot_string);
 
 	return new_string;
 }