Browse Source

Edit content guidelines, remove typographic marks

- Removed typographic marks in the entire repo
- Removed a line about why we don't use a wiki
- Indented notes with 4 spaces
- Addressed review comments
Nathan Lovato 4 years ago
parent
commit
9df8c5c383

+ 1 - 3
README.md

@@ -19,7 +19,7 @@ add-on.
 
 If you'd like to contribute to the official documentation, whether you want to improve existing pages or write a new one, we would ask you to follow our workflow and guidelines:
 
-1. If you want to write a new page, please start by opening an issue or join the discussion on an open issue with your proposal. This ensures that your work matches our [content guidelines](https://docs.godotengine.org/en/latest/community/contributing/content_guidelines.html) and saves both you and the reviewers' time.
+1. If you want to write a new page, please start by opening an issue or join the discussion on an open issue with your proposal. This ensures that your work matches our [content guidelines](https://docs.godotengine.org/en/latest/community/contributing/content_guidelines.html) and saves everyone time.
 2. Before writing, be sure to check out our style guides:
     - [Writing style guide](https://docs.godotengine.org/en/latest/community/contributing/docs_writing_guidelines.html)
     - [GDScript style guide](https://docs.godotengine.org/en/latest/tutorials/scripting/gdscript/gdscript_styleguide.html) if you write GDScript code.
@@ -29,8 +29,6 @@ We also detail how to create new pages on the documentation [here](https://docs.
 
 **Pull Requests should use the `master` branch by default. Only make Pull Requests against other branches (e.g. `3.2` or `2.1`) if your changes only apply to that version of Godot.**
 
-_Though less convenient to edit than a wiki, having direct access to the source files in a revision control system is a big plus to ensure the quality of our documentation._
-
 ### Editing existing pages
 
 To edit an existing page, locate its .rst source file and open it in your favorite text editor. You can then commit the changes, push them to your fork and make a pull request.

+ 16 - 12
community/contributing/content_guidelines.rst

@@ -13,7 +13,7 @@ We want to achieve two goals:
    them to learn from the docs.
 2. **Write a complete reference manual**. Our goal here is not to teach
    programming foundations. Instead, we should provide a reference for how
-   Godots features work.
+   Godot's features work.
 
 Guidelines and principles
 -------------------------
@@ -25,15 +25,15 @@ Still, we should strive to achieve the two goals listed above.
 Writing complete and accessible documentation
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-**A feature doesn’t exist unless it is documented**. If a user can’t find
-information about a feature and how it works, it doesnt exist to them. We
+**A feature doesn't exist unless it is documented**. If a user can't find
+information about a feature and how it works, it doesn't exist to them. We
 should ensure that we cover everything Godot does.
 
 .. note::
 
-   When adding or updating an engine feature, the documentation team needs to
-   know about it. Contributors should open an issue on the `godot-docs` repository
-   when their work gets merged and requires documentation.
+    When adding or updating an engine feature, the documentation team needs to
+    know about it. Contributors should open an issue on the `godot-docs` repository
+    when their work gets merged and requires documentation.
 
 Do your best to keep documents **under 1000 words in length**. If a page goes
 past that threshold, consider splitting it into two parts if possible. Limiting
@@ -41,11 +41,15 @@ page size forces us to write concisely and to break large documents so they each
 focus on a particular problem.
 
 Make it clear what **problem** each page or section of a page tackles and what
-the user will learn from it. Users need to know if theyre reading the correct
+the user will learn from it. Users need to know if they're reading the correct
 guide to solving problems they encounter. For example, instead of writing the
-heading “Signals”, consider writing “Reacting to changes in another object with
-signals”. While a bit long, the second title makes it clear what the purpose of 
-signals is.
+heading "Signals", consider writing "Reacting to changes with signals". The
+second title makes it clear what the purpose of signals is.
+
+.. note::
+
+    Long section titles lead to long entries in the side menu, which can make
+    navigation cumbersome. Try to keep headings five words long or less.
 
 If the page assumes specific knowledge of other Godot features, mention it and
 link it to the corresponding documentation. For instance, a page about physics
@@ -71,7 +75,7 @@ benefit everyone.
 Always make an effort to **put yourself in the user's shoes**. When we
 understand something thoroughly, it becomes evident to us. We may fail to think
 about details relevant to a newcomer, but **good documentation meets users where
-they are**. We should strive to explain each features capabilities or intended
+they are**. We should strive to explain each feature's capabilities or intended
 uses with the most straightforward language possible.
 
 Try to remember what you first needed to know when learning about the feature or
@@ -88,6 +92,6 @@ practice explaining the feature before writing about it.
 
 When a page assumes knowledge of another engine feature, declare it at the
 beginning and link to resources that cover what users need. You may also link to
-other websites for pre-requisites beyond the documentations scope. For example,
+other websites for pre-requisites beyond the documentation's scope. For example,
 you could link to an introduction to programming in the getting started guide, or a
 website that teaches math theory in the math section.

+ 1 - 1
getting_started/step_by_step/your_first_game.rst

@@ -573,7 +573,7 @@ Adjust the "Speed (FPS)" to ``3`` for all animations.
 
 .. image:: img/mob_animations.gif
 
-Set the ``Playing`` property in the Inspector to “On”.
+Set the ``Playing`` property in the Inspector to "On".
 
 We'll select one of these animations randomly so that the mobs will have some variety.
 

+ 3 - 3
tutorials/export/exporting_pcks.rst

@@ -55,7 +55,7 @@ Generating PCK files
 --------------------
 
 In order to pack all resources of a project into a PCK file open the project
-and go to Project/Export and click on “Export PCK/Zip”. Also make sure to have
+and go to Project/Export and click on "Export PCK/Zip". Also make sure to have
 an export template selected while doing so.
 
 .. image:: img/export_pck.png
@@ -91,9 +91,9 @@ Opening PCK files at runtime
 
 To import a PCK file, one uses a one-liner. Keep in mind, there is no
 error or exception if the import fails. Instead, one might have to create some
-validation code as a layer on top. The following example expects a “mod.pck”
+validation code as a layer on top. The following example expects a "mod.pck"
 file in the directory of the games executable. The PCK file contains a
-“mod_scene.tscn” test scene in its root.
+"mod_scene.tscn" test scene in its root.
 
 .. tabs::
  .. code-tab:: gdscript GDScript

+ 1 - 1
tutorials/rendering/viewports.rst

@@ -187,7 +187,7 @@ The 2D usage mode is slightly faster and uses less memory compared to the 3D one
     If you need to render 3D shadows in the viewport, make sure to set the viewport's *Shadow Atlas Size* property to a value higher than 0.
     Otherwise, shadows won't be rendered. For reference, the Project Settings define it to 4096 by default.
 
-Godot also provides a way of customizing how everything is drawn inside :ref:`Viewports <class_Viewport>` using “Debug Draw”.
+Godot also provides a way of customizing how everything is drawn inside :ref:`Viewports <class_Viewport>` using "Debug Draw".
 Debug Draw allows you to specify one of four options for how the :ref:`Viewport <class_Viewport>` will display things drawn
 inside it. Debug Draw is disabled by default.
 

+ 1 - 1
tutorials/scripting/c_sharp/c_sharp_features.rst

@@ -96,7 +96,7 @@ Declaring a signal in C# is done with the ``[Signal]`` attribute on a delegate.
     delegate void MySignalWithArguments(string foo, int bar);
 
 These signals can then be connected either in the editor or from code with ``Connect``.
-If you want to connect a signal in the editor, you need to (re)build the project assemblies to see the new signal. This build can be manually triggered by clicking the “Build” button at the top right corner of the editor window.
+If you want to connect a signal in the editor, you need to (re)build the project assemblies to see the new signal. This build can be manually triggered by clicking the "Build" button at the top right corner of the editor window.
 
 .. code-block:: csharp