소스 검색

Change misleading comment in 'Your first 3D game'

On the collision processing code (Chapter 6 - Jumping and squashing monsters) there is a misleading comment saying that the collision.get_collider() == null has the purpose of checking for a collision with the ground.

This addresses the following open issue: https://github.com/godotengine/godot-docs/issues/9355
Filipe José 1 년 전
부모
커밋
d3e8abd710
1개의 변경된 파일5개의 추가작업 그리고 1개의 파일을 삭제
  1. 5 1
      getting_started/first_3d_game/06.jump_and_squash.rst

+ 5 - 1
getting_started/first_3d_game/06.jump_and_squash.rst

@@ -241,7 +241,11 @@ With this code, if no collisions occurred on a given frame, the loop won't run.
             # We get one of the collisions with the player
             var collision = get_slide_collision(index)
 
-            # If the collision is with ground
+            # If there are duplicate collisions with a mob in a single frame
+            # the mob will be deleted after the first collision, and a second call to 
+            # get_collider will return null, leading to a null pointer when calling 
+            # collision.get_collider().is_in_group("mob").
+            # This block of code prevents processing duplicate collisions.
             if collision.get_collider() == null:
                 continue