Jelajahi Sumber

Merge pull request #55358 from timothyqiu/pop-front-3.x

[3.x] Fix potential infinite loop when connecting HTTPClient
Rémi Verschelde 3 tahun lalu
induk
melakukan
c4f7ba4686
1 mengubah file dengan 1 tambahan dan 1 penghapusan
  1. 1 1
      core/io/http_client.cpp

+ 1 - 1
core/io/http_client.cpp

@@ -337,7 +337,7 @@ Error HTTPClient::poll() {
 
 
 					Error err = ERR_BUG; // Should be at least one entry.
 					Error err = ERR_BUG; // Should be at least one entry.
 					while (ip_candidates.size() > 0) {
 					while (ip_candidates.size() > 0) {
-						err = tcp_connection->connect_to_host(ip_candidates.front(), conn_port);
+						err = tcp_connection->connect_to_host(ip_candidates.pop_front(), conn_port);
 						if (err == OK) {
 						if (err == OK) {
 							break;
 							break;
 						}
 						}