Browse Source

tm: callbacks: obsolate description is removed.

The description about the callback insertion was
confusing because no locking is necessary to insert
new callbacks.
Miklos Tirpak 16 years ago
parent
commit
09b7b0b356
1 changed files with 3 additions and 11 deletions
  1. 3 11
      modules/tm/t_hooks.h

+ 3 - 11
modules/tm/t_hooks.h

@@ -146,21 +146,13 @@ struct cell;
  * incomplete -- this callback is called in very early stage
  * incomplete -- this callback is called in very early stage
  * before the message is shmem-ized (so that you can work
  * before the message is shmem-ized (so that you can work
  * with it).
  * with it).
- * It's safe to install other TMCB callbacks from here.
  * Note: this callback MUST be installed before forking
  * Note: this callback MUST be installed before forking
  * (the req_in_tmcb_hl callback list does not live in shmem and has no access
  * (the req_in_tmcb_hl callback list does not live in shmem and has no access
  * protection), i.e., at best from mod_init functions.
  * protection), i.e., at best from mod_init functions.
  *
  *
- * Note: all the other callbacks MUST be installed before or immediately after
- *  the transaction is created (they must not be installed from any place 
- *  where the transaction callbacks can be run or added simultaneously with 
- *  the add operation). Another safe way of installing them is to hold the
- *  REPLY lock prior to adding a callback.
- *  In general it's not safe to register callbacks from other TMCB callbacks,
- *  unless the contrary is explicitly stated in the TMCB callback description.
- *  For example a good place for installing them is from a TMCB_REQUEST_IN 
- *  callback.
- *
+ * Note: All the other callbacks can be safely installed when the
+ * transaction already exists, it does not need to be locked.
+ * 
  * TMCB_RESPONSE_IN -- a brand-new reply was received which matches
  * TMCB_RESPONSE_IN -- a brand-new reply was received which matches
  * an existing non-local transaction. It may or may not be a retransmission.
  * an existing non-local transaction. It may or may not be a retransmission.
  * No lock is held here (yet).
  * No lock is held here (yet).