Selaa lähdekoodia

sipcapture: make sure we null terminate the copy of the string

bug introduced at cbd7810fff3d5145c1ce34c0e362b5590bb92a12
Victor Seva 2 vuotta sitten
vanhempi
commit
192b681ce7
1 muutettua tiedostoa jossa 4 lisäystä ja 2 poistoa
  1. 4 2
      src/modules/sipcapture/sipcapture.c

+ 4 - 2
src/modules/sipcapture/sipcapture.c

@@ -2252,7 +2252,8 @@ static int sip_capture(
 
 	ip.s = ip_addr2a(&msg->rcv.src_ip);
 	ip.len = strlen(ip.s);
-	memcpy(buf_ip, ip.s, ip.len);
+	/* Copy, including teminating \0 */
+	memcpy(buf_ip, ip.s, ip.len + 1);
 	sco.source_ip.s = buf_ip;
 	sco.source_ip.len = ip.len;
 	sco.source_port = msg->rcv.src_port;
@@ -2839,7 +2840,8 @@ static int report_capture(sip_msg_t *msg, str *_table, str *_corr, str *_data)
 	/* IP source and destination */
 	ip.s = ip_addr2a(&msg->rcv.src_ip);
 	ip.len = strlen(ip.s);
-	memcpy(buf_ip, ip.s, ip.len);
+	/* Copy, including teminating \0 */
+	memcpy(buf_ip, ip.s, ip.len + 1);
 	sco.source_ip.s = buf_ip;
 	sco.source_ip.len = ip.len;
 	sco.source_port = msg->rcv.src_port;