|
@@ -77,9 +77,6 @@ and commit history, there are several *rules* required for each contribution.
|
|
|
* code **should** be formatted with **clang-format** or to match the style of
|
|
* code **should** be formatted with **clang-format** or to match the style of
|
|
|
the component that the commit applies to. The `.clang-format` file is part of
|
|
the component that the commit applies to. The `.clang-format` file is part of
|
|
|
Kamailio source code tree, in the root folder.
|
|
Kamailio source code tree, in the root folder.
|
|
|
- * personal branches of developers done inside Kamailio GIT repository must be
|
|
|
|
|
- prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
|
|
|
|
|
- `new-feature` or `alice-new-feature` or other variant without `developerid/`.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
### Commit Message Format ###
|
|
### Commit Message Format ###
|
|
@@ -135,6 +132,25 @@ The above content about commit message format is taken from Kamailio wiki page:
|
|
|
* https://www.kamailio.org/wiki/devel/git-commit-guidelines
|
|
* https://www.kamailio.org/wiki/devel/git-commit-guidelines
|
|
|
* it is recommended you read that one as well.
|
|
* it is recommended you read that one as well.
|
|
|
|
|
|
|
|
|
|
+### Developer Access ###
|
|
|
|
|
+
|
|
|
|
|
+ * developer access (commit rights) to Kamailio GIT repository is granted to
|
|
|
|
|
+ people that contribute relevant components (e.g., modules) or have consistent
|
|
|
|
|
+ contributions over a long interval of time
|
|
|
|
|
+ * each developer has to create an account on github.com portal. The
|
|
|
|
|
+ `developerid` is the username on github.com portal
|
|
|
|
|
+ * after getting developer access, it is still recommended to use pull request
|
|
|
|
|
+ for commits done to other components of Kamailio, to allow the main developer
|
|
|
|
|
+ of the component as well as the other developers to review the changes
|
|
|
|
|
+ * commits to own components can be pushed directly, without a pull request.
|
|
|
|
|
+ However, if the developer wants other people to review the changes, using a
|
|
|
|
|
+ pull request is the way to do it
|
|
|
|
|
+ * personal branches of developers done inside Kamailio GIT repository must be
|
|
|
|
|
+ prefixed with `developerid/`, e.g., `alice/new-feature`. Do not use just
|
|
|
|
|
+ `new-feature` or `alice-new-feature` or other variant without `developerid/`
|
|
|
|
|
+ * the [Contributions Basic Rules](#basic-rules) from the sections above have
|
|
|
|
|
+ to be followed as well after getting developer access
|
|
|
|
|
+
|
|
|
## Reporting Issues ##
|
|
## Reporting Issues ##
|
|
|
|
|
|
|
|
Whenever reporting an issue, along with the description of the problems, try to
|
|
Whenever reporting an issue, along with the description of the problems, try to
|
Daniel-Constantin Mierla