Ver código fonte

ims_usrloc_pcscf: Remove unused parameter from docs and module

Carsten Bock 8 anos atrás
pai
commit
a466c7bf1f

+ 14 - 0
src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf.xml

@@ -39,6 +39,20 @@
 			<email>[email protected]</email>
 		</address>
       </editor>
+
+      <editor>
+        <firstname>Carsten</firstname>
+
+        <surname>Bock</surname>
+        
+	<affiliation>
+          <orgname>ng-voice GmbH</orgname>
+        </affiliation>
+
+        <address>
+			<email>[email protected]</email>
+		</address>
+      </editor>
     </authorgroup>
 
     <copyright>

+ 0 - 53
src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_admin.xml

@@ -156,59 +156,6 @@ modparam("ims_usrloc_pcscf", "db_mode", 1)
       </example>
     </section>
 
-    <section>
-      <title>hashing_type (int)</title>
-
-      <para>This is used to specify how contacts are stored in the internal
-      memory hashing structures. This is an important parameter, not only for
-      efficiency, but also for functionality. IMS can get rather confusing
-      when it comes to contacts, SIP URIs and Implicitly registered SIP URIs
-      (IMPUs). Originally the hash for storage of contacts was performed over
-      the full contact URI viz ([email protected]:12345;user=phone). This
-      scheme is useful (from a performance perspective) in circumstances where
-      you have many SIP URIs being registered from the same host/port.
-      However, this causes problems in IMS environments where an implicit
-      registration set of IMPU's is implicitly registered on behalf of a UA
-      when it registers. This is because the implicit contact being used in
-      subsequent requests could use a different SIP URI, for example
-      [email protected]:12345. In this case the P-CSCF would not be able to
-      retrieve the initial contact as the hash over the different contact
-      would in most cases be different. It was therefore proposed to hash the
-      contact by IP:PORT only, effectively identifying a "device" - assuming a
-      1-1 relationship between an IP:PORT pair. In our example, we would get
-      to the same hash slot using the second SIP URI as we got using the
-      initial registered SIP URI. Within this slot we can now search for the
-      appropriate contact (remember there are still collision possibilities)
-      and then traverse through the linked list if iumplcit IMPUs to find the
-      contact currently being used. Of course if it is not found, then you can
-      deny the request.</para>
-
-      <itemizedlist>
-        <listitem>
-          <para>0 - This uses the original hash over AOR method. By default we
-          are backwards compatible...</para>
-        </listitem>
-        <listitem>
-          <para>1 - Use the newer hash over the Host from Contact-Header.</para>
-        </listitem>
-        <listitem>
-          <para>2 - Use the newer hash over the source-IP from where the 
-		request was received (useful for NAT-Scenarios)</para>
-        </listitem>
-      </itemizedlist>
-
-      <para><emphasis>Default value is 0.</emphasis></para>
-
-      <example>
-        <title>Set hashing_type parameter</title>
-
-        <programlisting format="linespecific">...
-modparam("ims_usrloc_pcscf", "hashing_type", 1)
-...
-</programlisting>
-      </example>
-    </section>
-
     <section>
       <title>match_contact_host_port (int)</title>
 

+ 0 - 3
src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c

@@ -84,8 +84,6 @@ str db_url          = str_init(DEFAULT_DB_URL);	/*!< Database URL */
 int timer_interval  = 60;						/*!< Timer interval in seconds */
 int db_mode         = 0;						/*!< Database sync scheme: 0-no db, 1-write through, 2-write back, 3-only db */
 int ul_fetch_rows 	= 2000;
-int hashing_type 	= 0;						/*!< has type for storing P-CSCF contacts - 0 - use full contact AOR, 1 - use IP:PORT only */
-
 int match_contact_host_port = 1;					/*!< Should we match contact just based on rui host and port*/
 
 db1_con_t* ul_dbh = 0;
@@ -111,7 +109,6 @@ static param_export_t params[] = {
 	{"db_url",              PARAM_STR, &db_url        },
 	{"timer_interval",      INT_PARAM, &timer_interval  },
 	{"db_mode",             INT_PARAM, &db_mode         },
-	{"hashing_type",		INT_PARAM, &hashing_type	},
 
 	{"match_contact_host_port",		INT_PARAM, &match_contact_host_port	},
         {"expires_grace",		INT_PARAM, &expires_grace	},

+ 0 - 1
src/modules/ims_usrloc_pcscf/pcontact.c

@@ -59,7 +59,6 @@
 #include "../../core/parser/parse_uri.h"
 
 extern int db_mode;
-extern int hashing_type;
 
 extern int expires_grace;
 

+ 0 - 1
src/modules/ims_usrloc_pcscf/udomain.c

@@ -64,7 +64,6 @@
 
 extern int db_mode;
 extern int db_mode_ext;
-extern unsigned int hashing_type;
 extern int match_contact_host_port;
 
 #ifdef STATISTICS

+ 0 - 1
src/modules/ims_usrloc_pcscf/usrloc.c

@@ -52,7 +52,6 @@
 #include "../../core/parser/parse_uri.h"
 
 extern unsigned int init_flag;
-extern int hashing_type;
 
 int bind_usrloc(usrloc_api_t* api) {
 	if (!api) {