core: Added void to declarations of functions with empty argument list

In C language, a declaration in the form int f(); is equivalent to int f(...);, thus being able to accept an indefinit number of parameters. With the -Wstrict-prototypes GCC options, these declarations are reported as "function declaration isn’t a prototype".
On some cases, this may trick the compiler into generating unoptimized code (like preparing to handle variadic argument list).
In all cases having a declaration int f() and a definition inf f(int) is missleading, even if standard compliant.
This is still Work in Progress. (maybe adding the -Wstrict-prototypes option to default is desireable)

atomic_ops_init.h

@@ -40,8 +40,8 @@
 #define __atomic_ops_init_h
 
 /*! \brief init atomic ops */
-int init_atomic_ops();
+int init_atomic_ops(void);
 /*! \brief destroy atomic ops (e.g. frees the locks, if locks are used) */
-void destroy_atomic_ops();
+void destroy_atomic_ops(void);
 
 #endif

basex.h

@@ -860,7 +860,7 @@ inline static int q_base64_dec(unsigned char* src, int slen,
 }
 
 /*! \brief inits internal lookup tables */
-int init_basex();
+int init_basex(void);
 
 
 #endif /* _basex_h */

cfg/cfg_select.h

@@ -35,10 +35,10 @@ struct cfg_read_handle {
 };
 
 /* free the list of not yet fixed selects */
-void cfg_free_selects();
+void cfg_free_selects(void);
 
 /* fix-up the select calls */
-int cfg_fixup_selects();
+int cfg_fixup_selects(void);
 
 int select_cfg_var(str *res, select_t *s, struct sip_msg *msg);
 

counters.h

@@ -87,8 +87,8 @@ extern int _cnts_row_len; /* number of elements per row */
 
 
 
-int init_counters();
-void destroy_counters();
+int init_counters(void);
+void destroy_counters(void);
 int counters_prefork_init(int max_process_no);
 
 

daemonize.c

@@ -110,7 +110,7 @@ void daemon_status_init()
  *
  * @return 0 on success, -1 on error (and sets errno).
  */
-int daemon_status_pre_daemonize()
+int daemon_status_pre_daemonize(void)
 {
 	int ret;
 	

daemonize.h

@@ -28,17 +28,17 @@
 #define _daemonize_h
 
 int daemonize(char* name, int daemon_status_fd_input);
-int do_suid();
+int do_suid(void);
 int increase_open_fds(int target);
 int set_core_dump(int enable, long unsigned int size);
-int mem_lock_pages();
+int mem_lock_pages(void);
 int set_rt_prio(int prio, int policy);
 
-void daemon_status_init();
-void daemon_status_on_fork_cleanup();
+void daemon_status_init(void);
+void daemon_status_on_fork_cleanup(void);
 int daemon_status_send(char status);
-void daemon_status_no_wait();
-void daemon_status_on_fork_cleanup();
+void daemon_status_no_wait(void);
+void daemon_status_on_fork_cleanup(void);
 
 #endif /*_daemonize_h */
 

dns_cache.h

@@ -195,12 +195,12 @@ void fix_dns_flags(str *gname, str *name);
 int use_dns_failover_fixup(void *handle, str *gname, str *name, void **val);
 int use_dns_cache_fixup(void *handle, str *gname, str *name, void **val);
 int dns_cache_max_mem_fixup(void *handle, str *gname, str *name, void **val);
-int init_dns_cache();
+int init_dns_cache(void);
 #ifdef USE_DNS_CACHE_STATS
 int init_dns_cache_stats(int iproc_num);
 #define DNS_CACHE_ALL_STATS "dc_all_stats"
 #endif
-void destroy_dns_cache();
+void destroy_dns_cache(void);
 
 
 void dns_hash_put(struct dns_hash_entry* e);

dprint.h

@@ -104,7 +104,7 @@
 /** @brief my_pid(), process_no are from pt.h but we cannot \#include it here
    because of circular dependencies */
 extern int process_no;
-extern int my_pid();
+extern int my_pid(void);
 
 /** @brief non-zero if logging to stderr instead to the syslog */
 extern int log_stderr;

dst_blacklist.c

@@ -309,7 +309,7 @@ inline static int blacklist_run_hooks(struct blst_callbacks_lst *cb_lst,
 /** init per protocol blacklist event ignore masks.
  * @return 0 on success, < 0 on error.
  */
-int blst_init_ign_masks()
+int blst_init_ign_masks(void)
 {
 	if ((PROTO_UDP > PROTO_LAST) || (PROTO_TCP > PROTO_LAST) ||
 		(PROTO_TLS > PROTO_LAST) || (PROTO_SCTP > PROTO_LAST)){

dst_blacklist.h

@@ -83,12 +83,12 @@ struct blacklist_hook{
 int register_blacklist_hook(struct blacklist_hook *h, int type);
 #endif /* DST_BLACKLIST_HOOKS */
 
-int init_dst_blacklist();
+int init_dst_blacklist(void);
 #ifdef USE_DST_BLACKLIST_STATS
 int init_dst_blacklist_stats(int iproc_num);
 #define DST_BLACKLIST_ALL_STATS "bkl_all_stats"
 #endif
-void destroy_dst_blacklist();
+void destroy_dst_blacklist(void);
 
 
 /** force add to the blacklist.

endianness.h

@@ -72,7 +72,7 @@ extern int _endian_test_int;
 #define is_little_endian()	endian_test()
 
 
-extern int endianness_sanity_check();
+extern int endianness_sanity_check(void);
 
 /* detect compile time endianess */
 #if defined __BYTE_ORDER && defined __LITTLE_ENDIAN && defined __BIG_ENDIAN

flags.h

@@ -68,6 +68,6 @@ int flag_in_range( flag_t flag );
 int register_flag(char* name, int pos);
 int get_flag_no(char* name, int len);
 int check_flag(int pos);
-void init_named_flags();
+void init_named_flags(void);
 
 #endif

hash_func.c

@@ -163,7 +163,7 @@ void hashtest_cycle( int hits[TABLE_ENTRIES+5], char *ip )
 				}
 }
 
-void hashtest()
+void hashtest(void)
 {
 	int hits[TABLE_ENTRIES+5];
 	int i;

lock_ops.c

@@ -48,7 +48,7 @@
 #include "lock_ops.h"
 
 /* returns 0 on success, -1 on error */
-int init_lock_ops()
+int init_lock_ops(void)
 {
 #ifdef USE_FUTEX
 	int os_ver;
@@ -66,6 +66,6 @@ int init_lock_ops()
 
 
 
-void destroy_lock_ops()
+void destroy_lock_ops(void)
 {
 }

lock_ops_init.h

@@ -27,7 +27,7 @@
 #ifndef __lock_ops_init_h
 #define __lock_ops_init_h
 
-int init_lock_ops();
-void destroy_lock_ops();
+int init_lock_ops(void);
+void destroy_lock_ops(void);
 
 #endif

main.c

@@ -263,7 +263,7 @@ Options:\n\
 
 
 /* print compile-time constants */
-void print_ct_constants()
+void print_ct_constants(void)
 {
 #ifdef ADAPTIVE_WAIT
 	printf("ADAPTIVE_WAIT_LOOPS=%d, ", ADAPTIVE_WAIT_LOOPS);
@@ -283,7 +283,7 @@ void print_ct_constants()
 }
 
 /* print compile-time constants */
-void print_internals()
+void print_internals(void)
 {
 	printf("Print out of %s internals\n", NAME);
 	printf("  Version: %s\n", full_version);
@@ -312,7 +312,7 @@ void print_internals()
 
 /* debugging function */
 /*
-void receive_stdin_loop()
+void receive_stdin_loop(void)
 {
 	#define BSIZE 1024
 	char buf[BSIZE+1];
@@ -541,7 +541,7 @@ static int cfg_ok=0;
 
 
 extern FILE* yyin;
-extern int yyparse();
+extern int yyparse(void);
 
 
 int is_main=1; /* flag = is this the  "main" process? */
@@ -713,7 +713,7 @@ static void shutdown_children(int sig, int show_status)
 
 
 
-void handle_sigs()
+void handle_sigs(void)
 {
 	pid_t	chld;
 	int	chld_status;
@@ -893,7 +893,7 @@ void sig_usr(int signo)
 
 
 /* install the signal handlers, returns 0 on success, -1 on error */
-int install_sigs()
+int install_sigs(void)
 {
 	/* added by jku: add exit handler */
 	if (set_sig_h(SIGINT, sig_usr) == SIG_ERR ) {
@@ -1259,7 +1259,7 @@ int fix_cfg_file(void)
 
 
 /* main loop */
-int main_loop()
+int main_loop(void)
 {
 	int  i;
 	pid_t pid;

nonsip_hooks.h

@@ -59,8 +59,8 @@ struct nonsip_hook{
 };
 
 
-int init_nonsip_hooks();
-void destroy_nonsip_hooks();
+int init_nonsip_hooks(void);
+void destroy_nonsip_hooks(void);
 int register_nonsip_msg_hook(struct nonsip_hook *h);
 int nonsip_msg_run_hooks(struct sip_msg* msg);
 

poll_types.h

@@ -50,7 +50,7 @@ extern char* poll_method_str[POLL_END];
 extern char* poll_support; 
 
 
-enum poll_types choose_poll_method();
+enum poll_types choose_poll_method(void);
 
 /* returns 0 on success, and an error message on error */
 char* check_poll_method(enum poll_types poll_method);

pt.h

@@ -63,9 +63,9 @@ extern int process_no;
 extern struct tcp_child* tcp_children;
 
 int init_pt(int proc_no);
-int get_max_procs();
+int get_max_procs(void);
 int register_procs(int no);
-int get_max_open_fds();
+int get_max_open_fds(void);
 int register_fds(int no);
 
 
@@ -74,7 +74,7 @@ int close_extra_socks(int proc_id, int proc_no);
 #define get_proc_no() ((process_count)?*process_count:0)
 
 /* return processes pid */
-int my_pid();
+int my_pid(void);
 
 /**
  * Forks a new process.

rand/fastrand.h

@@ -31,7 +31,7 @@
 /* side effect: seeds also random w/ seed */
 void fastrand_seed(unsigned int seed);
 /* generate a 32 bit random number */
-unsigned int fastrand();
+unsigned int fastrand(void);
 /* generate a random number between 0 and max inclusive ( 0 <= r <= max)
  * should not be used for cryptography */
 unsigned int fastrand_max(unsigned int max);

resolve.h

@@ -457,7 +457,7 @@ skip_ipv4:
 }
 
 
-int resolv_init();
+int resolv_init(void);
 
 /* callback/fixup functions executed by the configuration framework */
 void resolv_reinit(str *gname, str *name);

route.h

@@ -92,15 +92,15 @@ extern struct route_list event_rt;
 /* script optimization level */
 extern int scr_opt_lev;
 
-int init_routes();
-void destroy_routes();
+int init_routes(void);
+void destroy_routes(void);
 int route_get(struct route_list* rt, char* name);
 int route_lookup(struct route_list* rt, char* name);
 
 void push(struct action* a, struct action** head);
 int add_actions(struct action* a, struct action** head);
-void print_rls();
-int fix_rls();
+void print_rls(void);
+int fix_rls(void);
 
 int eval_expr(struct run_act_ctx* h, struct expr* e, struct sip_msg* msg);
 

rpc_lookup.h

@@ -32,8 +32,8 @@
 extern rpc_export_t** rpc_sarray;
 extern int rpc_sarray_crt_size;
 
-int init_rpcs();
-int destroy_rpcs();
+int init_rpcs(void);
+int destroy_rpcs(void);
 
 rpc_export_t* rpc_lookup(const char* name, int len);
 int rpc_register(rpc_export_t* rpc);

script_cb.h

@@ -69,8 +69,8 @@ struct script_cb{
  */
 int register_script_cb( cb_function f, unsigned int flags, void *param );
 
-int init_script_cb();
-void destroy_script_cb();
+int init_script_cb(void);
+void destroy_script_cb(void);
 
 /* Execute pre-script callbacks of a given type.
  * Returns 0 on error, 1 on success

sctp_options.h

@@ -67,9 +67,9 @@ extern struct cfg_group_sctp sctp_default_cfg;
 /* sctp config handle */
 extern void* sctp_cfg;
 
-void init_sctp_options();
-void sctp_options_check();
-int sctp_register_cfg();
+void init_sctp_options(void);
+void sctp_options_check(void);
+int sctp_register_cfg(void);
 void sctp_options_get(struct cfg_group_sctp *s);
 int sctp_get_os_defaults(struct cfg_group_sctp *s);
 int sctp_get_cfg_from_sock(int s, struct cfg_group_sctp* cfg);

sctp_server.h

@@ -35,21 +35,21 @@ struct sctp_gen_info{
 	int sctp_total_connections;
 };
 
-int init_sctp();
-void destroy_sctp();
+int init_sctp(void);
+void destroy_sctp(void);
 int sctp_check_compiled_sockopts(char* buf, int size);
-int sctp_check_support();
+int sctp_check_support(void);
 int sctp_init_sock(struct socket_info* sock_info);
-int sctp_rcv_loop();
+int sctp_rcv_loop(void);
 int sctp_msg_send(struct dest_info* dst, char* buf, unsigned len);
 
 /* generic sctp information (stats a.s.o) */
 void sctp_get_info(struct sctp_gen_info* sinf);
 
-void destroy_sctp();
+void destroy_sctp(void);
 
 int sctp_setsockopt(int s, int level, int optname,
 					void* optval, socklen_t optlen, char* err_prefix);
 
-void sctp_con_tracking_flush();
+void sctp_con_tracking_flush(void);
 #endif /* _sctp_server_h */

select_buf.h

@@ -51,7 +51,7 @@ char* get_static_buffer(int req_size);
  * Reset offset to unused space
  */
 
-int reset_static_buffer();
+int reset_static_buffer(void);
 
 int str_to_static_buffer(str* res, str* s);
 int int_to_static_buffer(str* res, int val);

shm_init.h

@@ -27,8 +27,8 @@
 #ifndef __shm_init_h
 #define __shm_init_h
 
-int shm_initialized();
-int init_shm();
+int shm_initialized(void);
+int init_shm(void);
 
 #endif /*__shm_init_h*/
 

socket_info.h

@@ -80,7 +80,7 @@ extern enum sip_protos nxt_proto[PROTO_LAST+1];
 
 extern int socket_types;
 
-void init_proto_order();
+void init_proto_order(void);
 
 int add_listen_iface(char* name, struct name_lst* nlst,
 						unsigned short port, unsigned short proto,
@@ -89,9 +89,9 @@ int add_listen_advertise_iface(char* name, struct name_lst* nlst,
 						unsigned short port, unsigned short proto,
 						char *useaddr, unsigned short useport,
 						enum si_flags flags);
-int fix_all_socket_lists();
-void print_all_socket_lists();
-void print_aliases();
+int fix_all_socket_lists(void);
+void print_all_socket_lists(void);
+void print_aliases(void);
 
 struct socket_info* grep_sock_info(str* host, unsigned short port,
 										unsigned short proto);
@@ -123,7 +123,7 @@ static inline int next_proto(unsigned short proto)
 /* gets first non-null socket_info structure
  * (useful if for. e.g we are not listening on any udp sockets )
  */
-inline static struct socket_info* get_first_socket()
+inline static struct socket_info* get_first_socket(void)
 {
 	if (udp_listen) return udp_listen;
 #ifdef USE_TCP

tcp_init.h

@@ -58,11 +58,11 @@ struct tcp_child{
 #define TCP_ALIAS_REPLACE   2
 
 
-int init_tcp();
-void destroy_tcp();
+int init_tcp(void);
+void destroy_tcp(void);
 int tcp_init(struct socket_info* sock_info);
-int tcp_init_children();
-void tcp_main_loop();
+int tcp_init_children(void);
+void tcp_main_loop(void);
 void tcp_receive_loop(int unix_sock);
 int tcp_fix_child_sockets(int* fd);
 

tcp_options.h

@@ -152,9 +152,9 @@ extern struct cfg_group_tcp tcp_default_cfg;
 extern void* tcp_cfg;
 
 
-void init_tcp_options();
-void tcp_options_check();
-int tcp_register_cfg();
+void init_tcp_options(void);
+void tcp_options_check(void);
+int tcp_register_cfg(void);
 void tcp_options_get(struct cfg_group_tcp* t);
 
 #ifdef USE_TCP

tcp_stats.h

@@ -63,8 +63,8 @@ struct tcp_counters_h {
 
 extern struct tcp_counters_h tcp_cnts_h;
 
-int tcp_stats_init();
-void tcp_stats_destroy();
+int tcp_stats_init(void);
+void tcp_stats_destroy(void);
 
 #define INIT_TCP_STATS() tcp_stats_init()
 

timer.h

@@ -132,20 +132,20 @@ struct timer_ln{ /* timer_link already used in tm */
 
 
 
-void timer_main(); /* timer main loop, never exists */
+void timer_main(void); /* timer main loop, never exists */
 
 
-int init_timer();
-int arm_timer();
-void destroy_timer();
+int init_timer(void);
+int arm_timer(void);
+void destroy_timer(void);
 
 #ifdef USE_SLOW_TIMER
-int arm_slow_timer();
-void slow_timer_main();
+int arm_slow_timer(void);
+void slow_timer_main(void);
 #endif
 
 
-struct timer_ln* timer_alloc();
+struct timer_ln* timer_alloc(void);
 void timer_free(struct timer_ln* t);
 
 #ifdef TIMER_DEBUG
@@ -203,7 +203,7 @@ struct sr_timer{
 /*register a periodic timer;
  * ret: <0 on error*/
 int register_timer(timer_function f, void* param, unsigned int interval);
-ticks_t get_ticks();
-ticks_t get_ticks_raw();
+ticks_t get_ticks(void);
+ticks_t get_ticks_raw(void);
 
 #endif

tls_hooks.h

@@ -79,10 +79,10 @@ struct tls_hooks{
 	int (*init_si)(struct socket_info* si);
 	/* generic init function (called at ser init, after module initialization
 	 *  and process table creation)*/
-	int (*init)();
+	int (*init)(void);
 	/* destroy function, called after the modules are destroyed, and 
 	 * after  destroy_tcp() */
-	void (*destroy)();
+	void (*destroy)(void);
 };
 
 

tls_hooks_init.h

@@ -48,11 +48,11 @@
 #endif
 
 
-int tls_loaded();
-int tls_has_init_si(); /*returns true if a handle for tls_init is registered*/
+int tls_loaded(void);
+int tls_has_init_si(void); /*returns true if a handle for tls_init is registered*/
 int tls_init(struct socket_info* si);
-int init_tls();
-void destroy_tls();
+int init_tls(void);
+void destroy_tls(void);
 
 #endif /* TLS_HOOKS */
 #endif

udp_server.h

@@ -39,7 +39,7 @@
 
 int udp_init(struct socket_info* si);
 int udp_send(struct dest_info* dst, char *buf, unsigned len);
-int udp_rcv_loop();
+int udp_rcv_loop(void);
 
 
 #endif

ut.h

@@ -522,7 +522,7 @@ inline static void sleep_us( unsigned int nusecs )
 
 
 /* portable determination of max_path */
-inline static int pathmax()
+inline static int pathmax(void)
 {
 #ifdef PATH_MAX
 	static int pathmax=PATH_MAX;