瀏覽代碼

Merge pull request #829 from kamailio/janssonrpc-fix-memory-leak

janssonrpc-c: fix memory leak when using janssonrpc_notification
Emmanuel Schmidbauer 9 年之前
父節點
當前提交
bcc3857e21
共有 1 個文件被更改,包括 11 次插入8 次删除
  1. 11 8
      modules/janssonrpc-c/janssonrpc_io.c

+ 11 - 8
modules/janssonrpc-c/janssonrpc_io.c

@@ -428,15 +428,18 @@ int jsonrpc_send(str conn, jsonrpc_request_t* req, bool notify_only)
 	if(ns) pkg_free(ns);
 	if(json) free(json);
 
-	if (sent && notify_only == false) {
-
-		const struct timeval tv = ms_to_tv(req->timeout);
+	if (sent) {
+		if (notify_only == true) { // free the request if using janssonrpc_notification function
+			free_request(req);
+		} else {
+			const struct timeval tv = ms_to_tv(req->timeout);
 
-		req->timeout_ev = evtimer_new(global_ev_base, timeout_cb, (void*)req);
-		if(event_add(req->timeout_ev, &tv)<0) {
-			ERR("event_add failed while setting request timer (%s).",
-					strerror(errno));
-			return -1;
+			req->timeout_ev = evtimer_new(global_ev_base, timeout_cb, (void*)req);
+			if(event_add(req->timeout_ev, &tv)<0) {
+				ERR("event_add failed while setting request timer (%s).",
+						strerror(errno));
+				return -1;
+			}
 		}
 	}