Procházet zdrojové kódy

tsilo: Fix pointer comparison in ts_set_tm_callbacks

- Fix cloned ts_transaction pointer comparison to check for
  NULL rather than less than zero. The latter doesn't make
  sense for an allocated pointer.
Chris Double před 10 roky
rodič
revize
e304f9d8d4
1 změnil soubory, kde provedl 1 přidání a 4 odebrání
  1. 1 4
      modules/tsilo/ts_handlers.c

+ 1 - 4
modules/tsilo/ts_handlers.c

@@ -40,14 +40,11 @@ int ts_set_tm_callbacks(struct cell *t, sip_msg_t *req, ts_transaction_t *ts)
 	if(t==NULL)
 	if(t==NULL)
 		return -1;
 		return -1;
 
 
-	if ( (ts_clone=clone_ts_transaction(ts)) < 0 ) {
+	if ( (ts_clone=clone_ts_transaction(ts)) == NULL ) {
 		LM_ERR("failed to clone transaction\n");
 		LM_ERR("failed to clone transaction\n");
 		return -1;
 		return -1;
 	}
 	}
 
 
-	if (ts_clone == NULL) {
-		LM_ERR("transaction clone null\n");
-	}
 	if ( _tmb.register_tmcb( req, t,TMCB_DESTROY,
 	if ( _tmb.register_tmcb( req, t,TMCB_DESTROY,
 			ts_onreply, (void*)ts_clone, free_ts_transaction)<0 ) {
 			ts_onreply, (void*)ts_clone, free_ts_transaction)<0 ) {
 		LM_ERR("failed to register TMCB for transaction %d:%d\n", t->hash_index, t->label);
 		LM_ERR("failed to register TMCB for transaction %d:%d\n", t->hash_index, t->label);