Fix AWSNativeSDK library dependencies which would randomly cause compile errors depending on how cmake configure built the linker order. All AWSNativeSDK libs depend on the Core library, but if lucky, the core lib would be linked in before building another lib (like Lamdba or S3)

Signed-off-by: AMZN-Gene <[email protected]>

package-system/AWSNativeSDK/FindAWSNativeSDK.cmake.Android

@@ -137,6 +137,8 @@ ly_declare_aws_library(
         AccessManagement
     LIB_FILE 
         aws-cpp-sdk-access-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdentity ####
@@ -145,6 +147,8 @@ ly_declare_aws_library(
         CognitoIdentity
     LIB_FILE 
         aws-cpp-sdk-cognito-identity
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdp ####
@@ -153,6 +157,8 @@ ly_declare_aws_library(
         CognitoIdp
     LIB_FILE 
         aws-cpp-sdk-cognito-idp
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DeviceFarm ####
@@ -161,6 +167,8 @@ ly_declare_aws_library(
         DeviceFarm
     LIB_FILE 
         aws-cpp-sdk-devicefarm
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DynamoDB ####
@@ -169,6 +177,8 @@ ly_declare_aws_library(
         DynamoDB
     LIB_FILE 
         aws-cpp-sdk-dynamodb
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### GameLift ####
@@ -177,6 +187,8 @@ ly_declare_aws_library(
         GameLift
     LIB_FILE 
         aws-cpp-sdk-gamelift
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### IdentityManagement ####
@@ -185,6 +197,8 @@ ly_declare_aws_library(
         IdentityManagement
     LIB_FILE 
         aws-cpp-sdk-identity-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Kinesis ####
@@ -193,6 +207,8 @@ ly_declare_aws_library(
         Kinesis
     LIB_FILE 
         aws-cpp-sdk-kinesis
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Lambda ####
@@ -201,6 +217,8 @@ ly_declare_aws_library(
         Lambda
     LIB_FILE 
         aws-cpp-sdk-lambda
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### MobileAnalytics ####
@@ -209,6 +227,8 @@ ly_declare_aws_library(
         MobileAnalytics
     LIB_FILE 
         aws-cpp-sdk-mobileanalytics
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Queues ####
@@ -217,6 +237,8 @@ ly_declare_aws_library(
         Queues
     LIB_FILE 
         aws-cpp-sdk-queues
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### S3 ####
@@ -225,6 +247,8 @@ ly_declare_aws_library(
         S3
     LIB_FILE 
         aws-cpp-sdk-s3
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SNS ####
@@ -233,6 +257,8 @@ ly_declare_aws_library(
         SNS
     LIB_FILE 
         aws-cpp-sdk-sns
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SQS ####
@@ -241,6 +267,8 @@ ly_declare_aws_library(
         SQS
     LIB_FILE 
         aws-cpp-sdk-sqs
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### STS ####
@@ -249,6 +277,8 @@ ly_declare_aws_library(
         STS
     LIB_FILE 
         aws-cpp-sdk-sts
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Transfer ####
@@ -257,6 +287,8 @@ ly_declare_aws_library(
         Transfer
     LIB_FILE 
         aws-cpp-sdk-transfer
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 

package-system/AWSNativeSDK/FindAWSNativeSDK.cmake.Linux

@@ -121,6 +121,8 @@ ly_declare_aws_library(
         AccessManagement
     LIB_FILE 
         aws-cpp-sdk-access-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdentity ####
@@ -129,6 +131,8 @@ ly_declare_aws_library(
         CognitoIdentity
     LIB_FILE 
         aws-cpp-sdk-cognito-identity
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdp ####
@@ -137,6 +141,8 @@ ly_declare_aws_library(
         CognitoIdp
     LIB_FILE 
         aws-cpp-sdk-cognito-idp
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DeviceFarm ####
@@ -145,6 +151,8 @@ ly_declare_aws_library(
         DeviceFarm
     LIB_FILE 
         aws-cpp-sdk-devicefarm
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DynamoDB ####
@@ -153,6 +161,8 @@ ly_declare_aws_library(
         DynamoDB
     LIB_FILE 
         aws-cpp-sdk-dynamodb
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### GameLift ####
@@ -161,6 +171,8 @@ ly_declare_aws_library(
         GameLift
     LIB_FILE 
         aws-cpp-sdk-gamelift
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### IdentityManagement ####
@@ -169,6 +181,8 @@ ly_declare_aws_library(
         IdentityManagement
     LIB_FILE 
         aws-cpp-sdk-identity-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Kinesis ####
@@ -177,6 +191,8 @@ ly_declare_aws_library(
         Kinesis
     LIB_FILE 
         aws-cpp-sdk-kinesis
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Lambda ####
@@ -185,6 +201,8 @@ ly_declare_aws_library(
         Lambda
     LIB_FILE 
         aws-cpp-sdk-lambda
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### MobileAnalytics ####
@@ -193,6 +211,8 @@ ly_declare_aws_library(
         MobileAnalytics
     LIB_FILE 
         aws-cpp-sdk-mobileanalytics
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Queues ####
@@ -201,6 +221,8 @@ ly_declare_aws_library(
         Queues
     LIB_FILE 
         aws-cpp-sdk-queues
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### S3 ####
@@ -209,6 +231,8 @@ ly_declare_aws_library(
         S3
     LIB_FILE 
         aws-cpp-sdk-s3
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SNS ####
@@ -217,6 +241,8 @@ ly_declare_aws_library(
         SNS
     LIB_FILE 
         aws-cpp-sdk-sns
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SQS ####
@@ -225,6 +251,8 @@ ly_declare_aws_library(
         SQS
     LIB_FILE 
         aws-cpp-sdk-sqs
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### STS ####
@@ -233,6 +261,8 @@ ly_declare_aws_library(
         STS
     LIB_FILE 
         aws-cpp-sdk-sts
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Transfer ####
@@ -241,6 +271,8 @@ ly_declare_aws_library(
         Transfer
     LIB_FILE 
         aws-cpp-sdk-transfer
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 

package-system/AWSNativeSDK/FindAWSNativeSDK.cmake.Mac

@@ -159,6 +159,8 @@ ly_declare_aws_library(
         AccessManagement
     LIB_FILE 
         aws-cpp-sdk-access-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdentity ####
@@ -167,6 +169,8 @@ ly_declare_aws_library(
         CognitoIdentity
     LIB_FILE 
         aws-cpp-sdk-cognito-identity
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdp ####
@@ -175,6 +179,8 @@ ly_declare_aws_library(
         CognitoIdp
     LIB_FILE 
         aws-cpp-sdk-cognito-idp
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DeviceFarm ####
@@ -183,6 +189,8 @@ ly_declare_aws_library(
         DeviceFarm
     LIB_FILE 
         aws-cpp-sdk-devicefarm
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DynamoDB ####
@@ -191,6 +199,8 @@ ly_declare_aws_library(
         DynamoDB
     LIB_FILE 
         aws-cpp-sdk-dynamodb
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### GameLift ####
@@ -199,6 +209,8 @@ ly_declare_aws_library(
         GameLift
     LIB_FILE 
         aws-cpp-sdk-gamelift
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### IdentityManagement ####
@@ -207,6 +219,8 @@ ly_declare_aws_library(
         IdentityManagement
     LIB_FILE 
         aws-cpp-sdk-identity-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Kinesis ####
@@ -215,6 +229,8 @@ ly_declare_aws_library(
         Kinesis
     LIB_FILE 
         aws-cpp-sdk-kinesis
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Lambda ####
@@ -223,6 +239,8 @@ ly_declare_aws_library(
         Lambda
     LIB_FILE 
         aws-cpp-sdk-lambda
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### MobileAnalytics ####
@@ -231,6 +249,8 @@ ly_declare_aws_library(
         MobileAnalytics
     LIB_FILE 
         aws-cpp-sdk-mobileanalytics
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Queues ####
@@ -239,6 +259,8 @@ ly_declare_aws_library(
         Queues
     LIB_FILE 
         aws-cpp-sdk-queues
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### S3 ####
@@ -247,6 +269,8 @@ ly_declare_aws_library(
         S3
     LIB_FILE 
         aws-cpp-sdk-s3
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SNS ####
@@ -255,6 +279,8 @@ ly_declare_aws_library(
         SNS
     LIB_FILE 
         aws-cpp-sdk-sns
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SQS ####
@@ -263,6 +289,8 @@ ly_declare_aws_library(
         SQS
     LIB_FILE 
         aws-cpp-sdk-sqs
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### STS ####
@@ -271,6 +299,8 @@ ly_declare_aws_library(
         STS
     LIB_FILE 
         aws-cpp-sdk-sts
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Transfer ####
@@ -279,6 +309,8 @@ ly_declare_aws_library(
         Transfer
     LIB_FILE 
         aws-cpp-sdk-transfer
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 

package-system/AWSNativeSDK/FindAWSNativeSDK.cmake.Windows

@@ -150,6 +150,8 @@ ly_declare_aws_library(
         AccessManagement
     LIB_FILE 
         aws-cpp-sdk-access-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdentity ####
@@ -158,6 +160,8 @@ ly_declare_aws_library(
         CognitoIdentity
     LIB_FILE 
         aws-cpp-sdk-cognito-identity
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdp ####
@@ -166,6 +170,8 @@ ly_declare_aws_library(
         CognitoIdp
     LIB_FILE 
         aws-cpp-sdk-cognito-idp
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DeviceFarm ####
@@ -174,6 +180,8 @@ ly_declare_aws_library(
         DeviceFarm
     LIB_FILE 
         aws-cpp-sdk-devicefarm
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DynamoDB ####
@@ -182,6 +190,8 @@ ly_declare_aws_library(
         DynamoDB
     LIB_FILE 
         aws-cpp-sdk-dynamodb
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### GameLift ####
@@ -190,6 +200,8 @@ ly_declare_aws_library(
         GameLift
     LIB_FILE 
         aws-cpp-sdk-gamelift
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### IdentityManagement ####
@@ -198,6 +210,8 @@ ly_declare_aws_library(
         IdentityManagement
     LIB_FILE 
         aws-cpp-sdk-identity-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Kinesis ####
@@ -206,6 +220,8 @@ ly_declare_aws_library(
         Kinesis
     LIB_FILE 
         aws-cpp-sdk-kinesis
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Lambda ####
@@ -214,6 +230,8 @@ ly_declare_aws_library(
         Lambda
     LIB_FILE 
         aws-cpp-sdk-lambda
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### MobileAnalytics ####
@@ -222,6 +240,8 @@ ly_declare_aws_library(
         MobileAnalytics
     LIB_FILE 
         aws-cpp-sdk-mobileanalytics
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Queues ####
@@ -230,6 +250,8 @@ ly_declare_aws_library(
         Queues
     LIB_FILE 
         aws-cpp-sdk-queues
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### S3 ####
@@ -238,6 +260,8 @@ ly_declare_aws_library(
         S3
     LIB_FILE 
         aws-cpp-sdk-s3
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SNS ####
@@ -246,6 +270,8 @@ ly_declare_aws_library(
         SNS
     LIB_FILE 
         aws-cpp-sdk-sns
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SQS ####
@@ -254,6 +280,8 @@ ly_declare_aws_library(
         SQS
     LIB_FILE 
         aws-cpp-sdk-sqs
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### STS ####
@@ -262,6 +290,8 @@ ly_declare_aws_library(
         STS
     LIB_FILE 
         aws-cpp-sdk-sts
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Transfer ####
@@ -270,6 +300,8 @@ ly_declare_aws_library(
         Transfer
     LIB_FILE 
         aws-cpp-sdk-transfer
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 

package-system/AWSNativeSDK/FindAWSNativeSDK.cmake.iOS

@@ -96,6 +96,8 @@ ly_declare_aws_library(
         AccessManagement
     LIB_FILE 
         aws-cpp-sdk-access-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdentity ####
@@ -104,6 +106,8 @@ ly_declare_aws_library(
         CognitoIdentity
     LIB_FILE 
         aws-cpp-sdk-cognito-identity
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### CognitoIdp ####
@@ -112,6 +116,8 @@ ly_declare_aws_library(
         CognitoIdp
     LIB_FILE 
         aws-cpp-sdk-cognito-idp
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DeviceFarm ####
@@ -120,6 +126,8 @@ ly_declare_aws_library(
         DeviceFarm
     LIB_FILE 
         aws-cpp-sdk-devicefarm
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### DynamoDB ####
@@ -128,6 +136,8 @@ ly_declare_aws_library(
         DynamoDB
     LIB_FILE 
         aws-cpp-sdk-dynamodb
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### GameLift ####
@@ -136,6 +146,8 @@ ly_declare_aws_library(
         GameLift
     LIB_FILE 
         aws-cpp-sdk-gamelift
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### IdentityManagement ####
@@ -144,6 +156,8 @@ ly_declare_aws_library(
         IdentityManagement
     LIB_FILE 
         aws-cpp-sdk-identity-management
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Kinesis ####
@@ -152,6 +166,8 @@ ly_declare_aws_library(
         Kinesis
     LIB_FILE 
         aws-cpp-sdk-kinesis
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Lambda ####
@@ -160,6 +176,8 @@ ly_declare_aws_library(
         Lambda
     LIB_FILE 
         aws-cpp-sdk-lambda
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### MobileAnalytics ####
@@ -168,6 +186,8 @@ ly_declare_aws_library(
         MobileAnalytics
     LIB_FILE 
         aws-cpp-sdk-mobileanalytics
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Queues ####
@@ -176,6 +196,8 @@ ly_declare_aws_library(
         Queues
     LIB_FILE 
         aws-cpp-sdk-queues
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### S3 ####
@@ -184,6 +206,8 @@ ly_declare_aws_library(
         S3
     LIB_FILE 
         aws-cpp-sdk-s3
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SNS ####
@@ -192,6 +216,8 @@ ly_declare_aws_library(
         SNS
     LIB_FILE 
         aws-cpp-sdk-sns
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### SQS ####
@@ -200,6 +226,8 @@ ly_declare_aws_library(
         SQS
     LIB_FILE 
         aws-cpp-sdk-sqs
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### STS ####
@@ -208,6 +236,8 @@ ly_declare_aws_library(
         STS
     LIB_FILE 
         aws-cpp-sdk-sts
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )
 
 #### Transfer ####
@@ -216,6 +246,8 @@ ly_declare_aws_library(
         Transfer
     LIB_FILE 
         aws-cpp-sdk-transfer
+    BUILD_DEPENDENCIES
+        3rdParty::AWSNativeSDK::Core
 )