Browse Source

Add comment for OpClass conflict between WavePrefixBitCount and WavePrefixOp.

Xiang Li 8 years ago
parent
commit
c5d59d7e66
1 changed files with 3 additions and 0 deletions
  1. 3 0
      utils/hct/hctdb.py

+ 3 - 0
utils/hct/hctdb.py

@@ -1045,6 +1045,9 @@ class db_dxil(object):
             db_dxil_param(0, "i32", "", "operation result"),
             db_dxil_param(2, "i1", "value", "input value")])
         next_op_idx += 1
+        # WavePrefixBitCount has different signature compare to WavePrefixOp, set its opclass to WavePrefixOp is not correct.
+        # It works now because WavePrefixOp and WavePrefixBitCount don't interfere on overload types.
+        # Keep it unchanged for back-compat.
         self.add_dxil_op("WavePrefixBitCount", next_op_idx, "WavePrefixOp", "returns the count of bits set to 1 on prior lanes", "v", "", [
             db_dxil_param(0, "i32", "", "operation result"),
             db_dxil_param(2, "i1", "value", "input value")])