Move all filecheck tests to quick-test (#1911)

This is a cleanup pass to move all one-off FileCheck tests to quick-test, so that they don't need special code and can then be moved around/reorganized more easily. A few notes:
* Many tests still use CodeGenTest() rather than file-check, so they basically only check that the compiler produces some kind of code. I haven't touched them, but will migrate them to file-check later on.
* Added a failure when batch directory test runs find no tests. This made me find that we were never running the hoist_constant_array test due to a typo in the code.
* Some tests were used both by CompilerTest and by ValidationTest, the latter of which compiles to DXIL, modifies it using some string replacements, and checks for validation failures. I've duplicated those tests to quick-test, where they are batch-run normally, and validation, where they are used for validation. There's more cleanup of validation tests to be done.
* Deleted bindings3.hlsl (never executed due to typo), and bindings4.hlsl (never executed due to being unreferenced)

tools/clang/test/CodeGenHLSL/Samples/MiniEngine/FXAAResolveWorkQueueCS.hlsl

@@ -2,10 +2,9 @@
 
 // CHECK: flattenedThreadIdInGroup
 // CHECK: bufferLoad
+// CHECK: br i1
 // CHECK: bufferStore
-// note that the following checks might fail on release builds, as they rely on basic block names being preserved
-// CHECK: if.then
-// CHECK: if.end
+// CHECK: br label
 
 //
 // Copyright (c) Microsoft. All rights reserved.

tools/clang/test/CodeGenHLSL/bindings3.hlsl

@@ -1,74 +0,0 @@
-// RUN: %dxc -E main -T ps_6_0 %s  | FileCheck %s
-
-// CHECK: error: unbounded resource buf3 at register 8 overlaps with resource buf2 at register 18, space 0
-// CHECK: error: resource tbuf2 at register 18 overlaps with resource Tex3 at register 8, space 0
-// CHECK: error: more than one unbounded resource (Tex3 and tbuf3) in space 0
-// CHECK: error: unbounded resource tbuf3 could not be allocated
-// CHECK: error: resource tbuf4 could not be allocated
-
-
-cbuffer MyCB : register(b11, space3)
-{
-  float4 f : packoffset(c4);
-  float4 f2 : packoffset(c7);
-  float fa[3][5] : packoffset(c8);
-
-  tbuffer MyTB : register(t11, space3)
-  {
-    float f3 : packoffset(c4);
-    float4 f4 : packoffset(c7);
-    //float4 f_unbounded[] : packoffset(c8);
-  };
-};
-
-Texture2D<float> Tex1; // t0
-Texture2D Tex2[3][7] : register(t11);
-Texture2D<float> Tex3[] : register(t8); // unbounded
-
-RWTexture2D<float4> RWTex1[4];  // u0
-RWTexture2D<float4> RWTex2 : register(u7);
-RWTexture2D<float4> RWTex3[] : register(u5);  // unbounded
-
-// Ensure unused explicitly bound does not reserve space:
-RWTexture2D<float4> RWUnused[6] : register(u17);
-
-struct Foo
-{
-  float4 f;
-  int4 i;
-};
-
-SamplerComparisonState Samp1; // s0
-SamplerState Samp2[2][3] : register(s11); // s11
-SamplerComparisonState Samp3[] : register(s4);
-
-ConstantBuffer<Foo> buf1[]; // b0, unbounded
-ConstantBuffer<Foo> buf2[4][16] : register(b18, space3);
-ConstantBuffer<Foo> buf3[] : register(b8, space3); // unbounded
-
-TextureBuffer<Foo> tbuf1[2][2]; // t0
-TextureBuffer<Foo> tbuf2[4] : register(t18);  // unused
-TextureBuffer<Foo> tbuf3[]; // unbounded
-TextureBuffer<Foo> tbuf4[256]; // cannot allocate due to unbounded resource
-
-float4 main(int4 a : A, float4 coord : TEXCOORD) : SV_TARGET
-{
-  return (float4)1.0
-    * f3   // c4
-    * f4   // c7
-    // * f_unbounded[13]   // c8 + 13 = c21
-    * buf1[2].f // cb0 + 2 = cb2
-    * buf2[2][5].f // cb18 + (2 * 16) + 5 = cb55
-    * buf3[27].f // cb8 + 27 = cb35
-    * Tex1.SampleCmp(Samp1, coord.xy, coord.z)  // t0, s0
-    // * Tex2[2][5].Sample(Samp2[1][2], coord.xy)  // t11 + (2 + 3) + 5 = t22, s11 + (1 * 3) + 2 = s16
-    * Tex3[23].SampleCmp(Samp3[43], coord.xy, coord.z)  // t8 + 23 = t31, s4 + 43 = s47
-    * RWTex1[2].Load(a.xy)    // u0 + 2 = u2
-    // * RWTex2.Load(a.xy)       // u7
-    * RWTex3[18].Load(a.xy)   // u5 + 18 = u23
-    * tbuf1[1][1].i // t32 + (1 * 2) + 1 = t35
-    * tbuf2[1].f // t1 + 1 = t2
-    * tbuf3[3].f // t3 + 3 = t6
-    * tbuf4[200].f
-    ;
-}

tools/clang/test/CodeGenHLSL/bindings4.hlsl

@@ -1,81 +0,0 @@
-// RUN: %dxc -E main -T ps_6_0 %s  | FileCheck %s
-
-// CHECK: ; Resource Bindings:
-// CHECK: ;
-// CHECK: ; Name                                 Type  Format         Dim      ID      HLSL Bind  Count
-// CHECK: ; ------------------------------ ---------- ------- ----------- ------- -------------- ------
-// CHECK: ; buf1                              cbuffer      NA          NA     CB0            cb0     4
-// CHECK: ; buf3                              cbuffer      NA          NA     CB1            cb8unbounded
-// CHECK: ; Samp1                             sampler      NA          NA      S0             s0     1
-// CHECK: ; Tex1                              texture     f32          2d      T0             t0     1
-// CHECK: ; MyTB                              texture     u32     tbuffer      T1     t11,space3     1
-// CHECK: ; tbuf1                             texture     u32     tbuffer      T2             t1     4
-// CHECK: ; tbuf3                             texture     u32     tbuffer      T3             t5unbounded
-// CHECK: ; RWTex1                                UAV     f32          2d      U0             u0     4
-// CHECK: ; RWTex3                                UAV     f32          2d      U1             u5unbounded
-
-
-cbuffer MyCB : register(b11, space3)
-{
-  float4 f : packoffset(c4);
-  float4 f2 : packoffset(c7);
-  float fa[3][5] : packoffset(c8);
-
-  tbuffer MyTB : register(t11, space3)
-  {
-    float f3 : packoffset(c4);
-    float4 f4 : packoffset(c7);
-    //float4 f_unbounded[] : packoffset(c8);
-  };
-};
-
-Texture2D<float> Tex1; // t0
-Texture2D Tex2[3][7] : register(t11);
-Texture2D<float> Tex3[] : register(t8); // unbounded
-
-RWTexture2D<float4> RWTex1[4];  // u0
-RWTexture2D<float4> RWTex2 : register(u7);
-RWTexture2D<float4> RWTex3[] : register(u5);  // unbounded
-
-// Ensure unused explicitly bound does not reserve space:
-RWTexture2D<float4> RWUnused[6] : register(u17);
-
-struct Foo
-{
-  float4 f;
-  int4 i;
-};
-
-SamplerComparisonState Samp1; // s0
-SamplerState Samp2[2][3] : register(s11); // s11
-SamplerComparisonState Samp3[] : register(s4); // unused
-
-ConstantBuffer<Foo> buf1[]; // b0, unbounded
-ConstantBuffer<Foo> buf2[4][16] : register(b18, space3);  // unused
-ConstantBuffer<Foo> buf3[] : register(b8, space3); // unbounded
-
-TextureBuffer<Foo> tbuf1[2][2]; // t0
-TextureBuffer<Foo> tbuf2[4] : register(t18);  // unused
-TextureBuffer<Foo> tbuf3[]; // unbounded
-
-float4 main(int4 a : A, float4 coord : TEXCOORD) : SV_TARGET
-{
-  return (float4)1.0
-    // * f  // will overlap with buf3
-    * f3   // c4
-    * f4   // c7
-    // * f_unbounded[13]   // c8 + 13 = c21
-    * buf1[2].f // cb0 + 2 = cb2
-    // * buf2[2][5].f // cb18 + (2 * 16) + 5 = cb55
-    * buf3[27].f // cb8 + 27 = cb35
-    * Tex1.SampleCmp(Samp1, coord.xy, coord.z)  // t0, s0
-    // * Tex2[2][5].Sample(Samp2[1][2], coord.xy)  // t11 + (2 + 3) + 5 = t22, s11 + (1 * 3) + 2 = s16
-    // * Tex3[23].SampleCmp(Samp3[43], coord.xy, coord.z)  // t8 + 23 = t31, s4 + 43 = s47
-    * RWTex1[2].Load(a.xy)    // u0 + 2 = u2
-    // * RWTex2.Load(a.xy)       // u7
-    * RWTex3[18].Load(a.xy)   // u5 + 18 = u23
-    * tbuf1[1][1].i // t32 + (1 * 2) + 1 = t35
-    // * tbuf2[1].f // t1 + 1 = t2
-    * tbuf3[3].f // t3 + 3 = t6
-    ;
-}

tools/clang/test/CodeGenHLSL/quick-test/NonUniform.hlsl

@@ -0,0 +1,22 @@
+// RUN: %dxc -E main -T ps_6_0 %s | FileCheck %s
+
+// CHECK: createHandle
+// CHECK: i1 true)
+
+// CHECK: createHandle
+// CHECK: i1 true)
+
+// CHECK: createHandle
+// CHECK: i1 true)
+
+Texture1D<float4> tex[5] : register(t3);
+SamplerState SS[3] : register(s2);
+
+[RootSignature("DescriptorTable(SRV(t3, numDescriptors=5)),\
+                DescriptorTable(Sampler(s2, numDescriptors=3))")]
+float4 main(int i : A, float j : B) : SV_TARGET
+{
+  float4 r = tex[NonUniformResourceIndex(i)].Sample(SS[NonUniformResourceIndex(i)], i);
+  r += tex[NonUniformResourceIndex(j)].Sample(SS[i], j+2);
+  return r;
+}