DxilContainerTest.cpp 80 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913
  1. ///////////////////////////////////////////////////////////////////////////////
  2. // //
  3. // DxilContainerTest.cpp //
  4. // Copyright (C) Microsoft Corporation. All rights reserved. //
  5. // This file is distributed under the University of Illinois Open Source //
  6. // License. See LICENSE.TXT for details. //
  7. // //
  8. // Provides tests for container formatting and validation. //
  9. // //
  10. ///////////////////////////////////////////////////////////////////////////////
  11. #ifndef UNICODE
  12. #define UNICODE
  13. #endif
  14. #ifdef __APPLE__
  15. // Workaround for ambiguous wcsstr on Mac
  16. #define _WCHAR_H_CPLUSPLUS_98_CONFORMANCE_
  17. #endif
  18. #include <memory>
  19. #include <vector>
  20. #include <string>
  21. #include <tuple>
  22. #include <cassert>
  23. #include <sstream>
  24. #include <algorithm>
  25. #include <unordered_set>
  26. #include "dxc/Support/WinIncludes.h"
  27. #include "dxc/dxcapi.h"
  28. #ifdef _WIN32
  29. #include <atlfile.h>
  30. #include <d3dcompiler.h>
  31. #pragma comment(lib, "d3dcompiler.lib")
  32. #if _MSC_VER >= 1920
  33. #define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
  34. #include <experimental/filesystem>
  35. #else
  36. #include <filesystem>
  37. #endif
  38. #endif
  39. #include "llvm/Support/Format.h"
  40. #include "llvm/Support/raw_ostream.h"
  41. #include "dxc/Test/HLSLTestData.h"
  42. #include "dxc/Test/HlslTestUtils.h"
  43. #include "dxc/Test/DxcTestUtils.h"
  44. #include "dxc/Support/Global.h"
  45. #include "dxc/Support/dxcapi.use.h"
  46. #include "dxc/Support/HLSLOptions.h"
  47. #include "dxc/DxilContainer/DxilContainer.h"
  48. #include "dxc/DxilContainer/DxilRuntimeReflection.h"
  49. #include "dxc/DxilContainer/DxilPipelineStateValidation.h"
  50. #include "dxc/DXIL/DxilShaderFlags.h"
  51. #include "dxc/DXIL/DxilUtil.h"
  52. #include <fstream>
  53. #include <chrono>
  54. #include <codecvt>
  55. using namespace std;
  56. using namespace hlsl_test;
  57. #ifdef _WIN32
  58. using namespace std::experimental::filesystem;
  59. static uint8_t MaskCount(uint8_t V) {
  60. DXASSERT_NOMSG(0 <= V && V <= 0xF);
  61. static const uint8_t Count[16] = {
  62. 0, 1, 1, 2,
  63. 1, 2, 2, 3,
  64. 1, 2, 2, 3,
  65. 2, 3, 3, 4
  66. };
  67. return Count[V];
  68. }
  69. #endif
  70. #ifdef _WIN32
  71. class DxilContainerTest {
  72. #else
  73. class DxilContainerTest : public ::testing::Test {
  74. #endif
  75. public:
  76. BEGIN_TEST_CLASS(DxilContainerTest)
  77. TEST_CLASS_PROPERTY(L"Parallel", L"true")
  78. TEST_METHOD_PROPERTY(L"Priority", L"0")
  79. END_TEST_CLASS()
  80. TEST_CLASS_SETUP(InitSupport);
  81. TEST_METHOD(CompileWhenDebugSourceThenSourceMatters)
  82. TEST_METHOD(CompileAS_CheckPSV0)
  83. TEST_METHOD(CompileWhenOkThenCheckRDAT)
  84. TEST_METHOD(CompileWhenOkThenCheckRDAT2)
  85. TEST_METHOD(CompileWhenOkThenCheckReflection1)
  86. TEST_METHOD(DxcUtils_CreateReflection)
  87. TEST_METHOD(CompileWhenOKThenIncludesFeatureInfo)
  88. TEST_METHOD(CompileWhenOKThenIncludesSignatures)
  89. TEST_METHOD(CompileWhenSigSquareThenIncludeSplit)
  90. TEST_METHOD(DisassemblyWhenMissingThenFails)
  91. TEST_METHOD(DisassemblyWhenBCInvalidThenFails)
  92. TEST_METHOD(DisassemblyWhenInvalidThenFails)
  93. TEST_METHOD(DisassemblyWhenValidThenOK)
  94. TEST_METHOD(ValidateFromLL_Abs2)
  95. TEST_METHOD(DxilContainerUnitTest)
  96. TEST_METHOD(ReflectionMatchesDXBC_CheckIn)
  97. BEGIN_TEST_METHOD(ReflectionMatchesDXBC_Full)
  98. TEST_METHOD_PROPERTY(L"Priority", L"1")
  99. END_TEST_METHOD()
  100. dxc::DxcDllSupport m_dllSupport;
  101. VersionSupportInfo m_ver;
  102. void CreateBlobPinned(_In_bytecount_(size) LPCVOID data, SIZE_T size,
  103. UINT32 codePage, _Outptr_ IDxcBlobEncoding **ppBlob) {
  104. CComPtr<IDxcLibrary> library;
  105. IFT(m_dllSupport.CreateInstance(CLSID_DxcLibrary, &library));
  106. IFT(library->CreateBlobWithEncodingFromPinned((LPBYTE)data, size, codePage,
  107. ppBlob));
  108. }
  109. void CreateBlobFromText(_In_z_ const char *pText,
  110. _Outptr_ IDxcBlobEncoding **ppBlob) {
  111. CreateBlobPinned(pText, strlen(pText), CP_UTF8, ppBlob);
  112. }
  113. HRESULT CreateCompiler(IDxcCompiler **ppResult) {
  114. if (!m_dllSupport.IsEnabled()) {
  115. VERIFY_SUCCEEDED(m_dllSupport.Initialize());
  116. }
  117. return m_dllSupport.CreateInstance(CLSID_DxcCompiler, ppResult);
  118. }
  119. #ifdef _WIN32 // - Reflection Unsupported
  120. void CompareShaderInputBindDesc(D3D12_SHADER_INPUT_BIND_DESC *pTestDesc,
  121. D3D12_SHADER_INPUT_BIND_DESC *pBaseDesc) {
  122. VERIFY_ARE_EQUAL(pTestDesc->BindCount, pBaseDesc->BindCount);
  123. VERIFY_ARE_EQUAL(pTestDesc->BindPoint, pBaseDesc->BindPoint);
  124. VERIFY_ARE_EQUAL(pTestDesc->Dimension, pBaseDesc->Dimension);
  125. VERIFY_ARE_EQUAL_STR(pTestDesc->Name, pBaseDesc->Name);
  126. VERIFY_ARE_EQUAL(pTestDesc->NumSamples, pBaseDesc->NumSamples);
  127. VERIFY_ARE_EQUAL(pTestDesc->ReturnType, pBaseDesc->ReturnType);
  128. VERIFY_ARE_EQUAL(pTestDesc->Space, pBaseDesc->Space);
  129. if (pBaseDesc->Type == D3D_SIT_UAV_APPEND_STRUCTURED ||
  130. pBaseDesc->Type == D3D_SIT_UAV_CONSUME_STRUCTURED) {
  131. // dxil only have rw with counter.
  132. VERIFY_ARE_EQUAL(pTestDesc->Type, D3D_SIT_UAV_RWSTRUCTURED_WITH_COUNTER);
  133. } else if (pTestDesc->Type == D3D_SIT_STRUCTURED &&
  134. pBaseDesc->Type != D3D_SIT_STRUCTURED) {
  135. VERIFY_ARE_EQUAL(pBaseDesc->Type, D3D_SIT_TEXTURE);
  136. } else
  137. VERIFY_ARE_EQUAL(pTestDesc->Type, pBaseDesc->Type);
  138. // D3D_SIF_USERPACKED is not set consistently in fxc (new-style ConstantBuffer).
  139. UINT unusedFlag = D3D_SIF_USERPACKED;
  140. VERIFY_ARE_EQUAL(pTestDesc->uFlags & ~unusedFlag, pBaseDesc->uFlags & ~unusedFlag);
  141. // VERIFY_ARE_EQUAL(pTestDesc->uID, pBaseDesc->uID); // Like register, this can vary.
  142. }
  143. void CompareParameterDesc(D3D12_SIGNATURE_PARAMETER_DESC *pTestDesc,
  144. D3D12_SIGNATURE_PARAMETER_DESC *pBaseDesc, bool isInput) {
  145. VERIFY_ARE_EQUAL(0, _stricmp(pTestDesc->SemanticName, pBaseDesc->SemanticName));
  146. if (pTestDesc->SystemValueType == D3D_NAME_CLIP_DISTANCE) return; // currently generating multiple clip distance params, one per component
  147. VERIFY_ARE_EQUAL(pTestDesc->ComponentType, pBaseDesc->ComponentType);
  148. VERIFY_ARE_EQUAL(MaskCount(pTestDesc->Mask), MaskCount(pBaseDesc->Mask));
  149. VERIFY_ARE_EQUAL(pTestDesc->MinPrecision, pBaseDesc->MinPrecision);
  150. if (!isInput) {
  151. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0)
  152. VERIFY_ARE_EQUAL(pTestDesc->ReadWriteMask != 0, pBaseDesc->ReadWriteMask != 0);
  153. else
  154. VERIFY_ARE_EQUAL(MaskCount(pTestDesc->ReadWriteMask), MaskCount(pBaseDesc->ReadWriteMask));
  155. }
  156. // VERIFY_ARE_EQUAL(pTestDesc->Register, pBaseDesc->Register);
  157. //VERIFY_ARE_EQUAL(pTestDesc->SemanticIndex, pBaseDesc->SemanticIndex);
  158. VERIFY_ARE_EQUAL(pTestDesc->Stream, pBaseDesc->Stream);
  159. VERIFY_ARE_EQUAL(pTestDesc->SystemValueType, pBaseDesc->SystemValueType);
  160. }
  161. void CompareType(ID3D12ShaderReflectionType *pTest,
  162. ID3D12ShaderReflectionType *pBase)
  163. {
  164. D3D12_SHADER_TYPE_DESC testDesc, baseDesc;
  165. VERIFY_SUCCEEDED(pTest->GetDesc(&testDesc));
  166. VERIFY_SUCCEEDED(pBase->GetDesc(&baseDesc));
  167. VERIFY_ARE_EQUAL(testDesc.Class, baseDesc.Class);
  168. VERIFY_ARE_EQUAL(testDesc.Type, baseDesc.Type);
  169. VERIFY_ARE_EQUAL(testDesc.Rows, baseDesc.Rows);
  170. VERIFY_ARE_EQUAL(testDesc.Columns, baseDesc.Columns);
  171. VERIFY_ARE_EQUAL(testDesc.Elements, baseDesc.Elements);
  172. VERIFY_ARE_EQUAL(testDesc.Members, baseDesc.Members);
  173. VERIFY_ARE_EQUAL(testDesc.Offset, baseDesc.Offset);
  174. // DXIL Reflection doesn't expose half type name,
  175. // and that shouldn't matter because this is only
  176. // in the case where half maps to float.
  177. std::string baseName(baseDesc.Name);
  178. if (baseName.compare(0, 4, "half", 4) == 0)
  179. baseName = baseName.replace(0, 4, "float", 5);
  180. VERIFY_ARE_EQUAL_STR(testDesc.Name, baseName.c_str());
  181. for (UINT i = 0; i < baseDesc.Members; ++i) {
  182. ID3D12ShaderReflectionType* testMemberType = pTest->GetMemberTypeByIndex(i);
  183. ID3D12ShaderReflectionType* baseMemberType = pBase->GetMemberTypeByIndex(i);
  184. VERIFY_IS_NOT_NULL(testMemberType);
  185. VERIFY_IS_NOT_NULL(baseMemberType);
  186. CompareType(testMemberType, baseMemberType);
  187. LPCSTR testMemberName = pTest->GetMemberTypeName(i);
  188. LPCSTR baseMemberName = pBase->GetMemberTypeName(i);
  189. VERIFY_ARE_EQUAL(0, strcmp(testMemberName, baseMemberName));
  190. }
  191. }
  192. typedef HRESULT (__stdcall ID3D12ShaderReflection::*GetParameterDescFn)(UINT, D3D12_SIGNATURE_PARAMETER_DESC*);
  193. void SortNameIdxVector(std::vector<std::tuple<LPCSTR, UINT, UINT>> &value) {
  194. struct FirstPredT {
  195. bool operator()(std::tuple<LPCSTR, UINT, UINT> &l,
  196. std::tuple<LPCSTR, UINT, UINT> &r) {
  197. int strResult = strcmp(std::get<0>(l), std::get<0>(r));
  198. return (strResult < 0 ) || (strResult == 0 && std::get<1>(l) < std::get<1>(r));
  199. }
  200. } FirstPred;
  201. std::sort(value.begin(), value.end(), FirstPred);
  202. }
  203. void CompareParameterDescs(UINT count, ID3D12ShaderReflection *pTest,
  204. ID3D12ShaderReflection *pBase,
  205. GetParameterDescFn Fn, bool isInput) {
  206. std::vector<std::tuple<LPCSTR, UINT, UINT>> testParams, baseParams;
  207. testParams.reserve(count);
  208. baseParams.reserve(count);
  209. for (UINT i = 0; i < count; ++i) {
  210. D3D12_SIGNATURE_PARAMETER_DESC D;
  211. VERIFY_SUCCEEDED((pTest->*Fn)(i, &D));
  212. testParams.push_back(std::make_tuple(D.SemanticName, D.SemanticIndex, i));
  213. VERIFY_SUCCEEDED((pBase->*Fn)(i, &D));
  214. baseParams.push_back(std::make_tuple(D.SemanticName, D.SemanticIndex, i));
  215. }
  216. SortNameIdxVector(testParams);
  217. SortNameIdxVector(baseParams);
  218. for (UINT i = 0; i < count; ++i) {
  219. D3D12_SIGNATURE_PARAMETER_DESC testParamDesc, baseParamDesc;
  220. VERIFY_SUCCEEDED(
  221. (pTest->*Fn)(std::get<2>(testParams[i]), &testParamDesc));
  222. VERIFY_SUCCEEDED(
  223. (pBase->*Fn)(std::get<2>(baseParams[i]), &baseParamDesc));
  224. CompareParameterDesc(&testParamDesc, &baseParamDesc, isInput);
  225. }
  226. }
  227. void CompareReflection(ID3D12ShaderReflection *pTest, ID3D12ShaderReflection *pBase) {
  228. D3D12_SHADER_DESC testDesc, baseDesc;
  229. VERIFY_SUCCEEDED(pTest->GetDesc(&testDesc));
  230. VERIFY_SUCCEEDED(pBase->GetDesc(&baseDesc));
  231. VERIFY_ARE_EQUAL(D3D12_SHVER_GET_TYPE(testDesc.Version), D3D12_SHVER_GET_TYPE(baseDesc.Version));
  232. VERIFY_ARE_EQUAL(testDesc.ConstantBuffers, baseDesc.ConstantBuffers);
  233. VERIFY_ARE_EQUAL(testDesc.BoundResources, baseDesc.BoundResources);
  234. VERIFY_ARE_EQUAL(testDesc.InputParameters, baseDesc.InputParameters);
  235. VERIFY_ARE_EQUAL(testDesc.OutputParameters, baseDesc.OutputParameters);
  236. VERIFY_ARE_EQUAL(testDesc.PatchConstantParameters, baseDesc.PatchConstantParameters);
  237. {
  238. for (UINT i = 0; i < testDesc.ConstantBuffers; ++i) {
  239. ID3D12ShaderReflectionConstantBuffer *pTestCB, *pBaseCB;
  240. D3D12_SHADER_BUFFER_DESC testCB, baseCB;
  241. pTestCB = pTest->GetConstantBufferByIndex(i);
  242. VERIFY_SUCCEEDED(pTestCB->GetDesc(&testCB));
  243. pBaseCB = pBase->GetConstantBufferByName(testCB.Name);
  244. VERIFY_SUCCEEDED(pBaseCB->GetDesc(&baseCB));
  245. VERIFY_ARE_EQUAL_STR(testCB.Name, baseCB.Name);
  246. VERIFY_ARE_EQUAL(testCB.Type, baseCB.Type);
  247. VERIFY_ARE_EQUAL(testCB.Variables, baseCB.Variables);
  248. VERIFY_ARE_EQUAL(testCB.Size, baseCB.Size);
  249. VERIFY_ARE_EQUAL(testCB.uFlags, baseCB.uFlags);
  250. llvm::StringMap<D3D12_SHADER_VARIABLE_DESC> variableMap;
  251. llvm::StringMap<ID3D12ShaderReflectionType*> variableTypeMap;
  252. for (UINT vi = 0; vi < testCB.Variables; ++vi) {
  253. ID3D12ShaderReflectionVariable *pBaseConst;
  254. D3D12_SHADER_VARIABLE_DESC baseConst;
  255. pBaseConst = pBaseCB->GetVariableByIndex(vi);
  256. VERIFY_SUCCEEDED(pBaseConst->GetDesc(&baseConst));
  257. variableMap[baseConst.Name] = baseConst;
  258. ID3D12ShaderReflectionType* pBaseType = pBaseConst->GetType();
  259. VERIFY_IS_NOT_NULL(pBaseType);
  260. variableTypeMap[baseConst.Name] = pBaseType;
  261. }
  262. for (UINT vi = 0; vi < testCB.Variables; ++vi) {
  263. ID3D12ShaderReflectionVariable *pTestConst;
  264. D3D12_SHADER_VARIABLE_DESC testConst;
  265. pTestConst = pTestCB->GetVariableByIndex(vi);
  266. VERIFY_SUCCEEDED(pTestConst->GetDesc(&testConst));
  267. VERIFY_ARE_EQUAL(variableMap.count(testConst.Name), 1);
  268. D3D12_SHADER_VARIABLE_DESC baseConst = variableMap[testConst.Name];
  269. VERIFY_ARE_EQUAL(testConst.uFlags, baseConst.uFlags);
  270. VERIFY_ARE_EQUAL(testConst.StartOffset, baseConst.StartOffset);
  271. VERIFY_ARE_EQUAL(testConst.Size, baseConst.Size);
  272. ID3D12ShaderReflectionType* pTestType = pTestConst->GetType();
  273. VERIFY_IS_NOT_NULL(pTestType);
  274. VERIFY_ARE_EQUAL(variableTypeMap.count(testConst.Name), 1);
  275. ID3D12ShaderReflectionType* pBaseType = variableTypeMap[testConst.Name];
  276. CompareType(pTestType, pBaseType);
  277. }
  278. }
  279. }
  280. for (UINT i = 0; i < testDesc.BoundResources; ++i) {
  281. D3D12_SHADER_INPUT_BIND_DESC testParamDesc, baseParamDesc;
  282. VERIFY_SUCCEEDED(pTest->GetResourceBindingDesc(i, &testParamDesc), WStrFmt(L"i=%u", i));
  283. VERIFY_SUCCEEDED(pBase->GetResourceBindingDescByName(testParamDesc.Name, &baseParamDesc));
  284. CompareShaderInputBindDesc(&testParamDesc, &baseParamDesc);
  285. }
  286. CompareParameterDescs(testDesc.InputParameters, pTest, pBase, &ID3D12ShaderReflection::GetInputParameterDesc, true);
  287. CompareParameterDescs(testDesc.OutputParameters, pTest, pBase,
  288. &ID3D12ShaderReflection::GetOutputParameterDesc,
  289. false);
  290. bool isHs = testDesc.HSPartitioning != D3D_TESSELLATOR_PARTITIONING::D3D11_TESSELLATOR_PARTITIONING_UNDEFINED;
  291. CompareParameterDescs(
  292. testDesc.PatchConstantParameters, pTest, pBase,
  293. &ID3D12ShaderReflection::GetPatchConstantParameterDesc, !isHs);
  294. {
  295. UINT32 testTotal, testX, testY, testZ;
  296. UINT32 baseTotal, baseX, baseY, baseZ;
  297. testTotal = pTest->GetThreadGroupSize(&testX, &testY, &testZ);
  298. baseTotal = pBase->GetThreadGroupSize(&baseX, &baseY, &baseZ);
  299. VERIFY_ARE_EQUAL(testTotal, baseTotal);
  300. VERIFY_ARE_EQUAL(testX, baseX);
  301. VERIFY_ARE_EQUAL(testY, baseY);
  302. VERIFY_ARE_EQUAL(testZ, baseZ);
  303. }
  304. }
  305. #endif // _WIN32 - Reflection unsupported
  306. #ifdef _WIN32 // - Reflection unsupported
  307. HRESULT CompileFromFile(LPCWSTR path, bool useDXBC,
  308. UINT fxcFlags, IDxcBlob **ppBlob) {
  309. std::vector<FileRunCommandPart> parts;
  310. ParseCommandPartsFromFile(path, parts);
  311. VERIFY_IS_TRUE(parts.size() > 0);
  312. unsigned partIdx = 0;
  313. if (parts[0].Command.compare("%dxilver") == 0) {
  314. partIdx = 1;
  315. }
  316. FileRunCommandPart &dxc = parts[partIdx];
  317. VERIFY_ARE_EQUAL_STR(dxc.Command.c_str(), "%dxc");
  318. m_dllSupport.Initialize();
  319. hlsl::options::MainArgs args;
  320. hlsl::options::DxcOpts opts;
  321. dxc.ReadOptsForDxc(args, opts);
  322. if (opts.CodeGenHighLevel) return E_FAIL; // skip for now
  323. if (useDXBC) {
  324. // Consider supporting defines and flags if/when needed.
  325. std::string TargetProfile(opts.TargetProfile.str());
  326. TargetProfile[3] = '5';
  327. // Some shaders may need flags, and /Gec is incompatible with SM 5.1
  328. TargetProfile[5] = (fxcFlags & D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY) ? '0' : '1';
  329. CComPtr<ID3DBlob> pDxbcBlob;
  330. CComPtr<ID3DBlob> pDxbcErrors;
  331. HRESULT hr = D3DCompileFromFile(path, nullptr, D3D_COMPILE_STANDARD_FILE_INCLUDE,
  332. opts.EntryPoint.str().c_str(),
  333. TargetProfile.c_str(),
  334. fxcFlags,
  335. 0, &pDxbcBlob, &pDxbcErrors);
  336. LPCSTR errors = pDxbcErrors ? (const char *)pDxbcErrors->GetBufferPointer() : "";
  337. (void)errors;
  338. IFR(hr);
  339. IFR(pDxbcBlob.QueryInterface(ppBlob));
  340. }
  341. else {
  342. FileRunCommandResult result = dxc.Run(m_dllSupport, nullptr);
  343. IFRBOOL(result.ExitCode == 0, E_FAIL);
  344. IFR(result.OpResult->GetResult(ppBlob));
  345. }
  346. return S_OK;
  347. }
  348. void CreateReflectionFromBlob(IDxcBlob *pBlob, ID3D12ShaderReflection **ppReflection) {
  349. CComPtr<IDxcContainerReflection> pReflection;
  350. UINT32 shaderIdx;
  351. m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection);
  352. VERIFY_SUCCEEDED(pReflection->Load(pBlob));
  353. VERIFY_SUCCEEDED(pReflection->FindFirstPartKind(hlsl::DFCC_DXIL, &shaderIdx));
  354. VERIFY_SUCCEEDED(pReflection->GetPartReflection(shaderIdx, __uuidof(ID3D12ShaderReflection), (void**)ppReflection));
  355. }
  356. void CreateReflectionFromDXBC(IDxcBlob *pBlob, ID3D12ShaderReflection **ppReflection) {
  357. VERIFY_SUCCEEDED(
  358. D3DReflect(pBlob->GetBufferPointer(), pBlob->GetBufferSize(),
  359. __uuidof(ID3D12ShaderReflection), (void **)ppReflection));
  360. }
  361. #endif // _WIN32 - Reflection unsupported
  362. void CompileToProgram(LPCSTR program, LPCWSTR entryPoint, LPCWSTR target,
  363. LPCWSTR *pArguments, UINT32 argCount,
  364. IDxcBlob **ppProgram,
  365. IDxcOperationResult **ppResult = nullptr) {
  366. CComPtr<IDxcCompiler> pCompiler;
  367. CComPtr<IDxcBlobEncoding> pSource;
  368. CComPtr<IDxcBlob> pProgram;
  369. CComPtr<IDxcOperationResult> pResult;
  370. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  371. CreateBlobFromText(program, &pSource);
  372. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", entryPoint,
  373. target, pArguments, argCount, nullptr,
  374. 0, nullptr, &pResult));
  375. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  376. *ppProgram = pProgram.Detach();
  377. if (ppResult)
  378. *ppResult = pResult.Detach();
  379. }
  380. bool DoesValidatorSupportDebugName() {
  381. CComPtr<IDxcVersionInfo> pVersionInfo;
  382. UINT Major, Minor;
  383. HRESULT hrVer = m_dllSupport.CreateInstance(CLSID_DxcValidator, &pVersionInfo);
  384. if (hrVer == E_NOINTERFACE) return false;
  385. VERIFY_SUCCEEDED(hrVer);
  386. VERIFY_SUCCEEDED(pVersionInfo->GetVersion(&Major, &Minor));
  387. return !(Major == 1 && Minor < 1);
  388. }
  389. bool DoesValidatorSupportShaderHash() {
  390. CComPtr<IDxcVersionInfo> pVersionInfo;
  391. UINT Major, Minor;
  392. HRESULT hrVer = m_dllSupport.CreateInstance(CLSID_DxcValidator, &pVersionInfo);
  393. if (hrVer == E_NOINTERFACE) return false;
  394. VERIFY_SUCCEEDED(hrVer);
  395. VERIFY_SUCCEEDED(pVersionInfo->GetVersion(&Major, &Minor));
  396. return !(Major == 1 && Minor < 5);
  397. }
  398. std::string CompileToDebugName(LPCSTR program, LPCWSTR entryPoint,
  399. LPCWSTR target, LPCWSTR *pArguments, UINT32 argCount) {
  400. CComPtr<IDxcBlob> pProgram;
  401. CComPtr<IDxcBlob> pNameBlob;
  402. CComPtr<IDxcContainerReflection> pContainer;
  403. UINT32 index;
  404. CompileToProgram(program, entryPoint, target, pArguments, argCount, &pProgram);
  405. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pContainer));
  406. VERIFY_SUCCEEDED(pContainer->Load(pProgram));
  407. if (FAILED(pContainer->FindFirstPartKind(hlsl::DFCC_ShaderDebugName, &index))) {
  408. return std::string();
  409. }
  410. VERIFY_SUCCEEDED(pContainer->GetPartContent(index, &pNameBlob));
  411. const hlsl::DxilShaderDebugName *pDebugName = (hlsl::DxilShaderDebugName *)pNameBlob->GetBufferPointer();
  412. return std::string((const char *)(pDebugName + 1));
  413. }
  414. std::string RetrieveHashFromBlob(IDxcBlob* pHashBlob) {
  415. VERIFY_ARE_NOT_EQUAL(pHashBlob, nullptr);
  416. VERIFY_ARE_EQUAL(pHashBlob->GetBufferSize(), sizeof(DxcShaderHash));
  417. const hlsl::DxilShaderHash *pShaderHash = (hlsl::DxilShaderHash *)pHashBlob->GetBufferPointer();
  418. std::string result;
  419. llvm::raw_string_ostream os(result);
  420. for (int i = 0; i < 16; ++i)
  421. os << llvm::format("%.2x", pShaderHash->Digest[i]);
  422. return os.str();
  423. }
  424. std::string CompileToShaderHash(LPCSTR program, LPCWSTR entryPoint,
  425. LPCWSTR target, LPCWSTR *pArguments, UINT32 argCount) {
  426. CComPtr<IDxcOperationResult> pResult;
  427. CComPtr<IDxcBlob> pProgram;
  428. CComPtr<IDxcBlob> pHashBlob;
  429. CComPtr<IDxcContainerReflection> pContainer;
  430. UINT32 index;
  431. CompileToProgram(program, entryPoint, target, pArguments, argCount, &pProgram, &pResult);
  432. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pContainer));
  433. VERIFY_SUCCEEDED(pContainer->Load(pProgram));
  434. if (FAILED(pContainer->FindFirstPartKind(hlsl::DFCC_ShaderHash, &index))) {
  435. return std::string();
  436. }
  437. VERIFY_SUCCEEDED(pContainer->GetPartContent(index, &pHashBlob));
  438. std::string hashFromPart = RetrieveHashFromBlob(pHashBlob);
  439. CComPtr<IDxcResult> pDxcResult;
  440. if (SUCCEEDED(pResult->QueryInterface(&pDxcResult))) {
  441. // Make sure shader hash was returned in result
  442. VERIFY_IS_TRUE(pDxcResult->HasOutput(DXC_OUT_SHADER_HASH));
  443. pHashBlob.Release();
  444. VERIFY_SUCCEEDED(pDxcResult->GetOutput(DXC_OUT_SHADER_HASH, IID_PPV_ARGS(&pHashBlob), nullptr));
  445. std::string hashFromResult = RetrieveHashFromBlob(pHashBlob);
  446. VERIFY_ARE_EQUAL(hashFromPart, hashFromPart);
  447. }
  448. return hashFromPart;
  449. }
  450. std::string DisassembleProgram(LPCSTR program, LPCWSTR entryPoint,
  451. LPCWSTR target) {
  452. CComPtr<IDxcCompiler> pCompiler;
  453. CComPtr<IDxcBlob> pProgram;
  454. CComPtr<IDxcBlobEncoding> pDisassembly;
  455. CompileToProgram(program, entryPoint, target, nullptr, 0, &pProgram);
  456. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  457. VERIFY_SUCCEEDED(pCompiler->Disassemble(pProgram, &pDisassembly));
  458. return BlobToUtf8(pDisassembly);
  459. }
  460. void SetupBasicHeader(hlsl::DxilContainerHeader *pHeader,
  461. uint32_t partCount = 0) {
  462. ZeroMemory(pHeader, sizeof(*pHeader));
  463. pHeader->HeaderFourCC = hlsl::DFCC_Container;
  464. pHeader->Version.Major = 1;
  465. pHeader->Version.Minor = 0;
  466. pHeader->PartCount = partCount;
  467. pHeader->ContainerSizeInBytes =
  468. sizeof(hlsl::DxilContainerHeader) +
  469. sizeof(uint32_t) * partCount +
  470. sizeof(hlsl::DxilPartHeader) * partCount;
  471. }
  472. void CodeGenTestCheck(LPCWSTR name) {
  473. std::wstring fullPath = hlsl_test::GetPathToHlslDataFile(name);
  474. FileRunTestResult t = FileRunTestResult::RunFromFileCommands(fullPath.c_str());
  475. if (t.RunResult != 0) {
  476. CA2W commentWide(t.ErrorMessage.c_str(), CP_UTF8);
  477. WEX::Logging::Log::Comment(commentWide);
  478. WEX::Logging::Log::Error(L"Run result is not zero");
  479. }
  480. }
  481. #ifdef _WIN32 // Reflection unsupported
  482. WEX::Common::String WStrFmt(const wchar_t* msg, ...) {
  483. va_list args;
  484. va_start(args, msg);
  485. WEX::Common::String result = WEX::Common::String().FormatV(msg, args);
  486. va_end(args);
  487. return result;
  488. }
  489. void ReflectionTest(LPCWSTR name, bool ignoreIfDXBCFails,
  490. UINT fxcFlags = D3DCOMPILE_ENABLE_UNBOUNDED_DESCRIPTOR_TABLES) {
  491. WEX::Logging::Log::Comment(WEX::Common::String().Format(L"Reflection comparison for %s", name));
  492. // Skip if unsupported.
  493. std::vector<FileRunCommandPart> parts;
  494. ParseCommandPartsFromFile(name, parts);
  495. VERIFY_IS_TRUE(parts.size() > 0);
  496. if (parts[0].Command.compare("%dxilver") == 0) {
  497. VERIFY_IS_TRUE(parts.size() > 1);
  498. auto result = parts[0].Run(m_dllSupport, nullptr);
  499. if (result.ExitCode != 0)
  500. return;
  501. }
  502. CComPtr<IDxcBlob> pProgram;
  503. CComPtr<IDxcBlob> pProgramDXBC;
  504. HRESULT hrDXBC = CompileFromFile(name, true, fxcFlags, &pProgramDXBC);
  505. if (FAILED(hrDXBC)) {
  506. WEX::Logging::Log::Comment(L"Failed to compile DXBC blob.");
  507. if (ignoreIfDXBCFails) return;
  508. VERIFY_FAIL();
  509. }
  510. if (FAILED(CompileFromFile(name, false, 0, &pProgram))) {
  511. WEX::Logging::Log::Comment(L"Failed to compile DXIL blob.");
  512. VERIFY_FAIL();
  513. }
  514. CComPtr<ID3D12ShaderReflection> pProgramReflection;
  515. CComPtr<ID3D12ShaderReflection> pProgramReflectionDXBC;
  516. CreateReflectionFromBlob(pProgram, &pProgramReflection);
  517. CreateReflectionFromDXBC(pProgramDXBC, &pProgramReflectionDXBC);
  518. CompareReflection(pProgramReflection, pProgramReflectionDXBC);
  519. }
  520. #endif // _WIN32 - Reflection unsupported
  521. };
  522. bool DxilContainerTest::InitSupport() {
  523. if (!m_dllSupport.IsEnabled()) {
  524. VERIFY_SUCCEEDED(m_dllSupport.Initialize());
  525. m_ver.Initialize(m_dllSupport);
  526. }
  527. return true;
  528. }
  529. #ifdef _WIN32
  530. TEST_F(DxilContainerTest, CompileWhenDebugSourceThenSourceMatters) {
  531. char program1[] = "float4 main() : SV_Target { return 0; }";
  532. char program2[] = " float4 main() : SV_Target { return 0; } ";
  533. LPCWSTR Zi[] = { L"/Zi", L"/Qembed_debug" };
  534. LPCWSTR ZiZss[] = { L"/Zi", L"/Qembed_debug", L"/Zss" };
  535. LPCWSTR ZiZsb[] = { L"/Zi", L"/Qembed_debug", L"/Zsb" };
  536. LPCWSTR Zsb[] = { L"/Zsb" };
  537. // No debug info, no debug name...
  538. std::string noName = CompileToDebugName(program1, L"main", L"ps_6_0", nullptr, 0);
  539. VERIFY_IS_TRUE(noName.empty());
  540. if (!DoesValidatorSupportDebugName())
  541. return;
  542. // Debug info, default to source name.
  543. std::string sourceName1 = CompileToDebugName(program1, L"main", L"ps_6_0", Zi, _countof(Zi));
  544. VERIFY_IS_FALSE(sourceName1.empty());
  545. // Deterministic naming.
  546. std::string sourceName1Again = CompileToDebugName(program1, L"main", L"ps_6_0", Zi, _countof(Zi));
  547. VERIFY_ARE_EQUAL_STR(sourceName1.c_str(), sourceName1Again.c_str());
  548. // Use program binary by default, so name should be the same.
  549. std::string sourceName2 = CompileToDebugName(program2, L"main", L"ps_6_0", Zi, _countof(Zi));
  550. VERIFY_IS_TRUE(0 == strcmp(sourceName2.c_str(), sourceName1.c_str()));
  551. // Source again, different because different switches are specified.
  552. std::string sourceName1Zss = CompileToDebugName(program1, L"main", L"ps_6_0", ZiZss, _countof(ZiZss));
  553. VERIFY_IS_FALSE(0 == strcmp(sourceName1Zss.c_str(), sourceName1.c_str()));
  554. // Binary program 1 and 2 should be different from source and equal to each other.
  555. std::string binName1 = CompileToDebugName(program1, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  556. std::string binName2 = CompileToDebugName(program2, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  557. VERIFY_ARE_EQUAL_STR(binName1.c_str(), binName2.c_str());
  558. VERIFY_IS_FALSE(0 == strcmp(sourceName1Zss.c_str(), binName1.c_str()));
  559. if (!DoesValidatorSupportShaderHash())
  560. return;
  561. // Verify source hash
  562. std::string binHash1Zss = CompileToShaderHash(program1, L"main", L"ps_6_0", ZiZss, _countof(ZiZss));
  563. VERIFY_IS_FALSE(binHash1Zss.empty());
  564. // bin hash when compiling with /Zi
  565. std::string binHash1 = CompileToShaderHash(program1, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  566. VERIFY_IS_FALSE(binHash1.empty());
  567. // Without /Zi hash for /Zsb should be the same
  568. std::string binHash2 = CompileToShaderHash(program2, L"main", L"ps_6_0", Zsb, _countof(Zsb));
  569. VERIFY_IS_FALSE(binHash2.empty());
  570. VERIFY_ARE_EQUAL_STR(binHash1.c_str(), binHash2.c_str());
  571. // Source hash and bin hash should be different
  572. VERIFY_IS_FALSE(0 == strcmp(binHash1Zss.c_str(), binHash1.c_str()));
  573. }
  574. #endif // _WIN32
  575. TEST_F(DxilContainerTest, CompileWhenOKThenIncludesSignatures) {
  576. char program[] =
  577. "struct PSInput {\r\n"
  578. " float4 position : SV_POSITION;\r\n"
  579. " float4 color : COLOR;\r\n"
  580. "};\r\n"
  581. "PSInput VSMain(float4 position : POSITION, float4 color : COLOR) {\r\n"
  582. " PSInput result;\r\n"
  583. " result.position = position;\r\n"
  584. " result.color = color;\r\n"
  585. " return result;\r\n"
  586. "}\r\n"
  587. "float4 PSMain(PSInput input) : SV_TARGET {\r\n"
  588. " return input.color;\r\n"
  589. "}";
  590. {
  591. std::string s = DisassembleProgram(program, L"VSMain", L"vs_6_0");
  592. // NOTE: this will change when proper packing is done, and when 'always-reads' is accurately implemented.
  593. const char expected_1_4[] =
  594. ";\n"
  595. "; Input signature:\n"
  596. ";\n"
  597. "; Name Index Mask Register SysValue Format Used\n"
  598. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  599. "; POSITION 0 xyzw 0 NONE float \n" // should read 'xyzw' in Used
  600. "; COLOR 0 xyzw 1 NONE float \n" // should read '1' in register
  601. ";\n"
  602. ";\n"
  603. "; Output signature:\n"
  604. ";\n"
  605. "; Name Index Mask Register SysValue Format Used\n"
  606. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  607. "; SV_Position 0 xyzw 0 POS float xyzw\n" // could read SV_POSITION
  608. "; COLOR 0 xyzw 1 NONE float xyzw\n"; // should read '1' in register
  609. const char expected[] =
  610. ";\n"
  611. "; Input signature:\n"
  612. ";\n"
  613. "; Name Index Mask Register SysValue Format Used\n"
  614. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  615. "; POSITION 0 xyzw 0 NONE float xyzw\n" // should read 'xyzw' in Used
  616. "; COLOR 0 xyzw 1 NONE float xyzw\n" // should read '1' in register
  617. ";\n"
  618. ";\n"
  619. "; Output signature:\n"
  620. ";\n"
  621. "; Name Index Mask Register SysValue Format Used\n"
  622. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  623. "; SV_Position 0 xyzw 0 POS float xyzw\n" // could read SV_POSITION
  624. "; COLOR 0 xyzw 1 NONE float xyzw\n"; // should read '1' in register
  625. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0) {
  626. std::string start(s.c_str(), strlen(expected_1_4));
  627. VERIFY_ARE_EQUAL_STR(expected_1_4, start.c_str());
  628. } else {
  629. std::string start(s.c_str(), strlen(expected));
  630. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  631. }
  632. }
  633. {
  634. std::string s = DisassembleProgram(program, L"PSMain", L"ps_6_0");
  635. // NOTE: this will change when proper packing is done, and when 'always-reads' is accurately implemented.
  636. const char expected_1_4[] =
  637. ";\n"
  638. "; Input signature:\n"
  639. ";\n"
  640. "; Name Index Mask Register SysValue Format Used\n"
  641. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  642. "; SV_Position 0 xyzw 0 POS float \n" // could read SV_POSITION
  643. "; COLOR 0 xyzw 1 NONE float \n" // should read '1' in register, xyzw in Used
  644. ";\n"
  645. ";\n"
  646. "; Output signature:\n"
  647. ";\n"
  648. "; Name Index Mask Register SysValue Format Used\n"
  649. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  650. "; SV_Target 0 xyzw 0 TARGET float xyzw\n";// could read SV_TARGET
  651. const char expected[] =
  652. ";\n"
  653. "; Input signature:\n"
  654. ";\n"
  655. "; Name Index Mask Register SysValue Format Used\n"
  656. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  657. "; SV_Position 0 xyzw 0 POS float \n" // could read SV_POSITION
  658. "; COLOR 0 xyzw 1 NONE float xyzw\n" // should read '1' in register, xyzw in Used
  659. ";\n"
  660. ";\n"
  661. "; Output signature:\n"
  662. ";\n"
  663. "; Name Index Mask Register SysValue Format Used\n"
  664. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  665. "; SV_Target 0 xyzw 0 TARGET float xyzw\n";// could read SV_TARGET
  666. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0) {
  667. std::string start(s.c_str(), strlen(expected_1_4));
  668. VERIFY_ARE_EQUAL_STR(expected_1_4, start.c_str());
  669. } else {
  670. std::string start(s.c_str(), strlen(expected));
  671. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  672. }
  673. }
  674. }
  675. TEST_F(DxilContainerTest, CompileWhenSigSquareThenIncludeSplit) {
  676. #if 0 // TODO: reenable test when multiple rows are supported.
  677. const char program[] =
  678. "float main(float4x4 a : A, int4 b : B) : SV_Target {\n"
  679. " return a[b.x][b.y];\n"
  680. "}";
  681. std::string s = DisassembleProgram(program, L"main", L"ps_6_0");
  682. const char expected[] =
  683. "// Input signature:\n"
  684. "//\n"
  685. "// Name Index Mask Register SysValue Format Used\n"
  686. "// -------------------- ----- ------ -------- -------- ------- ------\n"
  687. "// A 0 xyzw 0 NONE float xyzw\n"
  688. "// A 1 xyzw 1 NONE float xyzw\n"
  689. "// A 2 xyzw 2 NONE float xyzw\n"
  690. "// A 3 xyzw 3 NONE float xyzw\n"
  691. "// B 0 xyzw 4 NONE int xy\n"
  692. "//\n"
  693. "//\n"
  694. "// Output signature:\n"
  695. "//\n"
  696. "// Name Index Mask Register SysValue Format Used\n"
  697. "// -------------------- ----- ------ -------- -------- ------- ------\n"
  698. "// SV_Target 0 x 0 TARGET float x\n";
  699. std::string start(s.c_str(), strlen(expected));
  700. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  701. #endif
  702. }
  703. TEST_F(DxilContainerTest, CompileAS_CheckPSV0) {
  704. if (m_ver.SkipDxilVersion(1, 5)) return;
  705. const char asSource[] =
  706. "struct PayloadType { uint a, b, c; };\n"
  707. "[shader(\"amplification\")]\n"
  708. "[numthreads(1,1,1)]\n"
  709. "void main(uint idx : SV_GroupIndex) {\n"
  710. " PayloadType p = { idx, 2, 3 };\n"
  711. " DispatchMesh(1,1,1, p);\n"
  712. "}";
  713. CComPtr<IDxcCompiler> pCompiler;
  714. CComPtr<IDxcBlobEncoding> pSource;
  715. CComPtr<IDxcBlob> pProgram;
  716. CComPtr<IDxcOperationResult> pResult;
  717. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  718. CreateBlobFromText(asSource, &pSource);
  719. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  720. L"as_6_5", nullptr, 0, nullptr, 0,
  721. nullptr, &pResult));
  722. HRESULT hrStatus;
  723. VERIFY_SUCCEEDED(pResult->GetStatus(&hrStatus));
  724. VERIFY_SUCCEEDED(hrStatus);
  725. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  726. CComPtr<IDxcContainerReflection> containerReflection;
  727. uint32_t partCount;
  728. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  729. IFT(containerReflection->Load(pProgram));
  730. IFT(containerReflection->GetPartCount(&partCount));
  731. bool blobFound = false;
  732. for (uint32_t i = 0; i < partCount; ++i) {
  733. uint32_t kind;
  734. VERIFY_SUCCEEDED(containerReflection->GetPartKind(i, &kind));
  735. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_PipelineStateValidation) {
  736. blobFound = true;
  737. CComPtr<IDxcBlob> pBlob;
  738. VERIFY_SUCCEEDED(containerReflection->GetPartContent(i, &pBlob));
  739. DxilPipelineStateValidation PSV;
  740. PSV.InitFromPSV0(pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  741. PSVShaderKind kind = PSV.GetShaderKind();
  742. VERIFY_ARE_EQUAL(PSVShaderKind::Amplification, kind);
  743. PSVRuntimeInfo0* pInfo = PSV.GetPSVRuntimeInfo0();
  744. VERIFY_IS_NOT_NULL(pInfo);
  745. VERIFY_ARE_EQUAL(12, pInfo->AS.PayloadSizeInBytes);
  746. break;
  747. }
  748. }
  749. VERIFY_IS_TRUE(blobFound);
  750. }
  751. TEST_F(DxilContainerTest, CompileWhenOkThenCheckRDAT) {
  752. if (m_ver.SkipDxilVersion(1, 3)) return;
  753. const char *shader = "float c_buf;"
  754. "RWTexture1D<int4> tex : register(u5);"
  755. "Texture1D<float4> tex2 : register(t0);"
  756. "RWByteAddressBuffer b_buf;"
  757. "struct Foo { float2 f2; int2 i2; };"
  758. "AppendStructuredBuffer<Foo> append_buf;"
  759. "ConsumeStructuredBuffer<Foo> consume_buf;"
  760. "RasterizerOrderedByteAddressBuffer rov_buf;"
  761. "globallycoherent RWByteAddressBuffer gc_buf;"
  762. "float function_import(float x);"
  763. "export float function0(min16float x) { "
  764. " return x + 1 + tex[0].x; }"
  765. "export float function1(float x, min12int i) {"
  766. " return x + c_buf + b_buf.Load(x) + tex2[i].x; }"
  767. "export float function2(float x) { return x + function_import(x); }"
  768. "export void function3(int i) {"
  769. " Foo f = consume_buf.Consume();"
  770. " f.f2 += 0.5; append_buf.Append(f);"
  771. " rov_buf.Store(i, f.i2.x);"
  772. " gc_buf.Store(i, f.i2.y);"
  773. " b_buf.Store(i, f.i2.x + f.i2.y); }";
  774. CComPtr<IDxcCompiler> pCompiler;
  775. CComPtr<IDxcBlobEncoding> pSource;
  776. CComPtr<IDxcBlob> pProgram;
  777. CComPtr<IDxcBlobEncoding> pDisassembly;
  778. CComPtr<IDxcOperationResult> pResult;
  779. struct CheckResFlagInfo { std::string name; hlsl::DXIL::ResourceKind kind; hlsl::RDAT::DxilResourceFlag flag; };
  780. const unsigned numResFlagCheck = 5;
  781. CheckResFlagInfo resFlags[numResFlagCheck] = {
  782. { "b_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::None },
  783. { "append_buf", hlsl::DXIL::ResourceKind::StructuredBuffer, hlsl::RDAT::DxilResourceFlag::UAVCounter },
  784. { "consume_buf", hlsl::DXIL::ResourceKind::StructuredBuffer, hlsl::RDAT::DxilResourceFlag::UAVCounter },
  785. { "gc_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::UAVGloballyCoherent },
  786. { "rov_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::UAVRasterizerOrderedView }
  787. };
  788. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  789. CreateBlobFromText(shader, &pSource);
  790. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  791. L"lib_6_3", nullptr, 0, nullptr, 0,
  792. nullptr, &pResult));
  793. HRESULT hrStatus;
  794. VERIFY_SUCCEEDED(pResult->GetStatus(&hrStatus));
  795. VERIFY_SUCCEEDED(hrStatus);
  796. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  797. CComPtr<IDxcContainerReflection> containerReflection;
  798. uint32_t partCount;
  799. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  800. IFT(containerReflection->Load(pProgram));
  801. IFT(containerReflection->GetPartCount(&partCount));
  802. bool blobFound = false;
  803. for (uint32_t i = 0; i < partCount; ++i) {
  804. uint32_t kind;
  805. IFT(containerReflection->GetPartKind(i, &kind));
  806. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_RuntimeData) {
  807. blobFound = true;
  808. using namespace hlsl::RDAT;
  809. CComPtr<IDxcBlob> pBlob;
  810. IFT(containerReflection->GetPartContent(i, &pBlob));
  811. // Validate using DxilRuntimeData
  812. DxilRuntimeData context;
  813. context.InitFromRDAT((char *)pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  814. FunctionTableReader *funcTableReader = context.GetFunctionTableReader();
  815. ResourceTableReader *resTableReader = context.GetResourceTableReader();
  816. VERIFY_ARE_EQUAL(funcTableReader->GetNumFunctions(), 4);
  817. std::string str("function");
  818. for (uint32_t j = 0; j < funcTableReader->GetNumFunctions(); ++j) {
  819. FunctionReader funcReader = funcTableReader->GetItem(j);
  820. std::string funcName(funcReader.GetUnmangledName());
  821. VERIFY_IS_TRUE(str.compare(funcName.substr(0,8)) == 0);
  822. std::string cur_str = str;
  823. cur_str.push_back('0' + j);
  824. if (cur_str.compare("function0") == 0) {
  825. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 1);
  826. hlsl::ShaderFlags flag;
  827. flag.SetUAVLoadAdditionalFormats(true);
  828. flag.SetLowPrecisionPresent(true);
  829. uint64_t rawFlag = flag.GetFeatureInfo();
  830. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag(), rawFlag);
  831. ResourceReader resReader = funcReader.GetResource(0);
  832. VERIFY_ARE_EQUAL(resReader.GetResourceClass(), hlsl::DXIL::ResourceClass::UAV);
  833. VERIFY_ARE_EQUAL(resReader.GetResourceKind(), hlsl::DXIL::ResourceKind::Texture1D);
  834. }
  835. else if (cur_str.compare("function1") == 0) {
  836. hlsl::ShaderFlags flag;
  837. flag.SetLowPrecisionPresent(true);
  838. uint64_t rawFlag = flag.GetFeatureInfo();
  839. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag(), rawFlag);
  840. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 3);
  841. }
  842. else if (cur_str.compare("function2") == 0) {
  843. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag() & 0xffffffffffffffff, 0);
  844. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 0);
  845. std::string dependency = funcReader.GetDependency(0);
  846. VERIFY_IS_TRUE(dependency.find("function_import") != std::string::npos);
  847. }
  848. else if (cur_str.compare("function3") == 0) {
  849. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag() & 0xffffffffffffffff, 0);
  850. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), numResFlagCheck);
  851. for (unsigned i = 0; i < funcReader.GetNumResources(); ++i) {
  852. ResourceReader resReader = funcReader.GetResource(0);
  853. VERIFY_ARE_EQUAL(resReader.GetResourceClass(), hlsl::DXIL::ResourceClass::UAV);
  854. unsigned j = 0;
  855. for (; j < numResFlagCheck; ++j) {
  856. if (resFlags[j].name.compare(resReader.GetName()) == 0)
  857. break;
  858. }
  859. VERIFY_IS_LESS_THAN(j, numResFlagCheck);
  860. VERIFY_ARE_EQUAL(resReader.GetResourceKind(), resFlags[j].kind);
  861. VERIFY_ARE_EQUAL(resReader.GetFlags(), static_cast<uint32_t>(resFlags[j].flag));
  862. }
  863. }
  864. else {
  865. IFTBOOLMSG(false, E_FAIL, "unknown function name");
  866. }
  867. }
  868. VERIFY_ARE_EQUAL(resTableReader->GetNumResources(), 8);
  869. // This is validation test for DxilRuntimeReflection implemented on DxilRuntimeReflection.inl
  870. unique_ptr<DxilRuntimeReflection> pReflection(CreateDxilRuntimeReflection());
  871. VERIFY_IS_TRUE(pReflection->InitFromRDAT(pBlob->GetBufferPointer(), pBlob->GetBufferSize()));
  872. DxilLibraryDesc lib_reflection = pReflection->GetLibraryReflection();
  873. VERIFY_ARE_EQUAL(lib_reflection.NumFunctions, 4);
  874. for (uint32_t j = 0; j < 3; ++j) {
  875. DxilFunctionDesc function = lib_reflection.pFunction[j];
  876. std::string cur_str = str;
  877. cur_str.push_back('0' + j);
  878. if (cur_str.compare("function0") == 0) {
  879. hlsl::ShaderFlags flag;
  880. flag.SetUAVLoadAdditionalFormats(true);
  881. flag.SetLowPrecisionPresent(true);
  882. uint64_t rawFlag = flag.GetFeatureInfo();
  883. uint64_t featureFlag = static_cast<uint64_t>(function.FeatureInfo2) << 32;
  884. featureFlag |= static_cast<uint64_t>(function.FeatureInfo1);
  885. VERIFY_ARE_EQUAL(featureFlag, rawFlag);
  886. VERIFY_ARE_EQUAL(function.NumResources, 1);
  887. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  888. const DxilResourceDesc &resource = *function.Resources[0];
  889. VERIFY_ARE_EQUAL(resource.Class, (uint32_t)hlsl::DXIL::ResourceClass::UAV);
  890. VERIFY_ARE_EQUAL(resource.Kind, (uint32_t)hlsl::DXIL::ResourceKind::Texture1D);
  891. std::wstring wName = resource.Name;
  892. VERIFY_ARE_EQUAL(wName.compare(L"tex"), 0);
  893. }
  894. else if (cur_str.compare("function1") == 0) {
  895. hlsl::ShaderFlags flag;
  896. flag.SetLowPrecisionPresent(true);
  897. uint64_t rawFlag = flag.GetFeatureInfo();
  898. uint64_t featureFlag = static_cast<uint64_t>(function.FeatureInfo2) << 32;
  899. featureFlag |= static_cast<uint64_t>(function.FeatureInfo1);
  900. VERIFY_ARE_EQUAL(featureFlag, rawFlag);
  901. VERIFY_ARE_EQUAL(function.NumResources, 3);
  902. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  903. std::unordered_set<std::wstring> stringSet = { L"$Globals", L"b_buf", L"tex2" };
  904. for (uint32_t j = 0; j < 3; ++j) {
  905. const DxilResourceDesc &resource = *function.Resources[j];
  906. std::wstring compareName = resource.Name;
  907. VERIFY_IS_TRUE(stringSet.find(compareName) != stringSet.end());
  908. }
  909. }
  910. else if (cur_str.compare("function2") == 0) {
  911. VERIFY_ARE_EQUAL(function.FeatureInfo1, 0);
  912. VERIFY_ARE_EQUAL(function.FeatureInfo2, 0);
  913. VERIFY_ARE_EQUAL(function.NumResources, 0);
  914. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 1);
  915. std::wstring dependency = function.FunctionDependencies[0];
  916. VERIFY_IS_TRUE(dependency.find(L"function_import") != std::wstring::npos);
  917. }
  918. else if (cur_str.compare("function3") == 0) {
  919. VERIFY_ARE_EQUAL(function.FeatureInfo1, 0);
  920. VERIFY_ARE_EQUAL(function.FeatureInfo2, 0);
  921. VERIFY_ARE_EQUAL(function.NumResources, numResFlagCheck);
  922. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  923. for (unsigned i = 0; i < function.NumResources; ++i) {
  924. const DxilResourceDesc *res = function.Resources[i];
  925. VERIFY_ARE_EQUAL(res->Class, static_cast<uint32_t>(hlsl::DXIL::ResourceClass::UAV));
  926. unsigned j = 0;
  927. for (; j < numResFlagCheck; ++j) {
  928. CA2W WName(resFlags[j].name.c_str());
  929. std::wstring compareName(WName);
  930. if (compareName.compare(res->Name) == 0)
  931. break;
  932. }
  933. VERIFY_IS_LESS_THAN(j, numResFlagCheck);
  934. VERIFY_ARE_EQUAL(res->Kind, static_cast<uint32_t>(resFlags[j].kind));
  935. VERIFY_ARE_EQUAL(res->Flags, static_cast<uint32_t>(resFlags[j].flag));
  936. }
  937. }
  938. else {
  939. IFTBOOLMSG(false, E_FAIL, "unknown function name");
  940. }
  941. }
  942. VERIFY_IS_TRUE(lib_reflection.NumResources == 8);
  943. }
  944. }
  945. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  946. }
  947. TEST_F(DxilContainerTest, CompileWhenOkThenCheckRDAT2) {
  948. if (m_ver.SkipDxilVersion(1, 3)) return;
  949. // This is a case when the user of resource is a constant, not instruction.
  950. // Compiler generates the following load instruction for texture.
  951. // load %class.Texture2D, %class.Texture2D* getelementptr inbounds ([3 x
  952. // %class.Texture2D], [3 x %class.Texture2D]*
  953. // @"\01?ThreeTextures@@3PAV?$Texture2D@M@@A", i32 0, i32 0), align 4
  954. const char *shader =
  955. "SamplerState Sampler : register(s0); RWBuffer<float> Uav : "
  956. "register(u0); Texture2D<float> ThreeTextures[3] : register(t0); "
  957. "float function1();"
  958. "[shader(\"raygeneration\")] void RayGenMain() { Uav[0] = "
  959. "ThreeTextures[0].SampleLevel(Sampler, float2(0, 0), 0) + "
  960. "ThreeTextures[2].SampleLevel(Sampler, float2(0, 0), 0) + function1(); }";
  961. CComPtr<IDxcCompiler> pCompiler;
  962. CComPtr<IDxcBlobEncoding> pSource;
  963. CComPtr<IDxcBlob> pProgram;
  964. CComPtr<IDxcBlobEncoding> pDisassembly;
  965. CComPtr<IDxcOperationResult> pResult;
  966. HRESULT status;
  967. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  968. CreateBlobFromText(shader, &pSource);
  969. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  970. L"lib_6_3", nullptr, 0, nullptr, 0,
  971. nullptr, &pResult));
  972. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  973. VERIFY_SUCCEEDED(pResult->GetStatus(&status));
  974. VERIFY_SUCCEEDED(status);
  975. CComPtr<IDxcContainerReflection> pReflection;
  976. uint32_t partCount;
  977. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection));
  978. IFT(pReflection->Load(pProgram));
  979. IFT(pReflection->GetPartCount(&partCount));
  980. bool blobFound = false;
  981. for (uint32_t i = 0; i < partCount; ++i) {
  982. uint32_t kind;
  983. IFT(pReflection->GetPartKind(i, &kind));
  984. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_RuntimeData) {
  985. blobFound = true;
  986. using namespace hlsl::RDAT;
  987. CComPtr<IDxcBlob> pBlob;
  988. IFT(pReflection->GetPartContent(i, &pBlob));
  989. DxilRuntimeData context;
  990. context.InitFromRDAT((char *)pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  991. FunctionTableReader *funcTableReader = context.GetFunctionTableReader();
  992. ResourceTableReader *resTableReader = context.GetResourceTableReader();
  993. VERIFY_IS_TRUE(funcTableReader->GetNumFunctions() == 1);
  994. VERIFY_IS_TRUE(resTableReader->GetNumResources() == 3);
  995. FunctionReader funcReader = funcTableReader->GetItem(0);
  996. llvm::StringRef name(funcReader.GetUnmangledName());
  997. VERIFY_IS_TRUE(name.compare("RayGenMain") == 0);
  998. VERIFY_IS_TRUE(funcReader.GetShaderKind() ==
  999. hlsl::DXIL::ShaderKind::RayGeneration);
  1000. VERIFY_IS_TRUE(funcReader.GetNumResources() == 3);
  1001. VERIFY_IS_TRUE(funcReader.GetNumDependencies() == 1);
  1002. llvm::StringRef dependencyName =
  1003. hlsl::dxilutil::DemangleFunctionName(funcReader.GetDependency(0));
  1004. VERIFY_IS_TRUE(dependencyName.compare("function1") == 0);
  1005. }
  1006. }
  1007. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  1008. }
  1009. static uint32_t EncodedVersion_lib_6_3 = hlsl::EncodeVersion(hlsl::DXIL::ShaderKind::Library, 6, 3);
  1010. static uint32_t EncodedVersion_vs_6_3 = hlsl::EncodeVersion(hlsl::DXIL::ShaderKind::Vertex, 6, 3);
  1011. static void Ref1_CheckCBuffer_Globals(ID3D12ShaderReflectionConstantBuffer *pCBReflection, D3D12_SHADER_BUFFER_DESC &cbDesc) {
  1012. std::string cbName = cbDesc.Name;
  1013. VERIFY_IS_TRUE(cbName.compare("$Globals") == 0);
  1014. VERIFY_ARE_EQUAL(cbDesc.Size, 16);
  1015. VERIFY_ARE_EQUAL(cbDesc.Type, D3D_CT_CBUFFER);
  1016. VERIFY_ARE_EQUAL(cbDesc.Variables, 1);
  1017. // cbval1
  1018. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(0);
  1019. D3D12_SHADER_VARIABLE_DESC varDesc;
  1020. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1021. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval1");
  1022. VERIFY_ARE_EQUAL(varDesc.StartOffset, 0);
  1023. VERIFY_ARE_EQUAL(varDesc.Size, 4);
  1024. // TODO: verify rest of variable
  1025. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1026. D3D12_SHADER_TYPE_DESC tyDesc;
  1027. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1028. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_SCALAR);
  1029. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_FLOAT);
  1030. // TODO: verify rest of type
  1031. }
  1032. static void Ref1_CheckCBuffer_MyCB(ID3D12ShaderReflectionConstantBuffer *pCBReflection, D3D12_SHADER_BUFFER_DESC &cbDesc) {
  1033. std::string cbName = cbDesc.Name;
  1034. VERIFY_IS_TRUE(cbName.compare("MyCB") == 0);
  1035. VERIFY_ARE_EQUAL(cbDesc.Size, 32);
  1036. VERIFY_ARE_EQUAL(cbDesc.Type, D3D_CT_CBUFFER);
  1037. VERIFY_ARE_EQUAL(cbDesc.Variables, 2);
  1038. // cbval2
  1039. {
  1040. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(0);
  1041. D3D12_SHADER_VARIABLE_DESC varDesc;
  1042. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1043. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval2");
  1044. VERIFY_ARE_EQUAL(varDesc.StartOffset, 0);
  1045. VERIFY_ARE_EQUAL(varDesc.Size, 16);
  1046. // TODO: verify rest of variable
  1047. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1048. D3D12_SHADER_TYPE_DESC tyDesc;
  1049. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1050. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_VECTOR);
  1051. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_INT);
  1052. // TODO: verify rest of type
  1053. }
  1054. // cbval3
  1055. {
  1056. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(1);
  1057. D3D12_SHADER_VARIABLE_DESC varDesc;
  1058. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1059. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval3");
  1060. VERIFY_ARE_EQUAL(varDesc.StartOffset, 16);
  1061. VERIFY_ARE_EQUAL(varDesc.Size, 16);
  1062. // TODO: verify rest of variable
  1063. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1064. D3D12_SHADER_TYPE_DESC tyDesc;
  1065. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1066. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_VECTOR);
  1067. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_INT);
  1068. // TODO: verify rest of type
  1069. }
  1070. }
  1071. static void Ref1_CheckBinding_Globals(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1072. std::string resName = resDesc.Name;
  1073. VERIFY_IS_TRUE(resName.compare("$Globals") == 0);
  1074. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_CBUFFER);
  1075. // not explicitly bound:
  1076. VERIFY_ARE_EQUAL(resDesc.BindPoint, 4294967295);
  1077. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1078. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1079. }
  1080. static void Ref1_CheckBinding_MyCB(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1081. std::string resName = resDesc.Name;
  1082. VERIFY_IS_TRUE(resName.compare("MyCB") == 0);
  1083. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_CBUFFER);
  1084. VERIFY_ARE_EQUAL(resDesc.BindPoint, 11);
  1085. VERIFY_ARE_EQUAL(resDesc.Space, 2);
  1086. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1087. }
  1088. static void Ref1_CheckBinding_tex(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1089. std::string resName = resDesc.Name;
  1090. VERIFY_IS_TRUE(resName.compare("tex") == 0);
  1091. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_UAV_RWTYPED);
  1092. VERIFY_ARE_EQUAL(resDesc.BindPoint, 5);
  1093. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1094. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1095. }
  1096. static void Ref1_CheckBinding_tex2(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1097. std::string resName = resDesc.Name;
  1098. VERIFY_IS_TRUE(resName.compare("tex2") == 0);
  1099. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_TEXTURE);
  1100. VERIFY_ARE_EQUAL(resDesc.BindPoint, 0);
  1101. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1102. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1103. }
  1104. static void Ref1_CheckBinding_samp(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1105. std::string resName = resDesc.Name;
  1106. VERIFY_IS_TRUE(resName.compare("samp") == 0);
  1107. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_SAMPLER);
  1108. VERIFY_ARE_EQUAL(resDesc.BindPoint, 7);
  1109. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1110. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1111. }
  1112. static void Ref1_CheckBinding_b_buf(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1113. std::string resName = resDesc.Name;
  1114. VERIFY_IS_TRUE(resName.compare("b_buf") == 0);
  1115. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_UAV_RWBYTEADDRESS);
  1116. // not explicitly bound:
  1117. VERIFY_ARE_EQUAL(resDesc.BindPoint, 4294967295);
  1118. VERIFY_ARE_EQUAL(resDesc.Space, 4294967295);
  1119. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1120. }
  1121. const char *Ref1_Shader =
  1122. "float cbval1;"
  1123. "cbuffer MyCB : register(b11, space2) { int4 cbval2, cbval3; }"
  1124. "RWTexture1D<int4> tex : register(u5);"
  1125. "Texture1D<float4> tex2 : register(t0);"
  1126. "SamplerState samp : register(s7);"
  1127. "RWByteAddressBuffer b_buf;"
  1128. "export float function0(min16float x) { "
  1129. " return x + cbval2.x + tex[0].x; }"
  1130. "export float function1(float x, min12int i) {"
  1131. " return x + cbval1 + b_buf.Load(x) + tex2.Sample(samp, x).x; }"
  1132. "[shader(\"vertex\")]"
  1133. "float4 function2(float4 x : POSITION) : SV_Position { return x + cbval1 + cbval3.x; }";
  1134. TEST_F(DxilContainerTest, CompileWhenOkThenCheckReflection1) {
  1135. if (m_ver.SkipDxilVersion(1, 3)) return;
  1136. CComPtr<IDxcCompiler> pCompiler;
  1137. CComPtr<IDxcBlobEncoding> pSource;
  1138. CComPtr<IDxcBlob> pProgram;
  1139. CComPtr<IDxcBlobEncoding> pDisassembly;
  1140. CComPtr<IDxcOperationResult> pResult;
  1141. CComPtr<ID3D12LibraryReflection> pLibraryReflection;
  1142. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1143. CreateBlobFromText(Ref1_Shader, &pSource);
  1144. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1145. L"lib_6_3", nullptr, 0, nullptr, 0,
  1146. nullptr, &pResult));
  1147. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1148. CComPtr<IDxcContainerReflection> containerReflection;
  1149. uint32_t partCount;
  1150. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  1151. VERIFY_SUCCEEDED(containerReflection->Load(pProgram));
  1152. VERIFY_SUCCEEDED(containerReflection->GetPartCount(&partCount));
  1153. bool blobFound = false;
  1154. for (uint32_t i = 0; i < partCount; ++i) {
  1155. uint32_t kind;
  1156. VERIFY_SUCCEEDED(containerReflection->GetPartKind(i, &kind));
  1157. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_DXIL) {
  1158. blobFound = true;
  1159. VERIFY_SUCCEEDED(containerReflection->GetPartReflection(i, IID_PPV_ARGS(&pLibraryReflection)));
  1160. D3D12_LIBRARY_DESC LibDesc;
  1161. VERIFY_SUCCEEDED(pLibraryReflection->GetDesc(&LibDesc));
  1162. VERIFY_ARE_EQUAL(LibDesc.FunctionCount, 3);
  1163. for (INT iFn = 0; iFn < (INT)LibDesc.FunctionCount; iFn++) {
  1164. ID3D12FunctionReflection *pFunctionReflection = pLibraryReflection->GetFunctionByIndex(iFn);
  1165. D3D12_FUNCTION_DESC FnDesc;
  1166. pFunctionReflection->GetDesc(&FnDesc);
  1167. std::string Name = FnDesc.Name;
  1168. if (Name.compare("\01?function0@@YAM$min16f@@Z") == 0) {
  1169. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_lib_6_3);
  1170. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 1);
  1171. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 2);
  1172. D3D12_SHADER_BUFFER_DESC cbDesc;
  1173. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1174. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1175. std::string cbName = cbDesc.Name;
  1176. (void)(cbName);
  1177. Ref1_CheckCBuffer_MyCB(pCBReflection, cbDesc);
  1178. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1179. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1180. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1181. std::string resName = resDesc.Name;
  1182. if (resName.compare("$Globals") == 0) {
  1183. Ref1_CheckBinding_Globals(resDesc);
  1184. } else if (resName.compare("MyCB") == 0) {
  1185. Ref1_CheckBinding_MyCB(resDesc);
  1186. } else if (resName.compare("samp") == 0) {
  1187. Ref1_CheckBinding_samp(resDesc);
  1188. } else if (resName.compare("tex") == 0) {
  1189. Ref1_CheckBinding_tex(resDesc);
  1190. } else if (resName.compare("tex2") == 0) {
  1191. Ref1_CheckBinding_tex2(resDesc);
  1192. } else if (resName.compare("b_buf") == 0) {
  1193. Ref1_CheckBinding_b_buf(resDesc);
  1194. } else {
  1195. VERIFY_FAIL(L"Unexpected resource used");
  1196. }
  1197. }
  1198. } else if (Name.compare("\01?function1@@YAMM$min12i@@Z") == 0) {
  1199. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_lib_6_3);
  1200. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 1);
  1201. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 4);
  1202. D3D12_SHADER_BUFFER_DESC cbDesc;
  1203. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1204. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1205. std::string cbName = cbDesc.Name;
  1206. (void)(cbName);
  1207. Ref1_CheckCBuffer_Globals(pCBReflection, cbDesc);
  1208. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1209. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1210. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1211. std::string resName = resDesc.Name;
  1212. if (resName.compare("$Globals") == 0) {
  1213. Ref1_CheckBinding_Globals(resDesc);
  1214. } else if (resName.compare("MyCB") == 0) {
  1215. Ref1_CheckBinding_MyCB(resDesc);
  1216. } else if (resName.compare("samp") == 0) {
  1217. Ref1_CheckBinding_samp(resDesc);
  1218. } else if (resName.compare("tex") == 0) {
  1219. Ref1_CheckBinding_tex(resDesc);
  1220. } else if (resName.compare("tex2") == 0) {
  1221. Ref1_CheckBinding_tex2(resDesc);
  1222. } else if (resName.compare("b_buf") == 0) {
  1223. Ref1_CheckBinding_b_buf(resDesc);
  1224. } else {
  1225. VERIFY_FAIL(L"Unexpected resource used");
  1226. }
  1227. }
  1228. } else if (Name.compare("function2") == 0) {
  1229. // shader function with unmangled name
  1230. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_vs_6_3);
  1231. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 2);
  1232. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 2);
  1233. for (INT iCB = 0; iCB < (INT)FnDesc.BoundResources; iCB++) {
  1234. D3D12_SHADER_BUFFER_DESC cbDesc;
  1235. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1236. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1237. std::string cbName = cbDesc.Name;
  1238. if (cbName.compare("$Globals") == 0) {
  1239. Ref1_CheckCBuffer_Globals(pCBReflection, cbDesc);
  1240. } else if (cbName.compare("MyCB") == 0) {
  1241. Ref1_CheckCBuffer_MyCB(pCBReflection, cbDesc);
  1242. }
  1243. }
  1244. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1245. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1246. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1247. std::string resName = resDesc.Name;
  1248. if (resName.compare("$Globals") == 0) {
  1249. Ref1_CheckBinding_Globals(resDesc);
  1250. } else if (resName.compare("MyCB") == 0) {
  1251. Ref1_CheckBinding_MyCB(resDesc);
  1252. } else {
  1253. VERIFY_FAIL(L"Unexpected resource used");
  1254. }
  1255. }
  1256. } else {
  1257. VERIFY_FAIL(L"Unexpected function");
  1258. }
  1259. }
  1260. // TODO: FINISH THIS
  1261. }
  1262. }
  1263. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  1264. }
  1265. TEST_F(DxilContainerTest, DxcUtils_CreateReflection) {
  1266. if (m_ver.SkipDxilVersion(1, 3)) return;
  1267. CComPtr<IDxcUtils> pUtils;
  1268. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcUtils, &pUtils));
  1269. CComPtr<IDxcCompiler> pCompiler;
  1270. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1271. CComPtr<IDxcBlobEncoding> pSource;
  1272. CreateBlobFromText(Ref1_Shader, &pSource);
  1273. LPCWSTR options[] = {
  1274. L"-Qstrip_reflect_from_dxil",
  1275. L"-Qstrip_reflect"
  1276. };
  1277. const UINT32 kStripFromDxilOnly = 1; // just strip reflection from DXIL, not container
  1278. const UINT32 kStripFromContainer = 2; // strip reflection from DXIL and container
  1279. auto VerifyStripReflection = [&](IDxcBlob *pBlob, bool bShouldSucceed) {
  1280. CComPtr<IDxcContainerReflection> pReflection;
  1281. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection));
  1282. VERIFY_SUCCEEDED(pReflection->Load(pBlob));
  1283. UINT32 idxPart = (UINT32)-1;
  1284. if (bShouldSucceed)
  1285. VERIFY_SUCCEEDED(pReflection->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1286. else
  1287. VERIFY_FAILED(pReflection->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1288. CComPtr<IDxcContainerBuilder> pBuilder;
  1289. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerBuilder, &pBuilder));
  1290. VERIFY_SUCCEEDED(pBuilder->Load(pBlob));
  1291. if (bShouldSucceed) {
  1292. VERIFY_SUCCEEDED(pBuilder->RemovePart(DXC_PART_REFLECTION_DATA));
  1293. CComPtr<IDxcOperationResult> pResult;
  1294. VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
  1295. HRESULT hr = E_FAIL;
  1296. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1297. VERIFY_SUCCEEDED(hr);
  1298. CComPtr<IDxcBlob> pStrippedBlob;
  1299. pResult->GetResult(&pStrippedBlob);
  1300. CComPtr<IDxcContainerReflection> pReflection2;
  1301. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection2));
  1302. VERIFY_SUCCEEDED(pReflection2->Load(pStrippedBlob));
  1303. idxPart = (UINT32)-1;
  1304. VERIFY_FAILED(pReflection2->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1305. } else {
  1306. VERIFY_FAILED(pBuilder->RemovePart(DXC_PART_REFLECTION_DATA));
  1307. }
  1308. };
  1309. {
  1310. // Test Shader path
  1311. auto VerifyCreateReflectionShader = [&](IDxcBlob *pBlob, bool bValid)
  1312. {
  1313. DxcBuffer buffer = { pBlob->GetBufferPointer(), pBlob->GetBufferSize(), 0 };
  1314. CComPtr<ID3D12ShaderReflection> pShaderReflection;
  1315. VERIFY_SUCCEEDED(pUtils->CreateReflection(&buffer, IID_PPV_ARGS(&pShaderReflection)));
  1316. D3D12_SHADER_DESC desc;
  1317. VERIFY_SUCCEEDED(pShaderReflection->GetDesc(&desc));
  1318. VERIFY_ARE_EQUAL(desc.Version, EncodedVersion_vs_6_3);
  1319. if (bValid) {
  1320. VERIFY_ARE_EQUAL(desc.ConstantBuffers, 2);
  1321. VERIFY_ARE_EQUAL(desc.BoundResources, 2);
  1322. // That should be good enough to check that IDxcUtils::CreateReflection worked
  1323. }
  1324. };
  1325. {
  1326. // Test Full container path
  1327. CComPtr<IDxcOperationResult> pResult;
  1328. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"function2",
  1329. L"vs_6_3", options, kStripFromDxilOnly,
  1330. nullptr, 0, nullptr, &pResult));
  1331. HRESULT hr;
  1332. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1333. VERIFY_SUCCEEDED(hr);
  1334. CComPtr<IDxcBlob> pProgram;
  1335. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1336. VerifyCreateReflectionShader(pProgram, true);
  1337. // Verify reflection stripping
  1338. VerifyStripReflection(pProgram, true);
  1339. }
  1340. {
  1341. // From New IDxcResult API
  1342. CComPtr<IDxcOperationResult> pResult;
  1343. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"function2",
  1344. L"vs_6_3", options, kStripFromContainer,
  1345. nullptr, 0, nullptr, &pResult));
  1346. HRESULT hr;
  1347. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1348. VERIFY_SUCCEEDED(hr);
  1349. // Test separate reflection result path
  1350. CComPtr<IDxcResult> pResultV2;
  1351. CComPtr<IDxcBlob> pReflectionPart;
  1352. VERIFY_SUCCEEDED(pResult->QueryInterface(&pResultV2));
  1353. VERIFY_SUCCEEDED(pResultV2->GetOutput(DXC_OUT_REFLECTION, IID_PPV_ARGS(&pReflectionPart), nullptr));
  1354. VerifyCreateReflectionShader(pReflectionPart, true);
  1355. // Container should have limited reflection, and no reflection part
  1356. CComPtr<IDxcBlob> pProgram;
  1357. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1358. VerifyCreateReflectionShader(pProgram, false);
  1359. VerifyStripReflection(pProgram, false);
  1360. }
  1361. }
  1362. {
  1363. // Test Library path
  1364. auto VerifyCreateReflectionLibrary = [&](IDxcBlob *pBlob, bool bValid)
  1365. {
  1366. DxcBuffer buffer = { pBlob->GetBufferPointer(), pBlob->GetBufferSize(), 0 };
  1367. CComPtr<ID3D12LibraryReflection> pLibraryReflection;
  1368. VERIFY_SUCCEEDED(pUtils->CreateReflection(&buffer, IID_PPV_ARGS(&pLibraryReflection)));
  1369. D3D12_LIBRARY_DESC desc;
  1370. VERIFY_SUCCEEDED(pLibraryReflection->GetDesc(&desc));
  1371. if (bValid) {
  1372. VERIFY_ARE_EQUAL(desc.FunctionCount, 3);
  1373. // That should be good enough to check that IDxcUtils::CreateReflection worked
  1374. }
  1375. };
  1376. {
  1377. // Test Full container path
  1378. CComPtr<IDxcOperationResult> pResult;
  1379. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1380. L"lib_6_3", options, kStripFromDxilOnly,
  1381. nullptr, 0, nullptr, &pResult));
  1382. HRESULT hr;
  1383. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1384. VERIFY_SUCCEEDED(hr);
  1385. CComPtr<IDxcBlob> pProgram;
  1386. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1387. VerifyCreateReflectionLibrary(pProgram, true);
  1388. // Verify reflection stripping
  1389. VerifyStripReflection(pProgram, true);
  1390. }
  1391. {
  1392. // From New IDxcResult API
  1393. CComPtr<IDxcOperationResult> pResult;
  1394. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1395. L"lib_6_3", options, kStripFromContainer,
  1396. nullptr, 0, nullptr, &pResult));
  1397. HRESULT hr;
  1398. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1399. VERIFY_SUCCEEDED(hr);
  1400. // Test separate reflection result path
  1401. CComPtr<IDxcResult> pResultV2;
  1402. CComPtr<IDxcBlob> pReflectionPart;
  1403. VERIFY_SUCCEEDED(pResult->QueryInterface(&pResultV2));
  1404. VERIFY_SUCCEEDED(pResultV2->GetOutput(DXC_OUT_REFLECTION, IID_PPV_ARGS(&pReflectionPart), nullptr));
  1405. // Test Reflection part path
  1406. VerifyCreateReflectionLibrary(pReflectionPart, true);
  1407. // Container should have limited reflection, and no reflection part
  1408. CComPtr<IDxcBlob> pProgram;
  1409. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1410. VerifyCreateReflectionLibrary(pProgram, false);
  1411. VerifyStripReflection(pProgram, false);
  1412. }
  1413. }
  1414. }
  1415. TEST_F(DxilContainerTest, CompileWhenOKThenIncludesFeatureInfo) {
  1416. CComPtr<IDxcCompiler> pCompiler;
  1417. CComPtr<IDxcBlobEncoding> pSource;
  1418. CComPtr<IDxcBlob> pProgram;
  1419. CComPtr<IDxcBlobEncoding> pDisassembly;
  1420. CComPtr<IDxcOperationResult> pResult;
  1421. hlsl::DxilContainerHeader *pHeader;
  1422. hlsl::DxilPartIterator pPartIter(nullptr, 0);
  1423. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1424. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1425. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1426. nullptr, 0, nullptr, 0, nullptr,
  1427. &pResult));
  1428. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1429. // Now mess with the program bitcode.
  1430. pHeader = (hlsl::DxilContainerHeader *)pProgram->GetBufferPointer();
  1431. pPartIter = std::find_if(hlsl::begin(pHeader), hlsl::end(pHeader),
  1432. hlsl::DxilPartIsType(hlsl::DFCC_FeatureInfo));
  1433. VERIFY_ARE_NOT_EQUAL(hlsl::end(pHeader), pPartIter);
  1434. VERIFY_ARE_EQUAL(sizeof(uint64_t), (*pPartIter)->PartSize);
  1435. VERIFY_ARE_EQUAL(0U, *(const uint64_t *)hlsl::GetDxilPartData(*pPartIter));
  1436. }
  1437. TEST_F(DxilContainerTest, DisassemblyWhenBCInvalidThenFails) {
  1438. CComPtr<IDxcCompiler> pCompiler;
  1439. CComPtr<IDxcBlobEncoding> pSource;
  1440. CComPtr<IDxcBlob> pProgram;
  1441. CComPtr<IDxcBlobEncoding> pDisassembly;
  1442. CComPtr<IDxcOperationResult> pResult;
  1443. hlsl::DxilContainerHeader *pHeader;
  1444. hlsl::DxilPartHeader *pPart;
  1445. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1446. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1447. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1448. nullptr, 0, nullptr, 0, nullptr,
  1449. &pResult));
  1450. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1451. // Now mess with the program bitcode.
  1452. pHeader = (hlsl::DxilContainerHeader *)pProgram->GetBufferPointer();
  1453. pPart = const_cast<hlsl::DxilPartHeader *>(
  1454. *std::find_if(hlsl::begin(pHeader), hlsl::end(pHeader),
  1455. hlsl::DxilPartIsType(hlsl::DFCC_DXIL)));
  1456. strcpy_s(hlsl::GetDxilPartData(pPart), pPart->PartSize, "corruption");
  1457. VERIFY_FAILED(pCompiler->Disassemble(pProgram, &pDisassembly));
  1458. }
  1459. TEST_F(DxilContainerTest, DisassemblyWhenMissingThenFails) {
  1460. CComPtr<IDxcCompiler> pCompiler;
  1461. CComPtr<IDxcBlobEncoding> pSource;
  1462. CComPtr<IDxcBlobEncoding> pDisassembly;
  1463. hlsl::DxilContainerHeader header;
  1464. SetupBasicHeader(&header);
  1465. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1466. CreateBlobPinned(&header, header.ContainerSizeInBytes, 0, &pSource);
  1467. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1468. }
  1469. TEST_F(DxilContainerTest, DisassemblyWhenInvalidThenFails) {
  1470. CComPtr<IDxcCompiler> pCompiler;
  1471. CComPtr<IDxcBlobEncoding> pDisassembly;
  1472. uint8_t scratch[1024];
  1473. hlsl::DxilContainerHeader *pHeader = (hlsl::DxilContainerHeader *)scratch;
  1474. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1475. // Too small to contain header.
  1476. {
  1477. CComPtr<IDxcBlobEncoding> pSource;
  1478. SetupBasicHeader(pHeader);
  1479. CreateBlobPinned(pHeader, sizeof(hlsl::DxilContainerHeader) - 4, 0,
  1480. &pSource);
  1481. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1482. }
  1483. // Wrong major version.
  1484. {
  1485. CComPtr<IDxcBlobEncoding> pSource;
  1486. SetupBasicHeader(pHeader);
  1487. pHeader->Version.Major = 100;
  1488. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1489. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1490. }
  1491. // Size out of bounds.
  1492. {
  1493. CComPtr<IDxcBlobEncoding> pSource;
  1494. SetupBasicHeader(pHeader);
  1495. pHeader->ContainerSizeInBytes = 1024;
  1496. CreateBlobPinned(pHeader, sizeof(hlsl::DxilContainerHeader), 0,
  1497. &pSource);
  1498. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1499. }
  1500. // Size too large as per spec limit.
  1501. {
  1502. CComPtr<IDxcBlobEncoding> pSource;
  1503. SetupBasicHeader(pHeader);
  1504. pHeader->ContainerSizeInBytes = hlsl::DxilContainerMaxSize + 1;
  1505. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1506. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1507. }
  1508. // Not large enough to hold offset table.
  1509. {
  1510. CComPtr<IDxcBlobEncoding> pSource;
  1511. SetupBasicHeader(pHeader);
  1512. pHeader->PartCount = 1;
  1513. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1514. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1515. }
  1516. // Part offset out of bounds.
  1517. {
  1518. CComPtr<IDxcBlobEncoding> pSource;
  1519. SetupBasicHeader(pHeader);
  1520. pHeader->PartCount = 1;
  1521. *((uint32_t *)(pHeader + 1)) = 1024;
  1522. pHeader->ContainerSizeInBytes += sizeof(uint32_t);
  1523. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1524. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1525. }
  1526. // Part size out of bounds.
  1527. {
  1528. CComPtr<IDxcBlobEncoding> pSource;
  1529. SetupBasicHeader(pHeader);
  1530. pHeader->PartCount = 1;
  1531. *((uint32_t *)(pHeader + 1)) = sizeof(*pHeader) + sizeof(uint32_t);
  1532. pHeader->ContainerSizeInBytes += sizeof(uint32_t);
  1533. hlsl::GetDxilContainerPart(pHeader, 0)->PartSize = 1024;
  1534. pHeader->ContainerSizeInBytes += sizeof(hlsl::DxilPartHeader);
  1535. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1536. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1537. }
  1538. }
  1539. TEST_F(DxilContainerTest, DisassemblyWhenValidThenOK) {
  1540. CComPtr<IDxcCompiler> pCompiler;
  1541. CComPtr<IDxcBlobEncoding> pSource;
  1542. CComPtr<IDxcBlob> pProgram;
  1543. CComPtr<IDxcBlobEncoding> pDisassembly;
  1544. CComPtr<IDxcOperationResult> pResult;
  1545. hlsl::DxilContainerHeader header;
  1546. SetupBasicHeader(&header);
  1547. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1548. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1549. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1550. nullptr, 0, nullptr, 0, nullptr,
  1551. &pResult));
  1552. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1553. VERIFY_SUCCEEDED(pCompiler->Disassemble(pProgram, &pDisassembly));
  1554. std::string disassembleString(BlobToUtf8(pDisassembly));
  1555. VERIFY_ARE_NOT_EQUAL(0U, disassembleString.size());
  1556. }
  1557. class HlslFileVariables {
  1558. private:
  1559. std::wstring m_Entry;
  1560. std::wstring m_Mode;
  1561. std::wstring m_Target;
  1562. std::vector<std::wstring> m_Arguments;
  1563. std::vector<LPCWSTR> m_ArgumentPtrs;
  1564. public:
  1565. HlslFileVariables(HlslFileVariables &other) = delete;
  1566. const LPCWSTR *GetArguments() const { return m_ArgumentPtrs.data(); }
  1567. UINT32 GetArgumentCount() const { return m_ArgumentPtrs.size(); }
  1568. LPCWSTR GetEntry() const { return m_Entry.c_str(); }
  1569. LPCWSTR GetMode() const { return m_Mode.c_str(); }
  1570. LPCWSTR GetTarget() const { return m_Target.c_str(); }
  1571. void Reset();
  1572. HRESULT SetFromText(_In_count_(len) const char *pText, size_t len);
  1573. };
  1574. void HlslFileVariables::Reset() {
  1575. m_Entry.resize(0);
  1576. m_Mode.resize(0);
  1577. m_Target.resize(0);
  1578. m_Arguments.resize(0);
  1579. m_ArgumentPtrs.resize(0);
  1580. }
  1581. #include <codecvt>
  1582. static bool wcsneq(const wchar_t *pValue, const wchar_t *pCheck) {
  1583. return 0 == wcsncmp(pValue, pCheck, wcslen(pCheck));
  1584. }
  1585. HRESULT HlslFileVariables::SetFromText(_In_count_(len) const char *pText, size_t len) {
  1586. // Look for the line of interest.
  1587. const char *pEnd = pText + len;
  1588. const char *pLineEnd = pText;
  1589. while (pLineEnd < pEnd && *pLineEnd != '\n') pLineEnd++;
  1590. // Create a UTF-16-backing store.
  1591. std::wstring_convert<std::codecvt_utf8_utf16<wchar_t> > w;
  1592. std::wstring line = w.from_bytes(pText, pLineEnd);
  1593. // Find starting and ending '-*-' delimiters.
  1594. const wchar_t *pWText = line.c_str();
  1595. const wchar_t *pVarStart = wcsstr(pWText, L"-*-");
  1596. if (!pVarStart) return E_INVALIDARG;
  1597. pVarStart += 3;
  1598. const wchar_t *pVarEnd = wcsstr(pVarStart, L"-*-");
  1599. if (!pVarEnd) return E_INVALIDARG;
  1600. for (;;) {
  1601. // Find 'name' ':' 'value' ';'
  1602. const wchar_t *pVarNameStart = pVarStart;
  1603. while (pVarNameStart < pVarEnd && L' ' == *pVarNameStart) ++pVarNameStart;
  1604. if (pVarNameStart == pVarEnd) break;
  1605. const wchar_t *pVarValDelim = pVarNameStart;
  1606. while (pVarValDelim < pVarEnd && L':' != *pVarValDelim) ++pVarValDelim;
  1607. if (pVarValDelim == pVarEnd) break;
  1608. const wchar_t *pVarValStart = pVarValDelim + 1;
  1609. while (pVarValStart < pVarEnd && L' ' == *pVarValStart) ++pVarValStart;
  1610. if (pVarValStart == pVarEnd) break;
  1611. const wchar_t *pVarValEnd = pVarValStart;
  1612. while (pVarValEnd < pVarEnd && L';' != *pVarValEnd) ++pVarValEnd;
  1613. if (wcsneq(pVarNameStart, L"mode")) {
  1614. m_Mode.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1615. }
  1616. else if (wcsneq(pVarNameStart, L"hlsl-entry")) {
  1617. m_Entry.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1618. }
  1619. else if (wcsneq(pVarNameStart, L"hlsl-target")) {
  1620. m_Target.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1621. }
  1622. else if (wcsneq(pVarNameStart, L"hlsl-args")) {
  1623. // skip for now
  1624. }
  1625. }
  1626. return S_OK;
  1627. }
  1628. #ifdef _WIN32 // Reflection unsupported
  1629. TEST_F(DxilContainerTest, ReflectionMatchesDXBC_CheckIn) {
  1630. WEX::TestExecution::SetVerifyOutput verifySettings(WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures);
  1631. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\container\\SimpleBezier11DS.hlsl").c_str(), false);
  1632. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\container\\SubD11_SmoothPS.hlsl").c_str(), false);
  1633. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\structured_buffer_layout.hlsl").c_str(), false);
  1634. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\cb_sizes.hlsl").c_str(), false);
  1635. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\tbuffer.hlsl").c_str(), false,
  1636. D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY);
  1637. }
  1638. TEST_F(DxilContainerTest, ReflectionMatchesDXBC_Full) {
  1639. WEX::TestExecution::SetVerifyOutput verifySettings(WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures);
  1640. std::wstring codeGenPath = hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\Samples");
  1641. // This test was running at about three minutes; that can be enabled with TestAll=True,
  1642. // otherwise the much shorter list is used.
  1643. const bool TestAll = false;
  1644. LPCWSTR PreApprovedPaths[] = {
  1645. L"2DQuadShaders_VS.hlsl",
  1646. L"BC6HEncode_TryModeLE10CS.hlsl",
  1647. L"DepthViewerVS.hlsl",
  1648. L"DetailTessellation11_DS.hlsl",
  1649. L"GenerateHistogramCS.hlsl",
  1650. L"OIT_PS.hlsl",
  1651. L"PNTriangles11_DS.hlsl",
  1652. L"PerfGraphPS.hlsl",
  1653. L"PerfGraphVS.hlsl",
  1654. L"ScreenQuadVS.hlsl",
  1655. L"SimpleBezier11HS.hlsl"
  1656. };
  1657. // These tests should always be skipped
  1658. LPCWSTR SkipPaths[] = {
  1659. L".hlsli",
  1660. L"TessellatorCS40_defines.h",
  1661. L"SubD11_SubDToBezierHS",
  1662. L"ParticleTileCullingCS_fail_unroll.hlsl"
  1663. };
  1664. for (auto &p: recursive_directory_iterator(path(codeGenPath))) {
  1665. if (is_regular_file(p)) {
  1666. LPCWSTR fullPath = p.path().c_str();
  1667. auto Matches = [&](LPCWSTR candidate) {
  1668. LPCWSTR match = wcsstr(fullPath, candidate);
  1669. return nullptr != match;
  1670. };
  1671. // Skip failed tests.
  1672. LPCWSTR *SkipEnd = SkipPaths + _countof(SkipPaths);
  1673. if (SkipEnd != std::find_if(SkipPaths, SkipEnd, Matches))
  1674. continue;
  1675. if (!TestAll) {
  1676. bool shouldTest = false;
  1677. LPCWSTR *PreApprovedEnd = PreApprovedPaths + _countof(PreApprovedPaths);
  1678. shouldTest = PreApprovedEnd != std::find_if(PreApprovedPaths, PreApprovedEnd, Matches);
  1679. if (!shouldTest) {
  1680. continue;
  1681. }
  1682. }
  1683. auto start = std::chrono::system_clock::now();
  1684. ReflectionTest(fullPath, true);
  1685. if (TestAll) {
  1686. // If testing all cases, print out their timing.
  1687. auto end = std::chrono::system_clock::now();
  1688. auto dur = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
  1689. LogCommentFmt(L"%s,%u", fullPath, (unsigned)dur.count());
  1690. }
  1691. }
  1692. }
  1693. }
  1694. #endif // _WIN32 - Reflection unsupported
  1695. TEST_F(DxilContainerTest, ValidateFromLL_Abs2) {
  1696. CodeGenTestCheck(L"..\\CodeGenHLSL\\container\\abs2_m.ll");
  1697. }
  1698. TEST_F(DxilContainerTest, DxilContainerUnitTest) {
  1699. CComPtr<IDxcCompiler> pCompiler;
  1700. CComPtr<IDxcBlobEncoding> pSource;
  1701. CComPtr<IDxcBlob> pProgram;
  1702. CComPtr<IDxcBlobEncoding> pDisassembly;
  1703. CComPtr<IDxcOperationResult> pResult;
  1704. std::vector<LPCWSTR> arguments;
  1705. arguments.emplace_back(L"/Zi");
  1706. arguments.emplace_back(L"/Qembed_debug");
  1707. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1708. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1709. // Test DxilContainer with ShaderDebugInfoDXIL
  1710. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0", arguments.data(), arguments.size(), nullptr, 0, nullptr, &pResult));
  1711. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1712. const hlsl::DxilContainerHeader *pHeader = hlsl::IsDxilContainerLike(pProgram->GetBufferPointer(), pProgram->GetBufferSize());
  1713. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(pHeader, pProgram->GetBufferSize()));
  1714. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(pHeader, pProgram->GetBufferSize()));
  1715. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1716. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1717. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1718. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1719. pResult.Release();
  1720. pProgram.Release();
  1721. // Test DxilContainer without ShaderDebugInfoDXIL
  1722. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0", nullptr, 0, nullptr, 0, nullptr, &pResult));
  1723. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1724. pHeader = hlsl::IsDxilContainerLike(pProgram->GetBufferPointer(), pProgram->GetBufferSize());
  1725. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(pHeader, pProgram->GetBufferSize()));
  1726. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(pHeader, pProgram->GetBufferSize()));
  1727. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1728. VERIFY_IS_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1729. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1730. VERIFY_IS_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1731. // Test Empty DxilContainer
  1732. hlsl::DxilContainerHeader header;
  1733. SetupBasicHeader(&header);
  1734. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(&header, header.ContainerSizeInBytes));
  1735. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(&header, header.ContainerSizeInBytes));
  1736. VERIFY_IS_NULL(hlsl::GetDxilProgramHeader(&header, hlsl::DxilFourCC::DFCC_DXIL));
  1737. VERIFY_IS_NULL(hlsl::GetDxilPartByType(&header, hlsl::DxilFourCC::DFCC_DXIL));
  1738. }