DxilContainerTest.cpp 80 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916
  1. ///////////////////////////////////////////////////////////////////////////////
  2. // //
  3. // DxilContainerTest.cpp //
  4. // Copyright (C) Microsoft Corporation. All rights reserved. //
  5. // This file is distributed under the University of Illinois Open Source //
  6. // License. See LICENSE.TXT for details. //
  7. // //
  8. // Provides tests for container formatting and validation. //
  9. // //
  10. ///////////////////////////////////////////////////////////////////////////////
  11. #ifndef UNICODE
  12. #define UNICODE
  13. #endif
  14. #ifdef __APPLE__
  15. // Workaround for ambiguous wcsstr on Mac
  16. #define _WCHAR_H_CPLUSPLUS_98_CONFORMANCE_
  17. #endif
  18. #include <memory>
  19. #include <vector>
  20. #include <string>
  21. #include <tuple>
  22. #include <cassert>
  23. #include <sstream>
  24. #include <algorithm>
  25. #include <unordered_set>
  26. #include "dxc/Support/WinIncludes.h"
  27. #include "dxc/dxcapi.h"
  28. #ifdef _WIN32
  29. #include <atlfile.h>
  30. #include <d3dcompiler.h>
  31. #pragma comment(lib, "d3dcompiler.lib")
  32. #if _MSC_VER >= 1920
  33. #define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING
  34. #include <experimental/filesystem>
  35. #else
  36. #include <filesystem>
  37. #endif
  38. #endif
  39. #include "llvm/Support/Format.h"
  40. #include "llvm/Support/raw_ostream.h"
  41. #include "dxc/Test/HLSLTestData.h"
  42. #include "dxc/Test/HlslTestUtils.h"
  43. #include "dxc/Test/DxcTestUtils.h"
  44. #include "dxc/Support/Global.h"
  45. #include "dxc/Support/dxcapi.use.h"
  46. #include "dxc/Support/HLSLOptions.h"
  47. #include "dxc/DxilContainer/DxilContainer.h"
  48. #include "dxc/DxilContainer/DxilRuntimeReflection.h"
  49. #include <assert.h> // Needed for DxilPipelineStateValidation.h
  50. #include "dxc/DxilContainer/DxilPipelineStateValidation.h"
  51. #include "dxc/DXIL/DxilShaderFlags.h"
  52. #include "dxc/DXIL/DxilUtil.h"
  53. #include <fstream>
  54. #include <chrono>
  55. #include <codecvt>
  56. using namespace std;
  57. using namespace hlsl_test;
  58. #ifdef _WIN32
  59. using namespace std::experimental::filesystem;
  60. static uint8_t MaskCount(uint8_t V) {
  61. DXASSERT_NOMSG(0 <= V && V <= 0xF);
  62. static const uint8_t Count[16] = {
  63. 0, 1, 1, 2,
  64. 1, 2, 2, 3,
  65. 1, 2, 2, 3,
  66. 2, 3, 3, 4
  67. };
  68. return Count[V];
  69. }
  70. #endif
  71. #ifdef _WIN32
  72. class DxilContainerTest {
  73. #else
  74. class DxilContainerTest : public ::testing::Test {
  75. #endif
  76. public:
  77. BEGIN_TEST_CLASS(DxilContainerTest)
  78. TEST_CLASS_PROPERTY(L"Parallel", L"true")
  79. TEST_METHOD_PROPERTY(L"Priority", L"0")
  80. END_TEST_CLASS()
  81. TEST_CLASS_SETUP(InitSupport);
  82. TEST_METHOD(CompileWhenDebugSourceThenSourceMatters)
  83. TEST_METHOD(CompileAS_CheckPSV0)
  84. TEST_METHOD(CompileWhenOkThenCheckRDAT)
  85. TEST_METHOD(CompileWhenOkThenCheckRDAT2)
  86. TEST_METHOD(CompileWhenOkThenCheckReflection1)
  87. TEST_METHOD(DxcUtils_CreateReflection)
  88. TEST_METHOD(CompileWhenOKThenIncludesFeatureInfo)
  89. TEST_METHOD(CompileWhenOKThenIncludesSignatures)
  90. TEST_METHOD(CompileWhenSigSquareThenIncludeSplit)
  91. TEST_METHOD(DisassemblyWhenMissingThenFails)
  92. TEST_METHOD(DisassemblyWhenBCInvalidThenFails)
  93. TEST_METHOD(DisassemblyWhenInvalidThenFails)
  94. TEST_METHOD(DisassemblyWhenValidThenOK)
  95. TEST_METHOD(ValidateFromLL_Abs2)
  96. TEST_METHOD(DxilContainerUnitTest)
  97. TEST_METHOD(ReflectionMatchesDXBC_CheckIn)
  98. BEGIN_TEST_METHOD(ReflectionMatchesDXBC_Full)
  99. TEST_METHOD_PROPERTY(L"Priority", L"1")
  100. END_TEST_METHOD()
  101. dxc::DxcDllSupport m_dllSupport;
  102. VersionSupportInfo m_ver;
  103. void CreateBlobPinned(_In_bytecount_(size) LPCVOID data, SIZE_T size,
  104. UINT32 codePage, _Outptr_ IDxcBlobEncoding **ppBlob) {
  105. CComPtr<IDxcLibrary> library;
  106. IFT(m_dllSupport.CreateInstance(CLSID_DxcLibrary, &library));
  107. IFT(library->CreateBlobWithEncodingFromPinned((LPBYTE)data, size, codePage,
  108. ppBlob));
  109. }
  110. void CreateBlobFromText(_In_z_ const char *pText,
  111. _Outptr_ IDxcBlobEncoding **ppBlob) {
  112. CreateBlobPinned(pText, strlen(pText), CP_UTF8, ppBlob);
  113. }
  114. HRESULT CreateCompiler(IDxcCompiler **ppResult) {
  115. if (!m_dllSupport.IsEnabled()) {
  116. VERIFY_SUCCEEDED(m_dllSupport.Initialize());
  117. }
  118. return m_dllSupport.CreateInstance(CLSID_DxcCompiler, ppResult);
  119. }
  120. #ifdef _WIN32 // - Reflection Unsupported
  121. void CompareShaderInputBindDesc(D3D12_SHADER_INPUT_BIND_DESC *pTestDesc,
  122. D3D12_SHADER_INPUT_BIND_DESC *pBaseDesc) {
  123. VERIFY_ARE_EQUAL(pTestDesc->BindCount, pBaseDesc->BindCount);
  124. VERIFY_ARE_EQUAL(pTestDesc->BindPoint, pBaseDesc->BindPoint);
  125. VERIFY_ARE_EQUAL(pTestDesc->Dimension, pBaseDesc->Dimension);
  126. VERIFY_ARE_EQUAL_STR(pTestDesc->Name, pBaseDesc->Name);
  127. VERIFY_ARE_EQUAL(pTestDesc->NumSamples, pBaseDesc->NumSamples);
  128. VERIFY_ARE_EQUAL(pTestDesc->ReturnType, pBaseDesc->ReturnType);
  129. VERIFY_ARE_EQUAL(pTestDesc->Space, pBaseDesc->Space);
  130. if (pBaseDesc->Type == D3D_SIT_UAV_APPEND_STRUCTURED ||
  131. pBaseDesc->Type == D3D_SIT_UAV_CONSUME_STRUCTURED) {
  132. // dxil only have rw with counter.
  133. VERIFY_ARE_EQUAL(pTestDesc->Type, D3D_SIT_UAV_RWSTRUCTURED_WITH_COUNTER);
  134. } else if (pTestDesc->Type == D3D_SIT_STRUCTURED &&
  135. pBaseDesc->Type != D3D_SIT_STRUCTURED) {
  136. VERIFY_ARE_EQUAL(pBaseDesc->Type, D3D_SIT_TEXTURE);
  137. } else
  138. VERIFY_ARE_EQUAL(pTestDesc->Type, pBaseDesc->Type);
  139. // D3D_SIF_USERPACKED is not set consistently in fxc (new-style ConstantBuffer).
  140. UINT unusedFlag = D3D_SIF_USERPACKED;
  141. VERIFY_ARE_EQUAL(pTestDesc->uFlags & ~unusedFlag, pBaseDesc->uFlags & ~unusedFlag);
  142. // VERIFY_ARE_EQUAL(pTestDesc->uID, pBaseDesc->uID); // Like register, this can vary.
  143. }
  144. void CompareParameterDesc(D3D12_SIGNATURE_PARAMETER_DESC *pTestDesc,
  145. D3D12_SIGNATURE_PARAMETER_DESC *pBaseDesc, bool isInput) {
  146. VERIFY_ARE_EQUAL(0, _stricmp(pTestDesc->SemanticName, pBaseDesc->SemanticName));
  147. if (pTestDesc->SystemValueType == D3D_NAME_CLIP_DISTANCE) return; // currently generating multiple clip distance params, one per component
  148. VERIFY_ARE_EQUAL(pTestDesc->ComponentType, pBaseDesc->ComponentType);
  149. VERIFY_ARE_EQUAL(MaskCount(pTestDesc->Mask), MaskCount(pBaseDesc->Mask));
  150. VERIFY_ARE_EQUAL(pTestDesc->MinPrecision, pBaseDesc->MinPrecision);
  151. if (!isInput) {
  152. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0)
  153. VERIFY_ARE_EQUAL(pTestDesc->ReadWriteMask != 0, pBaseDesc->ReadWriteMask != 0);
  154. else
  155. VERIFY_ARE_EQUAL(MaskCount(pTestDesc->ReadWriteMask), MaskCount(pBaseDesc->ReadWriteMask));
  156. }
  157. // VERIFY_ARE_EQUAL(pTestDesc->Register, pBaseDesc->Register);
  158. //VERIFY_ARE_EQUAL(pTestDesc->SemanticIndex, pBaseDesc->SemanticIndex);
  159. VERIFY_ARE_EQUAL(pTestDesc->Stream, pBaseDesc->Stream);
  160. VERIFY_ARE_EQUAL(pTestDesc->SystemValueType, pBaseDesc->SystemValueType);
  161. }
  162. void CompareType(ID3D12ShaderReflectionType *pTest,
  163. ID3D12ShaderReflectionType *pBase)
  164. {
  165. D3D12_SHADER_TYPE_DESC testDesc, baseDesc;
  166. VERIFY_SUCCEEDED(pTest->GetDesc(&testDesc));
  167. VERIFY_SUCCEEDED(pBase->GetDesc(&baseDesc));
  168. VERIFY_ARE_EQUAL(testDesc.Class, baseDesc.Class);
  169. VERIFY_ARE_EQUAL(testDesc.Type, baseDesc.Type);
  170. VERIFY_ARE_EQUAL(testDesc.Rows, baseDesc.Rows);
  171. VERIFY_ARE_EQUAL(testDesc.Columns, baseDesc.Columns);
  172. VERIFY_ARE_EQUAL(testDesc.Elements, baseDesc.Elements);
  173. VERIFY_ARE_EQUAL(testDesc.Members, baseDesc.Members);
  174. VERIFY_ARE_EQUAL(testDesc.Offset, baseDesc.Offset);
  175. // DXIL Reflection doesn't expose half type name,
  176. // and that shouldn't matter because this is only
  177. // in the case where half maps to float.
  178. std::string baseName(baseDesc.Name);
  179. if (baseName.compare(0, 4, "half", 4) == 0)
  180. baseName = baseName.replace(0, 4, "float", 5);
  181. VERIFY_ARE_EQUAL_STR(testDesc.Name, baseName.c_str());
  182. for (UINT i = 0; i < baseDesc.Members; ++i) {
  183. ID3D12ShaderReflectionType* testMemberType = pTest->GetMemberTypeByIndex(i);
  184. ID3D12ShaderReflectionType* baseMemberType = pBase->GetMemberTypeByIndex(i);
  185. VERIFY_IS_NOT_NULL(testMemberType);
  186. VERIFY_IS_NOT_NULL(baseMemberType);
  187. CompareType(testMemberType, baseMemberType);
  188. LPCSTR testMemberName = pTest->GetMemberTypeName(i);
  189. LPCSTR baseMemberName = pBase->GetMemberTypeName(i);
  190. VERIFY_ARE_EQUAL(0, strcmp(testMemberName, baseMemberName));
  191. }
  192. }
  193. typedef HRESULT (__stdcall ID3D12ShaderReflection::*GetParameterDescFn)(UINT, D3D12_SIGNATURE_PARAMETER_DESC*);
  194. void SortNameIdxVector(std::vector<std::tuple<LPCSTR, UINT, UINT>> &value) {
  195. struct FirstPredT {
  196. bool operator()(std::tuple<LPCSTR, UINT, UINT> &l,
  197. std::tuple<LPCSTR, UINT, UINT> &r) {
  198. int strResult = strcmp(std::get<0>(l), std::get<0>(r));
  199. return (strResult < 0 ) || (strResult == 0 && std::get<1>(l) < std::get<1>(r));
  200. }
  201. } FirstPred;
  202. std::sort(value.begin(), value.end(), FirstPred);
  203. }
  204. void CompareParameterDescs(UINT count, ID3D12ShaderReflection *pTest,
  205. ID3D12ShaderReflection *pBase,
  206. GetParameterDescFn Fn, bool isInput) {
  207. std::vector<std::tuple<LPCSTR, UINT, UINT>> testParams, baseParams;
  208. testParams.reserve(count);
  209. baseParams.reserve(count);
  210. for (UINT i = 0; i < count; ++i) {
  211. D3D12_SIGNATURE_PARAMETER_DESC D;
  212. VERIFY_SUCCEEDED((pTest->*Fn)(i, &D));
  213. testParams.push_back(std::make_tuple(D.SemanticName, D.SemanticIndex, i));
  214. VERIFY_SUCCEEDED((pBase->*Fn)(i, &D));
  215. baseParams.push_back(std::make_tuple(D.SemanticName, D.SemanticIndex, i));
  216. }
  217. SortNameIdxVector(testParams);
  218. SortNameIdxVector(baseParams);
  219. for (UINT i = 0; i < count; ++i) {
  220. D3D12_SIGNATURE_PARAMETER_DESC testParamDesc, baseParamDesc;
  221. VERIFY_SUCCEEDED(
  222. (pTest->*Fn)(std::get<2>(testParams[i]), &testParamDesc));
  223. VERIFY_SUCCEEDED(
  224. (pBase->*Fn)(std::get<2>(baseParams[i]), &baseParamDesc));
  225. CompareParameterDesc(&testParamDesc, &baseParamDesc, isInput);
  226. }
  227. }
  228. void CompareReflection(ID3D12ShaderReflection *pTest, ID3D12ShaderReflection *pBase) {
  229. D3D12_SHADER_DESC testDesc, baseDesc;
  230. VERIFY_SUCCEEDED(pTest->GetDesc(&testDesc));
  231. VERIFY_SUCCEEDED(pBase->GetDesc(&baseDesc));
  232. VERIFY_ARE_EQUAL(D3D12_SHVER_GET_TYPE(testDesc.Version), D3D12_SHVER_GET_TYPE(baseDesc.Version));
  233. VERIFY_ARE_EQUAL(testDesc.ConstantBuffers, baseDesc.ConstantBuffers);
  234. VERIFY_ARE_EQUAL(testDesc.BoundResources, baseDesc.BoundResources);
  235. VERIFY_ARE_EQUAL(testDesc.InputParameters, baseDesc.InputParameters);
  236. VERIFY_ARE_EQUAL(testDesc.OutputParameters, baseDesc.OutputParameters);
  237. VERIFY_ARE_EQUAL(testDesc.PatchConstantParameters, baseDesc.PatchConstantParameters);
  238. {
  239. for (UINT i = 0; i < testDesc.ConstantBuffers; ++i) {
  240. ID3D12ShaderReflectionConstantBuffer *pTestCB, *pBaseCB;
  241. D3D12_SHADER_BUFFER_DESC testCB, baseCB;
  242. pTestCB = pTest->GetConstantBufferByIndex(i);
  243. VERIFY_SUCCEEDED(pTestCB->GetDesc(&testCB));
  244. pBaseCB = pBase->GetConstantBufferByName(testCB.Name);
  245. VERIFY_SUCCEEDED(pBaseCB->GetDesc(&baseCB));
  246. VERIFY_ARE_EQUAL_STR(testCB.Name, baseCB.Name);
  247. VERIFY_ARE_EQUAL(testCB.Type, baseCB.Type);
  248. VERIFY_ARE_EQUAL(testCB.Variables, baseCB.Variables);
  249. VERIFY_ARE_EQUAL(testCB.Size, baseCB.Size);
  250. VERIFY_ARE_EQUAL(testCB.uFlags, baseCB.uFlags);
  251. llvm::StringMap<D3D12_SHADER_VARIABLE_DESC> variableMap;
  252. llvm::StringMap<ID3D12ShaderReflectionType*> variableTypeMap;
  253. for (UINT vi = 0; vi < testCB.Variables; ++vi) {
  254. ID3D12ShaderReflectionVariable *pBaseConst;
  255. D3D12_SHADER_VARIABLE_DESC baseConst;
  256. pBaseConst = pBaseCB->GetVariableByIndex(vi);
  257. VERIFY_SUCCEEDED(pBaseConst->GetDesc(&baseConst));
  258. variableMap[baseConst.Name] = baseConst;
  259. ID3D12ShaderReflectionType* pBaseType = pBaseConst->GetType();
  260. VERIFY_IS_NOT_NULL(pBaseType);
  261. variableTypeMap[baseConst.Name] = pBaseType;
  262. }
  263. for (UINT vi = 0; vi < testCB.Variables; ++vi) {
  264. ID3D12ShaderReflectionVariable *pTestConst;
  265. D3D12_SHADER_VARIABLE_DESC testConst;
  266. pTestConst = pTestCB->GetVariableByIndex(vi);
  267. VERIFY_SUCCEEDED(pTestConst->GetDesc(&testConst));
  268. VERIFY_ARE_EQUAL(variableMap.count(testConst.Name), 1);
  269. D3D12_SHADER_VARIABLE_DESC baseConst = variableMap[testConst.Name];
  270. VERIFY_ARE_EQUAL(testConst.uFlags, baseConst.uFlags);
  271. VERIFY_ARE_EQUAL(testConst.StartOffset, baseConst.StartOffset);
  272. VERIFY_ARE_EQUAL(testConst.Size, baseConst.Size);
  273. ID3D12ShaderReflectionType* pTestType = pTestConst->GetType();
  274. VERIFY_IS_NOT_NULL(pTestType);
  275. VERIFY_ARE_EQUAL(variableTypeMap.count(testConst.Name), 1);
  276. ID3D12ShaderReflectionType* pBaseType = variableTypeMap[testConst.Name];
  277. CompareType(pTestType, pBaseType);
  278. }
  279. }
  280. }
  281. for (UINT i = 0; i < testDesc.BoundResources; ++i) {
  282. D3D12_SHADER_INPUT_BIND_DESC testParamDesc, baseParamDesc;
  283. VERIFY_SUCCEEDED(pTest->GetResourceBindingDesc(i, &testParamDesc), WStrFmt(L"i=%u", i));
  284. VERIFY_SUCCEEDED(pBase->GetResourceBindingDescByName(testParamDesc.Name, &baseParamDesc));
  285. CompareShaderInputBindDesc(&testParamDesc, &baseParamDesc);
  286. }
  287. CompareParameterDescs(testDesc.InputParameters, pTest, pBase, &ID3D12ShaderReflection::GetInputParameterDesc, true);
  288. CompareParameterDescs(testDesc.OutputParameters, pTest, pBase,
  289. &ID3D12ShaderReflection::GetOutputParameterDesc,
  290. false);
  291. bool isHs = testDesc.HSPartitioning != D3D_TESSELLATOR_PARTITIONING::D3D11_TESSELLATOR_PARTITIONING_UNDEFINED;
  292. CompareParameterDescs(
  293. testDesc.PatchConstantParameters, pTest, pBase,
  294. &ID3D12ShaderReflection::GetPatchConstantParameterDesc, !isHs);
  295. {
  296. UINT32 testTotal, testX, testY, testZ;
  297. UINT32 baseTotal, baseX, baseY, baseZ;
  298. testTotal = pTest->GetThreadGroupSize(&testX, &testY, &testZ);
  299. baseTotal = pBase->GetThreadGroupSize(&baseX, &baseY, &baseZ);
  300. VERIFY_ARE_EQUAL(testTotal, baseTotal);
  301. VERIFY_ARE_EQUAL(testX, baseX);
  302. VERIFY_ARE_EQUAL(testY, baseY);
  303. VERIFY_ARE_EQUAL(testZ, baseZ);
  304. }
  305. }
  306. #endif // _WIN32 - Reflection unsupported
  307. #ifdef _WIN32 // - Reflection unsupported
  308. HRESULT CompileFromFile(LPCWSTR path, bool useDXBC,
  309. UINT fxcFlags, IDxcBlob **ppBlob) {
  310. std::vector<FileRunCommandPart> parts;
  311. ParseCommandPartsFromFile(path, parts);
  312. VERIFY_IS_TRUE(parts.size() > 0);
  313. unsigned partIdx = 0;
  314. if (parts[0].Command.compare("%dxilver") == 0) {
  315. partIdx = 1;
  316. }
  317. FileRunCommandPart &dxc = parts[partIdx];
  318. VERIFY_ARE_EQUAL_STR(dxc.Command.c_str(), "%dxc");
  319. m_dllSupport.Initialize();
  320. hlsl::options::MainArgs args;
  321. hlsl::options::DxcOpts opts;
  322. dxc.ReadOptsForDxc(args, opts);
  323. if (opts.CodeGenHighLevel) return E_FAIL; // skip for now
  324. if (useDXBC) {
  325. // Consider supporting defines and flags if/when needed.
  326. std::string TargetProfile(opts.TargetProfile.str());
  327. TargetProfile[3] = '5';
  328. // Some shaders may need flags, and /Gec is incompatible with SM 5.1
  329. TargetProfile[5] = (fxcFlags & D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY) ? '0' : '1';
  330. CComPtr<ID3DBlob> pDxbcBlob;
  331. CComPtr<ID3DBlob> pDxbcErrors;
  332. HRESULT hr = D3DCompileFromFile(path, nullptr, D3D_COMPILE_STANDARD_FILE_INCLUDE,
  333. opts.EntryPoint.str().c_str(),
  334. TargetProfile.c_str(),
  335. fxcFlags,
  336. 0, &pDxbcBlob, &pDxbcErrors);
  337. LPCSTR errors = pDxbcErrors ? (const char *)pDxbcErrors->GetBufferPointer() : "";
  338. (void)errors;
  339. IFR(hr);
  340. IFR(pDxbcBlob.QueryInterface(ppBlob));
  341. }
  342. else {
  343. FileRunCommandResult result = dxc.Run(m_dllSupport, nullptr);
  344. IFRBOOL(result.ExitCode == 0, E_FAIL);
  345. IFR(result.OpResult->GetResult(ppBlob));
  346. }
  347. return S_OK;
  348. }
  349. void CreateReflectionFromBlob(IDxcBlob *pBlob, ID3D12ShaderReflection **ppReflection) {
  350. CComPtr<IDxcContainerReflection> pReflection;
  351. UINT32 shaderIdx;
  352. m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection);
  353. VERIFY_SUCCEEDED(pReflection->Load(pBlob));
  354. VERIFY_SUCCEEDED(pReflection->FindFirstPartKind(hlsl::DFCC_DXIL, &shaderIdx));
  355. VERIFY_SUCCEEDED(pReflection->GetPartReflection(shaderIdx, __uuidof(ID3D12ShaderReflection), (void**)ppReflection));
  356. }
  357. void CreateReflectionFromDXBC(IDxcBlob *pBlob, ID3D12ShaderReflection **ppReflection) {
  358. VERIFY_SUCCEEDED(
  359. D3DReflect(pBlob->GetBufferPointer(), pBlob->GetBufferSize(),
  360. __uuidof(ID3D12ShaderReflection), (void **)ppReflection));
  361. }
  362. #endif // _WIN32 - Reflection unsupported
  363. void CompileToProgram(LPCSTR program, LPCWSTR entryPoint, LPCWSTR target,
  364. LPCWSTR *pArguments, UINT32 argCount,
  365. IDxcBlob **ppProgram,
  366. IDxcOperationResult **ppResult = nullptr) {
  367. CComPtr<IDxcCompiler> pCompiler;
  368. CComPtr<IDxcBlobEncoding> pSource;
  369. CComPtr<IDxcBlob> pProgram;
  370. CComPtr<IDxcOperationResult> pResult;
  371. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  372. CreateBlobFromText(program, &pSource);
  373. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", entryPoint,
  374. target, pArguments, argCount, nullptr,
  375. 0, nullptr, &pResult));
  376. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  377. *ppProgram = pProgram.Detach();
  378. if (ppResult)
  379. *ppResult = pResult.Detach();
  380. }
  381. bool DoesValidatorSupportDebugName() {
  382. CComPtr<IDxcVersionInfo> pVersionInfo;
  383. UINT Major, Minor;
  384. HRESULT hrVer = m_dllSupport.CreateInstance(CLSID_DxcValidator, &pVersionInfo);
  385. if (hrVer == E_NOINTERFACE) return false;
  386. VERIFY_SUCCEEDED(hrVer);
  387. VERIFY_SUCCEEDED(pVersionInfo->GetVersion(&Major, &Minor));
  388. return !(Major == 1 && Minor < 1);
  389. }
  390. bool DoesValidatorSupportShaderHash() {
  391. CComPtr<IDxcVersionInfo> pVersionInfo;
  392. UINT Major, Minor;
  393. HRESULT hrVer = m_dllSupport.CreateInstance(CLSID_DxcValidator, &pVersionInfo);
  394. if (hrVer == E_NOINTERFACE) return false;
  395. VERIFY_SUCCEEDED(hrVer);
  396. VERIFY_SUCCEEDED(pVersionInfo->GetVersion(&Major, &Minor));
  397. return !(Major == 1 && Minor < 5);
  398. }
  399. std::string CompileToDebugName(LPCSTR program, LPCWSTR entryPoint,
  400. LPCWSTR target, LPCWSTR *pArguments, UINT32 argCount) {
  401. CComPtr<IDxcBlob> pProgram;
  402. CComPtr<IDxcBlob> pNameBlob;
  403. CComPtr<IDxcContainerReflection> pContainer;
  404. UINT32 index;
  405. CompileToProgram(program, entryPoint, target, pArguments, argCount, &pProgram);
  406. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pContainer));
  407. VERIFY_SUCCEEDED(pContainer->Load(pProgram));
  408. if (FAILED(pContainer->FindFirstPartKind(hlsl::DFCC_ShaderDebugName, &index))) {
  409. return std::string();
  410. }
  411. VERIFY_SUCCEEDED(pContainer->GetPartContent(index, &pNameBlob));
  412. const hlsl::DxilShaderDebugName *pDebugName = (hlsl::DxilShaderDebugName *)pNameBlob->GetBufferPointer();
  413. return std::string((const char *)(pDebugName + 1));
  414. }
  415. std::string RetrieveHashFromBlob(IDxcBlob* pHashBlob) {
  416. VERIFY_ARE_NOT_EQUAL(pHashBlob, nullptr);
  417. VERIFY_ARE_EQUAL(pHashBlob->GetBufferSize(), sizeof(DxcShaderHash));
  418. const hlsl::DxilShaderHash *pShaderHash = (hlsl::DxilShaderHash *)pHashBlob->GetBufferPointer();
  419. std::string result;
  420. llvm::raw_string_ostream os(result);
  421. for (int i = 0; i < 16; ++i)
  422. os << llvm::format("%.2x", pShaderHash->Digest[i]);
  423. return os.str();
  424. }
  425. std::string CompileToShaderHash(LPCSTR program, LPCWSTR entryPoint,
  426. LPCWSTR target, LPCWSTR *pArguments, UINT32 argCount) {
  427. CComPtr<IDxcOperationResult> pResult;
  428. CComPtr<IDxcBlob> pProgram;
  429. CComPtr<IDxcBlob> pHashBlob;
  430. CComPtr<IDxcContainerReflection> pContainer;
  431. UINT32 index;
  432. CompileToProgram(program, entryPoint, target, pArguments, argCount, &pProgram, &pResult);
  433. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pContainer));
  434. VERIFY_SUCCEEDED(pContainer->Load(pProgram));
  435. if (FAILED(pContainer->FindFirstPartKind(hlsl::DFCC_ShaderHash, &index))) {
  436. return std::string();
  437. }
  438. VERIFY_SUCCEEDED(pContainer->GetPartContent(index, &pHashBlob));
  439. std::string hashFromPart = RetrieveHashFromBlob(pHashBlob);
  440. CComPtr<IDxcResult> pDxcResult;
  441. if (SUCCEEDED(pResult->QueryInterface(&pDxcResult))) {
  442. // Make sure shader hash was returned in result
  443. VERIFY_IS_TRUE(pDxcResult->HasOutput(DXC_OUT_SHADER_HASH));
  444. pHashBlob.Release();
  445. VERIFY_SUCCEEDED(pDxcResult->GetOutput(DXC_OUT_SHADER_HASH, IID_PPV_ARGS(&pHashBlob), nullptr));
  446. std::string hashFromResult = RetrieveHashFromBlob(pHashBlob);
  447. VERIFY_ARE_EQUAL(hashFromPart, hashFromPart);
  448. }
  449. return hashFromPart;
  450. }
  451. std::string DisassembleProgram(LPCSTR program, LPCWSTR entryPoint,
  452. LPCWSTR target) {
  453. CComPtr<IDxcCompiler> pCompiler;
  454. CComPtr<IDxcBlob> pProgram;
  455. CComPtr<IDxcBlobEncoding> pDisassembly;
  456. CompileToProgram(program, entryPoint, target, nullptr, 0, &pProgram);
  457. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  458. VERIFY_SUCCEEDED(pCompiler->Disassemble(pProgram, &pDisassembly));
  459. return BlobToUtf8(pDisassembly);
  460. }
  461. void SetupBasicHeader(hlsl::DxilContainerHeader *pHeader,
  462. uint32_t partCount = 0) {
  463. ZeroMemory(pHeader, sizeof(*pHeader));
  464. pHeader->HeaderFourCC = hlsl::DFCC_Container;
  465. pHeader->Version.Major = 1;
  466. pHeader->Version.Minor = 0;
  467. pHeader->PartCount = partCount;
  468. pHeader->ContainerSizeInBytes =
  469. sizeof(hlsl::DxilContainerHeader) +
  470. sizeof(uint32_t) * partCount +
  471. sizeof(hlsl::DxilPartHeader) * partCount;
  472. }
  473. void CodeGenTestCheck(LPCWSTR name) {
  474. std::wstring fullPath = hlsl_test::GetPathToHlslDataFile(name);
  475. FileRunTestResult t = FileRunTestResult::RunFromFileCommands(fullPath.c_str());
  476. if (t.RunResult != 0) {
  477. CA2W commentWide(t.ErrorMessage.c_str(), CP_UTF8);
  478. WEX::Logging::Log::Comment(commentWide);
  479. WEX::Logging::Log::Error(L"Run result is not zero");
  480. }
  481. }
  482. #ifdef _WIN32 // Reflection unsupported
  483. WEX::Common::String WStrFmt(const wchar_t* msg, ...) {
  484. va_list args;
  485. va_start(args, msg);
  486. WEX::Common::String result = WEX::Common::String().FormatV(msg, args);
  487. va_end(args);
  488. return result;
  489. }
  490. void ReflectionTest(LPCWSTR name, bool ignoreIfDXBCFails,
  491. UINT fxcFlags = D3DCOMPILE_ENABLE_UNBOUNDED_DESCRIPTOR_TABLES) {
  492. WEX::Logging::Log::Comment(WEX::Common::String().Format(L"Reflection comparison for %s", name));
  493. // Skip if unsupported.
  494. std::vector<FileRunCommandPart> parts;
  495. ParseCommandPartsFromFile(name, parts);
  496. VERIFY_IS_TRUE(parts.size() > 0);
  497. if (parts[0].Command.compare("%dxilver") == 0) {
  498. VERIFY_IS_TRUE(parts.size() > 1);
  499. auto result = parts[0].Run(m_dllSupport, nullptr);
  500. if (result.ExitCode != 0)
  501. return;
  502. }
  503. CComPtr<IDxcBlob> pProgram;
  504. CComPtr<IDxcBlob> pProgramDXBC;
  505. HRESULT hrDXBC = CompileFromFile(name, true, fxcFlags, &pProgramDXBC);
  506. if (FAILED(hrDXBC)) {
  507. WEX::Logging::Log::Comment(L"Failed to compile DXBC blob.");
  508. if (ignoreIfDXBCFails) return;
  509. VERIFY_FAIL();
  510. }
  511. if (FAILED(CompileFromFile(name, false, 0, &pProgram))) {
  512. WEX::Logging::Log::Comment(L"Failed to compile DXIL blob.");
  513. VERIFY_FAIL();
  514. }
  515. CComPtr<ID3D12ShaderReflection> pProgramReflection;
  516. CComPtr<ID3D12ShaderReflection> pProgramReflectionDXBC;
  517. CreateReflectionFromBlob(pProgram, &pProgramReflection);
  518. CreateReflectionFromDXBC(pProgramDXBC, &pProgramReflectionDXBC);
  519. CompareReflection(pProgramReflection, pProgramReflectionDXBC);
  520. }
  521. #endif // _WIN32 - Reflection unsupported
  522. };
  523. bool DxilContainerTest::InitSupport() {
  524. if (!m_dllSupport.IsEnabled()) {
  525. VERIFY_SUCCEEDED(m_dllSupport.Initialize());
  526. m_ver.Initialize(m_dllSupport);
  527. }
  528. return true;
  529. }
  530. #ifdef _WIN32
  531. TEST_F(DxilContainerTest, CompileWhenDebugSourceThenSourceMatters) {
  532. char program1[] = "float4 main() : SV_Target { return 0; }";
  533. char program2[] = " float4 main() : SV_Target { return 0; } ";
  534. LPCWSTR Zi[] = { L"/Zi", L"/Qembed_debug" };
  535. LPCWSTR ZiZss[] = { L"/Zi", L"/Qembed_debug", L"/Zss" };
  536. LPCWSTR ZiZsb[] = { L"/Zi", L"/Qembed_debug", L"/Zsb" };
  537. LPCWSTR Zsb[] = { L"/Zsb" };
  538. // No debug info, no debug name...
  539. std::string noName = CompileToDebugName(program1, L"main", L"ps_6_0", nullptr, 0);
  540. VERIFY_IS_TRUE(noName.empty());
  541. if (!DoesValidatorSupportDebugName())
  542. return;
  543. // Debug info, default to source name.
  544. std::string sourceName1 = CompileToDebugName(program1, L"main", L"ps_6_0", Zi, _countof(Zi));
  545. VERIFY_IS_FALSE(sourceName1.empty());
  546. // Deterministic naming.
  547. std::string sourceName1Again = CompileToDebugName(program1, L"main", L"ps_6_0", Zi, _countof(Zi));
  548. VERIFY_ARE_EQUAL_STR(sourceName1.c_str(), sourceName1Again.c_str());
  549. // Use program binary by default, so name should be the same.
  550. std::string sourceName2 = CompileToDebugName(program2, L"main", L"ps_6_0", Zi, _countof(Zi));
  551. VERIFY_IS_TRUE(0 == strcmp(sourceName2.c_str(), sourceName1.c_str()));
  552. // Source again, different because different switches are specified.
  553. std::string sourceName1Zss = CompileToDebugName(program1, L"main", L"ps_6_0", ZiZss, _countof(ZiZss));
  554. VERIFY_IS_FALSE(0 == strcmp(sourceName1Zss.c_str(), sourceName1.c_str()));
  555. // Binary program 1 and 2 should be different from source and equal to each other.
  556. std::string binName1 = CompileToDebugName(program1, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  557. std::string binName2 = CompileToDebugName(program2, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  558. VERIFY_ARE_EQUAL_STR(binName1.c_str(), binName2.c_str());
  559. VERIFY_IS_FALSE(0 == strcmp(sourceName1Zss.c_str(), binName1.c_str()));
  560. if (!DoesValidatorSupportShaderHash())
  561. return;
  562. // Verify source hash
  563. std::string binHash1Zss = CompileToShaderHash(program1, L"main", L"ps_6_0", ZiZss, _countof(ZiZss));
  564. VERIFY_IS_FALSE(binHash1Zss.empty());
  565. // bin hash when compiling with /Zi
  566. std::string binHash1 = CompileToShaderHash(program1, L"main", L"ps_6_0", ZiZsb, _countof(ZiZsb));
  567. VERIFY_IS_FALSE(binHash1.empty());
  568. // Without /Zi hash for /Zsb should be the same
  569. std::string binHash2 = CompileToShaderHash(program2, L"main", L"ps_6_0", Zsb, _countof(Zsb));
  570. VERIFY_IS_FALSE(binHash2.empty());
  571. VERIFY_ARE_EQUAL_STR(binHash1.c_str(), binHash2.c_str());
  572. // Source hash and bin hash should be different
  573. VERIFY_IS_FALSE(0 == strcmp(binHash1Zss.c_str(), binHash1.c_str()));
  574. }
  575. #endif // _WIN32
  576. TEST_F(DxilContainerTest, CompileWhenOKThenIncludesSignatures) {
  577. char program[] =
  578. "struct PSInput {\r\n"
  579. " float4 position : SV_POSITION;\r\n"
  580. " float4 color : COLOR;\r\n"
  581. "};\r\n"
  582. "PSInput VSMain(float4 position : POSITION, float4 color : COLOR) {\r\n"
  583. " PSInput result;\r\n"
  584. " result.position = position;\r\n"
  585. " result.color = color;\r\n"
  586. " return result;\r\n"
  587. "}\r\n"
  588. "float4 PSMain(PSInput input) : SV_TARGET {\r\n"
  589. " return input.color;\r\n"
  590. "}";
  591. {
  592. std::string s = DisassembleProgram(program, L"VSMain", L"vs_6_0");
  593. // NOTE: this will change when proper packing is done, and when 'always-reads' is accurately implemented.
  594. const char expected_1_4[] =
  595. ";\n"
  596. "; Input signature:\n"
  597. ";\n"
  598. "; Name Index Mask Register SysValue Format Used\n"
  599. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  600. "; POSITION 0 xyzw 0 NONE float \n" // should read 'xyzw' in Used
  601. "; COLOR 0 xyzw 1 NONE float \n" // should read '1' in register
  602. ";\n"
  603. ";\n"
  604. "; Output signature:\n"
  605. ";\n"
  606. "; Name Index Mask Register SysValue Format Used\n"
  607. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  608. "; SV_Position 0 xyzw 0 POS float xyzw\n" // could read SV_POSITION
  609. "; COLOR 0 xyzw 1 NONE float xyzw\n"; // should read '1' in register
  610. const char expected[] =
  611. ";\n"
  612. "; Input signature:\n"
  613. ";\n"
  614. "; Name Index Mask Register SysValue Format Used\n"
  615. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  616. "; POSITION 0 xyzw 0 NONE float xyzw\n" // should read 'xyzw' in Used
  617. "; COLOR 0 xyzw 1 NONE float xyzw\n" // should read '1' in register
  618. ";\n"
  619. ";\n"
  620. "; Output signature:\n"
  621. ";\n"
  622. "; Name Index Mask Register SysValue Format Used\n"
  623. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  624. "; SV_Position 0 xyzw 0 POS float xyzw\n" // could read SV_POSITION
  625. "; COLOR 0 xyzw 1 NONE float xyzw\n"; // should read '1' in register
  626. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0) {
  627. std::string start(s.c_str(), strlen(expected_1_4));
  628. VERIFY_ARE_EQUAL_STR(expected_1_4, start.c_str());
  629. } else {
  630. std::string start(s.c_str(), strlen(expected));
  631. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  632. }
  633. }
  634. {
  635. std::string s = DisassembleProgram(program, L"PSMain", L"ps_6_0");
  636. // NOTE: this will change when proper packing is done, and when 'always-reads' is accurately implemented.
  637. const char expected_1_4[] =
  638. ";\n"
  639. "; Input signature:\n"
  640. ";\n"
  641. "; Name Index Mask Register SysValue Format Used\n"
  642. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  643. "; SV_Position 0 xyzw 0 POS float \n" // could read SV_POSITION
  644. "; COLOR 0 xyzw 1 NONE float \n" // should read '1' in register, xyzw in Used
  645. ";\n"
  646. ";\n"
  647. "; Output signature:\n"
  648. ";\n"
  649. "; Name Index Mask Register SysValue Format Used\n"
  650. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  651. "; SV_Target 0 xyzw 0 TARGET float xyzw\n";// could read SV_TARGET
  652. const char expected[] =
  653. ";\n"
  654. "; Input signature:\n"
  655. ";\n"
  656. "; Name Index Mask Register SysValue Format Used\n"
  657. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  658. "; SV_Position 0 xyzw 0 POS float \n" // could read SV_POSITION
  659. "; COLOR 0 xyzw 1 NONE float xyzw\n" // should read '1' in register, xyzw in Used
  660. ";\n"
  661. ";\n"
  662. "; Output signature:\n"
  663. ";\n"
  664. "; Name Index Mask Register SysValue Format Used\n"
  665. "; -------------------- ----- ------ -------- -------- ------- ------\n"
  666. "; SV_Target 0 xyzw 0 TARGET float xyzw\n";// could read SV_TARGET
  667. if (hlsl::DXIL::CompareVersions(m_ver.m_ValMajor, m_ver.m_ValMinor, 1, 5) < 0) {
  668. std::string start(s.c_str(), strlen(expected_1_4));
  669. VERIFY_ARE_EQUAL_STR(expected_1_4, start.c_str());
  670. } else {
  671. std::string start(s.c_str(), strlen(expected));
  672. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  673. }
  674. }
  675. }
  676. TEST_F(DxilContainerTest, CompileWhenSigSquareThenIncludeSplit) {
  677. #if 0 // TODO: reenable test when multiple rows are supported.
  678. const char program[] =
  679. "float main(float4x4 a : A, int4 b : B) : SV_Target {\n"
  680. " return a[b.x][b.y];\n"
  681. "}";
  682. std::string s = DisassembleProgram(program, L"main", L"ps_6_0");
  683. const char expected[] =
  684. "// Input signature:\n"
  685. "//\n"
  686. "// Name Index Mask Register SysValue Format Used\n"
  687. "// -------------------- ----- ------ -------- -------- ------- ------\n"
  688. "// A 0 xyzw 0 NONE float xyzw\n"
  689. "// A 1 xyzw 1 NONE float xyzw\n"
  690. "// A 2 xyzw 2 NONE float xyzw\n"
  691. "// A 3 xyzw 3 NONE float xyzw\n"
  692. "// B 0 xyzw 4 NONE int xy\n"
  693. "//\n"
  694. "//\n"
  695. "// Output signature:\n"
  696. "//\n"
  697. "// Name Index Mask Register SysValue Format Used\n"
  698. "// -------------------- ----- ------ -------- -------- ------- ------\n"
  699. "// SV_Target 0 x 0 TARGET float x\n";
  700. std::string start(s.c_str(), strlen(expected));
  701. VERIFY_ARE_EQUAL_STR(expected, start.c_str());
  702. #endif
  703. }
  704. TEST_F(DxilContainerTest, CompileAS_CheckPSV0) {
  705. if (m_ver.SkipDxilVersion(1, 5)) return;
  706. const char asSource[] =
  707. "struct PayloadType { uint a, b, c; };\n"
  708. "[shader(\"amplification\")]\n"
  709. "[numthreads(1,1,1)]\n"
  710. "void main(uint idx : SV_GroupIndex) {\n"
  711. " PayloadType p = { idx, 2, 3 };\n"
  712. " DispatchMesh(1,1,1, p);\n"
  713. "}";
  714. CComPtr<IDxcCompiler> pCompiler;
  715. CComPtr<IDxcBlobEncoding> pSource;
  716. CComPtr<IDxcBlob> pProgram;
  717. CComPtr<IDxcOperationResult> pResult;
  718. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  719. CreateBlobFromText(asSource, &pSource);
  720. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  721. L"as_6_5", nullptr, 0, nullptr, 0,
  722. nullptr, &pResult));
  723. HRESULT hrStatus;
  724. VERIFY_SUCCEEDED(pResult->GetStatus(&hrStatus));
  725. VERIFY_SUCCEEDED(hrStatus);
  726. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  727. CComPtr<IDxcContainerReflection> containerReflection;
  728. uint32_t partCount;
  729. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  730. IFT(containerReflection->Load(pProgram));
  731. IFT(containerReflection->GetPartCount(&partCount));
  732. bool blobFound = false;
  733. for (uint32_t i = 0; i < partCount; ++i) {
  734. uint32_t kind;
  735. VERIFY_SUCCEEDED(containerReflection->GetPartKind(i, &kind));
  736. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_PipelineStateValidation) {
  737. blobFound = true;
  738. CComPtr<IDxcBlob> pBlob;
  739. VERIFY_SUCCEEDED(containerReflection->GetPartContent(i, &pBlob));
  740. DxilPipelineStateValidation PSV;
  741. PSV.InitFromPSV0(pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  742. PSVShaderKind kind = PSV.GetShaderKind();
  743. VERIFY_ARE_EQUAL(PSVShaderKind::Amplification, kind);
  744. PSVRuntimeInfo0* pInfo = PSV.GetPSVRuntimeInfo0();
  745. VERIFY_IS_NOT_NULL(pInfo);
  746. VERIFY_ARE_EQUAL(12, pInfo->AS.PayloadSizeInBytes);
  747. break;
  748. }
  749. }
  750. VERIFY_IS_TRUE(blobFound);
  751. }
  752. TEST_F(DxilContainerTest, CompileWhenOkThenCheckRDAT) {
  753. if (m_ver.SkipDxilVersion(1, 3)) return;
  754. const char *shader = "float c_buf;"
  755. "RWTexture1D<int4> tex : register(u5);"
  756. "Texture1D<float4> tex2 : register(t0);"
  757. "RWByteAddressBuffer b_buf;"
  758. "struct Foo { float2 f2; int2 i2; };"
  759. "AppendStructuredBuffer<Foo> append_buf;"
  760. "ConsumeStructuredBuffer<Foo> consume_buf;"
  761. "RasterizerOrderedByteAddressBuffer rov_buf;"
  762. "globallycoherent RWByteAddressBuffer gc_buf;"
  763. "float function_import(float x);"
  764. "export float function0(min16float x) { "
  765. " return x + 1 + tex[0].x; }"
  766. "export float function1(float x, min12int i) {"
  767. " return x + c_buf + b_buf.Load(x) + tex2[i].x; }"
  768. "export float function2(float x) { return x + function_import(x); }"
  769. "export void function3(int i) {"
  770. " Foo f = consume_buf.Consume();"
  771. " f.f2 += 0.5; append_buf.Append(f);"
  772. " rov_buf.Store(i, f.i2.x);"
  773. " gc_buf.Store(i, f.i2.y);"
  774. " b_buf.Store(i, f.i2.x + f.i2.y); }";
  775. CComPtr<IDxcCompiler> pCompiler;
  776. CComPtr<IDxcBlobEncoding> pSource;
  777. CComPtr<IDxcBlob> pProgram;
  778. CComPtr<IDxcBlobEncoding> pDisassembly;
  779. CComPtr<IDxcOperationResult> pResult;
  780. struct CheckResFlagInfo { std::string name; hlsl::DXIL::ResourceKind kind; hlsl::RDAT::DxilResourceFlag flag; };
  781. const unsigned numResFlagCheck = 5;
  782. CheckResFlagInfo resFlags[numResFlagCheck] = {
  783. { "b_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::None },
  784. { "append_buf", hlsl::DXIL::ResourceKind::StructuredBuffer, hlsl::RDAT::DxilResourceFlag::UAVCounter },
  785. { "consume_buf", hlsl::DXIL::ResourceKind::StructuredBuffer, hlsl::RDAT::DxilResourceFlag::UAVCounter },
  786. { "gc_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::UAVGloballyCoherent },
  787. { "rov_buf", hlsl::DXIL::ResourceKind::RawBuffer, hlsl::RDAT::DxilResourceFlag::UAVRasterizerOrderedView }
  788. };
  789. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  790. CreateBlobFromText(shader, &pSource);
  791. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  792. L"lib_6_3", nullptr, 0, nullptr, 0,
  793. nullptr, &pResult));
  794. HRESULT hrStatus;
  795. VERIFY_SUCCEEDED(pResult->GetStatus(&hrStatus));
  796. VERIFY_SUCCEEDED(hrStatus);
  797. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  798. CComPtr<IDxcContainerReflection> containerReflection;
  799. uint32_t partCount;
  800. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  801. IFT(containerReflection->Load(pProgram));
  802. IFT(containerReflection->GetPartCount(&partCount));
  803. bool blobFound = false;
  804. for (uint32_t i = 0; i < partCount; ++i) {
  805. uint32_t kind;
  806. IFT(containerReflection->GetPartKind(i, &kind));
  807. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_RuntimeData) {
  808. blobFound = true;
  809. using namespace hlsl::RDAT;
  810. CComPtr<IDxcBlob> pBlob;
  811. IFT(containerReflection->GetPartContent(i, &pBlob));
  812. // Validate using DxilRuntimeData
  813. DxilRuntimeData context;
  814. context.InitFromRDAT((char *)pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  815. FunctionTableReader *funcTableReader = context.GetFunctionTableReader();
  816. ResourceTableReader *resTableReader = context.GetResourceTableReader();
  817. VERIFY_ARE_EQUAL(funcTableReader->GetNumFunctions(), 4);
  818. std::string str("function");
  819. for (uint32_t j = 0; j < funcTableReader->GetNumFunctions(); ++j) {
  820. FunctionReader funcReader = funcTableReader->GetItem(j);
  821. std::string funcName(funcReader.GetUnmangledName());
  822. VERIFY_IS_TRUE(str.compare(funcName.substr(0,8)) == 0);
  823. std::string cur_str = str;
  824. cur_str.push_back('0' + j);
  825. if (cur_str.compare("function0") == 0) {
  826. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 1);
  827. hlsl::ShaderFlags flag;
  828. flag.SetUAVLoadAdditionalFormats(true);
  829. flag.SetLowPrecisionPresent(true);
  830. uint64_t rawFlag = flag.GetFeatureInfo();
  831. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag(), rawFlag);
  832. ResourceReader resReader = funcReader.GetResource(0);
  833. VERIFY_ARE_EQUAL(resReader.GetResourceClass(), hlsl::DXIL::ResourceClass::UAV);
  834. VERIFY_ARE_EQUAL(resReader.GetResourceKind(), hlsl::DXIL::ResourceKind::Texture1D);
  835. }
  836. else if (cur_str.compare("function1") == 0) {
  837. hlsl::ShaderFlags flag;
  838. flag.SetLowPrecisionPresent(true);
  839. uint64_t rawFlag = flag.GetFeatureInfo();
  840. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag(), rawFlag);
  841. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 3);
  842. }
  843. else if (cur_str.compare("function2") == 0) {
  844. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag() & 0xffffffffffffffff, 0);
  845. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), 0);
  846. std::string dependency = funcReader.GetDependency(0);
  847. VERIFY_IS_TRUE(dependency.find("function_import") != std::string::npos);
  848. }
  849. else if (cur_str.compare("function3") == 0) {
  850. VERIFY_ARE_EQUAL(funcReader.GetFeatureFlag() & 0xffffffffffffffff, 0);
  851. VERIFY_ARE_EQUAL(funcReader.GetNumResources(), numResFlagCheck);
  852. for (unsigned i = 0; i < funcReader.GetNumResources(); ++i) {
  853. ResourceReader resReader = funcReader.GetResource(0);
  854. VERIFY_ARE_EQUAL(resReader.GetResourceClass(), hlsl::DXIL::ResourceClass::UAV);
  855. unsigned j = 0;
  856. for (; j < numResFlagCheck; ++j) {
  857. if (resFlags[j].name.compare(resReader.GetName()) == 0)
  858. break;
  859. }
  860. VERIFY_IS_LESS_THAN(j, numResFlagCheck);
  861. VERIFY_ARE_EQUAL(resReader.GetResourceKind(), resFlags[j].kind);
  862. VERIFY_ARE_EQUAL(resReader.GetFlags(), static_cast<uint32_t>(resFlags[j].flag));
  863. }
  864. }
  865. else {
  866. IFTBOOLMSG(false, E_FAIL, "unknown function name");
  867. }
  868. }
  869. VERIFY_ARE_EQUAL(resTableReader->GetNumResources(), 8);
  870. // This is validation test for DxilRuntimeReflection implemented on DxilRuntimeReflection.inl
  871. unique_ptr<DxilRuntimeReflection> pReflection(CreateDxilRuntimeReflection());
  872. VERIFY_IS_TRUE(pReflection->InitFromRDAT(pBlob->GetBufferPointer(), pBlob->GetBufferSize()));
  873. DxilLibraryDesc lib_reflection = pReflection->GetLibraryReflection();
  874. VERIFY_ARE_EQUAL(lib_reflection.NumFunctions, 4);
  875. for (uint32_t j = 0; j < 3; ++j) {
  876. DxilFunctionDesc function = lib_reflection.pFunction[j];
  877. std::string cur_str = str;
  878. cur_str.push_back('0' + j);
  879. if (cur_str.compare("function0") == 0) {
  880. hlsl::ShaderFlags flag;
  881. flag.SetUAVLoadAdditionalFormats(true);
  882. flag.SetLowPrecisionPresent(true);
  883. uint64_t rawFlag = flag.GetFeatureInfo();
  884. uint64_t featureFlag = static_cast<uint64_t>(function.FeatureInfo2) << 32;
  885. featureFlag |= static_cast<uint64_t>(function.FeatureInfo1);
  886. VERIFY_ARE_EQUAL(featureFlag, rawFlag);
  887. VERIFY_ARE_EQUAL(function.NumResources, 1);
  888. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  889. const DxilResourceDesc &resource = *function.Resources[0];
  890. VERIFY_ARE_EQUAL(resource.Class, (uint32_t)hlsl::DXIL::ResourceClass::UAV);
  891. VERIFY_ARE_EQUAL(resource.Kind, (uint32_t)hlsl::DXIL::ResourceKind::Texture1D);
  892. std::wstring wName = resource.Name;
  893. VERIFY_ARE_EQUAL(wName.compare(L"tex"), 0);
  894. }
  895. else if (cur_str.compare("function1") == 0) {
  896. hlsl::ShaderFlags flag;
  897. flag.SetLowPrecisionPresent(true);
  898. uint64_t rawFlag = flag.GetFeatureInfo();
  899. uint64_t featureFlag = static_cast<uint64_t>(function.FeatureInfo2) << 32;
  900. featureFlag |= static_cast<uint64_t>(function.FeatureInfo1);
  901. VERIFY_ARE_EQUAL(featureFlag, rawFlag);
  902. VERIFY_ARE_EQUAL(function.NumResources, 3);
  903. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  904. std::unordered_set<std::wstring> stringSet = { L"$Globals", L"b_buf", L"tex2" };
  905. for (uint32_t j = 0; j < 3; ++j) {
  906. const DxilResourceDesc &resource = *function.Resources[j];
  907. std::wstring compareName = resource.Name;
  908. VERIFY_IS_TRUE(stringSet.find(compareName) != stringSet.end());
  909. }
  910. }
  911. else if (cur_str.compare("function2") == 0) {
  912. VERIFY_ARE_EQUAL(function.FeatureInfo1, 0);
  913. VERIFY_ARE_EQUAL(function.FeatureInfo2, 0);
  914. VERIFY_ARE_EQUAL(function.NumResources, 0);
  915. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 1);
  916. std::wstring dependency = function.FunctionDependencies[0];
  917. VERIFY_IS_TRUE(dependency.find(L"function_import") != std::wstring::npos);
  918. }
  919. else if (cur_str.compare("function3") == 0) {
  920. VERIFY_ARE_EQUAL(function.FeatureInfo1, 0);
  921. VERIFY_ARE_EQUAL(function.FeatureInfo2, 0);
  922. VERIFY_ARE_EQUAL(function.NumResources, numResFlagCheck);
  923. VERIFY_ARE_EQUAL(function.NumFunctionDependencies, 0);
  924. for (unsigned i = 0; i < function.NumResources; ++i) {
  925. const DxilResourceDesc *res = function.Resources[i];
  926. VERIFY_ARE_EQUAL(res->Class, static_cast<uint32_t>(hlsl::DXIL::ResourceClass::UAV));
  927. unsigned j = 0;
  928. for (; j < numResFlagCheck; ++j) {
  929. CA2W WName(resFlags[j].name.c_str());
  930. std::wstring compareName(WName);
  931. if (compareName.compare(res->Name) == 0)
  932. break;
  933. }
  934. VERIFY_IS_LESS_THAN(j, numResFlagCheck);
  935. VERIFY_ARE_EQUAL(res->Kind, static_cast<uint32_t>(resFlags[j].kind));
  936. VERIFY_ARE_EQUAL(res->Flags, static_cast<uint32_t>(resFlags[j].flag));
  937. }
  938. }
  939. else {
  940. IFTBOOLMSG(false, E_FAIL, "unknown function name");
  941. }
  942. }
  943. VERIFY_IS_TRUE(lib_reflection.NumResources == 8);
  944. }
  945. }
  946. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  947. }
  948. TEST_F(DxilContainerTest, CompileWhenOkThenCheckRDAT2) {
  949. if (m_ver.SkipDxilVersion(1, 3)) return;
  950. // This is a case when the user of resource is a constant, not instruction.
  951. // Compiler generates the following load instruction for texture.
  952. // load %class.Texture2D, %class.Texture2D* getelementptr inbounds ([3 x
  953. // %class.Texture2D], [3 x %class.Texture2D]*
  954. // @"\01?ThreeTextures@@3PAV?$Texture2D@M@@A", i32 0, i32 0), align 4
  955. const char *shader =
  956. "SamplerState Sampler : register(s0); RWBuffer<float> Uav : "
  957. "register(u0); Texture2D<float> ThreeTextures[3] : register(t0); "
  958. "float function1();"
  959. "[shader(\"raygeneration\")] void RayGenMain() { Uav[0] = "
  960. "ThreeTextures[0].SampleLevel(Sampler, float2(0, 0), 0) + "
  961. "ThreeTextures[2].SampleLevel(Sampler, float2(0, 0), 0) + function1(); }";
  962. CComPtr<IDxcCompiler> pCompiler;
  963. CComPtr<IDxcBlobEncoding> pSource;
  964. CComPtr<IDxcBlob> pProgram;
  965. CComPtr<IDxcBlobEncoding> pDisassembly;
  966. CComPtr<IDxcOperationResult> pResult;
  967. HRESULT status;
  968. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  969. CreateBlobFromText(shader, &pSource);
  970. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main",
  971. L"lib_6_3", nullptr, 0, nullptr, 0,
  972. nullptr, &pResult));
  973. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  974. VERIFY_SUCCEEDED(pResult->GetStatus(&status));
  975. VERIFY_SUCCEEDED(status);
  976. CComPtr<IDxcContainerReflection> pReflection;
  977. uint32_t partCount;
  978. IFT(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection));
  979. IFT(pReflection->Load(pProgram));
  980. IFT(pReflection->GetPartCount(&partCount));
  981. bool blobFound = false;
  982. for (uint32_t i = 0; i < partCount; ++i) {
  983. uint32_t kind;
  984. IFT(pReflection->GetPartKind(i, &kind));
  985. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_RuntimeData) {
  986. blobFound = true;
  987. using namespace hlsl::RDAT;
  988. CComPtr<IDxcBlob> pBlob;
  989. IFT(pReflection->GetPartContent(i, &pBlob));
  990. DxilRuntimeData context;
  991. context.InitFromRDAT((char *)pBlob->GetBufferPointer(), pBlob->GetBufferSize());
  992. FunctionTableReader *funcTableReader = context.GetFunctionTableReader();
  993. ResourceTableReader *resTableReader = context.GetResourceTableReader();
  994. VERIFY_IS_TRUE(funcTableReader->GetNumFunctions() == 1);
  995. VERIFY_IS_TRUE(resTableReader->GetNumResources() == 3);
  996. FunctionReader funcReader = funcTableReader->GetItem(0);
  997. llvm::StringRef name(funcReader.GetUnmangledName());
  998. VERIFY_IS_TRUE(name.compare("RayGenMain") == 0);
  999. VERIFY_IS_TRUE(funcReader.GetShaderKind() ==
  1000. hlsl::DXIL::ShaderKind::RayGeneration);
  1001. VERIFY_IS_TRUE(funcReader.GetNumResources() == 3);
  1002. VERIFY_IS_TRUE(funcReader.GetNumDependencies() == 1);
  1003. llvm::StringRef dependencyName =
  1004. hlsl::dxilutil::DemangleFunctionName(funcReader.GetDependency(0));
  1005. VERIFY_IS_TRUE(dependencyName.compare("function1") == 0);
  1006. }
  1007. }
  1008. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  1009. }
  1010. static uint32_t EncodedVersion_lib_6_3 = hlsl::EncodeVersion(hlsl::DXIL::ShaderKind::Library, 6, 3);
  1011. static uint32_t EncodedVersion_vs_6_3 = hlsl::EncodeVersion(hlsl::DXIL::ShaderKind::Vertex, 6, 3);
  1012. static void Ref1_CheckCBuffer_Globals(ID3D12ShaderReflectionConstantBuffer *pCBReflection, D3D12_SHADER_BUFFER_DESC &cbDesc) {
  1013. std::string cbName = cbDesc.Name;
  1014. VERIFY_IS_TRUE(cbName.compare("$Globals") == 0);
  1015. VERIFY_ARE_EQUAL(cbDesc.Size, 16);
  1016. VERIFY_ARE_EQUAL(cbDesc.Type, D3D_CT_CBUFFER);
  1017. VERIFY_ARE_EQUAL(cbDesc.Variables, 1);
  1018. // cbval1
  1019. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(0);
  1020. D3D12_SHADER_VARIABLE_DESC varDesc;
  1021. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1022. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval1");
  1023. VERIFY_ARE_EQUAL(varDesc.StartOffset, 0);
  1024. VERIFY_ARE_EQUAL(varDesc.Size, 4);
  1025. // TODO: verify rest of variable
  1026. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1027. D3D12_SHADER_TYPE_DESC tyDesc;
  1028. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1029. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_SCALAR);
  1030. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_FLOAT);
  1031. // TODO: verify rest of type
  1032. }
  1033. static void Ref1_CheckCBuffer_MyCB(ID3D12ShaderReflectionConstantBuffer *pCBReflection, D3D12_SHADER_BUFFER_DESC &cbDesc) {
  1034. std::string cbName = cbDesc.Name;
  1035. VERIFY_IS_TRUE(cbName.compare("MyCB") == 0);
  1036. VERIFY_ARE_EQUAL(cbDesc.Size, 32);
  1037. VERIFY_ARE_EQUAL(cbDesc.Type, D3D_CT_CBUFFER);
  1038. VERIFY_ARE_EQUAL(cbDesc.Variables, 2);
  1039. // cbval2
  1040. {
  1041. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(0);
  1042. D3D12_SHADER_VARIABLE_DESC varDesc;
  1043. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1044. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval2");
  1045. VERIFY_ARE_EQUAL(varDesc.StartOffset, 0);
  1046. VERIFY_ARE_EQUAL(varDesc.Size, 16);
  1047. // TODO: verify rest of variable
  1048. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1049. D3D12_SHADER_TYPE_DESC tyDesc;
  1050. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1051. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_VECTOR);
  1052. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_INT);
  1053. // TODO: verify rest of type
  1054. }
  1055. // cbval3
  1056. {
  1057. ID3D12ShaderReflectionVariable *pVar = pCBReflection->GetVariableByIndex(1);
  1058. D3D12_SHADER_VARIABLE_DESC varDesc;
  1059. VERIFY_SUCCEEDED(pVar->GetDesc(&varDesc));
  1060. VERIFY_ARE_EQUAL_STR(varDesc.Name, "cbval3");
  1061. VERIFY_ARE_EQUAL(varDesc.StartOffset, 16);
  1062. VERIFY_ARE_EQUAL(varDesc.Size, 16);
  1063. // TODO: verify rest of variable
  1064. ID3D12ShaderReflectionType *pType = pVar->GetType();
  1065. D3D12_SHADER_TYPE_DESC tyDesc;
  1066. VERIFY_SUCCEEDED(pType->GetDesc(&tyDesc));
  1067. VERIFY_ARE_EQUAL(tyDesc.Class, D3D_SVC_VECTOR);
  1068. VERIFY_ARE_EQUAL(tyDesc.Type, D3D_SVT_INT);
  1069. // TODO: verify rest of type
  1070. }
  1071. }
  1072. static void Ref1_CheckBinding_Globals(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1073. std::string resName = resDesc.Name;
  1074. VERIFY_IS_TRUE(resName.compare("$Globals") == 0);
  1075. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_CBUFFER);
  1076. // not explicitly bound:
  1077. VERIFY_ARE_EQUAL(resDesc.BindPoint, 4294967295);
  1078. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1079. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1080. }
  1081. static void Ref1_CheckBinding_MyCB(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1082. std::string resName = resDesc.Name;
  1083. VERIFY_IS_TRUE(resName.compare("MyCB") == 0);
  1084. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_CBUFFER);
  1085. VERIFY_ARE_EQUAL(resDesc.BindPoint, 11);
  1086. VERIFY_ARE_EQUAL(resDesc.Space, 2);
  1087. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1088. }
  1089. static void Ref1_CheckBinding_tex(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1090. std::string resName = resDesc.Name;
  1091. VERIFY_IS_TRUE(resName.compare("tex") == 0);
  1092. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_UAV_RWTYPED);
  1093. VERIFY_ARE_EQUAL(resDesc.BindPoint, 5);
  1094. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1095. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1096. }
  1097. static void Ref1_CheckBinding_tex2(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1098. std::string resName = resDesc.Name;
  1099. VERIFY_IS_TRUE(resName.compare("tex2") == 0);
  1100. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_TEXTURE);
  1101. VERIFY_ARE_EQUAL(resDesc.BindPoint, 0);
  1102. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1103. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1104. }
  1105. static void Ref1_CheckBinding_samp(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1106. std::string resName = resDesc.Name;
  1107. VERIFY_IS_TRUE(resName.compare("samp") == 0);
  1108. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_SAMPLER);
  1109. VERIFY_ARE_EQUAL(resDesc.BindPoint, 7);
  1110. VERIFY_ARE_EQUAL(resDesc.Space, 0);
  1111. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1112. }
  1113. static void Ref1_CheckBinding_b_buf(D3D12_SHADER_INPUT_BIND_DESC &resDesc) {
  1114. std::string resName = resDesc.Name;
  1115. VERIFY_IS_TRUE(resName.compare("b_buf") == 0);
  1116. VERIFY_ARE_EQUAL(resDesc.Type, D3D_SIT_UAV_RWBYTEADDRESS);
  1117. // not explicitly bound:
  1118. VERIFY_ARE_EQUAL(resDesc.BindPoint, 4294967295);
  1119. VERIFY_ARE_EQUAL(resDesc.Space, 4294967295);
  1120. VERIFY_ARE_EQUAL(resDesc.BindCount, 1);
  1121. }
  1122. const char *Ref1_Shader =
  1123. "float cbval1;"
  1124. "cbuffer MyCB : register(b11, space2) { int4 cbval2, cbval3; }"
  1125. "RWTexture1D<int4> tex : register(u5);"
  1126. "Texture1D<float4> tex2 : register(t0);"
  1127. "SamplerState samp : register(s7);"
  1128. "RWByteAddressBuffer b_buf;"
  1129. "export float function0(min16float x) { "
  1130. " return x + cbval2.x + tex[0].x; }"
  1131. "export float function1(float x, min12int i) {"
  1132. " return x + cbval1 + b_buf.Load(x) + tex2.Sample(samp, x).x; }"
  1133. "[shader(\"vertex\")]"
  1134. "float4 function2(float4 x : POSITION) : SV_Position { return x + cbval1 + cbval3.x; }";
  1135. TEST_F(DxilContainerTest, CompileWhenOkThenCheckReflection1) {
  1136. if (m_ver.SkipDxilVersion(1, 3)) return;
  1137. CComPtr<IDxcCompiler> pCompiler;
  1138. CComPtr<IDxcBlobEncoding> pSource;
  1139. CComPtr<IDxcBlob> pProgram;
  1140. CComPtr<IDxcBlobEncoding> pDisassembly;
  1141. CComPtr<IDxcOperationResult> pResult;
  1142. CComPtr<ID3D12LibraryReflection> pLibraryReflection;
  1143. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1144. CreateBlobFromText(Ref1_Shader, &pSource);
  1145. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1146. L"lib_6_3", nullptr, 0, nullptr, 0,
  1147. nullptr, &pResult));
  1148. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1149. CComPtr<IDxcContainerReflection> containerReflection;
  1150. uint32_t partCount;
  1151. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &containerReflection));
  1152. VERIFY_SUCCEEDED(containerReflection->Load(pProgram));
  1153. VERIFY_SUCCEEDED(containerReflection->GetPartCount(&partCount));
  1154. bool blobFound = false;
  1155. for (uint32_t i = 0; i < partCount; ++i) {
  1156. uint32_t kind;
  1157. VERIFY_SUCCEEDED(containerReflection->GetPartKind(i, &kind));
  1158. if (kind == (uint32_t)hlsl::DxilFourCC::DFCC_DXIL) {
  1159. blobFound = true;
  1160. VERIFY_SUCCEEDED(containerReflection->GetPartReflection(i, IID_PPV_ARGS(&pLibraryReflection)));
  1161. D3D12_LIBRARY_DESC LibDesc;
  1162. VERIFY_SUCCEEDED(pLibraryReflection->GetDesc(&LibDesc));
  1163. VERIFY_ARE_EQUAL(LibDesc.FunctionCount, 3);
  1164. for (INT iFn = 0; iFn < (INT)LibDesc.FunctionCount; iFn++) {
  1165. ID3D12FunctionReflection *pFunctionReflection = pLibraryReflection->GetFunctionByIndex(iFn);
  1166. D3D12_FUNCTION_DESC FnDesc;
  1167. pFunctionReflection->GetDesc(&FnDesc);
  1168. std::string Name = FnDesc.Name;
  1169. if (Name.compare("\01?function0@@YAM$min16f@@Z") == 0) {
  1170. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_lib_6_3);
  1171. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 1);
  1172. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 2);
  1173. D3D12_SHADER_BUFFER_DESC cbDesc;
  1174. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1175. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1176. std::string cbName = cbDesc.Name;
  1177. (void)(cbName);
  1178. Ref1_CheckCBuffer_MyCB(pCBReflection, cbDesc);
  1179. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1180. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1181. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1182. std::string resName = resDesc.Name;
  1183. if (resName.compare("$Globals") == 0) {
  1184. Ref1_CheckBinding_Globals(resDesc);
  1185. } else if (resName.compare("MyCB") == 0) {
  1186. Ref1_CheckBinding_MyCB(resDesc);
  1187. } else if (resName.compare("samp") == 0) {
  1188. Ref1_CheckBinding_samp(resDesc);
  1189. } else if (resName.compare("tex") == 0) {
  1190. Ref1_CheckBinding_tex(resDesc);
  1191. } else if (resName.compare("tex2") == 0) {
  1192. Ref1_CheckBinding_tex2(resDesc);
  1193. } else if (resName.compare("b_buf") == 0) {
  1194. Ref1_CheckBinding_b_buf(resDesc);
  1195. } else {
  1196. VERIFY_FAIL(L"Unexpected resource used");
  1197. }
  1198. }
  1199. } else if (Name.compare("\01?function1@@YAMM$min12i@@Z") == 0) {
  1200. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_lib_6_3);
  1201. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 1);
  1202. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 4);
  1203. D3D12_SHADER_BUFFER_DESC cbDesc;
  1204. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1205. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1206. std::string cbName = cbDesc.Name;
  1207. (void)(cbName);
  1208. Ref1_CheckCBuffer_Globals(pCBReflection, cbDesc);
  1209. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1210. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1211. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1212. std::string resName = resDesc.Name;
  1213. if (resName.compare("$Globals") == 0) {
  1214. Ref1_CheckBinding_Globals(resDesc);
  1215. } else if (resName.compare("MyCB") == 0) {
  1216. Ref1_CheckBinding_MyCB(resDesc);
  1217. } else if (resName.compare("samp") == 0) {
  1218. Ref1_CheckBinding_samp(resDesc);
  1219. } else if (resName.compare("tex") == 0) {
  1220. Ref1_CheckBinding_tex(resDesc);
  1221. } else if (resName.compare("tex2") == 0) {
  1222. Ref1_CheckBinding_tex2(resDesc);
  1223. } else if (resName.compare("b_buf") == 0) {
  1224. Ref1_CheckBinding_b_buf(resDesc);
  1225. } else {
  1226. VERIFY_FAIL(L"Unexpected resource used");
  1227. }
  1228. }
  1229. } else if (Name.compare("function2") == 0) {
  1230. // shader function with unmangled name
  1231. VERIFY_ARE_EQUAL(FnDesc.Version, EncodedVersion_vs_6_3);
  1232. VERIFY_ARE_EQUAL(FnDesc.ConstantBuffers, 2);
  1233. VERIFY_ARE_EQUAL(FnDesc.BoundResources, 2);
  1234. for (INT iCB = 0; iCB < (INT)FnDesc.BoundResources; iCB++) {
  1235. D3D12_SHADER_BUFFER_DESC cbDesc;
  1236. ID3D12ShaderReflectionConstantBuffer *pCBReflection = pFunctionReflection->GetConstantBufferByIndex(0);
  1237. VERIFY_SUCCEEDED(pCBReflection->GetDesc(&cbDesc));
  1238. std::string cbName = cbDesc.Name;
  1239. if (cbName.compare("$Globals") == 0) {
  1240. Ref1_CheckCBuffer_Globals(pCBReflection, cbDesc);
  1241. } else if (cbName.compare("MyCB") == 0) {
  1242. Ref1_CheckCBuffer_MyCB(pCBReflection, cbDesc);
  1243. }
  1244. }
  1245. for (INT iRes = 0; iRes < (INT)FnDesc.BoundResources; iRes++) {
  1246. D3D12_SHADER_INPUT_BIND_DESC resDesc;
  1247. pFunctionReflection->GetResourceBindingDesc(iRes, &resDesc);
  1248. std::string resName = resDesc.Name;
  1249. if (resName.compare("$Globals") == 0) {
  1250. Ref1_CheckBinding_Globals(resDesc);
  1251. } else if (resName.compare("MyCB") == 0) {
  1252. Ref1_CheckBinding_MyCB(resDesc);
  1253. } else {
  1254. VERIFY_FAIL(L"Unexpected resource used");
  1255. }
  1256. }
  1257. } else {
  1258. VERIFY_FAIL(L"Unexpected function");
  1259. }
  1260. }
  1261. // TODO: FINISH THIS
  1262. }
  1263. }
  1264. IFTBOOLMSG(blobFound, E_FAIL, "failed to find RDAT blob after compiling");
  1265. }
  1266. TEST_F(DxilContainerTest, DxcUtils_CreateReflection) {
  1267. // Reflection stripping fails on DXIL.dll ver. < 1.5
  1268. if (m_ver.SkipDxilVersion(1, 5)) return;
  1269. CComPtr<IDxcUtils> pUtils;
  1270. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcUtils, &pUtils));
  1271. CComPtr<IDxcCompiler> pCompiler;
  1272. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1273. CComPtr<IDxcBlobEncoding> pSource;
  1274. CreateBlobFromText(Ref1_Shader, &pSource);
  1275. LPCWSTR options[] = {
  1276. L"-Qstrip_reflect_from_dxil",
  1277. L"-Qstrip_reflect"
  1278. };
  1279. const UINT32 kStripFromDxilOnly = 1; // just strip reflection from DXIL, not container
  1280. const UINT32 kStripFromContainer = 2; // strip reflection from DXIL and container
  1281. auto VerifyStripReflection = [&](IDxcBlob *pBlob, bool bShouldSucceed) {
  1282. CComPtr<IDxcContainerReflection> pReflection;
  1283. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection));
  1284. VERIFY_SUCCEEDED(pReflection->Load(pBlob));
  1285. UINT32 idxPart = (UINT32)-1;
  1286. if (bShouldSucceed)
  1287. VERIFY_SUCCEEDED(pReflection->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1288. else
  1289. VERIFY_FAILED(pReflection->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1290. CComPtr<IDxcContainerBuilder> pBuilder;
  1291. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerBuilder, &pBuilder));
  1292. VERIFY_SUCCEEDED(pBuilder->Load(pBlob));
  1293. if (bShouldSucceed) {
  1294. VERIFY_SUCCEEDED(pBuilder->RemovePart(DXC_PART_REFLECTION_DATA));
  1295. CComPtr<IDxcOperationResult> pResult;
  1296. VERIFY_SUCCEEDED(pBuilder->SerializeContainer(&pResult));
  1297. HRESULT hr = E_FAIL;
  1298. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1299. VERIFY_SUCCEEDED(hr);
  1300. CComPtr<IDxcBlob> pStrippedBlob;
  1301. pResult->GetResult(&pStrippedBlob);
  1302. CComPtr<IDxcContainerReflection> pReflection2;
  1303. VERIFY_SUCCEEDED(m_dllSupport.CreateInstance(CLSID_DxcContainerReflection, &pReflection2));
  1304. VERIFY_SUCCEEDED(pReflection2->Load(pStrippedBlob));
  1305. idxPart = (UINT32)-1;
  1306. VERIFY_FAILED(pReflection2->FindFirstPartKind(DXC_PART_REFLECTION_DATA, &idxPart));
  1307. } else {
  1308. VERIFY_FAILED(pBuilder->RemovePart(DXC_PART_REFLECTION_DATA));
  1309. }
  1310. };
  1311. {
  1312. // Test Shader path
  1313. auto VerifyCreateReflectionShader = [&](IDxcBlob *pBlob, bool bValid)
  1314. {
  1315. DxcBuffer buffer = { pBlob->GetBufferPointer(), pBlob->GetBufferSize(), 0 };
  1316. CComPtr<ID3D12ShaderReflection> pShaderReflection;
  1317. VERIFY_SUCCEEDED(pUtils->CreateReflection(&buffer, IID_PPV_ARGS(&pShaderReflection)));
  1318. D3D12_SHADER_DESC desc;
  1319. VERIFY_SUCCEEDED(pShaderReflection->GetDesc(&desc));
  1320. VERIFY_ARE_EQUAL(desc.Version, EncodedVersion_vs_6_3);
  1321. if (bValid) {
  1322. VERIFY_ARE_EQUAL(desc.ConstantBuffers, 2);
  1323. VERIFY_ARE_EQUAL(desc.BoundResources, 2);
  1324. // That should be good enough to check that IDxcUtils::CreateReflection worked
  1325. }
  1326. };
  1327. {
  1328. // Test Full container path
  1329. CComPtr<IDxcOperationResult> pResult;
  1330. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"function2",
  1331. L"vs_6_3", options, kStripFromDxilOnly,
  1332. nullptr, 0, nullptr, &pResult));
  1333. HRESULT hr;
  1334. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1335. VERIFY_SUCCEEDED(hr);
  1336. CComPtr<IDxcBlob> pProgram;
  1337. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1338. VerifyCreateReflectionShader(pProgram, true);
  1339. // Verify reflection stripping
  1340. VerifyStripReflection(pProgram, true);
  1341. }
  1342. {
  1343. // From New IDxcResult API
  1344. CComPtr<IDxcOperationResult> pResult;
  1345. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"function2",
  1346. L"vs_6_3", options, kStripFromContainer,
  1347. nullptr, 0, nullptr, &pResult));
  1348. HRESULT hr;
  1349. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1350. VERIFY_SUCCEEDED(hr);
  1351. // Test separate reflection result path
  1352. CComPtr<IDxcResult> pResultV2;
  1353. CComPtr<IDxcBlob> pReflectionPart;
  1354. VERIFY_SUCCEEDED(pResult->QueryInterface(&pResultV2));
  1355. VERIFY_SUCCEEDED(pResultV2->GetOutput(DXC_OUT_REFLECTION, IID_PPV_ARGS(&pReflectionPart), nullptr));
  1356. VerifyCreateReflectionShader(pReflectionPart, true);
  1357. // Container should have limited reflection, and no reflection part
  1358. CComPtr<IDxcBlob> pProgram;
  1359. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1360. VerifyCreateReflectionShader(pProgram, false);
  1361. VerifyStripReflection(pProgram, false);
  1362. }
  1363. }
  1364. {
  1365. // Test Library path
  1366. auto VerifyCreateReflectionLibrary = [&](IDxcBlob *pBlob, bool bValid)
  1367. {
  1368. DxcBuffer buffer = { pBlob->GetBufferPointer(), pBlob->GetBufferSize(), 0 };
  1369. CComPtr<ID3D12LibraryReflection> pLibraryReflection;
  1370. VERIFY_SUCCEEDED(pUtils->CreateReflection(&buffer, IID_PPV_ARGS(&pLibraryReflection)));
  1371. D3D12_LIBRARY_DESC desc;
  1372. VERIFY_SUCCEEDED(pLibraryReflection->GetDesc(&desc));
  1373. if (bValid) {
  1374. VERIFY_ARE_EQUAL(desc.FunctionCount, 3);
  1375. // That should be good enough to check that IDxcUtils::CreateReflection worked
  1376. }
  1377. };
  1378. {
  1379. // Test Full container path
  1380. CComPtr<IDxcOperationResult> pResult;
  1381. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1382. L"lib_6_3", options, kStripFromDxilOnly,
  1383. nullptr, 0, nullptr, &pResult));
  1384. HRESULT hr;
  1385. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1386. VERIFY_SUCCEEDED(hr);
  1387. CComPtr<IDxcBlob> pProgram;
  1388. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1389. VerifyCreateReflectionLibrary(pProgram, true);
  1390. // Verify reflection stripping
  1391. VerifyStripReflection(pProgram, true);
  1392. }
  1393. {
  1394. // From New IDxcResult API
  1395. CComPtr<IDxcOperationResult> pResult;
  1396. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"",
  1397. L"lib_6_3", options, kStripFromContainer,
  1398. nullptr, 0, nullptr, &pResult));
  1399. HRESULT hr;
  1400. VERIFY_SUCCEEDED(pResult->GetStatus(&hr));
  1401. VERIFY_SUCCEEDED(hr);
  1402. // Test separate reflection result path
  1403. CComPtr<IDxcResult> pResultV2;
  1404. CComPtr<IDxcBlob> pReflectionPart;
  1405. VERIFY_SUCCEEDED(pResult->QueryInterface(&pResultV2));
  1406. VERIFY_SUCCEEDED(pResultV2->GetOutput(DXC_OUT_REFLECTION, IID_PPV_ARGS(&pReflectionPart), nullptr));
  1407. // Test Reflection part path
  1408. VerifyCreateReflectionLibrary(pReflectionPart, true);
  1409. // Container should have limited reflection, and no reflection part
  1410. CComPtr<IDxcBlob> pProgram;
  1411. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1412. VerifyCreateReflectionLibrary(pProgram, false);
  1413. VerifyStripReflection(pProgram, false);
  1414. }
  1415. }
  1416. }
  1417. TEST_F(DxilContainerTest, CompileWhenOKThenIncludesFeatureInfo) {
  1418. CComPtr<IDxcCompiler> pCompiler;
  1419. CComPtr<IDxcBlobEncoding> pSource;
  1420. CComPtr<IDxcBlob> pProgram;
  1421. CComPtr<IDxcBlobEncoding> pDisassembly;
  1422. CComPtr<IDxcOperationResult> pResult;
  1423. hlsl::DxilContainerHeader *pHeader;
  1424. hlsl::DxilPartIterator pPartIter(nullptr, 0);
  1425. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1426. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1427. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1428. nullptr, 0, nullptr, 0, nullptr,
  1429. &pResult));
  1430. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1431. // Now mess with the program bitcode.
  1432. pHeader = (hlsl::DxilContainerHeader *)pProgram->GetBufferPointer();
  1433. pPartIter = std::find_if(hlsl::begin(pHeader), hlsl::end(pHeader),
  1434. hlsl::DxilPartIsType(hlsl::DFCC_FeatureInfo));
  1435. VERIFY_ARE_NOT_EQUAL(hlsl::end(pHeader), pPartIter);
  1436. VERIFY_ARE_EQUAL(sizeof(uint64_t), (*pPartIter)->PartSize);
  1437. VERIFY_ARE_EQUAL(0U, *(const uint64_t *)hlsl::GetDxilPartData(*pPartIter));
  1438. }
  1439. TEST_F(DxilContainerTest, DisassemblyWhenBCInvalidThenFails) {
  1440. CComPtr<IDxcCompiler> pCompiler;
  1441. CComPtr<IDxcBlobEncoding> pSource;
  1442. CComPtr<IDxcBlob> pProgram;
  1443. CComPtr<IDxcBlobEncoding> pDisassembly;
  1444. CComPtr<IDxcOperationResult> pResult;
  1445. hlsl::DxilContainerHeader *pHeader;
  1446. hlsl::DxilPartHeader *pPart;
  1447. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1448. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1449. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1450. nullptr, 0, nullptr, 0, nullptr,
  1451. &pResult));
  1452. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1453. // Now mess with the program bitcode.
  1454. pHeader = (hlsl::DxilContainerHeader *)pProgram->GetBufferPointer();
  1455. pPart = const_cast<hlsl::DxilPartHeader *>(
  1456. *std::find_if(hlsl::begin(pHeader), hlsl::end(pHeader),
  1457. hlsl::DxilPartIsType(hlsl::DFCC_DXIL)));
  1458. strcpy_s(hlsl::GetDxilPartData(pPart), pPart->PartSize, "corruption");
  1459. VERIFY_FAILED(pCompiler->Disassemble(pProgram, &pDisassembly));
  1460. }
  1461. TEST_F(DxilContainerTest, DisassemblyWhenMissingThenFails) {
  1462. CComPtr<IDxcCompiler> pCompiler;
  1463. CComPtr<IDxcBlobEncoding> pSource;
  1464. CComPtr<IDxcBlobEncoding> pDisassembly;
  1465. hlsl::DxilContainerHeader header;
  1466. SetupBasicHeader(&header);
  1467. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1468. CreateBlobPinned(&header, header.ContainerSizeInBytes, 0, &pSource);
  1469. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1470. }
  1471. TEST_F(DxilContainerTest, DisassemblyWhenInvalidThenFails) {
  1472. CComPtr<IDxcCompiler> pCompiler;
  1473. CComPtr<IDxcBlobEncoding> pDisassembly;
  1474. uint8_t scratch[1024];
  1475. hlsl::DxilContainerHeader *pHeader = (hlsl::DxilContainerHeader *)scratch;
  1476. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1477. // Too small to contain header.
  1478. {
  1479. CComPtr<IDxcBlobEncoding> pSource;
  1480. SetupBasicHeader(pHeader);
  1481. CreateBlobPinned(pHeader, sizeof(hlsl::DxilContainerHeader) - 4, 0,
  1482. &pSource);
  1483. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1484. }
  1485. // Wrong major version.
  1486. {
  1487. CComPtr<IDxcBlobEncoding> pSource;
  1488. SetupBasicHeader(pHeader);
  1489. pHeader->Version.Major = 100;
  1490. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1491. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1492. }
  1493. // Size out of bounds.
  1494. {
  1495. CComPtr<IDxcBlobEncoding> pSource;
  1496. SetupBasicHeader(pHeader);
  1497. pHeader->ContainerSizeInBytes = 1024;
  1498. CreateBlobPinned(pHeader, sizeof(hlsl::DxilContainerHeader), 0,
  1499. &pSource);
  1500. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1501. }
  1502. // Size too large as per spec limit.
  1503. {
  1504. CComPtr<IDxcBlobEncoding> pSource;
  1505. SetupBasicHeader(pHeader);
  1506. pHeader->ContainerSizeInBytes = hlsl::DxilContainerMaxSize + 1;
  1507. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1508. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1509. }
  1510. // Not large enough to hold offset table.
  1511. {
  1512. CComPtr<IDxcBlobEncoding> pSource;
  1513. SetupBasicHeader(pHeader);
  1514. pHeader->PartCount = 1;
  1515. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1516. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1517. }
  1518. // Part offset out of bounds.
  1519. {
  1520. CComPtr<IDxcBlobEncoding> pSource;
  1521. SetupBasicHeader(pHeader);
  1522. pHeader->PartCount = 1;
  1523. *((uint32_t *)(pHeader + 1)) = 1024;
  1524. pHeader->ContainerSizeInBytes += sizeof(uint32_t);
  1525. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1526. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1527. }
  1528. // Part size out of bounds.
  1529. {
  1530. CComPtr<IDxcBlobEncoding> pSource;
  1531. SetupBasicHeader(pHeader);
  1532. pHeader->PartCount = 1;
  1533. *((uint32_t *)(pHeader + 1)) = sizeof(*pHeader) + sizeof(uint32_t);
  1534. pHeader->ContainerSizeInBytes += sizeof(uint32_t);
  1535. hlsl::GetDxilContainerPart(pHeader, 0)->PartSize = 1024;
  1536. pHeader->ContainerSizeInBytes += sizeof(hlsl::DxilPartHeader);
  1537. CreateBlobPinned(pHeader, pHeader->ContainerSizeInBytes, 0, &pSource);
  1538. VERIFY_FAILED(pCompiler->Disassemble(pSource, &pDisassembly));
  1539. }
  1540. }
  1541. TEST_F(DxilContainerTest, DisassemblyWhenValidThenOK) {
  1542. CComPtr<IDxcCompiler> pCompiler;
  1543. CComPtr<IDxcBlobEncoding> pSource;
  1544. CComPtr<IDxcBlob> pProgram;
  1545. CComPtr<IDxcBlobEncoding> pDisassembly;
  1546. CComPtr<IDxcOperationResult> pResult;
  1547. hlsl::DxilContainerHeader header;
  1548. SetupBasicHeader(&header);
  1549. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1550. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1551. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0",
  1552. nullptr, 0, nullptr, 0, nullptr,
  1553. &pResult));
  1554. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1555. VERIFY_SUCCEEDED(pCompiler->Disassemble(pProgram, &pDisassembly));
  1556. std::string disassembleString(BlobToUtf8(pDisassembly));
  1557. VERIFY_ARE_NOT_EQUAL(0U, disassembleString.size());
  1558. }
  1559. class HlslFileVariables {
  1560. private:
  1561. std::wstring m_Entry;
  1562. std::wstring m_Mode;
  1563. std::wstring m_Target;
  1564. std::vector<std::wstring> m_Arguments;
  1565. std::vector<LPCWSTR> m_ArgumentPtrs;
  1566. public:
  1567. HlslFileVariables(HlslFileVariables &other) = delete;
  1568. const LPCWSTR *GetArguments() const { return m_ArgumentPtrs.data(); }
  1569. UINT32 GetArgumentCount() const { return m_ArgumentPtrs.size(); }
  1570. LPCWSTR GetEntry() const { return m_Entry.c_str(); }
  1571. LPCWSTR GetMode() const { return m_Mode.c_str(); }
  1572. LPCWSTR GetTarget() const { return m_Target.c_str(); }
  1573. void Reset();
  1574. HRESULT SetFromText(_In_count_(len) const char *pText, size_t len);
  1575. };
  1576. void HlslFileVariables::Reset() {
  1577. m_Entry.resize(0);
  1578. m_Mode.resize(0);
  1579. m_Target.resize(0);
  1580. m_Arguments.resize(0);
  1581. m_ArgumentPtrs.resize(0);
  1582. }
  1583. #include <codecvt>
  1584. static bool wcsneq(const wchar_t *pValue, const wchar_t *pCheck) {
  1585. return 0 == wcsncmp(pValue, pCheck, wcslen(pCheck));
  1586. }
  1587. HRESULT HlslFileVariables::SetFromText(_In_count_(len) const char *pText, size_t len) {
  1588. // Look for the line of interest.
  1589. const char *pEnd = pText + len;
  1590. const char *pLineEnd = pText;
  1591. while (pLineEnd < pEnd && *pLineEnd != '\n') pLineEnd++;
  1592. // Create a UTF-16-backing store.
  1593. std::wstring_convert<std::codecvt_utf8_utf16<wchar_t> > w;
  1594. std::wstring line = w.from_bytes(pText, pLineEnd);
  1595. // Find starting and ending '-*-' delimiters.
  1596. const wchar_t *pWText = line.c_str();
  1597. const wchar_t *pVarStart = wcsstr(pWText, L"-*-");
  1598. if (!pVarStart) return E_INVALIDARG;
  1599. pVarStart += 3;
  1600. const wchar_t *pVarEnd = wcsstr(pVarStart, L"-*-");
  1601. if (!pVarEnd) return E_INVALIDARG;
  1602. for (;;) {
  1603. // Find 'name' ':' 'value' ';'
  1604. const wchar_t *pVarNameStart = pVarStart;
  1605. while (pVarNameStart < pVarEnd && L' ' == *pVarNameStart) ++pVarNameStart;
  1606. if (pVarNameStart == pVarEnd) break;
  1607. const wchar_t *pVarValDelim = pVarNameStart;
  1608. while (pVarValDelim < pVarEnd && L':' != *pVarValDelim) ++pVarValDelim;
  1609. if (pVarValDelim == pVarEnd) break;
  1610. const wchar_t *pVarValStart = pVarValDelim + 1;
  1611. while (pVarValStart < pVarEnd && L' ' == *pVarValStart) ++pVarValStart;
  1612. if (pVarValStart == pVarEnd) break;
  1613. const wchar_t *pVarValEnd = pVarValStart;
  1614. while (pVarValEnd < pVarEnd && L';' != *pVarValEnd) ++pVarValEnd;
  1615. if (wcsneq(pVarNameStart, L"mode")) {
  1616. m_Mode.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1617. }
  1618. else if (wcsneq(pVarNameStart, L"hlsl-entry")) {
  1619. m_Entry.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1620. }
  1621. else if (wcsneq(pVarNameStart, L"hlsl-target")) {
  1622. m_Target.assign(pVarValStart, pVarValEnd - pVarValStart - 1);
  1623. }
  1624. else if (wcsneq(pVarNameStart, L"hlsl-args")) {
  1625. // skip for now
  1626. }
  1627. }
  1628. return S_OK;
  1629. }
  1630. #ifdef _WIN32 // Reflection unsupported
  1631. TEST_F(DxilContainerTest, ReflectionMatchesDXBC_CheckIn) {
  1632. WEX::TestExecution::SetVerifyOutput verifySettings(WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures);
  1633. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\container\\SimpleBezier11DS.hlsl").c_str(), false);
  1634. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\container\\SubD11_SmoothPS.hlsl").c_str(), false);
  1635. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\structured_buffer_layout.hlsl").c_str(), false);
  1636. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\cb_sizes.hlsl").c_str(), false);
  1637. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\tbuffer.hlsl").c_str(), false,
  1638. D3DCOMPILE_ENABLE_BACKWARDS_COMPATIBILITY);
  1639. ReflectionTest(hlsl_test::GetPathToHlslDataFile(L"..\\HLSLFileCheck\\d3dreflect\\texture2dms.hlsl").c_str(), false);
  1640. }
  1641. TEST_F(DxilContainerTest, ReflectionMatchesDXBC_Full) {
  1642. WEX::TestExecution::SetVerifyOutput verifySettings(WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures);
  1643. std::wstring codeGenPath = hlsl_test::GetPathToHlslDataFile(L"..\\CodeGenHLSL\\Samples");
  1644. // This test was running at about three minutes; that can be enabled with TestAll=True,
  1645. // otherwise the much shorter list is used.
  1646. const bool TestAll = false;
  1647. LPCWSTR PreApprovedPaths[] = {
  1648. L"2DQuadShaders_VS.hlsl",
  1649. L"BC6HEncode_TryModeLE10CS.hlsl",
  1650. L"DepthViewerVS.hlsl",
  1651. L"DetailTessellation11_DS.hlsl",
  1652. L"GenerateHistogramCS.hlsl",
  1653. L"OIT_PS.hlsl",
  1654. L"PNTriangles11_DS.hlsl",
  1655. L"PerfGraphPS.hlsl",
  1656. L"PerfGraphVS.hlsl",
  1657. L"ScreenQuadVS.hlsl",
  1658. L"SimpleBezier11HS.hlsl"
  1659. };
  1660. // These tests should always be skipped
  1661. LPCWSTR SkipPaths[] = {
  1662. L".hlsli",
  1663. L"TessellatorCS40_defines.h",
  1664. L"SubD11_SubDToBezierHS",
  1665. L"ParticleTileCullingCS_fail_unroll.hlsl"
  1666. };
  1667. for (auto &p: recursive_directory_iterator(path(codeGenPath))) {
  1668. if (is_regular_file(p)) {
  1669. LPCWSTR fullPath = p.path().c_str();
  1670. auto Matches = [&](LPCWSTR candidate) {
  1671. LPCWSTR match = wcsstr(fullPath, candidate);
  1672. return nullptr != match;
  1673. };
  1674. // Skip failed tests.
  1675. LPCWSTR *SkipEnd = SkipPaths + _countof(SkipPaths);
  1676. if (SkipEnd != std::find_if(SkipPaths, SkipEnd, Matches))
  1677. continue;
  1678. if (!TestAll) {
  1679. bool shouldTest = false;
  1680. LPCWSTR *PreApprovedEnd = PreApprovedPaths + _countof(PreApprovedPaths);
  1681. shouldTest = PreApprovedEnd != std::find_if(PreApprovedPaths, PreApprovedEnd, Matches);
  1682. if (!shouldTest) {
  1683. continue;
  1684. }
  1685. }
  1686. auto start = std::chrono::system_clock::now();
  1687. ReflectionTest(fullPath, true);
  1688. if (TestAll) {
  1689. // If testing all cases, print out their timing.
  1690. auto end = std::chrono::system_clock::now();
  1691. auto dur = std::chrono::duration_cast<std::chrono::milliseconds>(end - start);
  1692. LogCommentFmt(L"%s,%u", fullPath, (unsigned)dur.count());
  1693. }
  1694. }
  1695. }
  1696. }
  1697. #endif // _WIN32 - Reflection unsupported
  1698. TEST_F(DxilContainerTest, ValidateFromLL_Abs2) {
  1699. CodeGenTestCheck(L"..\\CodeGenHLSL\\container\\abs2_m.ll");
  1700. }
  1701. TEST_F(DxilContainerTest, DxilContainerUnitTest) {
  1702. CComPtr<IDxcCompiler> pCompiler;
  1703. CComPtr<IDxcBlobEncoding> pSource;
  1704. CComPtr<IDxcBlob> pProgram;
  1705. CComPtr<IDxcBlobEncoding> pDisassembly;
  1706. CComPtr<IDxcOperationResult> pResult;
  1707. std::vector<LPCWSTR> arguments;
  1708. arguments.emplace_back(L"/Zi");
  1709. arguments.emplace_back(L"/Qembed_debug");
  1710. VERIFY_SUCCEEDED(CreateCompiler(&pCompiler));
  1711. CreateBlobFromText("float4 main() : SV_Target { return 0; }", &pSource);
  1712. // Test DxilContainer with ShaderDebugInfoDXIL
  1713. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0", arguments.data(), arguments.size(), nullptr, 0, nullptr, &pResult));
  1714. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1715. const hlsl::DxilContainerHeader *pHeader = hlsl::IsDxilContainerLike(pProgram->GetBufferPointer(), pProgram->GetBufferSize());
  1716. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(pHeader, pProgram->GetBufferSize()));
  1717. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(pHeader, pProgram->GetBufferSize()));
  1718. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1719. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1720. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1721. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1722. pResult.Release();
  1723. pProgram.Release();
  1724. // Test DxilContainer without ShaderDebugInfoDXIL
  1725. VERIFY_SUCCEEDED(pCompiler->Compile(pSource, L"hlsl.hlsl", L"main", L"ps_6_0", nullptr, 0, nullptr, 0, nullptr, &pResult));
  1726. VERIFY_SUCCEEDED(pResult->GetResult(&pProgram));
  1727. pHeader = hlsl::IsDxilContainerLike(pProgram->GetBufferPointer(), pProgram->GetBufferSize());
  1728. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(pHeader, pProgram->GetBufferSize()));
  1729. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(pHeader, pProgram->GetBufferSize()));
  1730. VERIFY_IS_NOT_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1731. VERIFY_IS_NULL(hlsl::GetDxilProgramHeader(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1732. VERIFY_IS_NOT_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_DXIL));
  1733. VERIFY_IS_NULL(hlsl::GetDxilPartByType(pHeader, hlsl::DxilFourCC::DFCC_ShaderDebugInfoDXIL));
  1734. // Test Empty DxilContainer
  1735. hlsl::DxilContainerHeader header;
  1736. SetupBasicHeader(&header);
  1737. VERIFY_IS_TRUE(hlsl::IsValidDxilContainer(&header, header.ContainerSizeInBytes));
  1738. VERIFY_IS_NOT_NULL(hlsl::IsDxilContainerLike(&header, header.ContainerSizeInBytes));
  1739. VERIFY_IS_NULL(hlsl::GetDxilProgramHeader(&header, hlsl::DxilFourCC::DFCC_DXIL));
  1740. VERIFY_IS_NULL(hlsl::GetDxilPartByType(&header, hlsl::DxilFourCC::DFCC_DXIL));
  1741. }