format-strings-fixit.c 7.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261
  1. // RUN: cp %s %t
  2. // RUN: %clang_cc1 -pedantic -Wall -fixit %t
  3. // RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Werror %t
  4. // RUN: %clang_cc1 -E -o - %t | FileCheck %s
  5. /* This is a test of the various code modification hints that are
  6. provided as part of warning or extension diagnostics. All of the
  7. warnings will be fixed by -fixit, and the resulting file should
  8. compile cleanly with -Werror -pedantic. */
  9. int printf(char const *, ...);
  10. typedef __SIZE_TYPE__ size_t;
  11. typedef __INTMAX_TYPE__ intmax_t;
  12. typedef __UINTMAX_TYPE__ uintmax_t;
  13. typedef __PTRDIFF_TYPE__ ptrdiff_t;
  14. typedef __WCHAR_TYPE__ wchar_t;
  15. void test() {
  16. // Basic types
  17. printf("%s", (int) 123);
  18. printf("abc%0f", "testing testing 123");
  19. printf("%u", (long) -12);
  20. printf("%p", 123);
  21. printf("%c\n", "x");
  22. printf("%c\n", 1.23);
  23. // Larger types
  24. printf("%+.2d", (unsigned long long) 123456);
  25. printf("%1d", (long double) 1.23);
  26. // Flag handling
  27. printf("%0+s", (unsigned) 31337); // 0 flag should stay
  28. printf("%#p", (void *) 0);
  29. printf("% +f", 1.23); // + flag should stay
  30. printf("%0-f", 1.23); // - flag should stay
  31. // Positional arguments
  32. #pragma clang diagnostic push // Don't warn about using positional arguments.
  33. #pragma clang diagnostic ignored "-Wformat-non-iso"
  34. printf("%1$f:%2$.*3$f:%4$.*3$f\n", 1, 2, 3, 4);
  35. #pragma clang diagnostic pop
  36. // Precision
  37. printf("%10.5d", 1l); // (bug 7394)
  38. printf("%.2c", 'a');
  39. // Ignored flags
  40. printf("%0-f", 1.23);
  41. // Bad length modifiers
  42. printf("%hhs", "foo");
  43. #pragma clang diagnostic push // Don't warn about using positional arguments.
  44. #pragma clang diagnostic ignored "-Wformat-non-iso"
  45. printf("%1$zp", (void *)0);
  46. #pragma clang diagnostic pop
  47. // Preserve the original formatting for unsigned integers.
  48. unsigned long val = 42;
  49. printf("%X", val);
  50. // size_t, etc.
  51. printf("%f", (size_t) 42);
  52. printf("%f", (intmax_t) 42);
  53. printf("%f", (uintmax_t) 42);
  54. printf("%f", (ptrdiff_t) 42);
  55. // Look beyond the first typedef.
  56. typedef size_t my_size_type;
  57. typedef intmax_t my_intmax_type;
  58. typedef uintmax_t my_uintmax_type;
  59. typedef ptrdiff_t my_ptrdiff_type;
  60. typedef int my_int_type;
  61. printf("%f", (my_size_type) 42);
  62. printf("%f", (my_intmax_type) 42);
  63. printf("%f", (my_uintmax_type) 42);
  64. printf("%f", (my_ptrdiff_type) 42);
  65. printf("%f", (my_int_type) 42);
  66. // string
  67. printf("%ld", "foo");
  68. // Preserve the original choice of conversion specifier.
  69. printf("%o", (long) 42);
  70. printf("%u", (long) 42);
  71. printf("%x", (long) 42);
  72. printf("%X", (long) 42);
  73. printf("%i", (unsigned long) 42);
  74. printf("%d", (unsigned long) 42);
  75. printf("%F", (long double) 42);
  76. printf("%e", (long double) 42);
  77. printf("%E", (long double) 42);
  78. printf("%g", (long double) 42);
  79. printf("%G", (long double) 42);
  80. printf("%a", (long double) 42);
  81. printf("%A", (long double) 42);
  82. }
  83. int scanf(char const *, ...);
  84. void test2(int intSAParm[static 2]) {
  85. char str[100];
  86. char *vstr = "abc";
  87. short shortVar;
  88. unsigned short uShortVar;
  89. int intVar;
  90. int intAVar[2];
  91. unsigned uIntVar;
  92. float floatVar;
  93. double doubleVar;
  94. long double longDoubleVar;
  95. long longVar;
  96. unsigned long uLongVar;
  97. long long longLongVar;
  98. unsigned long long uLongLongVar;
  99. size_t sizeVar;
  100. intmax_t intmaxVar;
  101. uintmax_t uIntmaxVar;
  102. ptrdiff_t ptrdiffVar;
  103. enum {A, B, C} enumVar;
  104. // Some string types.
  105. scanf("%lf", str);
  106. scanf("%lf", vstr);
  107. scanf("%ls", str);
  108. scanf("%ls", str);
  109. // Some integer types.
  110. scanf("%f", &shortVar);
  111. scanf("%f", &uShortVar);
  112. scanf("%p", &intVar);
  113. scanf("%f", intAVar);
  114. scanf("%f", intSAParm);
  115. scanf("%Lf", &uIntVar);
  116. scanf("%ld", &floatVar);
  117. scanf("%f", &doubleVar);
  118. scanf("%d", &longDoubleVar);
  119. scanf("%f", &longVar);
  120. scanf("%f", &uLongVar);
  121. scanf("%f", &longLongVar);
  122. scanf("%f", &uLongLongVar);
  123. scanf("%d", &enumVar); // FIXME: We ought to fix specifiers for enums.
  124. // Some named ints.
  125. scanf("%f", &sizeVar);
  126. scanf("%f", &intmaxVar);
  127. scanf("%f", &uIntmaxVar);
  128. scanf("%f", &ptrdiffVar);
  129. // Look beyond the first typedef for named integer types.
  130. typedef size_t my_size_type;
  131. typedef intmax_t my_intmax_type;
  132. typedef uintmax_t my_uintmax_type;
  133. typedef ptrdiff_t my_ptrdiff_type;
  134. typedef int my_int_type;
  135. scanf("%f", (my_size_type*)&sizeVar);
  136. scanf("%f", (my_intmax_type*)&intmaxVar);
  137. scanf("%f", (my_uintmax_type*)&uIntmaxVar);
  138. scanf("%f", (my_ptrdiff_type*)&ptrdiffVar);
  139. scanf("%f", (my_int_type*)&intVar);
  140. // Preserve the original formatting.
  141. scanf("%o", &longVar);
  142. scanf("%u", &longVar);
  143. scanf("%x", &longVar);
  144. scanf("%X", &longVar);
  145. scanf("%i", &uLongVar);
  146. scanf("%d", &uLongVar);
  147. scanf("%F", &longDoubleVar);
  148. scanf("%e", &longDoubleVar);
  149. scanf("%E", &longDoubleVar);
  150. scanf("%g", &longDoubleVar);
  151. scanf("%G", &longDoubleVar);
  152. scanf("%a", &longDoubleVar);
  153. scanf("%A", &longDoubleVar);
  154. }
  155. // Validate the fixes.
  156. // CHECK: printf("%d", (int) 123);
  157. // CHECK: printf("abc%s", "testing testing 123");
  158. // CHECK: printf("%ld", (long) -12);
  159. // CHECK: printf("%d", 123);
  160. // CHECK: printf("%s\n", "x");
  161. // CHECK: printf("%f\n", 1.23);
  162. // CHECK: printf("%+.2lld", (unsigned long long) 123456);
  163. // CHECK: printf("%1Lf", (long double) 1.23);
  164. // CHECK: printf("%0u", (unsigned) 31337);
  165. // CHECK: printf("%p", (void *) 0);
  166. // CHECK: printf("%+f", 1.23);
  167. // CHECK: printf("%-f", 1.23);
  168. // CHECK: printf("%1$d:%2$.*3$d:%4$.*3$d\n", 1, 2, 3, 4);
  169. // CHECK: printf("%10.5ld", 1l);
  170. // CHECK: printf("%c", 'a');
  171. // CHECK: printf("%-f", 1.23);
  172. // CHECK: printf("%s", "foo");
  173. // CHECK: printf("%1$p", (void *)0);
  174. // CHECK: printf("%lX", val);
  175. // CHECK: printf("%zu", (size_t) 42);
  176. // CHECK: printf("%jd", (intmax_t) 42);
  177. // CHECK: printf("%ju", (uintmax_t) 42);
  178. // CHECK: printf("%td", (ptrdiff_t) 42);
  179. // CHECK: printf("%zu", (my_size_type) 42);
  180. // CHECK: printf("%jd", (my_intmax_type) 42);
  181. // CHECK: printf("%ju", (my_uintmax_type) 42);
  182. // CHECK: printf("%td", (my_ptrdiff_type) 42);
  183. // CHECK: printf("%d", (my_int_type) 42);
  184. // CHECK: printf("%s", "foo");
  185. // CHECK: printf("%lo", (long) 42);
  186. // CHECK: printf("%ld", (long) 42);
  187. // CHECK: printf("%lx", (long) 42);
  188. // CHECK: printf("%lX", (long) 42);
  189. // CHECK: printf("%lu", (unsigned long) 42);
  190. // CHECK: printf("%lu", (unsigned long) 42);
  191. // CHECK: printf("%LF", (long double) 42);
  192. // CHECK: printf("%Le", (long double) 42);
  193. // CHECK: printf("%LE", (long double) 42);
  194. // CHECK: printf("%Lg", (long double) 42);
  195. // CHECK: printf("%LG", (long double) 42);
  196. // CHECK: printf("%La", (long double) 42);
  197. // CHECK: printf("%LA", (long double) 42);
  198. // CHECK: scanf("%99s", str);
  199. // CHECK: scanf("%s", vstr);
  200. // CHECK: scanf("%99s", str);
  201. // CHECK: scanf("%99s", str);
  202. // CHECK: scanf("%hd", &shortVar);
  203. // CHECK: scanf("%hu", &uShortVar);
  204. // CHECK: scanf("%d", &intVar);
  205. // CHECK: scanf("%d", intAVar);
  206. // CHECK: scanf("%d", intSAParm);
  207. // CHECK: scanf("%u", &uIntVar);
  208. // CHECK: scanf("%f", &floatVar);
  209. // CHECK: scanf("%lf", &doubleVar);
  210. // CHECK: scanf("%Lf", &longDoubleVar);
  211. // CHECK: scanf("%ld", &longVar);
  212. // CHECK: scanf("%lu", &uLongVar);
  213. // CHECK: scanf("%lld", &longLongVar);
  214. // CHECK: scanf("%llu", &uLongLongVar);
  215. // CHECK: scanf("%d", &enumVar);
  216. // CHECK: scanf("%zu", &sizeVar);
  217. // CHECK: scanf("%jd", &intmaxVar);
  218. // CHECK: scanf("%ju", &uIntmaxVar);
  219. // CHECK: scanf("%td", &ptrdiffVar);
  220. // CHECK: scanf("%zu", (my_size_type*)&sizeVar);
  221. // CHECK: scanf("%jd", (my_intmax_type*)&intmaxVar);
  222. // CHECK: scanf("%ju", (my_uintmax_type*)&uIntmaxVar);
  223. // CHECK: scanf("%td", (my_ptrdiff_type*)&ptrdiffVar);
  224. // CHECK: scanf("%d", (my_int_type*)&intVar);
  225. // CHECK: scanf("%lo", &longVar);
  226. // CHECK: scanf("%lu", &longVar);
  227. // CHECK: scanf("%lx", &longVar);
  228. // CHECK: scanf("%lX", &longVar);
  229. // CHECK: scanf("%li", &uLongVar);
  230. // CHECK: scanf("%ld", &uLongVar);
  231. // CHECK: scanf("%LF", &longDoubleVar);
  232. // CHECK: scanf("%Le", &longDoubleVar);
  233. // CHECK: scanf("%LE", &longDoubleVar);
  234. // CHECK: scanf("%Lg", &longDoubleVar);
  235. // CHECK: scanf("%LG", &longDoubleVar);
  236. // CHECK: scanf("%La", &longDoubleVar);
  237. // CHECK: scanf("%LA", &longDoubleVar);