浏览代码

Review feedback addressed.

Signed-off-by: Vivien Oddou <[email protected]>
Vivien Oddou 2 年之前
父节点
当前提交
4acb31f806
共有 2 个文件被更改,包括 4 次插入2 次删除
  1. 2 2
      src/AzslcReflection.cpp
  2. 2 0
      src/AzslcUtils.h

+ 2 - 2
src/AzslcReflection.cpp

@@ -1057,7 +1057,7 @@ namespace AZ::ShaderCompiler
                 // loop over appearances over the program
                 // loop over appearances over the program
                 for (Seenat& ref : kindInfo->GetSeenats())
                 for (Seenat& ref : kindInfo->GetSeenats())
                 {
                 {
-                    verboseCout << "Seenat line " << ref.m_where.m_line << "\n";
+                    verboseCout << "Seen-at line " << ref.m_where.m_line << "\n";
                     // determine an impact score
                     // determine an impact score
                     impactScore += AnalyzeImpact(ref.m_where)  // dependent code that may be skipped depending on the value of that ref
                     impactScore += AnalyzeImpact(ref.m_where)  // dependent code that may be skipped depending on the value of that ref
                         + 1;  // by virtue of being mentioned (seenat), we count the reference as an access of cost 1.
                         + 1;  // by virtue of being mentioned (seenat), we count the reference as an access of cost 1.
@@ -1199,7 +1199,7 @@ namespace AZ::ShaderCompiler
                                       funcInfo->m_costScore);  // recurse and cache
                                       funcInfo->m_costScore);  // recurse and cache
                     }
                     }
                     scoreAccumulator += funcInfo->m_costScore;
                     scoreAccumulator += funcInfo->m_costScore;
-                    verboseCout << " " << concrete << " call score " << funcInfo->m_costScore << " added\n";
+                    verboseCout << " " << concrete << " cost score " << funcInfo->m_costScore << " added\n";
                 }
                 }
             }
             }
             // other cases forfeited for now, but that would at least include things like eg braces (f)()
             // other cases forfeited for now, but that would at least include things like eg braces (f)()

+ 2 - 0
src/AzslcUtils.h

@@ -965,7 +965,9 @@ namespace AZ::ShaderCompiler
         while (parent)
         while (parent)
         {
         {
             if (parent == assumedParent)
             if (parent == assumedParent)
+            {
                 return true;
                 return true;
+            }
             parent = parent->parent;
             parent = parent->parent;
         }
         }
         return false;
         return false;