Update signals/slots to match upstream changes

Signed-off-by: Alex Peterson <[email protected]>

Code/Tools/ProjectManager/Source/DownloadController.cpp

@@ -82,13 +82,13 @@ namespace O3DE::ProjectManager
             succeeded = false;
         }
 
-        const QString gemName = m_gemNames[0];
+        QString gemName = m_gemNames.front();
         m_gemNames.erase(m_gemNames.begin());
-        emit Done(succeeded, gemName);
+        emit Done(gemName, succeeded);
 
         if (!m_gemNames.empty())
         {
-            emit StartGemDownload(m_gemNames[0]);
+            emit StartGemDownload(m_gemNames.front());
         }
         else
         {

Code/Tools/ProjectManager/Source/DownloadController.h

@@ -58,7 +58,7 @@ namespace O3DE::ProjectManager
 
     signals:
         void StartGemDownload(const QString& gemName);
-        void Done(bool success, const QString& gemName);
+        void Done(const QString& gemName, bool success = true);
         void GemDownloadProgress(int percentage);
 
     private:

Code/Tools/ProjectManager/Source/GemCatalog/GemCatalogHeaderWidget.cpp

@@ -261,7 +261,7 @@ namespace O3DE::ProjectManager
             }
         };
 
-        auto downloadEnded = [=](bool /*success*/, const QString& /*gemName*/)
+        auto downloadEnded = [=](const QString& /*gemName*/, bool /*success*/)
         {
             update(0); // update the list to remove the gem that has finished
         };

Code/Tools/ProjectManager/Source/GemCatalog/GemCatalogScreen.cpp

@@ -459,7 +459,7 @@ namespace O3DE::ProjectManager
         emit ChangeScreenRequest(ProjectManagerScreen::GemRepos);
     }
 
-    void GemCatalogScreen::OnGemDownloadResult(bool succeeded, const QString& gemName)
+    void GemCatalogScreen::OnGemDownloadResult(const QString& gemName, bool succeeded)
     {
         if (succeeded)
         {

Code/Tools/ProjectManager/Source/GemCatalog/GemCatalogScreen.h

@@ -49,7 +49,7 @@ namespace O3DE::ProjectManager
         void OnGemStatusChanged(const QString& gemName, uint32_t numChangedDependencies);
         void OnAddGemClicked();
         void SelectGem(const QString& gemName);
-        void OnGemDownloadResult(bool succeeded, const QString& gemName);
+        void OnGemDownloadResult(const QString& gemName, bool succeeded = true);
         void Refresh();
 
     protected: