ソースを参照

set consistent names

Signed-off-by: amzn-ahmadkrm <[email protected]>
amzn-ahmadkrm 2 年 前
コミット
2cc47e148f

+ 5 - 5
Code/Editor/Core/EditorActionsHandler.cpp

@@ -1026,13 +1026,13 @@ void EditorActionsHandler::OnActionRegistrationHook()
         m_hotKeyManagerInterface->SetActionHotKey(actionIdentifier, "Ctrl+Space");
     }
 
-    // Show Icons
+    // Only Show Helpers For Selected Entities
     {
         const AZStd::string_view& actionIdentifier = "o3de.action.view.toggleSelectedHelpers";
 
         AzToolsFramework::ActionProperties actionProperties;
-        actionProperties.m_name = "Only Show Helpers for Selected Entities";
-        actionProperties.m_description = "Toggle show helpers for Entities";
+        actionProperties.m_name = "Only Show Helpers For Selected Entities";
+        actionProperties.m_description = "Toggle To Only Show Helpers For Entities";
         actionProperties.m_category = "View";
 
         m_actionManagerInterface->RegisterCheckableAction(
@@ -1043,7 +1043,7 @@ void EditorActionsHandler::OnActionRegistrationHook()
             {
                 AzToolsFramework::SetOnlyShowHelpersForSelectedEntities(!AzToolsFramework::OnlyShowHelpersForSelectedEntities());
                 AzToolsFramework::ViewportInteraction::ViewportSettingsNotificationBus::Broadcast(
-                    &AzToolsFramework::ViewportInteraction::ViewportSettingNotifications::OnOnlyDrawHelpersForSelectedItemsChanged,
+                    &AzToolsFramework::ViewportInteraction::ViewportSettingNotifications::OnOnlyShowHelpersForSelectedEntitiesChanged,
                     AzToolsFramework::OnlyShowHelpersForSelectedEntities());
             },
             []()
@@ -1777,7 +1777,7 @@ void EditorActionsHandler::OnIconsVisibilityChanged([[maybe_unused]] bool enable
     m_actionManagerInterface->TriggerActionUpdater(IconsStateChangedUpdaterIdentifier);
 }
 
-void EditorActionsHandler::OnOnlyDrawHelpersForSelectedItemsChanged([[maybe_unused]] bool enabled)
+void EditorActionsHandler::OnOnlyShowHelpersForSelectedEntitiesChanged([[maybe_unused]] bool enabled)
 {
     m_actionManagerInterface->TriggerActionUpdater(OnlyShowHelpersForSelectedEntitiesIdentifier);
 }

+ 1 - 1
Code/Editor/Core/EditorActionsHandler.h

@@ -81,7 +81,7 @@ private:
     void OnDrawHelpersChanged(bool enabled) override;
     void OnGridSnappingChanged(bool enabled) override;
     void OnIconsVisibilityChanged(bool enabled) override;
-    void OnOnlyDrawHelpersForSelectedItemsChanged(bool enabled) override;
+    void OnOnlyShowHelpersForSelectedEntitiesChanged(bool enabled) override;
 
     // Layouts
     void RefreshLayoutActions();

+ 1 - 1
Code/Editor/Core/LevelEditorMenuHandler.cpp

@@ -736,7 +736,7 @@ QMenu* LevelEditorMenuHandler::CreateViewMenu()
     viewportViewsMenuWrapper.AddSeparator();
     viewportViewsMenuWrapper.AddAction(AzToolsFramework::Helpers);
     viewportViewsMenuWrapper.AddAction(AzToolsFramework::Icons);
-    viewportViewsMenuWrapper.AddAction(AzToolsFramework::OnlyShowSelectedEntitiesHelpers);
+    viewportViewsMenuWrapper.AddAction(AzToolsFramework::OnlyShowHelpersForSelectedEntitiesAction);
 
     // Refresh Style
     viewMenu.AddAction(ID_SKINS_REFRESH);

+ 2 - 2
Code/Editor/MainWindow.cpp

@@ -1060,7 +1060,7 @@ void MainWindow::InitActions()
                     &AzToolsFramework::ViewportInteraction::ViewportSettingNotifications::OnIconsVisibilityChanged,
                     AzToolsFramework::IconsVisible());
             });
-    am->AddAction(AzToolsFramework::OnlyShowSelectedEntitiesHelpers, tr("Only Show For Selected Entities"))
+    am->AddAction(AzToolsFramework::OnlyShowHelpersForSelectedEntitiesAction, tr("Only Show For Selected Entities"))
         .SetToolTip(tr("Show/Hide Only selected (Ctrl+Shift+Space)"))
         .SetCheckable(true)
         .RegisterUpdateCallback(
@@ -1075,7 +1075,7 @@ void MainWindow::InitActions()
             {
                 AzToolsFramework::SetOnlyShowHelpersForSelectedEntities(!AzToolsFramework::OnlyShowHelpersForSelectedEntities());
                 AzToolsFramework::ViewportInteraction::ViewportSettingsNotificationBus::Broadcast(
-                    &AzToolsFramework::ViewportInteraction::ViewportSettingNotifications::OnOnlyDrawHelpersForSelectedItemsChanged,
+                    &AzToolsFramework::ViewportInteraction::ViewportSettingNotifications::OnOnlyShowHelpersForSelectedEntitiesChanged,
                     AzToolsFramework::OnlyShowHelpersForSelectedEntities());
             });
 

+ 1 - 1
Code/Framework/AzToolsFramework/AzToolsFramework/Viewport/ViewportMessages.h

@@ -246,7 +246,7 @@ namespace AzToolsFramework
             virtual void OnIconsVisibilityChanged([[maybe_unused]] bool enabled)
             {
             }
-            virtual void OnOnlyDrawHelpersForSelectedItemsChanged([[maybe_unused]] bool enabled)
+            virtual void OnOnlyShowHelpersForSelectedEntitiesChanged([[maybe_unused]] bool enabled)
             {
             }
 

+ 3 - 3
Code/Framework/AzToolsFramework/AzToolsFramework/Viewport/ViewportSettings.cpp

@@ -24,7 +24,7 @@ namespace AzToolsFramework
     constexpr AZStd::string_view ManipulatorViewBaseScaleSetting = "/Amazon/Preferences/Editor/Manipulator/ViewBaseScale";
     constexpr AZStd::string_view IconsVisibleSetting = "/Amazon/Preferences/Editor/IconsVisible";
     constexpr AZStd::string_view HelpersVisibleSetting = "/Amazon/Preferences/Editor/HelpersVisible";
-    constexpr AZStd::string_view SelectedEntitiesHelpersSetting = "/Amazon/Preferences/Editor/OnlyShowHelpersForSelectedEntities";
+    constexpr AZStd::string_view OnlyShowHelpersForSelectedEntitiesSetting = "/Amazon/Preferences/Editor/OnlyShowHelpersForSelectedEntities";
     constexpr AZStd::string_view ComponentSwitcherEnabledSetting = "/Amazon/Preferences/Editor/ComponentSwitcherEnabled";
     constexpr AZStd::string_view PrefabEditModeEffectEnabledSetting = "/Amazon/Preferences/Editor/PrefabEditModeEffectEnabled";
 
@@ -150,12 +150,12 @@ namespace AzToolsFramework
 
     bool OnlyShowHelpersForSelectedEntities()
     {
-        return GetRegistry(SelectedEntitiesHelpersSetting, false);
+        return GetRegistry(OnlyShowHelpersForSelectedEntitiesSetting, false);
     }
 
     void SetOnlyShowHelpersForSelectedEntities(const bool visible)
     {
-        SetRegistry(SelectedEntitiesHelpersSetting, visible);
+        SetRegistry(OnlyShowHelpersForSelectedEntitiesSetting, visible);
     }
 
     bool ComponentSwitcherEnabled()

+ 1 - 1
Code/Framework/AzToolsFramework/AzToolsFramework/ViewportSelection/EditorTransformComponentSelectionRequestBus.h

@@ -34,7 +34,7 @@ namespace AzToolsFramework
     constexpr inline AZ::Crc32 ViewportUiVisible = AZ_CRC_CE("org.o3de.action.editortransform.viewportuivisible");
     constexpr inline AZ::Crc32 Helpers = AZ_CRC_CE("org.o3de.action.editor.helpers");
     constexpr inline AZ::Crc32 Icons = AZ_CRC_CE("org.o3de.action.editor.icons");
-    constexpr inline AZ::Crc32 OnlyShowSelectedEntitiesHelpers = AZ_CRC_CE("org.o3de.action.editor.onlyshowselectedentitieshelpers");
+    constexpr inline AZ::Crc32 OnlyShowHelpersForSelectedEntitiesAction = AZ_CRC_CE("org.o3de.action.editor.onlyshowselectedentitieshelpers");
     //@}
 
     namespace ComponentModeFramework