2
0
Эх сурвалжийг харах

Adress PR Comments

Signed-off-by: mddvisu <[email protected]>
mddvisu 2 жил өмнө
parent
commit
5d55ea669c
12 өөрчлөгдсөн 23 нэмэгдсэн , 23 устгасан
  1. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactAddNodeable.ScriptCanvasNodeable.xml
  2. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactDecrementNodeable.ScriptCanvasNodeable.xml
  3. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactDivideNodeable.ScriptCanvasNodeable.xml
  4. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactIncrementNodeable.ScriptCanvasNodeable.xml
  5. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactMultiplyNodeable.ScriptCanvasNodeable.xml
  6. 5 5
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.ScriptCanvasNodeable.xml
  7. 3 3
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.cpp
  8. 4 4
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.h
  9. 1 1
      Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactSubtractNodeable.ScriptCanvasNodeable.xml
  10. 1 1
      Gems/ScriptCanvas/Code/scriptcanvasgem_common_files.cmake
  11. 2 2
      Gems/ScriptCanvas/Code/scriptcanvasgem_headers.cmake
  12. 2 2
      Gems/ScriptCanvasTesting/Assets/ScriptCanvas/UnitTests/LY_SC_UnitTest_CompactNodeBasicOperators.scriptcanvas

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactAddNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Adds the first input number to the second input number"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactDecrementNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Decrements the input number by 1"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactDivideNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Divides first input number by the second input number"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactIncrementNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Increments the input number by 1"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactMultiplyNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Multiplies the first input number by the second input number"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 5 - 5
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.ScriptCanvasNodeable.xml → Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.ScriptCanvasNodeable.xml

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="utf-8"?>
 
-<ScriptCanvas Include="Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.h" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+<ScriptCanvas Include="Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.h" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 			  xsi:noNamespaceSchemaLocation="../../../AutoGen/ScriptCanvasNodeable.xsd">
-    <Class Name="CompactNegativeNodeable"
-        QualifiedName="Nodeables::CompactNegativeNodeable"
+    <Class Name="CompactNegateNodeable"
+        QualifiedName="Nodeables::CompactNegateNodeable"
         PreferredClassName="*-1"
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
-        Description="Gets the negative of the input number"
-		Preset="compact">
+        Description="Multiplies the input number by -1"
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 3 - 3
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.cpp → Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.cpp

@@ -6,12 +6,12 @@
  *
  */
 
-#include "CompactNegativeNodeable.h"
+#include "CompactNegateNodeable.h"
 
 namespace ScriptCanvas::Nodeables
 {
-    float CompactNegativeNodeable::In(float a)
+    float CompactNegateNodeable::In(float a)
     {
-        return a * -1;
+        return -a;
     }
 }

+ 4 - 4
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.h → Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.h

@@ -12,15 +12,15 @@
 #include <ScriptCanvas/Core/Nodeable.h>
 #include <ScriptCanvas/Core/NodeableNode.h>
 
-#include <Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.generated.h>
+#include <Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.generated.h>
 
 namespace ScriptCanvas::Nodeables
 {
-    class CompactNegativeNodeable : public Nodeable
+    class CompactNegateNodeable : public Nodeable
     {
-        SCRIPTCANVAS_NODE(CompactNegativeNodeable);
+        SCRIPTCANVAS_NODE(CompactNegateNodeable);
 
     public:
-        AZ_CLASS_ALLOCATOR(CompactNegativeNodeable, AZ::SystemAllocator)
+        AZ_CLASS_ALLOCATOR(CompactNegateNodeable, AZ::SystemAllocator)
     };
 }

+ 1 - 1
Gems/ScriptCanvas/Code/Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactSubtractNodeable.ScriptCanvasNodeable.xml

@@ -8,7 +8,7 @@
         Category="Compact/Basic Operators"
         Namespace="ScriptCanvas"
         Description="Subtracts the first input number by the second input number"
-		Preset="compact">
+        Preset="compact">
 
         <Input Name="In" OutputName="Out">
             <Parameter Name="a" Type="float"/>

+ 1 - 1
Gems/ScriptCanvas/Code/scriptcanvasgem_common_files.cmake

@@ -101,7 +101,7 @@ set(FILES
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactDivideNodeable.cpp
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactIncrementNodeable.cpp
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactMultiplyNodeable.cpp
-    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.cpp
+    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.cpp
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactSubtractNodeable.cpp
     Include/ScriptCanvas/Libraries/Core/AzEventHandler.cpp
     Include/ScriptCanvas/Libraries/Core/BinaryOperator.cpp

+ 2 - 2
Gems/ScriptCanvas/Code/scriptcanvasgem_headers.cmake

@@ -136,8 +136,8 @@ set(FILES
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactIncrementNodeable.ScriptCanvasNodeable.xml
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactMultiplyNodeable.h
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactMultiplyNodeable.ScriptCanvasNodeable.xml
-    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.h
-    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegativeNodeable.ScriptCanvasNodeable.xml
+    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.h
+    Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactNegateNodeable.ScriptCanvasNodeable.xml
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactSubtractNodeable.h
     Include/ScriptCanvas/Libraries/Compact/BasicOperators/CompactSubtractNodeable.ScriptCanvasNodeable.xml
     Include/ScriptCanvas/Libraries/Core/AzEventHandler.h

+ 2 - 2
Gems/ScriptCanvasTesting/Assets/ScriptCanvas/UnitTests/LY_SC_UnitTest_CompactNodeBasicOperators.scriptcanvas

@@ -2212,10 +2212,10 @@
                                 "Id": {
                                     "id": 792352248110
                                 },
-                                "Name": "SC-Node(CompactNegativeNodeableNode)",
+                                "Name": "SC-Node(CompactNegateNodeableNode)",
                                 "Components": {
                                     "Component_[7612818545677164298]": {
-                                        "$type": "CompactNegativeNodeableNode",
+                                        "$type": "CompactNegateNodeableNode",
                                         "Id": 7612818545677164298,
                                         "Slots": [
                                             {