소스 검색

Addressing PR feedback

Benjamin Jillich 4 년 전
부모
커밋
e7e85f91d6

+ 0 - 1
Code/Tools/ProjectManager/Source/CreateProjectCtrl.cpp

@@ -92,7 +92,6 @@ namespace O3DE::ProjectManager
     void CreateProjectCtrl::HandleNextButton()
     {
         ScreenWidget* currentScreen = reinterpret_cast<ScreenWidget*>(m_stack->currentWidget());
-        const int currentScreenIndex = m_stack->currentIndex();
         ProjectManagerScreen screenEnum = currentScreen->GetScreenEnum();
 
         if (screenEnum == ProjectManagerScreen::NewProjectSettings)

+ 3 - 3
Code/Tools/ProjectManager/Source/GemCatalog/GemCatalogScreen.cpp

@@ -89,7 +89,7 @@ namespace O3DE::ProjectManager
             });
     }
 
-    void GemCatalogScreen::FillModel(const QString& projectPath, [[maybe_unused]] bool isNewProject)
+    void GemCatalogScreen::FillModel(const QString& projectPath, bool isNewProject)
     {
         AZ::Outcome<QVector<GemInfo>, AZStd::string> allGemInfosResult;
         if (isNewProject)
@@ -133,12 +133,12 @@ namespace O3DE::ProjectManager
             }
             else
             {
-                QMessageBox::critical(nullptr, "Operation failed", QString("Cannot retrieve enabled gems for project %1.\n\nError:\n%2").arg(projectPath, enabledGemNamesResult.GetError().c_str()));
+                QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve enabled gems for project %1.\n\nError:\n%2").arg(projectPath, enabledGemNamesResult.GetError().c_str()));
             }
         }
         else
         {
-            QMessageBox::critical(nullptr, "Operation failed", QString("Cannot retrieve gems for %1.\n\nError:\n%2").arg(projectPath, allGemInfosResult.GetError().c_str()));
+            QMessageBox::critical(nullptr, tr("Operation failed"), QString("Cannot retrieve gems for %1.\n\nError:\n%2").arg(projectPath, allGemInfosResult.GetError().c_str()));
         }
     }
 

+ 2 - 1
Code/Tools/ProjectManager/Source/PythonBindings.cpp

@@ -321,13 +321,14 @@ namespace O3DE::ProjectManager
         try
         {
             executionCallback();
-            return AZ::Success();
         }
         catch ([[maybe_unused]] const std::exception& e)
         {
             AZ_Warning("PythonBindings", false, "Python exception %s", e.what());
             return AZ::Failure<AZStd::string>(e.what());
         }
+
+        return AZ::Success();
     }
 
     bool PythonBindings::ExecuteWithLock(AZStd::function<void()> executionCallback)