Explorar el Código

Win32: Fix clang-cl interpreting -Wall as /Wall

Unlike -Wall, VS /Wall really means all warnings.

Closes #1780.
Camilla Löwy hace 5 años
padre
commit
ac627706ef
Se han modificado 2 ficheros con 7 adiciones y 1 borrados
  1. 1 0
      README.md
  2. 6 1
      src/CMakeLists.txt

+ 1 - 0
README.md

@@ -296,6 +296,7 @@ skills.
  - Eloi Marín Gratacós
  - Stefan Gustavson
  - Jonathan Hale
+ - hdf89shfdfs
  - Sylvain Hellegouarch
  - Matthew Henry
  - heromyth

+ 6 - 1
src/CMakeLists.txt

@@ -137,7 +137,12 @@ if ("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU" OR
     "${CMAKE_C_COMPILER_ID}" STREQUAL "Clang" OR
     "${CMAKE_C_COMPILER_ID}" STREQUAL "AppleClang")
 
-    target_compile_options(glfw PRIVATE "-Wall")
+    if ("${CMAKE_C_SIMULATE_ID}" STREQUAL "MSVC")
+        # Tell Clang-CL that this is a Clang flag
+        target_compile_options(glfw PRIVATE "/clang:-Wall")
+    else()
+        target_compile_options(glfw PRIVATE "-Wall")
+    endif()
 elseif (MSVC)
     target_compile_options(glfw PRIVATE "/W3")
 endif()