Browse Source

Clipper, Tables: removed `row_increase >= 0` assert. (#8886)

Seeing cases in my own tests that are not obvious so it seems like too much of a burden for the user to assert/crash, as the row count is not always useful anyhow.
ocornut 2 tuần trước cách đây
mục cha
commit
6351f00ff1
1 tập tin đã thay đổi với 2 bổ sung3 xóa
  1. 2 3
      imgui.cpp

+ 2 - 3
imgui.cpp

@@ -3142,10 +3142,9 @@ static void ImGuiListClipper_SeekCursorAndSetupPrevLine(ImGuiListClipper* clippe
     {
         if (table->IsInsideRow)
             ImGui::TableEndRow(table);
-        if ((clipper->Flags & ImGuiListClipperFlags_NoSetTableRowCounters) == 0)
+        const int row_increase = (int)((off_y / line_height) + 0.5f);
+        if (row_increase > 0 && (clipper->Flags & ImGuiListClipperFlags_NoSetTableRowCounters) == 0) // If your clipper item height is != from actual table row height, consider using ImGuiListClipperFlags_NoSetTableRowCounters. See #8886.
         {
-            const int row_increase = (int)((off_y / line_height) + 0.5f);
-            IM_ASSERT(row_increase >= 0); // If your clipper item height is != from actual table row height, consider using ImGuiListClipperFlags_NoSetTableRowCounters. See #8886.
             table->CurrentRow += row_increase;
             table->RowBgColorCounter += row_increase;
         }