Browse Source

Error Handling: fixed cases where recoverable error handling would crash. (#1651)

ocornut 9 months ago
parent
commit
e97b97467e
2 changed files with 5 additions and 1 deletions
  1. 4 0
      docs/CHANGELOG.txt
  2. 1 1
      imgui.cpp

+ 4 - 0
docs/CHANGELOG.txt

@@ -43,6 +43,10 @@ Breaking changes:
 
 
 Other changes:
 Other changes:
 
 
+- Error Handling: fixed cases where recoverable error handling would crash when 
+  processing errors outside of the NewFrame()..EndFrame() scope. (#1651)
+
+
 -----------------------------------------------------------------------
 -----------------------------------------------------------------------
  VERSION 1.91.5 (Released 2024-11-07)
  VERSION 1.91.5 (Released 2024-11-07)
 -----------------------------------------------------------------------
 -----------------------------------------------------------------------

+ 1 - 1
imgui.cpp

@@ -10542,7 +10542,7 @@ bool    ImGui::ErrorLog(const char* msg)
     // Output to tooltip
     // Output to tooltip
     if (g.IO.ConfigErrorRecoveryEnableTooltip)
     if (g.IO.ConfigErrorRecoveryEnableTooltip)
     {
     {
-        if (BeginErrorTooltip())
+        if (g.WithinFrameScope && BeginErrorTooltip())
         {
         {
             if (g.ErrorCountCurrentFrame < 20)
             if (g.ErrorCountCurrentFrame < 20)
             {
             {