Przeglądaj źródła

fir coverity finding: dsa_import double free

Karel Miko 8 lat temu
rodzic
commit
1e260eeaae
1 zmienionych plików z 2 dodań i 1 usunięć
  1. 2 1
      src/pk/dsa/dsa_import.c

+ 2 - 1
src/pk/dsa/dsa_import.c

@@ -103,10 +103,12 @@ int dsa_import(const unsigned char *in, unsigned long inlen, dsa_key *key)
         PKA_DSA, tmpbuf, &tmpbuf_len,
         LTC_ASN1_SEQUENCE, params, 3);
       if (err != CRYPT_OK) {
+         XFREE(tmpbuf);
          goto LBL_ERR;
       }
 
       if ((err=der_decode_integer(tmpbuf, tmpbuf_len, key->y)) != CRYPT_OK) {
+         XFREE(tmpbuf);
          goto LBL_ERR;
       }
 
@@ -125,7 +127,6 @@ LBL_OK:
 
   return CRYPT_OK;
 LBL_ERR:
-   XFREE(tmpbuf);
    mp_clear_multi(key->p, key->g, key->q, key->x, key->y, NULL);
    return err;
 }