浏览代码

Prevent undefined behavior

Don't call XMEMCPY() in case info (the source parameter to memcpy) is NULL
as this would trigger UB
Steffen Jaeckel 10 年之前
父节点
当前提交
f5016d88dd
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      src/misc/hkdf/hkdf.c

+ 3 - 1
src/misc/hkdf/hkdf.c

@@ -61,7 +61,9 @@ int hkdf_expand(int hash_idx, const unsigned char *info, unsigned long infolen,
    if (T == NULL) {
       return CRYPT_MEM;
    }
-   XMEMCPY(T + hashsize, info, infolen);
+   if (info != NULL) {
+      XMEMCPY(T + hashsize, info, infolen);
+   }
 
    /* HMAC data T(1) doesn't include a previous hash value */
    dat    = T    + hashsize;