helper.pl 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382
  1. #!/usr/bin/env perl
  2. use strict;
  3. use warnings;
  4. use Getopt::Long;
  5. use File::Find 'find';
  6. use File::Basename 'basename';
  7. use File::Glob 'bsd_glob';
  8. sub read_file {
  9. my $f = shift;
  10. open my $fh, "<", $f or die "FATAL: read_rawfile() cannot open file '$f': $!";
  11. binmode $fh;
  12. return do { local $/; <$fh> };
  13. }
  14. sub write_file {
  15. my ($f, $data) = @_;
  16. die "FATAL: write_file() no data" unless defined $data;
  17. open my $fh, ">", $f or die "FATAL: write_file() cannot open file '$f': $!";
  18. binmode $fh;
  19. print $fh $data or die "FATAL: write_file() cannot write to '$f': $!";
  20. close $fh or die "FATAL: write_file() cannot close '$f': $!";
  21. return;
  22. }
  23. sub check_source {
  24. my @all_files = (bsd_glob("makefile*"), bsd_glob("*.sh"), bsd_glob("*.pl"));
  25. find({ wanted=>sub { push @all_files, $_ if -f $_ }, no_chdir=>1 }, qw/src tests demos/);
  26. my $fails = 0;
  27. for my $file (sort @all_files) {
  28. next unless $file =~ /\.(c|h|pl|py|sh)$/ || basename($file) =~ /^makefile/i;
  29. my $troubles = {};
  30. my $lineno = 1;
  31. my $content = read_file($file);
  32. push @{$troubles->{crlf_line_end}}, '?' if $content =~ /\r/;
  33. for my $l (split /\n/, $content) {
  34. push @{$troubles->{merge_conflict}}, $lineno if $l =~ /^(<<<<<<<|=======|>>>>>>>)([^<=>]|$)/;
  35. push @{$troubles->{trailing_space}}, $lineno if $l =~ / $/;
  36. push @{$troubles->{tab}}, $lineno if $l =~ /\t/ && basename($file) !~ /^makefile/i;
  37. push @{$troubles->{non_ascii_char}}, $lineno if $l =~ /[^[:ascii:]]/;
  38. push @{$troubles->{cpp_comment}}, $lineno if $file =~ /\.(c|h)$/ && ($l =~ /\s\/\// || $l =~ /\/\/\s/);
  39. # in ./src we prefer using XMEMCPY, XMALLOC, XFREE ...
  40. push @{$troubles->{unwanted_memcpy}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmemcpy\s*\(/;
  41. push @{$troubles->{unwanted_malloc}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmalloc\s*\(/;
  42. push @{$troubles->{unwanted_realloc}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\brealloc\s*\(/;
  43. push @{$troubles->{unwanted_calloc}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bcalloc\s*\(/;
  44. push @{$troubles->{unwanted_free}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bfree\s*\(/;
  45. push @{$troubles->{unwanted_memset}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmemset\s*\(/;
  46. push @{$troubles->{unwanted_memcpy}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmemcpy\s*\(/;
  47. push @{$troubles->{unwanted_memmove}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmemmove\s*\(/;
  48. push @{$troubles->{unwanted_memcmp}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bmemcmp\s*\(/;
  49. push @{$troubles->{unwanted_strcmp}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bstrcmp\s*\(/;
  50. push @{$troubles->{unwanted_strcpy}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bstrcpy\s*\(/;
  51. push @{$troubles->{unwanted_strlen}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bstrlen\s*\(/;
  52. push @{$troubles->{unwanted_strncpy}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bstrncpy\s*\(/;
  53. push @{$troubles->{unwanted_clock}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bclock\s*\(/;
  54. push @{$troubles->{unwanted_qsort}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bqsort\s*\(/;
  55. push @{$troubles->{sizeof_no_brackets}}, $lineno if $file =~ /^src\/.*\.c$/ && $l =~ /\bsizeof\s*[^\(]/;
  56. if ($file =~ m|src/.*\.c$| &&
  57. $file !~ m|src/ciphers/.*\.c$| &&
  58. $file !~ m|src/math/.+_desc.c$| &&
  59. $file !~ m|src/pk/ec25519/tweetnacl.c$| &&
  60. $file !~ m|src/stream/sober128/sober128_stream.c$| &&
  61. $l =~ /^static(\s+[a-zA-Z0-9_]+)+\s++([^s][a-zA-Z0-9_]+)\s*\(/) {
  62. push @{$troubles->{staticfunc_name}}, "$2";
  63. }
  64. if ($file =~ m|src/.*\.[ch]$| && $l =~ /^\s*#\s*define\s+(_[A-Z_][a-zA-Z0-9_]*)\b/) {
  65. my $n = $1;
  66. push @{$troubles->{invalid_macro_name}}, "$lineno($n)"
  67. unless ($file eq 'src/headers/tomcrypt_cfg.h' && $n eq '__has_builtin') ||
  68. ($file eq 'src/prngs/rng_get_bytes.c' && $n eq '_WIN32_WINNT');
  69. }
  70. $lineno++;
  71. }
  72. for my $k (sort keys %$troubles) {
  73. warn "[$k] $file line:" . join(",", @{$troubles->{$k}}) . "\n";
  74. $fails++;
  75. }
  76. }
  77. warn( $fails > 0 ? "check-source: FAIL $fails\n" : "check-source: PASS\n" );
  78. return $fails;
  79. }
  80. sub check_defines {
  81. my $fails = 0;
  82. my $cust_h = read_file("src/headers/tomcrypt_custom.h");
  83. my $cryp_c = read_file("src/misc/crypt/crypt.c");
  84. $cust_h =~ s|/\*.*?\*/||sg; # remove comments
  85. $cryp_c =~ s|/\*.*?\*/||sg; # remove comments
  86. my %def = map { $_ => 1 } map { my $x = $_; $x =~ s/^\s*#define\s+(LTC_\S+).*$/$1/; $x } grep { /^\s*#define\s+LTC_\S+/ } split /\n/, $cust_h;
  87. for my $d (sort keys %def) {
  88. next if $d =~ /^LTC_(DH\d+|ECC\d+|ECC_\S+|MPI|MUTEX_\S+\(x\)|NO_\S+)$/;
  89. warn "$d missing in src/misc/crypt/crypt.c\n" and $fails++ if $cryp_c !~ /\Q$d\E/;
  90. }
  91. warn( $fails > 0 ? "check-defines: FAIL $fails\n" : "check-defines: PASS\n" );
  92. return $fails;
  93. }
  94. sub check_descriptor {
  95. my $which = shift;
  96. my $what = shift;
  97. my @src;
  98. my @descriptors;
  99. find({ wanted => sub { push @src, $_ if $_ =~ /\.c$/ }, no_chdir=>1 }, "./src/${which}/");
  100. for my $f (@src) {
  101. my @n = map { my $x = $_; $x =~ s/^.*?ltc_${what}_descriptor\s+(\S+).*$/$1/; $x } grep { $_ =~ /ltc_${what}_descriptor/ } split /\n/, read_file($f);
  102. push @descriptors, @n if @n;
  103. }
  104. my $fails = 0;
  105. for my $d (@descriptors) {
  106. for my $f ("./src/misc/crypt/crypt_register_all_${which}.c") {
  107. my $txt = read_file($f);
  108. warn "$d missing in $f\n" and $fails++ if $txt !~ /\Q$d\E/;
  109. }
  110. }
  111. for my $d (@descriptors) {
  112. for my $f ("./tests/test.c") {
  113. my $txt = read_file($f);
  114. warn "$d missing in $f\n" and $fails++ if $txt !~ /\Q$d\E/;
  115. }
  116. }
  117. my $name = sprintf("%-17s", "check-${which}:");
  118. warn( $fails > 0 ? "${name}FAIL $fails\n" : "${name}PASS\n" );
  119. return $fails;
  120. }
  121. sub check_descriptors {
  122. my $fails = 0;
  123. $fails = $fails + check_descriptor("ciphers", "cipher");
  124. $fails = $fails + check_descriptor("hashes", "hash");
  125. $fails = $fails + check_descriptor("prngs", "prng");
  126. return $fails;
  127. }
  128. sub check_comments {
  129. my $fails = 0;
  130. my $first_comment = <<'MARKER';
  131. /* LibTomCrypt, modular cryptographic library -- Tom St Denis */
  132. /* SPDX-License-Identifier: Unlicense */
  133. MARKER
  134. my @all_files;
  135. find({ wanted=> sub { push @all_files, $_ if $_ =~ /\.(c|h)$/ }, no_chdir=>1 }, 'demos', 'src', 'tests');
  136. for my $f (@all_files) {
  137. my $txt = read_file($f);
  138. if ($txt !~ /^\Q$first_comment\E/s) {
  139. warn "[first_comment] $f\n";
  140. $fails++;
  141. }
  142. }
  143. warn( $fails > 0 ? "check-comments: FAIL $fails\n" : "check-comments: PASS\n" );
  144. return $fails;
  145. }
  146. sub prepare_variable {
  147. my ($varname, @list) = @_;
  148. my $output = "$varname=";
  149. my $len = length($output);
  150. foreach my $obj (sort @list) {
  151. $len = $len + length $obj;
  152. $obj =~ s/\*/\$/;
  153. if ($len > 100) {
  154. $output .= "\\\n";
  155. $len = length $obj;
  156. }
  157. $output .= $obj . ' ';
  158. }
  159. $output =~ s/ $//;
  160. return $output;
  161. }
  162. sub prepare_msvc_files_xml {
  163. my ($all, $exclude_re, $targets) = @_;
  164. my $last = [];
  165. my $depth = 2;
  166. # sort files in the same order as visual studio (ugly, I know)
  167. my @parts = ();
  168. for my $orig (@$all) {
  169. my $p = $orig;
  170. $p =~ s|/|/~|g;
  171. $p =~ s|/~([^/]+)$|/$1|g;
  172. # now we have: 'src/pk/rsa/rsa_verify_hash.c' > 'src/~pk/~rsa/rsa_verify_hash.c'
  173. my @l = map { sprintf "% -99s", $_ } split /\//, $p;
  174. push @parts, [ $orig, join(':', @l) ];
  175. }
  176. my @sorted = map { $_->[0] } sort { $a->[1] cmp $b->[1] } @parts;
  177. my $files = "<Files>\r\n";
  178. for my $full (@sorted) {
  179. my @items = split /\//, $full; # split by '/'
  180. $full =~ s|/|\\|g; # replace '/' bt '\'
  181. shift @items; # drop first one (src)
  182. pop @items; # drop last one (filename.ext)
  183. my $current = \@items;
  184. if (join(':', @$current) ne join(':', @$last)) {
  185. my $common = 0;
  186. $common++ while ($last->[$common] && $current->[$common] && $last->[$common] eq $current->[$common]);
  187. my $back = @$last - $common;
  188. if ($back > 0) {
  189. $files .= ("\t" x --$depth) . "</Filter>\r\n" for (1..$back);
  190. }
  191. my $fwd = [ @$current ]; splice(@$fwd, 0, $common);
  192. for my $i (0..scalar(@$fwd) - 1) {
  193. $files .= ("\t" x $depth) . "<Filter\r\n";
  194. $files .= ("\t" x $depth) . "\tName=\"$fwd->[$i]\"\r\n";
  195. $files .= ("\t" x $depth) . "\t>\r\n";
  196. $depth++;
  197. }
  198. $last = $current;
  199. }
  200. $files .= ("\t" x $depth) . "<File\r\n";
  201. $files .= ("\t" x $depth) . "\tRelativePath=\"$full\"\r\n";
  202. $files .= ("\t" x $depth) . "\t>\r\n";
  203. if ($full =~ $exclude_re) {
  204. for (@$targets) {
  205. $files .= ("\t" x $depth) . "\t<FileConfiguration\r\n";
  206. $files .= ("\t" x $depth) . "\t\tName=\"$_\"\r\n";
  207. $files .= ("\t" x $depth) . "\t\tExcludedFromBuild=\"true\"\r\n";
  208. $files .= ("\t" x $depth) . "\t\t>\r\n";
  209. $files .= ("\t" x $depth) . "\t\t<Tool\r\n";
  210. $files .= ("\t" x $depth) . "\t\t\tName=\"VCCLCompilerTool\"\r\n";
  211. $files .= ("\t" x $depth) . "\t\t\tAdditionalIncludeDirectories=\"\"\r\n";
  212. $files .= ("\t" x $depth) . "\t\t\tPreprocessorDefinitions=\"\"\r\n";
  213. $files .= ("\t" x $depth) . "\t\t/>\r\n";
  214. $files .= ("\t" x $depth) . "\t</FileConfiguration>\r\n";
  215. }
  216. }
  217. ########### aes_enc "hack" disabled - discussion: https://github.com/libtom/libtomcrypt/pull/158
  218. # if ($full eq 'src\ciphers\aes\aes.c') { #hack
  219. # my %cmd = (
  220. # 'Debug|Win32' => [ 'Debug/aes.obj;Debug/aes_enc.obj', 'cl /nologo /MLd /W3 /Gm /GX /ZI /Od /I &quot;src\headers&quot; /I &quot;..\libtommath&quot; /D &quot;_DEBUG&quot; /D &quot;LTM_DESC&quot; /D &quot;WIN32&quot; /D &quot;_MBCS&quot; /D &quot;_LIB&quot; /D &quot;LTC_SOURCE&quot; /D &quot;USE_LTM&quot; /Fp&quot;Debug/libtomcrypt.pch&quot; /YX /Fo&quot;Debug/&quot; /Fd&quot;Debug/&quot; /FD /GZ /c $(InputPath)&#x0D;&#x0A;cl /nologo /DENCRYPT_ONLY /MLd /W3 /Gm /GX /ZI /Od /I &quot;src\headers&quot; /I &quot;..\libtommath&quot; /D &quot;_DEBUG&quot; /D &quot;LTM_DESC&quot; /D &quot;WIN32&quot; /D &quot;_MBCS&quot; /D &quot;_LIB&quot; /D &quot;LTC_SOURCE&quot; /D &quot;USE_LTM&quot; /Fp&quot;Debug/libtomcrypt.pch&quot; /YX /Fo&quot;Debug/aes_enc.obj&quot; /Fd&quot;Debug/&quot; /FD /GZ /c $(InputPath)&#x0D;&#x0A;' ],
  221. # 'Release|Win32' => [ 'Release/aes.obj;Release/aes_enc.obj', 'cl /nologo /MLd /W3 /Gm /GX /ZI /Od /I &quot;src\headers&quot; /I &quot;..\libtommath&quot; /D &quot;_DEBUG&quot; /D &quot;LTM_DESC&quot; /D &quot;WIN32&quot; /D &quot;_MBCS&quot; /D &quot;_LIB&quot; /D &quot;LTC_SOURCE&quot; /D &quot;USE_LTM&quot; /Fp&quot;Release/libtomcrypt.pch&quot; /YX /Fo&quot;Release/&quot; /Fd&quot;Release/&quot; /FD /GZ /c $(InputPath)&#x0D;&#x0A;cl /nologo /DENCRYPT_ONLY /MLd /W3 /Gm /GX /ZI /Od /I &quot;src\headers&quot; /I &quot;..\libtommath&quot; /D &quot;_DEBUG&quot; /D &quot;LTM_DESC&quot; /D &quot;WIN32&quot; /D &quot;_MBCS&quot; /D &quot;_LIB&quot; /D &quot;LTC_SOURCE&quot; /D &quot;USE_LTM&quot; /Fp&quot;Release/libtomcrypt.pch&quot; /YX /Fo&quot;Release/aes_enc.obj&quot; /Fd&quot;Release/&quot; /FD /GZ /c $(InputPath)&#x0D;&#x0A;' ],
  222. # );
  223. # for (@$targets) {
  224. # next unless $cmd{$_};
  225. # $files .= ("\t" x $depth) . "\t<FileConfiguration\r\n";
  226. # $files .= ("\t" x $depth) . "\t\tName=\"$_\"\r\n";
  227. # $files .= ("\t" x $depth) . "\t\t>\r\n";
  228. # $files .= ("\t" x $depth) . "\t\t<Tool\r\n";
  229. # $files .= ("\t" x $depth) . "\t\t\tName=\"VCCustomBuildTool\"\r\n";
  230. # $files .= ("\t" x $depth) . "\t\t\tCommandLine=\"$cmd{$_}[1]\"\r\n";
  231. # $files .= ("\t" x $depth) . "\t\t\tOutputs=\"$cmd{$_}[0]\"\r\n";
  232. # $files .= ("\t" x $depth) . "\t\t/>\r\n";
  233. # $files .= ("\t" x $depth) . "\t</FileConfiguration>\r\n";
  234. # }
  235. # }
  236. $files .= ("\t" x $depth) . "</File>\r\n";
  237. }
  238. $files .= ("\t" x --$depth) . "</Filter>\r\n" for (@$last);
  239. $files .= "\t</Files>";
  240. return $files;
  241. }
  242. sub patch_file {
  243. my ($content, @variables) = @_;
  244. for my $v (@variables) {
  245. if ($v =~ /^([A-Z0-9_]+)\s*=.*$/si) {
  246. my $name = $1;
  247. $content =~ s/\n\Q$name\E\b.*?[^\\]\n/\n$v\n/s;
  248. }
  249. else {
  250. die "patch_file failed: " . substr($v, 0, 30) . "..";
  251. }
  252. }
  253. return $content;
  254. }
  255. sub version_from_tomcrypt_h {
  256. my $h = read_file(shift);
  257. if ($h =~ /\n#define\s*SCRYPT\s*"([0-9]+)\.([0-9]+)\.([0-9]+)(\S*)"/s) {
  258. return "VERSION_PC=$1.$2.$3", "VERSION_LT=1:1", "VERSION=$1.$2.$3$4", "PROJECT_NUMBER=$1.$2.$3$4";
  259. }
  260. else {
  261. die "#define SCRYPT not found in tomcrypt.h";
  262. }
  263. }
  264. sub process_makefiles {
  265. my $write = shift;
  266. my $changed_count = 0;
  267. my @c = ();
  268. find({ no_chdir => 1, wanted => sub { push @c, $_ if -f $_ && $_ =~ /\.c$/ && $_ !~ /tab.c$/ } }, 'src');
  269. my @h = ();
  270. find({ no_chdir => 1, wanted => sub { push @h, $_ if -f $_ && $_ =~ /\.h$/ && $_ !~ /dh_static.h$/ && $_ !~ /tomcrypt_private.h$/ } }, 'src');
  271. my @all = ();
  272. find({ no_chdir => 1, wanted => sub { push @all, $_ if -f $_ && $_ =~ /\.(c|h)$/ } }, 'src');
  273. my @t = qw();
  274. find({ no_chdir => 1, wanted => sub { push @t, $_ if $_ =~ /(common|no_prng|_tests?|test).c$/ } }, 'tests');
  275. my @o = sort ('src/ciphers/aes/aes_enc.o', map { my $x = $_; $x =~ s/\.c$/.o/; $x } @c);
  276. my $var_o = prepare_variable("OBJECTS", @o);
  277. my $var_h = prepare_variable("HEADERS_PUB", (sort @h));
  278. (my $var_obj = $var_o) =~ s/\.o\b/.obj/sg;
  279. my $var_to = prepare_variable("TOBJECTS", sort map { my $x = $_; $x =~ s/\.c$/.o/; $x } @t);
  280. (my $var_tobj = $var_to) =~ s/\.o\b/.obj/sg;
  281. my @ver_version = version_from_tomcrypt_h("src/headers/tomcrypt.h");
  282. # update MSVC project files
  283. my $msvc_files = prepare_msvc_files_xml(\@all, qr/tab\.c$/, ['Debug|Win32', 'Release|Win32', 'Debug|x64', 'Release|x64']);
  284. for my $m (qw/libtomcrypt_VS2008.vcproj/) {
  285. my $old = read_file($m);
  286. my $new = $old;
  287. $new =~ s|<Files>.*</Files>|$msvc_files|s;
  288. if ($old ne $new) {
  289. write_file($m, $new) if $write;
  290. warn "changed: $m\n";
  291. $changed_count++;
  292. }
  293. }
  294. # update OBJECTS + HEADERS in makefile*
  295. for my $m (qw/ makefile makefile.shared makefile.unix makefile.mingw makefile.msvc makefile_include.mk doc\/Doxyfile /) {
  296. my $old = read_file($m);
  297. my $new = $m eq 'makefile.msvc' ? patch_file($old, $var_obj, $var_h, $var_tobj, @ver_version)
  298. : patch_file($old, $var_o, $var_h, $var_to, @ver_version);
  299. if ($old ne $new) {
  300. write_file($m, $new) if $write;
  301. warn "changed: $m\n";
  302. $changed_count++;
  303. }
  304. }
  305. if ($write) {
  306. return 0; # no failures
  307. }
  308. else {
  309. warn( $changed_count > 0 ? "check-makefiles: FAIL $changed_count\n" : "check-makefiles: PASS\n" );
  310. return $changed_count;
  311. }
  312. }
  313. sub die_usage {
  314. die <<"MARKER";
  315. usage: $0 -s OR $0 --check-source
  316. $0 -c OR $0 --check-descriptors
  317. $0 -d OR $0 --check-defines
  318. $0 -o OR $0 --check-comments
  319. $0 -m OR $0 --check-makefiles
  320. $0 -a OR $0 --check-all
  321. $0 -u OR $0 --update-makefiles
  322. $0 --fixupind crypt.ind
  323. MARKER
  324. }
  325. GetOptions( "s|check-source" => \my $check_source,
  326. "c|check-descriptors" => \my $check_descriptors,
  327. "d|check-defines" => \my $check_defines,
  328. "o|check-comments" => \my $check_comments,
  329. "m|check-makefiles" => \my $check_makefiles,
  330. "a|check-all" => \my $check_all,
  331. "u|update-makefiles" => \my $update_makefiles,
  332. "f|fixupind=s" => \my $fixupind,
  333. "h|help" => \my $help
  334. ) or die_usage;
  335. if ($fixupind) {
  336. my $txt = read_file($fixupind);
  337. $txt =~ s/^([^\n]*\n)/$1\n\\addcontentsline{toc}{chapter}{Index}\n/s;
  338. write_file($fixupind, $txt);
  339. exit 0;
  340. }
  341. my $failure;
  342. $failure ||= check_source() if $check_all || $check_source;
  343. $failure ||= check_defines() if $check_all || $check_defines;
  344. $failure ||= check_descriptors() if $check_all || $check_descriptors;
  345. $failure ||= check_comments() if $check_all || $check_comments;
  346. $failure ||= process_makefiles(0) if $check_all || $check_makefiles;
  347. $failure ||= process_makefiles(1) if $update_makefiles;
  348. die_usage unless defined $failure;
  349. exit $failure ? 1 : 0;
  350. # ref: $Format:%D$
  351. # git commit: $Format:%H$
  352. # commit time: $Format:%ai$