Przeglądaj źródła

2008-11-01 Sebastien Pouliot <[email protected]>

	* CmsRecipientCollection.cs: Add comment about compatibility-NRE
	[Found using Gendarme CheckParametersNullityInVisibleMethodsRule]


svn path=/trunk/mcs/; revision=117621
Sebastien Pouliot 17 lat temu
rodzic
commit
899b4184dc

+ 5 - 0
mcs/class/System.Security/System.Security.Cryptography.Pkcs/ChangeLog

@@ -1,3 +1,8 @@
+2008-11-01  Sebastien Pouliot  <[email protected]>
+
+	* CmsRecipientCollection.cs: Add comment about compatibility-NRE
+	[Found using Gendarme CheckParametersNullityInVisibleMethodsRule]
+
 2008-10-12  Sebastien Pouliot  <[email protected]>
 
 	* EnvelopedCms.cs, SignedCms.cs: Remove unneeded field 

+ 4 - 3
mcs/class/System.Security/System.Security.Cryptography.Pkcs/CmsRecipientCollection.cs

@@ -5,7 +5,7 @@
 //	Sebastien Pouliot  <[email protected]>
 //
 // (C) 2003 Motus Technologies Inc. (http://www.motus.com)
-// Copyright (C) 2004-2005 Novell, Inc (http://www.novell.com)
+// Copyright (C) 2004-2005, 2008 Novell, Inc (http://www.novell.com)
 //
 // Permission is hereby granted, free of charge, to any person obtaining
 // a copy of this software and associated documentation files (the
@@ -45,13 +45,14 @@ namespace System.Security.Cryptography.Pkcs {
 			_list = new ArrayList ();
 		}
 
-		public CmsRecipientCollection (CmsRecipient recipient) : base () 
+		public CmsRecipientCollection (CmsRecipient recipient)
 		{
 			_list.Add (recipient);
 		}
 
-		public CmsRecipientCollection (SubjectIdentifierType recipientIdentifierType, X509Certificate2Collection certificates) : base () 
+		public CmsRecipientCollection (SubjectIdentifierType recipientIdentifierType, X509Certificate2Collection certificates)
 		{
+			// no null check, MS throws a NullReferenceException here
 			foreach (X509Certificate2 x509 in certificates) {
 				CmsRecipient p7r = new CmsRecipient (recipientIdentifierType, x509);
 				_list.Add (p7r);