Refactoring: ensure proper cleanup

svn path=/trunk/mcs/; revision=76599

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbCommand/OleDbCommand_ExecuteReader.cs

@@ -203,11 +203,11 @@ namespace MonoTests.System.Data.OleDb
 				finally
 				{
 					if (rdr != null) rdr.Close();
-					EndCase(exp); 
-					exp = null;
 					//cleanup db:
 					OleDbCommand cleanup = new OleDbCommand("DELETE FROM Categories WHERE CategoryName='__TEST_RECORD__'", con);
 					cleanup.ExecuteNonQuery();
+					EndCase(exp); 
+					exp = null;
 				}
 			}
 
@@ -431,10 +431,10 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
 				if (reader != null) reader.Close();
 				tr.Commit();
 				con.Close();
+				EndCase(exp);
 			}
 		}
 		[Test]

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbCommand/OleDbCommand_Parameters.cs

@@ -128,9 +128,9 @@ namespace MonoTests.System.Data.OleDb
 				}
 				finally
 				{
+					currentlyTested.ExecuteDelete(rowId);
 					EndCase(exp);
 					exp = null;
-					currentlyTested.ExecuteDelete(rowId);
 				}
 			}
 		}
@@ -174,10 +174,10 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
-				exp = null;
 				DbTypeParametersCollection.ExecuteDelete(ConnectedDataProvider.EXTENDED_TYPES_TABLE_NAME, rowId);
 				conn.Close();
+				EndCase(exp);
+				exp = null;
 			}
 
 		}
@@ -214,10 +214,10 @@ namespace MonoTests.System.Data.OleDb
 				exp = ex;
 			}
 			finally {
-				EndCase(exp);
-				exp = null;
 				DbTypeParametersCollection.ExecuteDelete(ConnectedDataProvider.EXTENDED_TYPES_TABLE_NAME, rowId);
 				conn.Close();
+				EndCase(exp);
+				exp = null;
 			}
 		}
 	}

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbConnection/OleDbConnection_ConnectionString.cs

@@ -116,12 +116,12 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
-				exp=null;
 				if (con != null && con.State == ConnectionState.Open)
 				{
 					con.Close();
 				}
+				EndCase(exp);
+				exp=null;
 			}
 		}
 
@@ -197,12 +197,12 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
-				exp = null;
 				if (con != null && con.State != ConnectionState.Closed)
 				{
 					con.Close();
 				}
+				EndCase(exp);
+				exp = null;
 			}
 		}
 		#endregion

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbDataReader/OleDbDataReader_GetDateTime.cs

@@ -93,7 +93,6 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp); 
 				if (rdr != null && !rdr.IsClosed)
 				{
 					rdr.Close();
@@ -102,6 +101,7 @@ namespace MonoTests.System.Data.OleDb
 				{
 					con.Close();
 				}
+				EndCase(exp); 
 				exp = null;
 			}
 		}
@@ -140,7 +140,6 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
 				if (rdr != null && !rdr.IsClosed)
 				{
 					rdr.Close();
@@ -149,6 +148,7 @@ namespace MonoTests.System.Data.OleDb
 				{
 					con.Close();
 				}
+				EndCase(exp);
 			}
 		}
 		

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbDataReader/OleDbDataReader_GetGuiid_I.cs

@@ -101,8 +101,6 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
-				exp = null;
 				if ( (rdr != null) && (!rdr.IsClosed) )
 				{
 					rdr.Close();
@@ -115,6 +113,8 @@ namespace MonoTests.System.Data.OleDb
 				{
 					con.Close();
 				}
+				EndCase(exp);
+				exp = null;
 			}
 		}
 
@@ -148,8 +148,6 @@ namespace MonoTests.System.Data.OleDb
 			}
 			finally
 			{
-				EndCase(exp);
-				exp = null;
 				if ( (rdr != null) && (!rdr.IsClosed) )
 				{
 					rdr.Close();
@@ -162,6 +160,8 @@ namespace MonoTests.System.Data.OleDb
 				{
 					con.Close();
 				}
+				EndCase(exp);
+				exp = null;
 				
 			}
 		}

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbDataReader/OleDbDataReader_GetValue.cs

@@ -154,8 +154,6 @@ namespace MonoTests.System.Data.OleDb
 				}
 				finally
 				{
-					EndCase(exp);
-					exp = null;
 					if (rdr != null && !rdr.IsClosed)
 					{
 						rdr.Close();
@@ -165,6 +163,8 @@ namespace MonoTests.System.Data.OleDb
 						selectCon.Close();
 					}
 					currentlyTested.ExecuteDelete(rowId);
+					EndCase(exp);
+					exp = null;
 				}
 			}
 		}

mcs/class/System.Data/Test/ProviderTests/System.Data.OleDb.jvm/OleDbParameter/OleDbParameter_ctor_SOtype.cs

@@ -150,7 +150,6 @@ public class OleDbParameter_ctor_SOtype : ADONetTesterClass
 		}
 		finally
 		{
-			EndCase(exp);
 			if(rdr != null && !rdr.IsClosed)
 			{
 				rdr.Close();
@@ -159,6 +158,7 @@ public class OleDbParameter_ctor_SOtype : ADONetTesterClass
 			{
 				con.Close();
 			}
+			EndCase(exp);
 			exp=null;
 		}
 	}