ChangeLog 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587
  1. 2008-05-14 Sebastien Pouliot <[email protected]>
  2. * EncoderParameters.cs: Don't downcast an IntPtr to an Int32.
  3. [Found using Gendarme]
  4. 2007-12-13 Vladimir Krasnov <[email protected]>
  5. * ImageCodec.jvm.cs: fixed bitmap resolution
  6. 2007-11-05 Sebastien Pouliot <[email protected]>
  7. * Metafile.cs: Stream position is not moved for metafiles.
  8. 2007-05-30 Sebastien Pouliot <[email protected]>
  9. * ImageAttributes.cs: Remove TODO for ColorMatrixFlags and Gray
  10. ColorMatrix support methods. Add TODO on some stuff not supported by
  11. libgdiplus (so MoMA reports gets more accurate). Fix coding style.
  12. 2007-05-09 Igor Zelmanovich <[email protected]>
  13. * EncoderParameter.jvm.cs: removed destructor,
  14. Dispose doesn't throw exception.
  15. 2007-04-26 Sebastien Pouliot <[email protected]>
  16. * Metafile.cs: Reduce size by reusing more complex ctors. Add Linux
  17. support to metafile recoding with the new delegate-based functions.
  18. 2007-04-26 Sebastien Pouliot <[email protected]>
  19. * Metafile.cs: Complete all ctors (except for stream-based one outside
  20. Windows) with calls into GDI+.
  21. 2007-03-28 Sebastien Pouliot <[email protected]>
  22. * MetaHeader.cs: Make workaround (#81254) permanent and return correct
  23. values on big endian architectures.
  24. 2007-03-28 Sebastien Pouliot <[email protected]>
  25. * MetaHeader.cs: Workaround bug #81254 where the SPARC architecture
  26. can't use the misaligned integer in the structure (with Pack=2).
  27. 2007-03-14 Sebastien Pouliot <[email protected]>
  28. * MetafileHeader.cs: WmfHeader is available on non-placeable WMF too.
  29. 2007-03-09 Sebastien Pouliot <[email protected]>
  30. * MetafileHeader.cs: WmfHeader throws if the metafile isn't a WMF (e.g.
  31. EMF, EMF+ or EMF dual).
  32. 2007-03-09 Sebastien Pouliot <[email protected]>
  33. * MetafileHeader.cs: Fix offset to match correct C definition.
  34. 2007-02-21 Sebastien Pouliot <[email protected]>
  35. * Metafile.cs: Implement a few cases required to playback metafiles.
  36. * MetafileHeader.cs: Implemented.
  37. * MetaHeader.cs: Implemented.
  38. * WmfPlaceableFileHeader.cs: Adjust packing.
  39. 2007-01-12 Sebastien Pouliot <[email protected]>
  40. * ImageAttribute.cs: Reuse code in SetColorMatrix overloads.
  41. 2007-01-08 Sebastien Pouliot <[email protected]>
  42. * ImageCodecInfo.cs: Remove MonoTODO on SignaturePatterns.
  43. 2006-11-22 Sebastien Pouliot <[email protected]>
  44. * ImageAttributes.cs: Better MonoTODO description.
  45. * ImageCodecInfo.cs: Add MonoTODO description.
  46. * Metafile.cs: Use a single MonoTODO on the class itself. MoMA will
  47. detect and report that every ctors/methods/properties are throwing
  48. NotImplementedException.
  49. * MetafileHeader.cs: Use a single MonoTODO on the class itself. MoMA
  50. will detect and report that every ctors/methods/properties are
  51. throwing NotImplementedException.
  52. 2006-10-31 Sebastien Pouliot <[email protected]>
  53. * MetaHeader.cs: Fix layout (order is important in sequential structs)
  54. and use the struct field names;
  55. * WmfPlaceableFileHeader.cs: Implement all TODO.
  56. 2006-09-14 Sebastien Pouliot <[email protected]>
  57. * BitmapData.cs: Change fields visibility to private as they either
  58. have get/set properties or shouldn't be used in managed code (as they
  59. do not exists when using MS GDI+). Added more warnings comments.
  60. 2006-09-01 Sebastien Pouliot <[email protected]>
  61. * BitmapData.cs: Invert left and top fields to be in sync with gdip.h
  62. 2006-08-25 Sebastien Pouliot <[email protected]>
  63. * ColorMatrix.cs: Add Alloc and Free method helpers for interop.
  64. * ImageAttributes.cs: Fix all methods accepting a ColorMatrix (i.e.
  65. which calls GdipSetImageAttributesColorMatrix) to use IntPtr instead
  66. of the ColorMatrix itself.
  67. 2006-07-19 Sebastien Pouliot <[email protected]>
  68. * ImageFormat.cs: Re-fixed ToString method to match MS output when
  69. the ImageFormat instance comes from the static properties. Create the
  70. default ImageFormat on demand (and avoid creating 10 instances of
  71. ImageFormat in the static ctor).
  72. 2006-05-30 Sebastien Pouliot <[email protected]>
  73. * ImageFormat.cs: Avoid double-cast in Equals method.
  74. 2006-05-24 Sebastien Pouliot <[email protected]>
  75. * ImageFormat.cs: Fixed ToString method to match MS output.
  76. 2006-05-21 Sebastien Pouliot <[email protected]>
  77. * ColorAdjustType.cs: Removed [Serializable] from 2.0 profile.
  78. * ColorChannelFlag.cs: Removed [Serializable] from 2.0 profile.
  79. * ColorMapType.cs: Removed [Serializable] from 2.0 profile.
  80. * ColorMatrixFlag.cs: Removed [Serializable] from 2.0 profile.
  81. * ColorMode.cs: Removed [Serializable] from 2.0 profile.
  82. * EmfPlusRecordType.cs: Removed [Serializable] from 2.0 profile.
  83. * EmfType.cs: Removed [Serializable] from 2.0 profile.
  84. * EncoderParameterValueType.cs: Removed [Serializable] from 2.0
  85. profile.
  86. * EncoderValue.cs: Removed [Serializable] from 2.0 profile.
  87. * ImageCodecFlags.cs: Removed [Serializable] from 2.0 profile.
  88. * ImageCodecInfo.cs: Removed [Serializable] from 2.0 profile.
  89. * ImageFlags.cs: Removed [Serializable] from 2.0 profile.
  90. * ImageLockMode.cs: Removed [Serializable] from 2.0 profile.
  91. * Metafile.cs: Removed [Serializable] from 2.0 profile.
  92. * MetafileFrameUnit.cs: Removed [Serializable] from 2.0 profile.
  93. * MetafileType.cs: Removed [Serializable] from 2.0 profile.
  94. * PixelFormat.cs: Removed [Serializable] from 2.0 profile.
  95. * PlayRecordCallback.cs: Removed [Serializable] from 2.0 profile.
  96. 2006-05-05 Sebastien Pouliot <[email protected]>
  97. * PaletteFlags.cs: corcompare fixes for 2.0. Add [Flags] and remove
  98. [Serializable]
  99. 2006-04-20 Peter Dennis Bartok <[email protected]>
  100. * BitmapData.cs: Updated to match the BitmapData structure
  101. from libgdiplus r59689.
  102. 2006-04-19 Peter Dennis Bartok <[email protected]>
  103. * BitmapData.cs: Updated to match the BitmapData structure
  104. from libgdiplus r59661.
  105. 2006-04-03 Gonzalo Paniagua Javier <[email protected]>
  106. * ImageAttributes.cs: SetColorKey(color, color) now calls the
  107. color,color,ColorAdjustType.
  108. 2006-02-09 Peter Dennis Bartok <[email protected]>
  109. * ColorPalette.cs, EncoderParameters.cs, EncoderParameter.cs,
  110. ImageAttributes.cs: 64bit cleanup and some simplifications
  111. 2006-01-27 Sebastien Pouliot <[email protected]>
  112. * ImageAttributes.cs: Ensure Marshal.FreeHGlobal is called for all
  113. unmanaged memory allocated with AllocHGlobal.
  114. * ImageCodecInfo.cs: Ensure Marshal.FreeHGlobal is called for all
  115. unmanaged memory allocated with AllocHGlobal.
  116. 2005-11-23 Vladimir Krasnov <[email protected]>
  117. * ImageCodec.jvm.cs: fixed ProcessOneCodec, sometime it was failed
  118. on parsing version of codec
  119. 2005-11-17 Vladimir Krasnov <[email protected]>
  120. * ImageCodec.jvm.cs: fixed WriteImage, removed flush
  121. of native output
  122. 2005-11-17 Raja R Harinath <[email protected]>
  123. * ColorMatrix.cs: Make it have Sequential layout.
  124. 2005-11-16 Konstantin Triger <[email protected]>
  125. * ImageCodec.jvm.cs: refactoring.
  126. 2005-11-14 Vladimir Krasnov <[email protected]>
  127. * ImageCodec.jvm.cs: Fixed error handling in codecs emumeration flow
  128. 2005-11-13 Kornél Pál <[email protected]>
  129. * ImageFormat.cs: Fixed ToString to use this.Equals to reflect argument
  130. changes to ImageFormat objects. Added Exif and Icon strings to ToString
  131. and reordered formats to match declaration.
  132. 2005-11-13 Konstantin Triger <[email protected]>
  133. * ImageCodec.jvm.cs: throw an exception if codec is not found.
  134. 2005-10-31 Jordi Mas i Hernandez <[email protected]>
  135. * ImageFormat.cs: Fixes ToString method
  136. 2005-09-27 Vladimir Krasnov <[email protected]>
  137. * ImageCodec.jvm.cs: implemented IDsposable,
  138. fixed NativeReader, NativeWriter, NativeStream
  139. 2005-10-20 Konstantin Triger <[email protected]>
  140. * Metafile.jvm.cs: implement abstact Clone
  141. 2005-10-04 Peter Dennis Bartok <[email protected]>
  142. * EncoderParameter.cs, EncoderParameters.cs: Calling GC.SuppressFinalize
  143. from the Dispose method; fixes bug #76329
  144. 2005-09-21 Vladimir Krasnov <[email protected]>
  145. * ImageCodec.jvm.cs: refactoring of read/write methods, members access levels
  146. 2005-09-14 Vladimir Krasnov <[email protected]>
  147. * ImageCodecInfo.jvm.cs: fixed ImageCodec namespace
  148. * ImageCodec.jvm.cs: refactoring of read/write methods
  149. 2005-09-07 Vladimir Krasnov <[email protected]>
  150. * ImageCodecInfo.jvm.cs: fixed GetValueFromMetadata, SetResolution
  151. 2005-09-07 Vladimir Krasnov <[email protected]>
  152. * ImageCodecInfo.jvm.cs: Refactoring
  153. * Added ImageCodec.jvm.cs
  154. 2005-08-28 Vladimir Krasnov <[email protected]>
  155. * ImageCodecInfo.jvm.cs: Fixed Iterate
  156. 2005-08-03 Andrew Skiba <[email protected]>
  157. * ImageCodecInfo.jvm.cs: implement via java imageio, add internal APIs for
  158. fast read-only requests
  159. * Methafile.jvm.cs: change in not implemented api to match image.jvm.cs
  160. 2005-08-03 Andrew Skiba <[email protected]>
  161. * Metafile.jvm.cs: add TARGET_JVM implementation
  162. 2005-08-03 Andrew Skiba <[email protected]>
  163. * ColorPalette.cs, FrameDimension.cs, EncoderParameters.cs: TARGET_JVM
  164. exclude not supported internal methods
  165. * EncoderParameter.jvm.cs, ImageAttributes.jvm.cs, ImageFormat.jvm.cs,
  166. ImageCodecInfo.jvm.cs: added TARGET_JVM implementation of these classes
  167. 2005-03-23 Jordi Mas i Hernandez <[email protected]>
  168. * ColorPalette.cs: fixes ColorPalette marshaling
  169. 2004-03-21 Jordi Mas i Hernadez <[email protected]>
  170. * ColorMatrix.cs: fixes Matrix00 init
  171. * ImageAttributes.cs: fixes dispose method and signature
  172. 2004-02-25 Jordi Mas i Hernadez <[email protected]>
  173. * ColorMatrix.cs: rewritten to be able to marshall it properly
  174. 2004-12-27 Zoltan Varga <[email protected]>
  175. * ImageCodecInfo.cs: Fix marshalling of arrays on amd64.
  176. 2004-11-25 Marek Safar <[email protected]>
  177. * ColorPalette.cs: Add CheckStatus to GetAdjustedPalette.
  178. 2004-11-03 Miguel de Icaza <[email protected]>
  179. * ColorPalette.cs: Add internal Clone method
  180. 2004-10-08 Ravindra <[email protected]>
  181. * BitmapData.cs: Synchronized the class with BitmapData struct
  182. in libgdiplus.
  183. 2004-06-13 Gert Driesen <[email protected]>
  184. * EmfPlusRecordType.cs: fixed mismatches in enum field values
  185. 2004-05-18 Jordi Mas i Hernadez <[email protected]>
  186. * ImageAttributes.cs: SetBrushRemapTable and SetRemapTable were
  187. passing bad parameters to GDI+ causing them not to work
  188. 2004-05-16 Gert Driesen ([email protected])
  189. * EncoderParameterValueType.cs: fix Windows build (CSC),
  190. MCS bug #58571
  191. * EncoderParameter.cs: removed ctors taking int value,
  192. to fix public API
  193. 2004-05-14 Vladimir Vukicevic <[email protected]>
  194. * EncoderParameters.cs: Added ToNativePtr() method to marshal
  195. struct correctly to a native struct. Resulting data should be
  196. FreeHGlobal'd when finished.
  197. * EncoderParameter.cs: Changed data storage to correspond to
  198. native code layout (so we can pass these structs directly to
  199. native code). Also changed layout to match native layout.
  200. * EncoderParameterValueType.cs: force EncoderParameterValueType to
  201. be Int32
  202. 2004-05-13 Jordi Mas i Hernadez <[email protected]>
  203. * ColorMatrix.cs:Make private data private
  204. * ColorPalette.cs: Make private data private
  205. * Encoder.cs: Make private data private
  206. * EncoderParameter.cs: Make private data private
  207. * EncoderParameters.cs: Make private data private
  208. * MetaHeader.cs: Make private data private
  209. * PropertyItem.cs: Make private data private
  210. 2004-05-04 Vladimir Vukicevic <[email protected]>
  211. * BitmapData.cs: re-synchronized with libgdiplus; also
  212. removed memory deallocs here (as the data is always owned
  213. by libgdiplus)
  214. 2004-04-28 Sanjay Gupta <[email protected]>
  215. Modified files from dos2unix format.
  216. 2004-04-27 Ravindra <[email protected]>
  217. * ImageAttributes.cs: Implemented SetWrapMode(WrapMode) method.
  218. 2004-04-27 Jordi Mas i Hernadez <[email protected]>
  219. * ImageFormat.cs: completed missimg members
  220. * ImageCodecInfo.cs: Use GDI+ calls instead of native C#
  221. 2004-04-27 Sanjay Gupta <[email protected]>
  222. * ImageFormat.cs: Implemented Equals() method.
  223. 2004-04-27 Sanjay Gupta <[email protected]>
  224. * ImageFormat.cs: Implemented ToString() method.
  225. 2004-04-06 Vladimir Vukicevic <[email protected]>
  226. * BitmapData.cs: synced up data structure with libgdiplus
  227. * BmpCodec.cs, JPEGCodec.cs, PNGCodec.cs: Removed codec impls,
  228. left just codecinfo getters; the codecs are in libgdiplus
  229. * ImageCodecInfo.cs: removed encode/decode delegates
  230. 2004-03-31 Jordi Mas i Hernadez <[email protected]>
  231. * FrameDimension.cs: added missing members
  232. 2004-03-26 Jordi Mas i Hernadez <[email protected]>
  233. * ImageAttributes.cs: added missing members and complete the wrapper
  234. 2004-03-04 Jordi Mas i Hernadez <[email protected]>
  235. * BmpCodec.cs: fixes DPI in BMP
  236. * Image.cs: gets DPI using GDI+ api
  237. 2004-03-04 Jordi Mas i Hernadez <[email protected]>
  238. * BmpCodec.cs
  239. Added support for diffent formats
  240. Fixed bugs in import and export
  241. Support for OS/2 and palettes
  242. * Image.cs
  243. Palettes
  244. 2004-03-04 Sanjay Gupta <[email protected]>
  245. * Metafile.cs: Added constructor with correct signature.
  246. 2004-03-04 Nick Drochak <[email protected]>
  247. * Metafile.cs: Fix build, remove duplicate member.
  248. 2004-03-03 Sanjay Gupta <[email protected]>
  249. *ImageAttributes.cs: Added few missing functions
  250. *Metafile.cs: Added stubs for missing constructors and functions
  251. 2004-03-03 Nick Drochak <[email protected]>
  252. * BmpCodec.cs: Remove unsed variable.
  253. 2004-02-17 Ravindra <[email protected]>
  254. * EncoderParameter.cs: Did few bug fixes and changed the file
  255. format to unix.
  256. 2004-02-13 Sanjay Gupta <[email protected]>
  257. * FrameDimension.cs: Implemented missing functionalities
  258. 2004-02-12 Ravindra <[email protected]>
  259. * EncoderParameters.cs: Implemented.
  260. * EncoderParameter.cs: Implemented.
  261. 2004-01-21 Jordi Mas i Hernàdez <[email protected]>
  262. * BmpBitmap.cs: fixed encoding and decoding problems
  263. * ImageAttributes.cs: implemented
  264. 2004-01-19 Ravindra <[email protected]>
  265. * Encoder.cs: Implemented.
  266. 2004-01-10 Ravindra <[email protected]>
  267. * All Enums: Made serializable.
  268. * ImageAttributes.cs: Implements ICloneable.
  269. * Metafile.cs: Made serializable and invisible to COM.
  270. 2003-11-13 Andreas Nahr <[email protected]>
  271. * ColorMap.cs: Implemented
  272. * ColorMatrix.cs: Implemented, Removed unneccesary members
  273. * ImageAttributes.cs: Fixed signature
  274. * ImageCodecInfo.cs: Added missing attribure, hide constructor
  275. * ImageFormat.cs: Implemented, Added attribute
  276. * MetaHeader.cs: Implemented
  277. * PropertyItem.cs: Implemented
  278. * ImageFlags.cs: Added Attribute
  279. * ImageCodecFlags.cs: Added Attribute
  280. * EmfPlusRecordType.cs: Added missing members
  281. 2003-11-12 Alexandre Pigolkine <[email protected]>
  282. * BitmapData.cs new function to convert BRG to RGB
  283. * JPEGCodec.cs convert BRG to RBG
  284. * PNGCodec.cs
  285. 2003-11-02 Alexandre Pigolkine <[email protected]>
  286. * BmpCodec.cs
  287. * ImageCodecInfo.cs
  288. * JPEGCodec.cs
  289. * PNGCodec.cs
  290. codec can select pixel format of bitmap
  291. 2003-10-23 Miguel de Icaza <[email protected]>
  292. * JPEGCodec.cs (JSAMPARRAY): Do not allocate memory here anymore,
  293. we will just have the JPEG library copy directly into our buffer.
  294. (Encode, Decode): Ported to the new model which avoid copies, and
  295. eliminates InternalImageInfo.
  296. TODO: need to port the PNG coder/decoder, and add support for RGBA
  297. images which got dropped from this version
  298. * BmpCodec.cs: Rework this one to use BitmapData and Image. Do
  299. not use the RawBytes property, instead pull the data one line at a
  300. time, and write that out.
  301. * ImageCodecInfo.cs: Make the encoding and decoding delegates take
  302. a Image parameter;
  303. * BmpCodec.cs:
  304. * BitmapData.cs: Make this one sequential, and also mimic the
  305. layout of GdiPlus.h so we can use this instead of making copies
  306. back and forth.
  307. 2003-10-12 Alexandre Pigolkine
  308. * BmpCodec.cs warning removed
  309. 2003-07-23 Alexandre Pigolkine
  310. * JPEGCodec.cs
  311. * PNGCodec.cs
  312. * BmpCodec.cs cosmetic changes
  313. 2003-07-22 Alexandre Pigolkine
  314. * ImageCodecInfo.cs
  315. * ImageFormat.cs
  316. * JPEGCodec.cs
  317. changes for PNG codec
  318. * PNGCodec.cs added
  319. 2003-07-21 Andreas Nahr <[email protected]>
  320. * Metafile.cs: Inherits from image (fix for System.Drawing.Design)
  321. 2003-06-29 Alexandre Pigolkine
  322. * BmpCodec.cs handle 32bpp images
  323. * JPEGCodec.cs small fix
  324. 2003-06-27 Alexandre Pigolkine <[email protected]>
  325. * JPEGCodec.cs encode 32 bpp images
  326. 2003-06-23 Alexandre Pigolkine <[email protected]>
  327. * JPEGCodec.cs set pixel format in InternalImageInfo
  328. 2003-06-23 Alexandre Pigolkine <[email protected]>
  329. * BmpCodec.cs pixel format check added
  330. * JPEGCodec.cs encoder implemented
  331. 2003-06-15 Alexandre Pigolkine <[email protected]>
  332. * ColorPalette.cs
  333. * ImageCodecInfo.cs
  334. * ImageFormat.cs
  335. implementation added
  336. * BmpCodec.cs
  337. * JPEGCodec.cs
  338. added
  339. 2002-9-2 DennisHayes <[email protected]>
  340. * PropertyItem.cs t
  341. * MetaHeader.cs t
  342. * MetafileHeader.cs t
  343. * Metafile.cs t
  344. * ImageFormat.cs t
  345. * ImageCodecInfo.cs t
  346. * ColorMatrix.cs t
  347. * ColorMap.cs t
  348. * WmfPlaceableFileHeader.cs t
  349. * Added todos back
  350. 2002-9-2 DennisHayes <[email protected]>
  351. * checked in for Everaldo Canuto (everaldo.canuto@bol,com.br)
  352. * BitmapData.cs
  353. * ColorAdjustType.cs
  354. * ColorChannelFlag.cs
  355. * ColorMap.cs
  356. * ColorMapType.cs
  357. * ColorMatrix.cs
  358. * ColorMatrixFlag.cs
  359. * ColorMode.cs
  360. * EmfPlusRecordType.cs
  361. * EmfType.cs
  362. * EncoderParameterValueType.cs
  363. * EncoderValue.cs
  364. * ImageCodecFlags.cs
  365. * ImageCodecInfo.cs
  366. * ImageFlags.cs
  367. * ImageFormat.cs
  368. * ImageLockMode.cs
  369. * MetafileFrameUnit.cs
  370. * MetafileHeader.cs
  371. * MetaHeader.cs
  372. * PaletteFlags.cs
  373. * PixelFormat.cs
  374. * PlayRecordCallback.cs
  375. * PropertyItem.cs
  376. * WmfPlaceableFileHeader.cs
  377. * Added null classes for most/all classes, Many stubs, and some implmentation
  378. 2002-9-2 DennisHayes <[email protected]>
  379. * ColorPalette.cs
  380. * FrameDimension.cs
  381. * Metafile.cs
  382. * Added stubs, implmentation
  383. 2002-05-03 Mike Kestner <[email protected]>
  384. * Metafile.cs : Use System.IO. Fix exception typos.
  385. 2002-04-27 Christian Meyer <[email protected]>
  386. * Metafile.cs: Copyright now holds Ximian.
  387. 2002-04-21 Dennis Hayes <[email protected]>
  388. * corrected emum values.
  389. 2002-04-14 Christian Meyer <[email protected]>
  390. * ChangeLog: created.
  391. * Metafile.cs: Added. Wrote some ctors. No impl done, yet.