Browse Source

Merge pull request #4702 from flysand7/4632-futex-windows

[sync]: Fix typos in comments and remove my note.
Laytan 7 months ago
parent
commit
16eca1ded1
2 changed files with 2 additions and 5 deletions
  1. 0 3
      core/sync/futex_linux.odin
  2. 2 2
      core/sync/futex_windows.odin

+ 0 - 3
core/sync/futex_linux.odin

@@ -49,9 +49,6 @@ _futex_signal :: proc "contextless" (futex: ^Futex) {
 }
 
 _futex_broadcast :: proc "contextless" (futex: ^Futex)  {
-	// NOTE(flysand): This code was kinda funny and I don't want to remove it, but here I will
-	// record history of what has been in here before
-	//     FUTEX_WAKE_PRIVATE | FUTEX_WAKE
 	_, errno := linux.futex(cast(^linux.Futex) futex, linux.FUTEX_WAKE, {.PRIVATE}, max(i32))
 	#partial switch errno {
 	case .NONE:

+ 2 - 2
core/sync/futex_windows.odin

@@ -26,7 +26,7 @@ foreign Ntdll {
 	BUT requires taking the return value of it and if it is non-zero
 	converting that status to a DOS error and then SetLastError
 	If this is not done, then things don't work as expected when
-	and error occurs
+	an error occurs
 
 	GODDAMN MICROSOFT!
 */
@@ -46,7 +46,7 @@ _futex_wait :: proc "contextless" (f: ^Futex, expect: u32) -> bool {
 
 _futex_wait_with_timeout :: proc "contextless" (f: ^Futex, expect: u32, duration: time.Duration) -> bool {
 	expect := expect
-	// NOTE(bill): for some bizarre reason, this has be a negative number
+	// NOTE(bill): for some bizarre reason, this has to be a negative number
 	timeout := -i64(duration / 100)
 	return CustomWaitOnAddress(f, &expect, size_of(expect), &timeout)
 }