Browse Source

Add error requiring an explicit calling convention for foreign procedures

gingerBill 2 years ago
parent
commit
24ed07b6d5
3 changed files with 11 additions and 3 deletions
  1. 1 1
      core/runtime/os_specific_js.odin
  2. 2 2
      core/runtime/procs_wasm32.odin
  3. 8 0
      src/checker.cpp

+ 1 - 1
core/runtime/os_specific_js.odin

@@ -5,7 +5,7 @@ foreign import "odin_env"
 
 _os_write :: proc "contextless" (data: []byte) -> (int, _OS_Errno) {
 	foreign odin_env {
-		write :: proc "c" (fd: u32, p: []byte) ---
+		write :: proc "contextless" (fd: u32, p: []byte) ---
 	}
 	write(1, data)
 	return len(data), 0

+ 2 - 2
core/runtime/procs_wasm32.odin

@@ -8,7 +8,7 @@ ti_int :: struct #raw_union {
 }
 
 @(link_name="__ashlti3", linkage="strong")
-__ashlti3 :: proc "c" (a: i128, b_: u32) -> i128 {
+__ashlti3 :: proc "contextless" (a: i128, b_: u32) -> i128 {
 	bits_in_dword :: size_of(u32)*8
 	b := u32(b_)
 	
@@ -29,7 +29,7 @@ __ashlti3 :: proc "c" (a: i128, b_: u32) -> i128 {
 
 
 @(link_name="__multi3", linkage="strong")
-__multi3 :: proc "c" (a, b: i128) -> i128 {
+__multi3 :: proc "contextless" (a, b: i128) -> i128 {
 	x, y, r: ti_int
 	
 	x.all = a

+ 8 - 0
src/checker.cpp

@@ -3889,6 +3889,14 @@ gb_internal void check_collect_value_decl(CheckerContext *c, Ast *decl) {
 					GB_ASSERT(pl->type->kind == Ast_ProcType);
 					auto cc = pl->type->ProcType.calling_convention;
 					if (cc == ProcCC_ForeignBlockDefault) {
+						if (is_arch_wasm()) {
+							begin_error_block();
+							error(init, "For wasm related targets, it is required that you either define the"
+							            " @(default_calling_convention=<string>) on the foreign block or"
+							            " explicitly assign it on the procedure signature");
+							error_line("\tSuggestion: when dealing with normal Odin code (e.g. js_wasm32), use \"contextless\"; when dealing with Emscripten like code, use \"c\"\n");
+							end_error_block();
+						}
 						cc = ProcCC_CDecl;
 						if (c->foreign_context.default_cc > 0) {
 							cc = c->foreign_context.default_cc;