Browse Source

Err on types passed as operands to ternary if expressions

JasperGeer 2 years ago
parent
commit
2e3dd8dd0b
1 changed files with 14 additions and 0 deletions
  1. 14 0
      src/check_expr.cpp

+ 14 - 0
src/check_expr.cpp

@@ -7347,6 +7347,13 @@ ExprKind check_ternary_if_expr(CheckerContext *c, Operand *o, Ast *node, Type *t
 	check_expr_or_type(c, &x, te->x, type_hint);
 	node->viral_state_flags |= te->x->viral_state_flags;
 
+    if (x.mode == Addressing_Type || x.mode == Addressing_Type) {
+        gbString type_string = expr_to_string(x.expr);
+        error(node, "Type %s is invalid operand for ternary if expression", type_string);
+        gb_string_free(type_string);
+        return kind;
+    }
+
 	if (te->y != nullptr) {
 		Type *th = type_hint;
 		if (type_hint == nullptr && is_type_typed(x.type)) {
@@ -7359,6 +7366,13 @@ ExprKind check_ternary_if_expr(CheckerContext *c, Operand *o, Ast *node, Type *t
 		return kind;
 	}
 
+    if (y.mode == Addressing_Type || y.mode == Addressing_Type) {
+        gbString type_string = expr_to_string(y.expr);
+        error(node, "Type %s is invalid operand for ternary if expression", type_string);
+        gb_string_free(type_string);
+        return kind;
+    }
+
 	if (x.type == nullptr || x.type == t_invalid ||
 	    y.type == nullptr || y.type == t_invalid) {
 		return kind;