2
0
Эх сурвалжийг харах

Fix potential bad optimization bug in sync.Ticket_Mutex

When locking, we were not loading m.serving atomically and so the optimizer
could have hoisted the check out of the loop, thus resulting in an infinite loop.
Tetralux 5 жил өмнө
parent
commit
3afa2736b7
1 өөрчлөгдсөн 1 нэмэгдсэн , 1 устгасан
  1. 1 1
      core/sync/sync.odin

+ 1 - 1
core/sync/sync.odin

@@ -17,7 +17,7 @@ ticket_mutex_init :: proc(m: ^Ticket_Mutex) {
 
 ticket_mutex_lock :: inline proc(m: ^Ticket_Mutex) {
 	ticket := atomic_add(&m.ticket, 1, .Relaxed);
-	for ticket != m.serving {
+	for ticket != atomic_load(&m.serving, .Acquire) {
 		yield_processor();
 	}
 }