Browse Source

Replace `panic(fmt.tprintf(` antipattern with `fmt.panicf`

gingerBill 1 year ago
parent
commit
3ff8952813
3 changed files with 4 additions and 4 deletions
  1. 2 2
      core/crypto/rand_darwin.odin
  2. 1 1
      core/crypto/rand_linux.odin
  3. 1 1
      core/crypto/rand_windows.odin

+ 2 - 2
core/crypto/rand_darwin.odin

@@ -11,7 +11,7 @@ HAS_RAND_BYTES :: true
 _rand_bytes :: proc(dst: []byte) {
 	err := Sec.RandomCopyBytes(count=len(dst), bytes=raw_data(dst))
 	if err != .Success {
-        msg := CF.StringCopyToOdinString(Sec.CopyErrorMessageString(err))
-        panic(fmt.tprintf("crypto/rand_bytes: SecRandomCopyBytes returned non-zero result: %v %s", err, msg))
+	        msg := CF.StringCopyToOdinString(Sec.CopyErrorMessageString(err))
+	        fmt.panicf("crypto/rand_bytes: SecRandomCopyBytes returned non-zero result: %v %s", err, msg)
 	}
 }

+ 1 - 1
core/crypto/rand_linux.odin

@@ -32,7 +32,7 @@ _rand_bytes :: proc (dst: []byte) {
 			// All other failures are things that should NEVER happen
 			// unless the kernel interface changes (ie: the Linux
 			// developers break userland).
-			panic(fmt.tprintf("crypto: getrandom failed: %v", errno))
+			fmt.panicf("crypto: getrandom failed: %v", errno)
 		}
 		l -= n_read
 		dst = dst[n_read:]

+ 1 - 1
core/crypto/rand_windows.odin

@@ -20,7 +20,7 @@ _rand_bytes :: proc(dst: []byte) {
 				panic("crypto: BCryptGenRandom Invalid parameter")
 			case:
 				// Unknown error
-				panic(fmt.tprintf("crypto: BCryptGenRandom failed: %d\n", ret))
+				fmt.panicf("crypto: BCryptGenRandom failed: %d\n", ret)
 		}
 	}
 }