Browse Source

shm_open: comment with notes abt permissions

Beau McCartney 1 year ago
parent
commit
43e8da2e06
1 changed files with 5 additions and 0 deletions
  1. 5 0
      core/sys/darwin/xnu_system_call_helpers.odin

+ 5 - 0
core/sys/darwin/xnu_system_call_helpers.odin

@@ -206,6 +206,11 @@ sys_shm_open :: proc(name: string, oflag: Open_Flags, mode: Permission) -> (c.in
 	result := syscall_shm_open(cname, cmode, cflags)
 	state  := result != -1
 
+	// NOTE(beau): Presently fstat doesn't report any changed permissions
+	// on the file descriptor even with this fchmod (which fails with a
+	// non-zero return). I can also reproduce this with the syscalls in c
+	// so I suspect it's not odin's bug. I've left the fchmod in case the
+	// underlying issue is fixed.
 	if state && cflags != 0 {
 		state = (syscall_fchmod(result, cflags) != -1)
 	}