Przeglądaj źródła

Add mutex for `lb_handle_objc_find_or_register_class`

gingerBill 4 miesięcy temu
rodzic
commit
5eaff20f4a
2 zmienionych plików z 10 dodań i 1 usunięć
  1. 4 1
      src/llvm_backend.hpp
  2. 6 0
      src/llvm_backend_utility.cpp

+ 4 - 1
src/llvm_backend.hpp

@@ -165,7 +165,6 @@ struct lbModule {
 	PtrMap<u64/*type hash*/, LLVMTypeRef>  func_raw_types;         // mutex: func_raw_types_mutex
 	RecursiveMutex types_mutex;
 	RecursiveMutex func_raw_types_mutex;
-	RecursiveMutex objc_selectors_mutex;
 	i32 internal_type_level;
 
 	RwMutex values_mutex;
@@ -199,6 +198,10 @@ struct lbModule {
 	RecursiveMutex debug_values_mutex;
 	PtrMap<void *, LLVMMetadataRef> debug_values; 
 
+
+	RecursiveMutex objc_classes_mutex;
+	RecursiveMutex objc_selectors_mutex;
+
 	StringMap<lbObjcRef> objc_classes;
 	StringMap<lbObjcRef> objc_selectors;
 

+ 6 - 0
src/llvm_backend_utility.cpp

@@ -2165,6 +2165,9 @@ gb_internal lbValue lb_handle_objc_register_selector(lbProcedure *p, Ast *expr)
 }
 
 gb_internal lbAddr lb_handle_objc_find_or_register_class(lbProcedure *p, String const &name) {
+	mutex_lock(&p->module->objc_classes_mutex);
+	defer (mutex_unlock(&p->module->objc_classes_mutex));
+
 	lbObjcRef *found = string_map_get(&p->module->objc_classes, name);
 	if (found) {
 		return found->local_module_addr;
@@ -2187,7 +2190,10 @@ gb_internal lbAddr lb_handle_objc_find_or_register_class(lbProcedure *p, String
 		lbAddr default_addr = lb_add_global_generated_with_name(default_module, t_objc_Class, {},
 			make_string(cast(u8 const *)global_name, gb_string_length(global_name)),
 			&entity);
+
+		mutex_lock(&default_module->objc_classes_mutex);
 		string_map_set(&default_module->objc_classes, name, lbObjcRef{entity, default_addr});
+		mutex_unlock(&default_module->objc_classes_mutex);
 	}
 
 	lbValue ptr = lb_find_value_from_entity(p->module, entity);