Browse Source

fix: remove returns ErrNo for Windows, FreeBSD, Unix

Justin Hurstwright 1 year ago
parent
commit
8a63b6dff7
1 changed files with 7 additions and 2 deletions
  1. 7 2
      core/os/os_darwin.odin

+ 7 - 2
core/os/os_darwin.odin

@@ -527,6 +527,7 @@ get_last_error_string :: proc() -> string {
 	return cast(string)_darwin_string_error(cast(c.int)get_last_error())
 	return cast(string)_darwin_string_error(cast(c.int)get_last_error())
 }
 }
 
 
+
 open :: proc(path: string, flags: int = O_RDWR, mode: int = 0) -> (Handle, Errno) {
 open :: proc(path: string, flags: int = O_RDWR, mode: int = 0) -> (Handle, Errno) {
 	isDir := is_dir_path(path)
 	isDir := is_dir_path(path)
 	flags := flags
 	flags := flags
@@ -727,10 +728,14 @@ rename :: proc(old: string, new: string) -> bool {
 	return _unix_rename(old_cstr, new_cstr) != -1
 	return _unix_rename(old_cstr, new_cstr) != -1
 }
 }
 
 
-remove :: proc(path: string) -> bool {
+remove :: proc(path: string) -> Errno {
 	runtime.DEFAULT_TEMP_ALLOCATOR_TEMP_GUARD()
 	runtime.DEFAULT_TEMP_ALLOCATOR_TEMP_GUARD()
 	path_cstr := strings.clone_to_cstring(path, context.temp_allocator)
 	path_cstr := strings.clone_to_cstring(path, context.temp_allocator)
-	return _unix_remove(path_cstr) != -1
+	res := _unix_remove(path_cstr)
+	if res == -1 {
+		return Errno(get_last_error())
+	}
+	return ERROR_NONE
 }
 }
 
 
 @private
 @private