Browse Source

Minor style change

gingerBill 2 years ago
parent
commit
da479c7628
2 changed files with 2 additions and 8 deletions
  1. 2 4
      src/thread_pool.cpp
  2. 0 4
      src/threading.cpp

+ 2 - 4
src/thread_pool.cpp

@@ -61,9 +61,7 @@ void thread_pool_queue_push(Thread *thread, WorkerTask task) {
 		u64 tail = ((u32)capture) & mask;
 
 		u64 new_head = (head + 1) & mask;
-		if (new_head == tail) {
-			GB_PANIC("Thread Queue Full!\n");
-		}
+		GB_ASSERT_MSG(new_head != tail, "Thread Queue Full!");
 
 		// This *must* be done in here, to avoid a potential race condition where we no longer own the slot by the time we're assigning
 		thread->queue[head] = task;
@@ -139,7 +137,7 @@ gb_internal THREAD_PROC(thread_pool_thread_proc) {
 
 	for (;;) {
 work_start:
-		if (!pool->running) {
+		if (!pool->running.load()) {
 			break;
 		}
 

+ 0 - 4
src/threading.cpp

@@ -193,10 +193,6 @@ gb_internal void semaphore_wait(Semaphore *s) {
 		CONDITION_VARIABLE cond;
 	};
 	
-	gb_internal void condition_init(Condition *c) {
-	}
-	gb_internal void condition_destroy(Condition *c) {
-	}
 	gb_internal void condition_broadcast(Condition *c) {
 		WakeAllConditionVariable(&c->cond);
 	}