Browse Source

Fix lgtm warnings (#2477)

* Comparison is always true because finalSample >= 1

* Comparison is always false because keyCount >= 0
Crydsch 3 years ago
parent
commit
020e903193
2 changed files with 1 additions and 4 deletions
  1. 0 2
      src/extras/raygui.h
  2. 1 2
      src/raudio.c

+ 0 - 2
src/extras/raygui.h

@@ -1999,7 +1999,6 @@ bool GuiTextBox(Rectangle bounds, char *text, int textSize, bool editMode)
                 {
                     keyCount--;
                     text[keyCount] = '\0';
-                    if (keyCount < 0) keyCount = 0;
                 }
             }
 
@@ -2177,7 +2176,6 @@ bool GuiValueBox(Rectangle bounds, const char *text, int *value, int minValue, i
                 {
                     keyCount--;
                     textValue[keyCount] = '\0';
-                    if (keyCount < 0) keyCount = 0;
                     valueHasChanged = true;
                 }
             }

+ 1 - 2
src/raudio.c

@@ -1206,8 +1206,7 @@ Wave WaveCopy(Wave wave)
 // NOTE: Security check in case of out-of-range
 void WaveCrop(Wave *wave, int initSample, int finalSample)
 {
-    if ((initSample >= 0) && (initSample < finalSample) &&
-        (finalSample > 0) && ((unsigned int)finalSample < (wave->frameCount*wave->channels)))
+    if ((initSample >= 0) && (initSample < finalSample) && ((unsigned int)finalSample < (wave->frameCount*wave->channels)))
     {
         int sampleCount = finalSample - initSample;