Browse Source

rtextures: Fix ImageFromImage crash (#2594)

Height of the rectangle can be float, which
may lead to doing extra iteration of loop and
writing out of bounds.
Piotr Wierciński 3 years ago
parent
commit
5a2f25cc7c
1 changed files with 1 additions and 1 deletions
  1. 1 1
      src/rtextures.c

+ 1 - 1
src/rtextures.c

@@ -879,7 +879,7 @@ Image ImageFromImage(Image image, Rectangle rec)
     result.format = image.format;
     result.format = image.format;
     result.mipmaps = 1;
     result.mipmaps = 1;
 
 
-    for (int y = 0; y < rec.height; y++)
+    for (int y = 0; y < (int)rec.height; y++)
     {
     {
         memcpy(((unsigned char *)result.data) + y*(int)rec.width*bytesPerPixel, ((unsigned char *)image.data) + ((y + (int)rec.y)*image.width + (int)rec.x)*bytesPerPixel, (int)rec.width*bytesPerPixel);
         memcpy(((unsigned char *)result.data) + y*(int)rec.width*bytesPerPixel, ((unsigned char *)image.data) + ((y + (int)rec.y)*image.width + (int)rec.x)*bytesPerPixel, (int)rec.width*bytesPerPixel);
     }
     }