Browse Source

Review rlOrtho() to avoid return in the middle of the function

I usually try to avoid any return in the middle of functions, I try to keep them always at the end of the functions.
raysan5 4 years ago
parent
commit
7bd33e4406
1 changed files with 4 additions and 7 deletions
  1. 4 7
      src/rlgl.h

+ 4 - 7
src/rlgl.h

@@ -1100,15 +1100,12 @@ void rlFrustum(double left, double right, double bottom, double top, double znea
 // Multiply the current matrix by an orthographic matrix generated by parameters
 void rlOrtho(double left, double right, double bottom, double top, double znear, double zfar)
 {
-    if (right - left <= 0 || bottom - top <= 0)
+    if (((right - left) > 0) && ((bottom - top) > 0))
     {
-        *RLGL.State.currentMatrix = MatrixIdentity();
-        return;
+        Matrix matOrtho = MatrixOrtho(left, right, bottom, top, znear, zfar);
+        *RLGL.State.currentMatrix = MatrixMultiply(*RLGL.State.currentMatrix, matOrtho);
     }
-
-    Matrix matOrtho = MatrixOrtho(left, right, bottom, top, znear, zfar);
-
-    *RLGL.State.currentMatrix = MatrixMultiply(*RLGL.State.currentMatrix, matOrtho);
+    else *RLGL.State.currentMatrix = MatrixIdentity();
 }
 
 #endif