Browse Source

Try to not use that SetHandleInformation in pipe_make

I don't know what it does, but we do want to pass the pipe ends to
children process. Which probably means we don't want to disable
inherting. *shrug*
rexim 4 years ago
parent
commit
9bdb7079fe
1 changed files with 3 additions and 3 deletions
  1. 3 3
      nobuild2.h

+ 3 - 3
nobuild2.h

@@ -473,9 +473,9 @@ Pipe pipe_make(void)
         PANIC("Could not create pipe: %s", GetLastErrorAsString());
     }
     
-    if (!SetHandleInformation(pip.read, HANDLE_FLAG_INHERIT, 0)) {
-        PANIC("Could not create pipe: %s", GetLastErrorAsString());
-    }
+    // if (!SetHandleInformation(pip.read, HANDLE_FLAG_INHERIT, 0)) {
+    //     PANIC("Could not create pipe: %s", GetLastErrorAsString());
+    // }
 #else
     Fd pipefd[2];
     if (pipe(pipefd) < 0) {