Browse Source

Fixed an issue in servicestack where random number determination was excluding 10000.

The first parameter in the Next method is inclusive, while the second is
exclusive.
.Next(1,10000) => .Next(0,10000) + 1
Kevin Howard 12 years ago
parent
commit
0b6a6b3c7a

+ 2 - 2
servicestack/src/Model/World.cs

@@ -50,7 +50,7 @@ namespace ServiceStackBenchmark.Model
             {
                 lock (worlds)
                 {
-                    w.randomNumber = SafeRandom.Instance.Next(1, 10000);
+                    w.randomNumber = SafeRandom.Instance.Next(0, 10000) + 1;
                 }
             });
 
@@ -93,7 +93,7 @@ namespace ServiceStackBenchmark.Model
                     {
                         lock (worlds)
                         {
-                            worlds.Add(new World() { id = i, randomNumber = SafeRandom.Instance.Next(1, 10000) });
+                            worlds.Add(new World() { id = i, randomNumber = SafeRandom.Instance.Next(0, 10000) + 1 });
                         }
 
                     });

+ 4 - 4
servicestack/src/Service/MySqlService.cs

@@ -60,7 +60,7 @@ namespace ServiceStackBenchmark
         public object Get(MySqlDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // retrieve world from database
             using (var db = dbFactory.OpenDbConnection())
@@ -80,7 +80,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -123,7 +123,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -140,7 +140,7 @@ namespace ServiceStackBenchmark
         public object Get(MySqlCachedDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // create the cache key for the random world id
             var cacheKey = UrnId.CreateWithParts<World>(new string[] { dbType, id.ToString() });

+ 4 - 4
servicestack/src/Service/PostgreSqlService.cs

@@ -61,7 +61,7 @@ namespace ServiceStackBenchmark
         public object Get(PostgreSqlDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // retrieve world from database
             using (var db = dbFactory.OpenDbConnection())
@@ -81,7 +81,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -124,7 +124,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -141,7 +141,7 @@ namespace ServiceStackBenchmark
         public object Get(PostgreSqlCachedDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // create the cache key for the random world id
             var cacheKey = UrnId.CreateWithParts<World>(new string[] { dbType, id.ToString() });

+ 4 - 4
servicestack/src/Service/SqlServerService.cs

@@ -60,7 +60,7 @@ namespace ServiceStackBenchmark
         public object Get(SqlServerDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // retrieve world from database
             using (var db = dbFactory.OpenDbConnection())
@@ -80,7 +80,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -123,7 +123,7 @@ namespace ServiceStackBenchmark
             {
                 lock (ids)
                 {
-                    ids.Add(SafeRandom.Instance.Next(1, 10000));
+                    ids.Add(SafeRandom.Instance.Next(0, 10000) + 1);
                 }
             });
 
@@ -140,7 +140,7 @@ namespace ServiceStackBenchmark
         public object Get(SqlServerCachedDbRequest request)
         {
             // get a random world id
-            var id = SafeRandom.Instance.Next(1, 10000);
+            var id = SafeRandom.Instance.Next(0, 10000) + 1;
 
             // create the cache key for the random world id
             var cacheKey = UrnId.CreateWithParts<World>(new string[] { dbType, id.ToString() });