[ruby/sinatra] Release connection to pool outside block (#9336)

ActiveRecord 7.2 introduced ActiveRecord::Base.with_connection which
releases the connection after the block has run. This allows us to
remove clearing active connections after the request has finished.

|           |plaintext|update| json|   db|query|fortune|weighted_score|
|-----------|---------|------|-----|-----|-----|-------|--------------|
|master     |    73851|  7851|84330|37661|15144|  19934|          1109|
|branch     |    83429|  8401|91051|41432|14251|  21369|          1147|

frameworks/Ruby/sinatra/Gemfile

@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'activerecord', '~> 7.1', require: 'active_record'
+gem 'activerecord', '~> 7.2', require: 'active_record'
 gem 'oj'
 gem 'passenger', '~> 6.0', platforms: [:ruby, :mswin], require: false
 gem 'puma', '~> 6.4', require: false

frameworks/Ruby/sinatra/hello_world.rb

@@ -39,10 +39,6 @@ class HelloWorld < Sinatra::Base
     response['Server'] = SERVER_STRING
   end if SERVER_STRING
 
-  after do
-    ActiveRecord::Base.connection_handler.clear_active_connections!
-  end
-
   # Test type 1: JSON serialization
   get '/json' do
      json message: 'Hello, World!'
@@ -51,7 +47,7 @@ class HelloWorld < Sinatra::Base
   # Test type 2: Single database query
   get '/db' do
     world =
-      ActiveRecord::Base.connection_pool.with_connection do
+      ActiveRecord::Base.with_connection do
         World.find(rand1).attributes
       end
 
@@ -61,7 +57,7 @@ class HelloWorld < Sinatra::Base
   # Test type 3: Multiple database queries
   get '/queries' do
     worlds =
-      ActiveRecord::Base.connection_pool.with_connection do
+      ActiveRecord::Base.with_connection do
         ALL_IDS.sample(bounded_queries).map do |id|
           World.find(id).attributes
         end
@@ -72,7 +68,7 @@ class HelloWorld < Sinatra::Base
 
   # Test type 4: Fortunes
   get '/fortunes' do
-    @fortunes = ActiveRecord::Base.connection_pool.with_connection do
+    @fortunes = ActiveRecord::Base.with_connection do
       Fortune.all
     end.to_a
     @fortunes << Fortune.new(
@@ -86,17 +82,18 @@ class HelloWorld < Sinatra::Base
 
   # Test type 5: Database updates
   get '/updates' do
-    worlds =
-      ALL_IDS.sample(bounded_queries).map do |id|
-        world = ActiveRecord::Base.connection_pool.with_connection do
-          World.find(id)
-        end
+    worlds = nil
+    ActiveRecord::Base.with_connection do
+      worlds = ALL_IDS.sample(bounded_queries).map do |id|
+        world = World.find(id)
         new_value = rand1
         new_value = rand1 until new_value != world.randomNumber
         { id: id, randomNumber: new_value }
       end
-    ActiveRecord::Base.connection_pool.with_connection do
-      World.upsert_all(worlds.sort_by!{_1[:id]})
+    end
+    worlds.sort_by!{_1[:id]}
+    ActiveRecord::Base.with_connection do
+      World.upsert_all(worlds)
     end
     json worlds
   end