Browse Source

Kelp - Fix the 1:500 range warning

Stefan G 11 years ago
parent
commit
21870db4dc
2 changed files with 5 additions and 3 deletions
  1. 4 3
      frameworks/Perl/kelp/app.pl
  2. 1 0
      frameworks/Perl/kelp/t/main.t

+ 4 - 3
frameworks/Perl/kelp/app.pl

@@ -86,7 +86,8 @@ run;
 sub query {
 sub query {
     my ( $db, $count ) = @_;
     my ( $db, $count ) = @_;
     $count //= 1;
     $count //= 1;
-    $count = 1 unless $count =~ /^\d+$/;
+    $count = 1 if ( $count !~ /^\d+$/ || $count < 1 );
+    $count = 500 if $count > 500;
     my @response;
     my @response;
     for ( 1 .. $count ) {
     for ( 1 .. $count ) {
         my $id = int rand 10000 + 1;
         my $id = int rand 10000 + 1;
@@ -96,9 +97,9 @@ sub query {
         }
         }
         else {
         else {
             $sth[0]->execute($id);
             $sth[0]->execute($id);
-            $row = $sth[0]->fetchrow_hashref
+            $row = $sth[0]->fetchrow_hashref;
         }
         }
-        if ( $row ) {
+        if ($row) {
             if ( $count == 1 ) {
             if ( $count == 1 ) {
                 return { id => $id, randomNumber => $row->{randomNumber} };
                 return { id => $id, randomNumber => $row->{randomNumber} };
             }
             }

+ 1 - 0
frameworks/Perl/kelp/t/main.t

@@ -31,6 +31,7 @@ subtest queries => sub {
         $t->request( GET $uri )->json_cmp($world);
         $t->request( GET $uri )->json_cmp($world);
         $t->request( GET "$uri?queries=3" )
         $t->request( GET "$uri?queries=3" )
           ->json_cmp( [ $world, $world, $world ] );
           ->json_cmp( [ $world, $world, $world ] );
+        $t->request( GET "$uri?queries=0" )->json_cmp($world);
     }
     }
 };
 };