Browse Source

Merge pull request #330 from robfig/check_errors

Revel: Check all errors returned by DB
Patrick Falls 12 years ago
parent
commit
280c1be10b
1 changed files with 18 additions and 4 deletions
  1. 18 4
      revel/src/benchmark/app/controllers/app.go

+ 18 - 4
revel/src/benchmark/app/controllers/app.go

@@ -77,7 +77,11 @@ func (c App) Plaintext() revel.Result {
 func (c App) Db(queries int) revel.Result {
 	if queries <= 1 {
 		var w World
-		worldStatement.QueryRow(rand.Intn(WorldRowCount)+1).Scan(&w.Id, &w.RandomNumber)
+		err := worldStatement.QueryRow(rand.Intn(WorldRowCount)+1).
+			Scan(&w.Id, &w.RandomNumber)
+		if err != nil {
+			revel.ERROR.Fatalf("Error scanning world row: %v", err)
+		}
 		return c.RenderJson(w)
 	}
 
@@ -101,9 +105,16 @@ func (c App) Db(queries int) revel.Result {
 func (c App) Update(queries int) revel.Result {
 	if queries <= 1 {
 		var w World
-		worldStatement.QueryRow(rand.Intn(WorldRowCount)+1).Scan(&w.Id, &w.RandomNumber)
+		err := worldStatement.QueryRow(rand.Intn(WorldRowCount)+1).
+			Scan(&w.Id, &w.RandomNumber)
+		if err != nil {
+			revel.ERROR.Fatalf("Error scanning world row: %v", err)
+		}
 		w.RandomNumber = uint16(rand.Intn(WorldRowCount) + 1)
-		updateStatement.Exec(w.RandomNumber, w.Id)
+		_, err = updateStatement.Exec(w.RandomNumber, w.Id)
+		if err != nil {
+			revel.ERROR.Fatalf("Error updating row: %v", err)
+		}
 		return c.RenderJson(&w)
 	}
 
@@ -120,7 +131,10 @@ func (c App) Update(queries int) revel.Result {
 				revel.ERROR.Fatalf("Error scanning world row: %v", err)
 			}
 			ww[i].RandomNumber = uint16(rand.Intn(WorldRowCount) + 1)
-			updateStatement.Exec(ww[i].RandomNumber, ww[i].Id)
+			_, err = updateStatement.Exec(ww[i].RandomNumber, ww[i].Id)
+			if err != nil {
+				revel.ERROR.Fatalf("Error updating world row: %v", err)
+			}
 			wg.Done()
 		}(i)
 	}